Zulip Chat Archive
Stream: nightly-testing
Topic: nightly#102 adaptations for nightly-2025-10-29
github mathlib4 bot (Oct 29 2025 at 11:50):
chore: adaptations for nightly-2025-10-29 nightly#102 Please review this PR. At the next toolchain release this diff will land in 'master'.
Kevin Buzzard (Oct 29 2025 at 18:37):
Wooah this is a monster. Can we deal with https://github.com/leanprover-community/mathlib4-nightly-testing/pull/99 first, and then 100, and then this one?
Kim Morrison (Oct 29 2025 at 22:46):
Oh dear, I hadn't realised they had been stacking up.
Kim Morrison (Oct 29 2025 at 22:47):
Okay, merged nightly#99.
Kim Morrison (Oct 29 2025 at 22:52):
and nightly#100 is sent to bors, after which I will merge bump/v4.26.0 back into this PR, and it will hopefully be easier to review.
Kim Morrison (Oct 29 2025 at 22:52):
Thanks Kevin for the help reviewing these!!
Kim Morrison (Oct 31 2025 at 06:27):
Hmm, after merging the earlier ones, nightly#102 is still huge. Mostly it is just updating deprecations using the fix_deprecations.sh script from #30994.
Kevin Buzzard (Nov 02 2025 at 11:44):
Kim Morrison said:
Thanks Kevin for the help reviewing these!!
I find that reviewing them makes it easier to bump FLT because many of the issues which arise in an FLT bump have already been exposed by the recent mathlib bump.
Kevin Buzzard (Nov 02 2025 at 12:21):
OK this one is reviewed. I tidied parts of it up, well, I thought it was tidying up, I'll let someone else decide if these changes from (iff_lemma).mp to (one_way_lemma) are a step forward. There's a merge conflict because Yael pushed a nice golf in Data.Finset.Image which renders your change from Subtype.eq to Subtype.ext moot.
Last updated: Dec 20 2025 at 21:32 UTC