Zulip Chat Archive

Stream: nightly-testing

Topic: nightly#127 adaptations for nightly-2025-11-25


github mathlib4 bot (Nov 25 2025 at 13:21):

chore: adaptations for nightly-2025-11-25 nightly#127 Please review this PR. At the next toolchain release this diff will land in 'master'.

Kevin Buzzard (Nov 25 2025 at 13:24):

Looking through this now. The diff is huge (300+ files, 1600+ lines) and seems to be many many changes cutsat -> lia and omega -> lia. Is there anything else in there?

Kevin Buzzard (Nov 25 2025 at 13:34):

It would be interesting to benchmark these changes.

Kevin Buzzard (Nov 25 2025 at 13:36):

The scrollbar on the Files page is lying to me :-) It looks like I'm nearly at the bottom but occasionally it jumps up a bit. From the files list on the left I can see I'm abuot half way through and still no changes other than cutsat -> lia and omega -> lia

Much better than the old files page though, which would give up after around 200 files and make you open the rest manually.

Markus Himmel (Nov 25 2025 at 13:39):

There are a tiny number of adaptations to the String API in Mathlib.Data.String and Mathlib.Tactic. Aparat from that I think it's all lia.

Kevin Buzzard (Nov 25 2025 at 14:06):

I am happy to bors d+ this, I've gone through it all now.

@Joscha Mennicken is it possible to use radar on this repo to see what effect these changes have had?

Joscha Mennicken (Nov 25 2025 at 14:08):

Not at the moment, but we're working on getting it into radar.

Kevin Buzzard (Nov 25 2025 at 22:24):

Happy to merge this if someone else is prepared to look at my two comments on the PR and say "yeah this is fine".

Robin Arnez (Nov 25 2025 at 22:52):

Regarding the two small comments:
cutsat has been renamed to lia in lean4#11330 and Lean.Parser.Tactic.lia is in fact the correct new name.
grobner is a frontend to grind with specific options, so the fact the grobner can handle scientific literals comes directly from grind being able to normalize them.

Kevin Buzzard (Nov 26 2025 at 08:50):

Thanks. I merged.


Last updated: Dec 20 2025 at 21:32 UTC