Zulip Chat Archive

Stream: Carleson

Topic: Tracking upstreaming PRs?


Joachim Breitner (Jul 29 2024 at 14:23):

Just wondering: Do you happen to keep track of which mathlib PR came out of the Carleson projects, maybe to show off in the end “…and we contributed nn changes to mathlib?

Floris van Doorn (Jul 29 2024 at 14:36):

Yes, please just write "from the Carleson project" at the end of your commit message / PR description

Yury G. Kudryashov (Jul 29 2024 at 17:22):

Another option is to create a github "project" and add relevant PRs to this project. This can be done even after a PR is merged.

Kim Morrison (Jul 29 2024 at 22:41):

Another perfectly reasonable option is a label. It's more visible than a project, but I don't see that as being a bad thing.

Johan Commelin (Jul 30 2024 at 05:11):

We could have a bunch of project-XYZ labels. Maybe some of the existing labels should be renamed, to keep things mildly organized?

Yaël Dillies (Jul 30 2024 at 07:32):

Personally I've been adding From LeanAPAP/From LeanCamCombi/From PFR every time I upstream something and it works

Joseph Myers (Jul 30 2024 at 10:42):

It might be interesting to have statistics on commits coming from different projects (like the contributor statistics we used to have for mathlib3). Though if you look for lines starting "From" or "from" in commit messages, in either mathlib3 or mathlib4, you'll discover there are a lot of irregular cases that would complicate getting good statistics.

Jeremy Tan (Sep 20 2024 at 16:27):

Note: #16970 upstreams a lemma I needed for the project relating to max/min elements that are also upper/lower bounds


Last updated: May 02 2025 at 03:31 UTC