Zulip Chat Archive
Stream: Equational
Topic: WORKFLOW UPDATES
Pietro Monticone (Oct 08 2024 at 17:34):
I have just improved the workflows as follows:
- Claim Issue: Now handles white spaces.
- Disclaim Issue: Now handles white spaces.
- Propose PR: Now handles white spaces, case sensitivity, and the presence of
PR
betweenpropose
and#PR_NUMBER
. - Withdraw PR: Now handles white spaces, case sensitivity, and the presence of
PR
betweenwithdraw
and#PR_NUMBER
. - Awaiting Review: Now handles white spaces.
Shreyas Srinivas (Oct 08 2024 at 17:38):
Awesome!!
Pietro Monticone (Oct 08 2024 at 17:39):
I have tested it, but I cannot claim full coverage so feel free to send feedbacks and I will try to fix issues when I find the time.
Pietro Monticone (Oct 10 2024 at 16:09):
I will make the "Propose PR" and "Withdraw PR" more robust by integrating GitHub’s GraphQL API to link a PR to an issue without modifying the PR body (e.g. avoiding the use of “Closes #ISSUE_NUMBER”).
I’ll replace the part where the PR body is updated with a GraphQL mutation. The mutation will link the PR directly to the issue.
Pietro Monticone (Oct 10 2024 at 16:40):
Unfortunately, there seems to be no direct mutation to link a PR to an issue via GraphQL... Let's see if there is a workaround.
Notification Bot (Oct 10 2024 at 17:13):
Pietro Monticone has marked this topic as resolved.
Notification Bot (Oct 10 2024 at 23:20):
Pietro Monticone has marked this topic as unresolved.
Pietro Monticone (Oct 10 2024 at 23:28):
Now if users claim an issue which has not been added to the project board by the maintainers, they will receive an automatic message tagging the user and the maintainers.
Pietro Monticone (Oct 10 2024 at 23:35):
Maybe tagging maintainers isn't a great idea. I'll add a phrase pointing contributors to the #Equational channel and the CONTRIBUTING guide.
Pietro Monticone (Oct 10 2024 at 23:53):
Updated:
-
if users claim an issue which has not been added to the project board, they will receive the following automatic message:
claim-no-project -
if users claim an issue which has not been added to the "Unclaimed Outstanding Tasks", they will receive the following automatic message:
claim-no-unclaimed-task
Pietro Monticone (Oct 11 2024 at 16:02):
Fixed the escaping mechanism of the propose PR
workflow.
Now it works with arbitrarily complicated PR descriptions. Sorry for the inconvenience.
Cody Roux (Oct 12 2024 at 00:23):
Every trivial program ends up being a complicated parser...
Pietro Monticone (Oct 16 2024 at 21:46):
I have just finished generalising the dashboard-based workflow so that it's much easier to transfer from project to project. No more copy-pasting of the project ID from the GraphQL Explorer like @Terence Tao and I did the first time. Now the retrieval is fully automated.
One more step towards the full generality needed for the LeanProject template.
Related: #FLT > Project Dashboard
Last updated: May 02 2025 at 03:31 UTC