Linting PhysLean

Stream: PhysLean

[Joseph Tooby-Smith]

I made this PR PhysLean#790 which contains some documentation about the various linters which can be run on PhysLean and what they do. If anyone has any suggestions of how it can be improved, I would be very glad to hear them.

[Fabio Anzà]

Hey @Joseph Tooby-Smith , I was going through the linters (lake exe lint_all) and the Style linter was flagging a bunch of stuff on SpaceTime, which is not at all what I worked on.

The question is: should I fix those as well?

[Joseph Tooby-Smith]

Hmm odd, could you paste the output here? But no need to fix these.

[Joseph Tooby-Smith]

Ok, I manage to work this out - the linter errors you are seeing are on "optional linters" (lets call them), ones that appear in lake exe lint_all but are not strictly enforced by GitHub, so sometimes slip through the net.

I have fixed them in PhysLean#820, which I will merge, and then make a note here - after which merging with Master should remove these errors for you. (update: This PR has now been merged into master).

[Joseph Tooby-Smith]

(deleted - on a train with poor internet so sent message twice)

[Fabio Anzà]

Thanks, but it happened again. Not sure why. I'm attaching a screenshot
Screenshot 2025-11-27 at 6.53.07 PM.png

[Fabio Anzà]

I'm happy to fix them and they can get pulled once I issue the PR

[Joseph Tooby-Smith]

They should be fixed now :). You will need to update your fork with master (merge master into your fork), but then these should go away, no need for you to do anything :).