Are you a maintainer with just a short amount of time? The following kinds of pull requests could be relevant for you.
| Number |
Author |
Title |
Description |
Labels |
+/- |
Modified files (first 100) |
📝 |
💬 |
All users who commented or reviewed |
Assignee(s) |
Updated |
Last status change |
total time in review |
blocks |
| 43745 |
theebayuser author:theebayuser |
feat(Geometry/Euclidean): add Euler's quadrilateral theorem |
Adds Euler's quadrilateral theorem to Mathlib/Geometry/Euclidean/, and records it in docs/1000.yaml (Q18630480). It states: for any four points, the sum of the squares of the four sides of the quadrilateral a b c d equals the sum of the squares of the two diagonals, plus four times the square of the distance between the midpoints of the diagonals.
This PR was written with AI assistance (Claude Code).
|
t-euclidean-geometry
new-contributor
LLM-generated
maintainer-merge
|
84/0 |
Mathlib.lean,Mathlib/Analysis/InnerProductSpace/Basic.lean,Mathlib/Geometry/Euclidean/EulerQuadrilateral.lean,docs/1000.yaml |
4 |
17 |
['github-actions', 'jsm28', 'theebayuser', 'wwylele'] |
nobody |
36-49559 1 month ago |
41-42750 41 days ago |
58-33225 58 days |
0 |
| 44060 |
wwylele author:wwylele |
feat(Geometry/Euclidean): lemma about excenters and volumes |
This proves that volume = inradius * surface / n
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-euclidean-geometry
maintainer-merge
|
112/0 |
Mathlib.lean,Mathlib/Geometry/Euclidean/Volume/Incenter.lean |
2 |
8 |
['SnirBroshi', 'copilot-pull-request-reviewer', 'github-actions', 'jsm28', 'wwylele'] |
nobody |
26-42610 26 days ago |
26-42665 26 days ago |
48-42938 48 days |
2 |
| 41336 |
SnirBroshi author:SnirBroshi |
chore(Combinatorics/SimpleGraph/Girth): golf `egirth_top` using `cycleGraph` |
Golf `egirth_top` (#38529) using `cycleGraph_isContained_iff` (#35255)
Co-authored-by: Vlad Tsyrklevich <vlad@tsyrklevi.ch>
---
Speeds up the proof from ~120ms to ~30ms
(although it used to be ~600ms, not sure what happened, perhaps toolchains sped it up already)
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
5/11 |
Mathlib/Combinatorics/SimpleGraph/Girth.lean |
1 |
3 |
['YaelDillies', 'github-actions', 'mathlib-merge-conflicts'] |
nobody |
18-24693 18 days ago |
40-54856 40 days ago |
128-49258 128 days |
0 |
| 40204 |
Jun2M author:Jun2M |
feat(Combinatorics/HypergraphLike): add HypergraphLike class |
Introduces `HypergraphLike V I E G`, an object-indexed incidence interface for developing common graph theory across different representations.
Defines links and adjacency, incidence maps and fibers, and sets of incident vertices and edges. The basic API provides membership characterizations, fiber disjointness and union identities, and relationships between incidence data, links, and adjacency.
Codex assisted with the initial implementation and review; the code was subsequently revised by me.
The following is a longer write-up about what this PR is for, what this PR has, and why it is in this shape.
## Considerations
1. The main consideration for this PR is to create a common language different graph types can use to communicate their structure. The data in the type class is deliberately chosen to be as general as possible, accommodating hypergraphs, digraphs, simple graphs, and more.
2. (Hyper)Graphs are used both as a setting in which vertices, edges, walks, and colorings live, and as an algebraic object that can be modified. These two viewpoints can sometimes be at odds with each other. This typeclass is an acknowledgement that these two viewpoints are different, and both need to be fully supported separately with explicit connection. `HypergraphLike` is the way to view a graph as a setting. Various different graph structures are ways to view a graph as an algebraic object.
3. Graph theory has a lot of uses outside of graph theory. For example, group theory, topology, and more. The type class is designed to be easily applied to an arbitrary object that can be associated with a graph structure.
## Contents
The definition consists of:
| Data | Meaning |
| --- | --- |
| `V`, `I`, `E` | Ambient types of vertex, incidence, and edge labels |
| `V(G)`, `I(G)`, `E(G)` | The set of objects of the (hyper)graph structure |
| `attach'`, `edgeMap'` | The vertex and edge assigned to each incidence |
| `IsSource`, `IsTarget` | The directions in which an incidence can be traversed |
Every incidence is a source, a target, or both. This allows directed and undirected incidences in the same object. Distinct incidences may belong to the same vertex and edge.
`HypergraphLike` does not require the object to be a graph or hypergraph, or to be related to one. Any object can be associated with a (hyper)graph structure and use the graph theory API as such via a `HypergraphLike` instance. As a result, it is possible for an arbitrary object to be associated with a graph structure that it has nothing to do with.
- **`Link G e u v`:** a traversal of `e` from `u` to `v`, retaining a source incidence and a distinct target incidence. Distinctness prevents entering and leaving an undirected edge through the same incidence.
- **`IsLink` and `Adj`:** the existence of a link through a specified edge, and the existence of an edge linking two vertices.
- **`attach` and `edgeMap`:** total extensions of the incidence maps when the corresponding types are nonempty.
- **`edgeFiber` and `vertexFiber`:** the incidences belonging to an edge or vertex.
- **`incVerts` and `incEdges`:** the vertices incident to an edge and the edges incident to a vertex.
Apart from operations, graph API should be built on this type class. More specialized theories can add assumptions such as undirectedness, looplessness, or restrictions on the incidences of each edge. See PRs #43768, #43748 and more to come.
## Design decisions
### Why not require one concrete representation?
Alternative approach to unify various graph structures is to have one very general hypergraph definition and put all possible API there. By extending the definition with other conditions, you can inherit all the API while describing the graph class you want.
This is not used here because
1. It either loses the expected extensionality or restricts which representations can use the API.
2. The API can be inherited using the current instance method more generally (you don't need to `extend` the particular def to inherit them)
3. These two approaches have virtually no difference in formalization cost.
Asterisk for number 3 is that I have not tried to formalize every part of graph theory so it should be taken with a grain of salt. Nevertheless, I have not found cases where `extend` method reduces the formalization cost significantly.
The generality of application is the strong suit of the current approach. The discussion that led to this PR started with efforts to unify different graph structures in Mathlib and future structures to be implemented. The instance method allows even more flexibility. We could talk about a group (with a chosen generating set) being `HypergraphLike` by associating it with a Cayley graph, a CW complex with its 1-skeleton graph, or a lattice with its Hasse graph, in the same manner `SimpleGraph` is `HypergraphLike`. With `extend`, these will require a separate, bespoke association with the appropriate graph structure.
So, it suffices to argue that number 1 is true. The difficulty comes from the fact that the child structures have to contain additional data and therefore additional freedom that it really doesn't need. Consider two simple graphs `G` and `H`, each with vertex set `{u, v}` and single edge between them. In the naive approach where you define `SimpleGraph` like this:
```lean
structure SimpleGraph (ν ι ε : Type*) extends undirected ν ι ε, noMultiEdges ν ι ε ... where
```
Then, `G = H` may not hold. They could have different edge type, incidence type, edge set, incidence set, etc. That is, we have extensionality issue.
The fix is to constrain further until simple graph structure uniquely determines the rest. Here is one possible definition:
```lean
structure SimpleGraph (ν : Type*) extends undirected ν (ν × ν) (Sym2 ν), noMultiEdges ν (ν × ν) (Sym2 ν) ... where
edgeMap'_eq (i) : edgeMap' i = Sym2.mk i.val.fst i.val.snd
attach'_eq (i) : attach' i = i.val.fst
```
Now, any `multigraph` that happens to be a simple graph cannot use `SimpleGraph` results without going through the normalization function, showing that normalization only changed the labels and showing that the normalization function preserves whatever properties, etc. Results that depend on simplicity should be available for arbitrary incidence representations satisfying simplicity, rather than only for a canonical `SimpleGraph` representation. This happens every time a canonical form is chosen to resolve extensionality issues.
### Why per-object indexing?
Indexing by graph type was something I have adopted from `HasAdj` PR (#35776) without critical thinking. In the discussion for `Quiver` (#45034), as soon as I wrote "HypergraphLike expects you to know the edge type before you know what graph you are working with.", I started to think why this is necessary. It is not.
All the code I have about HypergraphLike can be migrated to per-object indexing very easily. The statements did get longer due to adding `HypergraphLike` instance to each graph object but virtually all proofs worked without any changes.
Philosophically, it makes the role of `HypergraphLike` clearer. `HypergraphLike` is defined to have one common language between different graph structures and that common language is the label types and incidence data. Merely belonging to the same Lean type should not impose additional uniformity. Where a result needs shared labels or compatible incidence maps, it can state those requirements explicitly.
In the cases of `Quiver`, it can be supported by `HypergraphLike` as now we supply the edge type along with the specific `Quiver` instance, not before.
Another benefit is that you can use `HypergraphLike` even when not all elements of a type can be interpreted as a graph. This aligns with the rest of the type class hierarchy being built on `HypergraphLike`. (#43768, #43748) `G : Graph V E` could happen to be a simple graph. A subset of a plane could be graph-like.
### Why ambient labels and support sets?
The `id` function holds a special place in our heads. Consider `G`, K4 graph with vertex set `{1, 2, 3, 4}`, and `H`, K5 graph with vertex set `{1, 2, 3, 4, 5}`. Remove edge `s(1, 2)` from `H`. Up to isomorphism, `G` is still a subgraph of `H`. But, with respect to the `id` function, `G` is no longer a subgraph of `H`.
Without support sets, the vertex set is the whole type, so graphs on different vertex sets live on different types. Then only embeddings can be stated, and you lose the labelled subgraph relation. That is, without some special treatment for subtypes, `HypergraphLike` will say `G` is a subgraph of `H` as there exists embedding of `G` into `H`.
Support sets in the type class are exactly the mechanism that allows "special treatment" for subtypes.
## Related work (Not dependency)
- #36743
- [HasAdj discussion](https://leanprover.zulipchat.com/#narrow/channel/252551-graph-theory/topic/HasAdj/with/575843445)
Co-authored-by: OpenAI Codex <codex@openai.com>
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
LLM-generated
maintainer-merge
|
458/0 |
Mathlib.lean,Mathlib/Combinatorics/HypergraphLike/Basic.lean |
2 |
59 |
['Jun2M', 'SnirBroshi', 'YaelDillies', 'copilot-pull-request-reviewer', 'github-actions', 'tb65536'] |
nobody |
16-2222 16 days ago |
16-43981 16 days ago |
128-70920 128 days |
10 |
| 41629 |
SnirBroshi author:SnirBroshi |
feat(Combinatorics/SimpleGraph/Subgraph): `neighborSet` of `coe`/`spanningCoe` |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
15/3 |
Mathlib/Combinatorics/SimpleGraph/Subgraph.lean |
1 |
2 |
['YaelDillies', 'github-actions'] |
nobody |
15-18286 15 days ago |
120-42571 120 days ago |
120-42498 120 days |
0 |
| 40967 |
Formalistic03 author:Formalistic03 |
feat(Combinatorics/SimpleGraph/Paths): some lemmas about inducing walks |
Could also be done via `SimpleGraph.Walk.map_induce`, but I thought that doing it directly is not much worse.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
new-contributor
t-combinatorics
maintainer-merge
|
59/0 |
Mathlib/Combinatorics/SimpleGraph/Paths.lean,Mathlib/Combinatorics/SimpleGraph/Walk/Maps.lean,Mathlib/Data/List/Nodup.lean,Mathlib/Data/Sym/Sym2.lean |
4 |
34 |
['Formalistic03', 'SnirBroshi', 'github-actions'] |
nobody |
14-49560 14 days ago |
35-11685 35 days ago |
128-72861 128 days |
0 |
| 45029 |
YaelDillies author:YaelDillies |
feat(Util): support `noWS` in `notation3` |
... and use it to define the conditional probability notation `μ[|s]`.
Generated by Claude Opus, reviewed line-by-line by myself.
Zulip discussion: [#mathlib reviewers > status of `notation3` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954)
Assisted-by: Claude Opus 5.5
---
- [ ] awaiting-Zulip: [#mathlib reviewers > status of `notation3` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954)
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
LLM-generated
maintainer-merge
t-meta
awaiting-zulip
|
40/34 |
Mathlib/Probability/ConditionalProbability.lean,Mathlib/Util/Notation3.lean,MathlibTest/Util/Notation3.lean |
3 |
19 |
['JovanGerb', 'Vierkantor', 'YaelDillies', 'eric-wieser', 'github-actions', 'grunweg'] |
Vierkantor assignee:Vierkantor |
14-23181 14 days ago |
16-3252 16 days ago |
4-40864 4 days |
0 |
| 41393 |
SnirBroshi author:SnirBroshi |
feat(SimpleGraph/Hamiltonian): a graph is Hamiltonian iff there's a Hamiltonian path with adjacent endpoints |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #41435
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
32/9 |
Mathlib/Combinatorics/SimpleGraph/Hamiltonian.lean |
1 |
5 |
['YaelDillies', 'github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] |
nobody |
14-7175 14 days ago |
39-46557 39 days ago |
119-37311 119 days |
2 |
| 41722 |
SnirBroshi author:SnirBroshi |
feat(SimpleGraph/Connectivity/Subgraph): `mapToSubgraph` API |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
36/0 |
Mathlib/Combinatorics/SimpleGraph/Connectivity/Subgraph.lean |
1 |
3 |
['YaelDillies', 'github-actions'] |
nobody |
14-2617 14 days ago |
14-2673 14 days ago |
118-22319 118 days |
1 |
| 41793 |
SnirBroshi author:SnirBroshi |
feat(Combinatorics/SimpleGraph): `fromEdgeSet edgeSet` for subgraphs and walks |
`fromEdgeSet G'.edgeSet = G'.spanningCoe` for a subgraph `G'`
`fromEdgeSet p.edgeSet = p.toSubgraph.spanningCoe` for a walk `p`
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
16/2 |
Mathlib/Combinatorics/SimpleGraph/Basic.lean,Mathlib/Combinatorics/SimpleGraph/Connectivity/Subgraph.lean,Mathlib/Combinatorics/SimpleGraph/Subgraph.lean |
3 |
2 |
['YaelDillies', 'github-actions'] |
nobody |
13-17506 13 days ago |
116-65851 116 days ago |
116-65778 116 days |
0 |
| 41623 |
SnirBroshi author:SnirBroshi |
feat(SimpleGraph/Trails): a walk is Eulerian iff it is a trail of length `G.edgeSet.encard` |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
38/3 |
Mathlib/Combinatorics/SimpleGraph/Paths.lean,Mathlib/Combinatorics/SimpleGraph/Trails.lean |
2 |
5 |
['YaelDillies', 'github-actions', 'mathlib-merge-conflicts'] |
nobody |
13-17243 13 days ago |
13-17339 13 days ago |
117-34151 117 days |
0 |
| 41633 |
SnirBroshi author:SnirBroshi |
feat(Combinatorics/SimpleGraph/Paths): length of closed a walk/trail isn't `1`/`2` |
For a closed walk `p`:
- `p.length ≠ 1`
- `p.IsTrail` → `p.length ≠ 2`
- `p.IsTrail` → `p.length ≤ 2` → `p.Nil`
---
Since a circuit is a closed non-nil trail, `IsTrail.nil_of_length_le_two` is basically the contrapositive of `IsCircuit.three_le_length`, but I think this form is useful.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
11/4 |
Mathlib/Combinatorics/SimpleGraph/Paths.lean,Mathlib/Combinatorics/SimpleGraph/Walk/Basic.lean |
2 |
3 |
['YaelDillies', 'github-actions', 'mathlib-merge-conflicts'] |
nobody |
13-17067 13 days ago |
65-1531 65 days ago |
116-19967 116 days |
0 |
| 41241 |
intgrah author:intgrah |
feat(Order/Category): cartesian closed and distributive structure on PartOrd and Preord |
Give `PartOrd` and `Preord` `CartesianMonoidalCategory`, `MonoidalClosed`, and `IsCartesianDistributive` instances.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
new-contributor
t-order
maintainer-merge
|
311/0 |
Mathlib.lean,Mathlib/Order/Category/PartOrd/CartesianClosed.lean,Mathlib/Order/Category/PartOrd/Colimits.lean,Mathlib/Order/Category/PartOrd/Reflective.lean,Mathlib/Order/Category/Preord/CartesianClosed.lean,Mathlib/Order/Category/Preord/Colimits.lean,Mathlib/Order/Category/Preord/Reflective.lean,Mathlib/Tactic/Linter/DirectoryDependency.lean |
8 |
27 |
['Vierkantor', 'YaelDillies', 'github-actions', 'intgrah', 'thomaskwaring'] |
nobody |
12-81973 12 days ago |
13-83851 13 days ago |
126-62066 126 days |
0 |
| 44996 |
WenrongZou author:WenrongZou |
feat(MvPowerSeries/Order): order of a difference of products |
In this PR, we add some lemmas about `MvPowerSeries.order`.
- `coeff_eq_of_lt_weightedOrder_sub`: if `weight w d < (f - g).weightedOrder w`, then `coeff d f = coeff d g`.
- `le_weightedOrder_prod_sub_prod`: if `n ≤ (a i - b i).weightedOrder w` for all `i ∈ s`, then `n ≤ (∏ i ∈ s, a i - ∏ i ∈ s, b i).weightedOrder w`.
- `add_nsmul_le_weightedOrder_prod_sub_prod`: if, in addition, every `a i` and `b i` has weighted order at least `k`, the bound becomes `n + (#s - 1) • k`.
We also add the corresponding `order` versions: `coeff_eq_of_lt_order_sub`, `le_order_prod_sub_prod` and `add_nsmul_le_order_prod_sub_prod`.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-ring-theory
maintainer-merge
|
55/1 |
Mathlib/RingTheory/MvPowerSeries/Order.lean |
1 |
7 |
['Vierkantor', 'WenrongZou', 'github-actions', 'riccardobrasca'] |
nobody |
12-4858 12 days ago |
18-9973 18 days ago |
22-13712 22 days |
1 |
| 45062 |
Parcly-Taxel author:Parcly-Taxel |
chore: remove more `defeqAttrib` options |
I ran `rm_set_option` on my laptop after #45027 but before #45039. These are the places where `set_option backward.defeqAttrib.useBackward true in` could be removed without errors, but doing so triggered the `unusedSimpArgs` linter. |
tech debt
maintainer-merge
awaiting-author
|
20/50 |
Mathlib/Algebra/Category/MonCat/Limits.lean,Mathlib/Algebra/Category/Ring/Constructions.lean,Mathlib/AlgebraicGeometry/Morphisms/RingHomProperties.lean,Mathlib/CategoryTheory/Functor/KanExtension/Basic.lean,Mathlib/CategoryTheory/Limits/Presheaf.lean,Mathlib/CategoryTheory/Limits/Shapes/SequentialProduct.lean,Mathlib/CategoryTheory/Sites/IsSheafFor.lean,Mathlib/CategoryTheory/Sites/Subcanonical.lean,Mathlib/CategoryTheory/Topos/Sheaf.lean,Mathlib/Condensed/Discrete/Colimit.lean,Mathlib/Geometry/RingedSpace/PresheafedSpace.lean,Mathlib/Topology/Sheaves/Alexandrov.lean,Mathlib/Topology/Sheaves/Skyscraper.lean |
13 |
8 |
['Parcly-Taxel', 'github-actions', 'grunweg', 'mathlib-merge-conflicts', 'themathqueen'] |
nobody |
7-20829 7 days ago |
16-84079 16 days ago |
1-43157 1 day |
0 |
| 42370 |
SnirBroshi author:SnirBroshi |
feat(Combinatorics/SimpleGraph/Maps): more `map`/`comap` API |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
114/9 |
Mathlib/Combinatorics/SimpleGraph/Maps.lean |
1 |
3 |
['Ruben-VandeVelde', 'github-actions', 'mathlib-merge-conflicts'] |
nobody |
6-59353 6 days ago |
63-64021 63 days ago |
98-21995 98 days |
1 |
| 43305 |
WenrongZou author:WenrongZou |
feat(PowerSeries/Derivative): add some lemmas |
In this PR, I migrated some results from Polynomial/Derivative.lean to PowerSeries/Derivative.lean.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-ring-theory
maintainer-merge
|
59/0 |
Mathlib/RingTheory/PowerSeries/Derivative.lean |
1 |
5 |
['Ruben-VandeVelde', 'WenrongZou', 'github-actions'] |
nobody |
6-56420 6 days ago |
6-56487 6 days ago |
68-82174 68 days |
0 |
| 41823 |
tb65536 author:tb65536 |
feat(Combinatorics/Design/Defs): definitions of combinatorial designs |
This PR adds the definitions of combinatorial designs.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
151/0 |
Mathlib.lean,Mathlib/Combinatorics/Design/Defs.lean |
2 |
18 |
['Jun2M', 'Parcly-Taxel', 'YaelDillies', 'github-actions', 'tb65536'] |
nobody |
6-38970 6 days ago |
7-14949 7 days ago |
115-54220 115 days |
1 |
| 45575 |
lua-vr author:lua-vr |
feat(Topology/Instances/AddCircle): `Infinite (AddCircle p)` for a densely ordered group |
---
Suggested in https://github.com/leanprover-community/mathlib4/pull/45360#discussion_r4408995830. If the scalars form an ordered group, then this version should be more general than using divisibility. CC @vihdzp
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
<!-- Message of single commit: --> |
t-topology
maintainer-merge
|
12/0 |
Mathlib/Topology/Instances/AddCircle/Defs.lean |
1 |
11 |
['felixpernegger', 'github-actions', 'lua-vr', 'vihdzp'] |
nobody |
5-79874 5 days ago |
5-80221 5 days ago |
7-3141 7 days |
2 |
| 45593 |
TJHeeringa author:TJHeeringa |
feat(Analysis/InnerProductSpace/Positive): add norm_map_le_iff_adjoint_comp_self(_le_id) |
This PR add the theorem `norm_map_le_iff_adjoint_comp_self`, which states that `‖p x‖ ≤ ‖q x‖` holds if and only if `adjoint p ∘L p ≤ adjoint q ∘L q` is true, and the corollary of this for `q = .id 𝕜 E` named `norm_map_le_iff_adjoint_comp_self_le_id`.
---
This is the contraction version of `norm_map_iff_adjoint_comp_self`.
This should probably go into dedicated to contractive maps, but that doesn't exist yet. Future PR?
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-analysis
maintainer-merge
|
13/0 |
Mathlib/Analysis/InnerProductSpace/Positive.lean |
1 |
16 |
['TJHeeringa', 'github-actions', 'themathqueen'] |
nobody |
5-8170 5 days ago |
5-63722 5 days ago |
5-69092 5 days |
0 |
| 45024 |
kim-em author:kim-em |
feat(linter): reject commands scoped with in section |
Commands such as `variable ... in section` do not open the section that their layout suggests: the generated `end` closes the inner section immediately and leaves the generated outer scope open. Named sections fail outright. Prefer opening a section first and putting the command inside it.
Add `linter.style.inSection` to the standard linter set for any command prefix ending in `section`, including `omit`, `include`, `variable`, `set_option`, `open`, `attribute`, local notation, and `universe`. The check uses the generic command-level `in` syntax instead of a list of command names. Nested prefixes receive one warning; scoped linter options are respected. The check lives in the existing style-linter module and adds no imports or separate source scan.
Fix both existing library uses: `Mathlib/Data/TypeVec.lean` (`variable`) and `Mathlib/CategoryTheory/Limits/Shapes/Pullback/IsPullback/BicartesianSq.lean` (`omit`). Preserve the eight intentional `set_option ... in section` test blocks in two existing test files with local opt-outs.
Tests cover all eight command forms above, multiline syntax and comments, section modifiers, nested wrappers, option disabling/re-enabling, valid per-declaration and ordinary section forms, quotations, strings, and elaboration failures. The new test file and both modified test files pass. Both changed library modules compile with the standard linter set and warnings as errors; all 327 compiled declaration-type fingerprints are unchanged. Text-style lint and `git diff --check` pass.
This PR targets current `master` independently of #45016 and #45017, and does not decide whether plain `omit` should be restricted.
:robot: prepared with Codex
|
maintainer-merge
t-linter
merge-conflict
|
274/2 |
Mathlib/CategoryTheory/Limits/Shapes/Pullback/IsPullback/BicartesianSq.lean,Mathlib/Data/TypeVec.lean,Mathlib/Init.lean,Mathlib/Tactic/Linter/Style.lean,MathlibTest/Linter/DeprecatedSyntax.lean,MathlibTest/Linter/InSection.lean,MathlibTest/Linter/TextBased.lean |
7 |
8 |
['adomani', 'github-actions', 'joneugster', 'leanprover-radar', 'mathlib-merge-conflicts'] |
nobody |
5-5481 5 days ago |
5-5482 5 days ago |
16-2867 16 days |
0 |
| 43637 |
gasparattila author:gasparattila |
feat(Topology/Sets): `ClosedIciTopology` and `OrderClosedTopology` instances for `Compacts` |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-topology
maintainer-merge
|
59/0 |
Mathlib/Topology/Sets/VietorisTopology.lean |
1 |
11 |
['gasparattila', 'github-actions', 'themathqueen'] |
alreadydone assignee:alreadydone |
4-75876 4 days ago |
11-59720 11 days ago |
60-77703 60 days |
0 |
| 44799 |
ooovi author:ooovi |
feat(Geometry/Convex): segments in convex space |
Adds segments and open segments for convex spaces, and provides some basic API. Follows `Mathlib.Analysis.Convex.Segment`.
---
I want to define extreme sets in convex space using open segments. I don't need a lot of API and just ported the basics from analysis, but I'm happy to add more if anyone needs anything.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-convex-geometry
maintainer-merge
|
265/0 |
Mathlib.lean,Mathlib/Geometry/Convex/Segment.lean |
2 |
76 |
['YaelDillies', 'github-actions', 'martinwintermath', 'ooovi', 'vihdzp', 'vlad902'] |
vihdzp assignee:vihdzp |
4-12667 4 days ago |
4-12667 4 days ago |
12-16145 12 days |
1 |
| 45190 |
marcelolynch author:marcelolynch |
ci: replace the remaining Node 20 actions |
GitHub's runners force Node 20 actions onto Node 24 and warn on every run. This change replaces the two actions that target an older Node.
`gh-get-current-pr` has no Node 24 release. The local composite action `.github/actions/find-open-pr` replaces it in the post-CI job, `update_dependencies.yml`, and `remove_deprecated_decls.yml`. The bot workflows find the open PR from their branch. The post-CI job uses the PR from the event or from the pushed branch, and only when the PR head is the commit that CI built. A failed API call fails the step.
`sync-task-issues` targets Node 12. An `actions/github-script` step replaces it in `sync_closed_tasks.yaml`. The step checks the `- [ ] depends on: #N` items when #N closes, and unchecks them when #N reopens.
🤖
|
CI
maintainer-merge
|
139/39 |
.github/actions/find-open-pr/action.yml,.github/workflows/build_template.yml,.github/workflows/remove_deprecated_decls.yml,.github/workflows/sync_closed_tasks.yaml,.github/workflows/update_dependencies.yml,docs/workflows.md |
6 |
7 |
['github-actions', 'joneugster', 'marcelolynch'] |
nobody |
4-1268 4 days ago |
13-82289 13 days ago |
15-5440 15 days |
0 |
| 44843 |
mathlib-splicebot author:mathlib-splicebot |
feat: `isInvertible_fderivWithin_writtenInExtChartAt` |
If the `mfderiv` of `f` is injective (invertible), so is the fderivWithin of `f` written in extended charts. |
t-differential-geometry
maintainer-merge
|
13/4 |
Mathlib/Geometry/Manifold/MFDeriv/Basic.lean |
1 |
11 |
['github-actions', 'grunweg', 'scholzhannah'] |
scholzhannah assignee:scholzhannah |
3-80233 3 days ago |
12-10967 12 days ago |
14-55543 14 days |
2 |
| 45644 |
wwylele author:wwylele |
feat(Analysis/Complex): arg(x*y) and log(x*y) for more cases |
Existing lemma only talks about `arg x + arg y ∈ Set.Ioc (-π) π`. Let's add other cases as well.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-analysis
maintainer-merge
|
40/0 |
Mathlib/Analysis/SpecialFunctions/Complex/Arg.lean,Mathlib/Analysis/SpecialFunctions/Complex/Log.lean |
2 |
8 |
['copilot-pull-request-reviewer', 'github-actions', 'themathqueen', 'wwylele'] |
nobody |
3-67235 3 days ago |
3-70606 3 days ago |
5-23008 5 days |
1 |
| 42327 |
riccardobrasca author:riccardobrasca |
feat: add levelOne_qExpansionAlgHom_injective |
We prove that the `q`-expansion map `ModularForm.qExpansionAlgHom` is injective on the graded ring `⨁ k, ModularForm Γ k` of modular forms of level `Γ`, for any arithmetic subgroup `Γ` (`ModularForm.qExpansionAlgHom_injective`).
We also add various API lemmas to to `CongruenceSubgroups.lean`.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-number-theory
maintainer-merge
|
257/20 |
Mathlib.lean,Mathlib/NumberTheory/ModularForms/CongruenceSubgroups.lean,Mathlib/NumberTheory/ModularForms/Cusps.lean,Mathlib/NumberTheory/ModularForms/QExpansion.lean,Mathlib/NumberTheory/ModularForms/QExpansionInjective.lean |
5 |
18 |
['github-actions', 'loefflerd', 'mathlib-merge-conflicts', 'riccardobrasca'] |
loefflerd assignee:loefflerd |
3-20791 3 days ago |
3-20839 3 days ago |
13-35765 13 days |
0 |
| 45357 |
JovanGerb author:JovanGerb |
chore(Util/Export): deprecate |
The file `Mathlib.Util.Export` defines an export format for Lean declarations. It is not documented, not tested, and seemingly not used. Nowadays, there is the alternative https://github.com/leanprover/lean4export. So, we deprecate this file.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
maintainer-merge
t-meta
|
5/0 |
Mathlib/Util/Export.lean |
1 |
3 |
['github-actions', 'j-loreaux', 'joneugster'] |
digama0 and joneugster assignee:digama0 assignee:joneugster |
3-14811 3 days ago |
13-166 13 days ago |
13-93 13 days |
0 |
| 45637 |
marcelolynch author:marcelolynch |
fix(Cache): repeat `--repo` in suggested cache commands |
When the user passes `--repo`, the cache tool now repeats it in the commands that it suggests. This applies to the suggestions of `cache query` and to the missing-files hint of `cache get`. Without `--repo`, the suggested command reads the cache of the checkout's git remote, which is not the repository that the user asked for.
🤖
|
CI
maintainer-merge
|
30/10 |
Cache/Main.lean,Cache/Query.lean,Cache/Test.lean,Cache/Warning.lean |
4 |
3 |
['github-actions', 'joneugster'] |
joneugster assignee:joneugster |
3-12969 3 days ago |
5-58567 5 days ago |
5-58494 5 days |
0 |
| 45573 |
YaelDillies author:YaelDillies |
chore(Algebra/Polynomial): parse `R[X]` as `R` + `[` + `X` + `]` |
The current notation has several issues:
1. It accepts whitespace, so `R [X]` parses as `Polynomial R` too.
2. It makes `[X]` a token, so `simp [X]` parses as `simp` + `[X]` (a parse error) rather than the expected `simp` + `[` + `X` + `]` because of the longest parse rule.
Replacing the `notation` containing the `[X]` token by a `syntax` containing the `[`, `X`, `]` tokens separated by `noWs` fixes the second issue. Adding one more `noWs` before the `[` token fixes the first issue.
The priority of the syntax is decided in comparison to that of `AddMonoidAlgebra` (which is `high`) and `GetElem`.
Written by Claude Opus, tweaked by myself.
Assisted-by: Claude Opus 5.5
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-algebra
LLM-generated
t-meta
maintainer-merge
label:t-algebra$ |
22/8 |
Mathlib/Algebra/Polynomial/Basic.lean |
1 |
2 |
['github-actions', 'joneugster'] |
joneugster assignee:joneugster |
3-11740 3 days ago |
3-80597 3 days ago |
7-19347 7 days |
0 |
| 44786 |
ZRTMRH author:ZRTMRH |
feat(Lean/Quote): restore `Quote` instances for `Int` and `Rat` |
Add `Quote Int` and `Quote Rat` instances, analogous to core's `Quote Nat`.
They turn a number into numeral syntax without a type ascription (e.g. `quote (-7 / 2 : ℚ)` is `-7 / 2`), so the result elaborates at the expected type. These could later be upstreamed to Lean core.
These instances were added in #942 as part of `polyrith`, fixed in #24470, and removed together with the implementation of `polyrith` in #29547. This PR restores them unchanged (apart from naming) in their own file. Tests provided.
Motivated from the project of `maximize` / `minimize` tactics (PR to follow) which print a computed rational bound in a "Try this" suggestion such as `have : 4 * x + y ≤ 7 / 2 := by linarith`. Discussed on Zulip: [maximize / minimize tactic for linear optimization](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/maximize.20.2F.20minimize.20tactic.20for.20linear.20optimization).
The test file is refined with AI assistance (Claude) and has been reviewed by the author.
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Co-authored-by: Aaron Liu <aaronliu2008@outlook.com>
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-meta
LLM-generated
new-contributor
maintainer-merge
|
164/0 |
Mathlib.lean,Mathlib/Lean/Quote.lean,MathlibTest/Quote.lean |
3 |
6 |
['ZRTMRH', 'github-actions', 'joneugster'] |
joneugster assignee:joneugster |
3-8833 3 days ago |
28-46775 28 days ago |
28-46702 28 days |
0 |
| 44997 |
TJHeeringa author:TJHeeringa |
feat(Analysis/InnerProductSpace): add abs for continuousLinearMaps between Hilbert spaces |
Schatten p-norm is based on the absolute value / modulus for continuous linear maps between Hilbert spaces. This PR adds that absolute value.
---
This PR is split of from #44525, which is a draft for the Schatten operators.
Mathlib has the similar `CFC.abs` but the adjoint is not a star operation for continuous linear maps between different Hilbert spaces.
The API I put here is limited as this is all what is needed to define the Schatten p-norms. If more is desired in this PR, then I'd be happy to add it.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-analysis
maintainer-merge
|
175/0 |
Mathlib.lean,Mathlib/Analysis/InnerProductSpace/Abs.lean,Mathlib/Analysis/InnerProductSpace/Positive.lean |
3 |
88 |
['TJHeeringa', 'github-actions', 'themathqueen'] |
nobody |
2-68805 2 days ago |
2-68858 2 days ago |
16-5323 16 days |
3 |
| 40599 |
ChiCubed author:ChiCubed |
feat(LinearAlgebra): rank-nullity theorems for Submodule map/comap |
We show forms of the rank-nullity theorem involving `Submodule.map` and `Submodule.comap`. Together with `LinearMap.ker_comp` this provides a formula for the rank of the kernel of a composite (and, in finite dimensions at least, for the rank of the range).
---
I didn't explicitly write the aforementioned formula for rank ker (f ∘ g) since it is just `LinearMap.ker_comp` followed by `LinearMap.lift_rank_comap`, but perhaps it should be added for discoverability?
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-algebra
new-contributor
maintainer-merge
label:t-algebra$ |
61/14 |
Mathlib/Algebra/Module/Submodule/Ker.lean,Mathlib/Algebra/Module/Submodule/Map.lean,Mathlib/Algebra/Module/Submodule/Range.lean,Mathlib/LinearAlgebra/Dimension/RankNullity.lean |
4 |
57 |
['ADedecker', 'ChiCubed', 'Vierkantor', 'github-actions', 'jcommelin', 'riccardobrasca', 'tb65536', 'themathqueen', 'wwylele'] |
kim-em assignee:kim-em |
1-84441 1 day ago |
2-19344 2 days ago |
134-77939 134 days |
0 |
| 45582 |
vihdzp author:vihdzp |
feat: interaction between `WithBot.succ` and `Order.pred` |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #45578 |
t-order
maintainer-merge
|
25/5 |
Mathlib/Order/SuccPred/Basic.lean,Mathlib/Order/SuccPred/WithBot.lean |
2 |
10 |
['YaelDillies', 'chenson2018', 'github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'vihdzp'] |
nobody |
1-80150 1 day ago |
2-13867 2 days ago |
3-133 3 days |
0 |
| 45617 |
Zetetic-Dhruv author:Zetetic-Dhruv |
feat(Data/Set/Card): `ncard` of `image2`, and sets of a given `ncard` |
- `Set.ncard_image2_le : (image2 f s t).ncard ≤ s.ncard * t.ncard` for finite `s` and `t`.
- `Set.Infinite.exists_superset_ncard_eq` now also says that the superset is finite; new `Set.exists_subset_ncard_eq`, and `Set.exists_superset_ncard_eq` and `Set.exists_ncard_eq` in an infinite type.
- `Set.ncard_eq_zero_iff : s.ncard = 0 ↔ s = ∅ ∨ s.Infinite`, as a `simp` lemma.
- `Data/Set/Card.lean` gets `set_option linter.style.longFile 1700`.
|
t-data
new-contributor
maintainer-merge
|
27/2 |
Mathlib/Data/Set/Card.lean |
1 |
10 |
['YaelDillies', 'Zetetic-Dhruv', 'github-actions'] |
nobody |
1-78743 1 day ago |
2-58238 2 days ago |
4-52605 4 days |
0 |
| 45761 |
VascoSch92 author:VascoSch92 |
fix(Data/ENat/Defs): derive `Repr` for `ℕ∞` |
Small fix.
`ENat` is a `def` for `WithTop ℕ`, so `WithTop.instRepr` is not found and `repr (5 : ℕ∞)` fails to elaborate.
Fixes #45740.
---
AI use: OpenHands (Claude Opus 5.5) located the cause, and propsed the solution. I verified by hand that the proposed solution was correct.
|
t-data
new-contributor
LLM-generated
maintainer-merge
|
1/1 |
Mathlib/Data/ENat/Defs.lean |
1 |
4 |
['github-actions', 'grunweg'] |
nobody |
1-78575 1 day ago |
2-11390 2 days ago |
2-11317 2 days |
0 |
| 44334 |
JovanGerb author:JovanGerb |
feat: `@[gcongr]` for `eq_top_mono` and friends |
This PR tags lemma `eq_top_mono` and various similar lemmas with `@[gcongr]`. This lets us use `grw` in places where we couldn't before. The supported maximal/minimal constants are `⊤`, `⊥`, `(∅ : Set _)`, `Set.univ`, `0`, `1`, each on either side of an equality `=` and an inequality `≠`.
`subset_eq_empty` is renamed to `eq_empty_of_subset`, to match `eq_univ_of_subset`.
Performance note: `@[gcongr]` lemmas are indexed only by the relation and head constand, which for these lemmas is `→` and `=` or `≠`. So, it will need to try all 12 available lemmas in these cases. I do not think that this will cause any noticeable performance issue. If it does, we can consider a more detailed indexing of `@[gcongr]` lemmas.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-order
t-meta
maintainer-merge
|
68/21 |
Mathlib/Algebra/Order/IsBotOne.lean,Mathlib/Data/Set/Basic.lean,Mathlib/Data/Set/Lattice/Bounded.lean,Mathlib/MeasureTheory/Measure/AddContent/CompactSystem.lean,Mathlib/Order/BoundedOrder/Basic.lean,Mathlib/Order/SetDissipate.lean,Mathlib/Topology/Closure.lean,Mathlib/Topology/Compactness/CompactSystem.lean,Mathlib/Topology/Compactness/Lindelof.lean,Mathlib/Topology/MetricSpace/Thickening.lean,Mathlib/Topology/Separation/Regular.lean,MathlibTest/Tactic/GRewrite.lean |
12 |
5 |
['github-actions', 'joneugster', 'leanprover-radar'] |
nobody |
1-74904 1 day ago |
1-74951 1 day ago |
39-39730 39 days |
1 |
| 44148 |
wwylele author:wwylele |
refactor(Geometry/Euclidean): promote Heron's formula to main mathlib |
Now we have a proper definition of triangle's area, we can make Heron's formula an official theorem in the main library. The original proof was mostly unchanged, with only the following modification
**1. Index change**
The naming and indexing was changed from
```
let a := dist p₁ p₂
let b := dist p₃ p₂
let c := dist p₁ p₃
```
to
```
let a := dist p₁ p₂
let b := dist p₁ p₃
let c := dist p₂ p₃
```
This is to follow the existing indexing convention of "1-2, 1-3, 2-3" for triangles. We have similar order for `h₁₂ h₁₃ h₂₃`
**2. Generalized to all degenerate cases**: Removed `(h1 : p₁ ≠ p₂) (h2 : p₃ ≠ p₂)`
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #41220 |
file-removed
t-euclidean-geometry
maintainer-merge
|
72/71 |
Archive.lean,Archive/Wiedijk100Theorems/HeronsFormula.lean,Mathlib/Geometry/Euclidean/Volume/Triangle.lean,docs/100.yaml |
4 |
10 |
['SnirBroshi', 'copilot-pull-request-reviewer', 'github-actions', 'jsm28', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'wwylele'] |
jsm28 assignee:jsm28 |
1-69257 1 day ago |
1-69333 1 day ago |
12-45179 12 days |
2 |
| 45646 |
Parcly-Taxel author:Parcly-Taxel |
feat: simultaneous Dirichlet approximation theorem |
This is an extension of `Real.exists_int_int_abs_mul_sub_le` to multiple numbers. The proof is similar.
----
I proved this along the way to proving Alon's result on [Erdős Problem 798](https://www.erdosproblems.com/forum/thread/798). Aristotle was only used for formalising _some_ parts of Alon's result – this was not one of those parts. |
t-number-theory
maintainer-merge
|
29/1 |
Mathlib/NumberTheory/DiophantineApproximation/Basic.lean |
1 |
7 |
['MichaelStollBayreuth', 'Parcly-Taxel', 'github-actions'] |
MichaelStollBayreuth assignee:MichaelStollBayreuth |
1-3842 1 day ago |
1-48008 1 day ago |
5-14527 5 days |
0 |
| 41308 |
sergantche author:sergantche |
feat: add `List.insertIdx_eraseIdx_getElem_perm` |
Adds `List.insertIdx_eraseIdx_getElem_perm`, showing that erasing an element by index and inserting it at any valid position gives a permutation of the original list.
This packages the existing lemmas `List.perm_insertIdx` and `List.getElem_cons_eraseIdx_perm` into a direct API lemma.
AI assistance was used in preparing this PR; I reviewed the statement and proof.
[](https://gitpod.io/from-referrer/) |
t-data
new-contributor
LLM-generated
maintainer-merge
|
5/0 |
Mathlib/Data/List/Perm/Basic.lean |
1 |
6 |
['YaelDillies', 'github-actions', 'sergantche', 'vlad902'] |
nobody |
1-540 1 day ago |
119-57547 119 days ago |
123-54344 123 days |
0 |
| Number |
Author |
Title |
Description |
Labels |
+/- |
Modified files (first 100) |
📝 |
💬 |
All users who commented or reviewed |
Assignee(s) |
Updated |
Last status change |
total time in review |
blocks |
| 43745 |
theebayuser author:theebayuser |
feat(Geometry/Euclidean): add Euler's quadrilateral theorem |
Adds Euler's quadrilateral theorem to Mathlib/Geometry/Euclidean/, and records it in docs/1000.yaml (Q18630480). It states: for any four points, the sum of the squares of the four sides of the quadrilateral a b c d equals the sum of the squares of the two diagonals, plus four times the square of the distance between the midpoints of the diagonals.
This PR was written with AI assistance (Claude Code).
|
t-euclidean-geometry
new-contributor
LLM-generated
maintainer-merge
|
84/0 |
Mathlib.lean,Mathlib/Analysis/InnerProductSpace/Basic.lean,Mathlib/Geometry/Euclidean/EulerQuadrilateral.lean,docs/1000.yaml |
4 |
17 |
['github-actions', 'jsm28', 'theebayuser', 'wwylele'] |
nobody |
36-49559 1 month ago |
41-42750 41 days ago |
58-33225 58 days |
0 |
| 44060 |
wwylele author:wwylele |
feat(Geometry/Euclidean): lemma about excenters and volumes |
This proves that volume = inradius * surface / n
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-euclidean-geometry
maintainer-merge
|
112/0 |
Mathlib.lean,Mathlib/Geometry/Euclidean/Volume/Incenter.lean |
2 |
8 |
['SnirBroshi', 'copilot-pull-request-reviewer', 'github-actions', 'jsm28', 'wwylele'] |
nobody |
26-42610 26 days ago |
26-42665 26 days ago |
48-42938 48 days |
2 |
| 41336 |
SnirBroshi author:SnirBroshi |
chore(Combinatorics/SimpleGraph/Girth): golf `egirth_top` using `cycleGraph` |
Golf `egirth_top` (#38529) using `cycleGraph_isContained_iff` (#35255)
Co-authored-by: Vlad Tsyrklevich <vlad@tsyrklevi.ch>
---
Speeds up the proof from ~120ms to ~30ms
(although it used to be ~600ms, not sure what happened, perhaps toolchains sped it up already)
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
5/11 |
Mathlib/Combinatorics/SimpleGraph/Girth.lean |
1 |
3 |
['YaelDillies', 'github-actions', 'mathlib-merge-conflicts'] |
nobody |
18-24693 18 days ago |
40-54856 40 days ago |
128-49258 128 days |
0 |
| 40204 |
Jun2M author:Jun2M |
feat(Combinatorics/HypergraphLike): add HypergraphLike class |
Introduces `HypergraphLike V I E G`, an object-indexed incidence interface for developing common graph theory across different representations.
Defines links and adjacency, incidence maps and fibers, and sets of incident vertices and edges. The basic API provides membership characterizations, fiber disjointness and union identities, and relationships between incidence data, links, and adjacency.
Codex assisted with the initial implementation and review; the code was subsequently revised by me.
The following is a longer write-up about what this PR is for, what this PR has, and why it is in this shape.
## Considerations
1. The main consideration for this PR is to create a common language different graph types can use to communicate their structure. The data in the type class is deliberately chosen to be as general as possible, accommodating hypergraphs, digraphs, simple graphs, and more.
2. (Hyper)Graphs are used both as a setting in which vertices, edges, walks, and colorings live, and as an algebraic object that can be modified. These two viewpoints can sometimes be at odds with each other. This typeclass is an acknowledgement that these two viewpoints are different, and both need to be fully supported separately with explicit connection. `HypergraphLike` is the way to view a graph as a setting. Various different graph structures are ways to view a graph as an algebraic object.
3. Graph theory has a lot of uses outside of graph theory. For example, group theory, topology, and more. The type class is designed to be easily applied to an arbitrary object that can be associated with a graph structure.
## Contents
The definition consists of:
| Data | Meaning |
| --- | --- |
| `V`, `I`, `E` | Ambient types of vertex, incidence, and edge labels |
| `V(G)`, `I(G)`, `E(G)` | The set of objects of the (hyper)graph structure |
| `attach'`, `edgeMap'` | The vertex and edge assigned to each incidence |
| `IsSource`, `IsTarget` | The directions in which an incidence can be traversed |
Every incidence is a source, a target, or both. This allows directed and undirected incidences in the same object. Distinct incidences may belong to the same vertex and edge.
`HypergraphLike` does not require the object to be a graph or hypergraph, or to be related to one. Any object can be associated with a (hyper)graph structure and use the graph theory API as such via a `HypergraphLike` instance. As a result, it is possible for an arbitrary object to be associated with a graph structure that it has nothing to do with.
- **`Link G e u v`:** a traversal of `e` from `u` to `v`, retaining a source incidence and a distinct target incidence. Distinctness prevents entering and leaving an undirected edge through the same incidence.
- **`IsLink` and `Adj`:** the existence of a link through a specified edge, and the existence of an edge linking two vertices.
- **`attach` and `edgeMap`:** total extensions of the incidence maps when the corresponding types are nonempty.
- **`edgeFiber` and `vertexFiber`:** the incidences belonging to an edge or vertex.
- **`incVerts` and `incEdges`:** the vertices incident to an edge and the edges incident to a vertex.
Apart from operations, graph API should be built on this type class. More specialized theories can add assumptions such as undirectedness, looplessness, or restrictions on the incidences of each edge. See PRs #43768, #43748 and more to come.
## Design decisions
### Why not require one concrete representation?
Alternative approach to unify various graph structures is to have one very general hypergraph definition and put all possible API there. By extending the definition with other conditions, you can inherit all the API while describing the graph class you want.
This is not used here because
1. It either loses the expected extensionality or restricts which representations can use the API.
2. The API can be inherited using the current instance method more generally (you don't need to `extend` the particular def to inherit them)
3. These two approaches have virtually no difference in formalization cost.
Asterisk for number 3 is that I have not tried to formalize every part of graph theory so it should be taken with a grain of salt. Nevertheless, I have not found cases where `extend` method reduces the formalization cost significantly.
The generality of application is the strong suit of the current approach. The discussion that led to this PR started with efforts to unify different graph structures in Mathlib and future structures to be implemented. The instance method allows even more flexibility. We could talk about a group (with a chosen generating set) being `HypergraphLike` by associating it with a Cayley graph, a CW complex with its 1-skeleton graph, or a lattice with its Hasse graph, in the same manner `SimpleGraph` is `HypergraphLike`. With `extend`, these will require a separate, bespoke association with the appropriate graph structure.
So, it suffices to argue that number 1 is true. The difficulty comes from the fact that the child structures have to contain additional data and therefore additional freedom that it really doesn't need. Consider two simple graphs `G` and `H`, each with vertex set `{u, v}` and single edge between them. In the naive approach where you define `SimpleGraph` like this:
```lean
structure SimpleGraph (ν ι ε : Type*) extends undirected ν ι ε, noMultiEdges ν ι ε ... where
```
Then, `G = H` may not hold. They could have different edge type, incidence type, edge set, incidence set, etc. That is, we have extensionality issue.
The fix is to constrain further until simple graph structure uniquely determines the rest. Here is one possible definition:
```lean
structure SimpleGraph (ν : Type*) extends undirected ν (ν × ν) (Sym2 ν), noMultiEdges ν (ν × ν) (Sym2 ν) ... where
edgeMap'_eq (i) : edgeMap' i = Sym2.mk i.val.fst i.val.snd
attach'_eq (i) : attach' i = i.val.fst
```
Now, any `multigraph` that happens to be a simple graph cannot use `SimpleGraph` results without going through the normalization function, showing that normalization only changed the labels and showing that the normalization function preserves whatever properties, etc. Results that depend on simplicity should be available for arbitrary incidence representations satisfying simplicity, rather than only for a canonical `SimpleGraph` representation. This happens every time a canonical form is chosen to resolve extensionality issues.
### Why per-object indexing?
Indexing by graph type was something I have adopted from `HasAdj` PR (#35776) without critical thinking. In the discussion for `Quiver` (#45034), as soon as I wrote "HypergraphLike expects you to know the edge type before you know what graph you are working with.", I started to think why this is necessary. It is not.
All the code I have about HypergraphLike can be migrated to per-object indexing very easily. The statements did get longer due to adding `HypergraphLike` instance to each graph object but virtually all proofs worked without any changes.
Philosophically, it makes the role of `HypergraphLike` clearer. `HypergraphLike` is defined to have one common language between different graph structures and that common language is the label types and incidence data. Merely belonging to the same Lean type should not impose additional uniformity. Where a result needs shared labels or compatible incidence maps, it can state those requirements explicitly.
In the cases of `Quiver`, it can be supported by `HypergraphLike` as now we supply the edge type along with the specific `Quiver` instance, not before.
Another benefit is that you can use `HypergraphLike` even when not all elements of a type can be interpreted as a graph. This aligns with the rest of the type class hierarchy being built on `HypergraphLike`. (#43768, #43748) `G : Graph V E` could happen to be a simple graph. A subset of a plane could be graph-like.
### Why ambient labels and support sets?
The `id` function holds a special place in our heads. Consider `G`, K4 graph with vertex set `{1, 2, 3, 4}`, and `H`, K5 graph with vertex set `{1, 2, 3, 4, 5}`. Remove edge `s(1, 2)` from `H`. Up to isomorphism, `G` is still a subgraph of `H`. But, with respect to the `id` function, `G` is no longer a subgraph of `H`.
Without support sets, the vertex set is the whole type, so graphs on different vertex sets live on different types. Then only embeddings can be stated, and you lose the labelled subgraph relation. That is, without some special treatment for subtypes, `HypergraphLike` will say `G` is a subgraph of `H` as there exists embedding of `G` into `H`.
Support sets in the type class are exactly the mechanism that allows "special treatment" for subtypes.
## Related work (Not dependency)
- #36743
- [HasAdj discussion](https://leanprover.zulipchat.com/#narrow/channel/252551-graph-theory/topic/HasAdj/with/575843445)
Co-authored-by: OpenAI Codex <codex@openai.com>
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
LLM-generated
maintainer-merge
|
458/0 |
Mathlib.lean,Mathlib/Combinatorics/HypergraphLike/Basic.lean |
2 |
59 |
['Jun2M', 'SnirBroshi', 'YaelDillies', 'copilot-pull-request-reviewer', 'github-actions', 'tb65536'] |
nobody |
16-2222 16 days ago |
16-43981 16 days ago |
128-70920 128 days |
10 |
| 41629 |
SnirBroshi author:SnirBroshi |
feat(Combinatorics/SimpleGraph/Subgraph): `neighborSet` of `coe`/`spanningCoe` |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
15/3 |
Mathlib/Combinatorics/SimpleGraph/Subgraph.lean |
1 |
2 |
['YaelDillies', 'github-actions'] |
nobody |
15-18286 15 days ago |
120-42571 120 days ago |
120-42498 120 days |
0 |
| 40967 |
Formalistic03 author:Formalistic03 |
feat(Combinatorics/SimpleGraph/Paths): some lemmas about inducing walks |
Could also be done via `SimpleGraph.Walk.map_induce`, but I thought that doing it directly is not much worse.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
new-contributor
t-combinatorics
maintainer-merge
|
59/0 |
Mathlib/Combinatorics/SimpleGraph/Paths.lean,Mathlib/Combinatorics/SimpleGraph/Walk/Maps.lean,Mathlib/Data/List/Nodup.lean,Mathlib/Data/Sym/Sym2.lean |
4 |
34 |
['Formalistic03', 'SnirBroshi', 'github-actions'] |
nobody |
14-49560 14 days ago |
35-11685 35 days ago |
128-72861 128 days |
0 |
| 45029 |
YaelDillies author:YaelDillies |
feat(Util): support `noWS` in `notation3` |
... and use it to define the conditional probability notation `μ[|s]`.
Generated by Claude Opus, reviewed line-by-line by myself.
Zulip discussion: [#mathlib reviewers > status of `notation3` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954)
Assisted-by: Claude Opus 5.5
---
- [ ] awaiting-Zulip: [#mathlib reviewers > status of `notation3` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954)
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
LLM-generated
maintainer-merge
t-meta
awaiting-zulip
|
40/34 |
Mathlib/Probability/ConditionalProbability.lean,Mathlib/Util/Notation3.lean,MathlibTest/Util/Notation3.lean |
3 |
19 |
['JovanGerb', 'Vierkantor', 'YaelDillies', 'eric-wieser', 'github-actions', 'grunweg'] |
Vierkantor assignee:Vierkantor |
14-23181 14 days ago |
16-3252 16 days ago |
4-40864 4 days |
0 |
| 41393 |
SnirBroshi author:SnirBroshi |
feat(SimpleGraph/Hamiltonian): a graph is Hamiltonian iff there's a Hamiltonian path with adjacent endpoints |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #41435
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
32/9 |
Mathlib/Combinatorics/SimpleGraph/Hamiltonian.lean |
1 |
5 |
['YaelDillies', 'github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] |
nobody |
14-7175 14 days ago |
39-46557 39 days ago |
119-37311 119 days |
2 |
| 41722 |
SnirBroshi author:SnirBroshi |
feat(SimpleGraph/Connectivity/Subgraph): `mapToSubgraph` API |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
36/0 |
Mathlib/Combinatorics/SimpleGraph/Connectivity/Subgraph.lean |
1 |
3 |
['YaelDillies', 'github-actions'] |
nobody |
14-2617 14 days ago |
14-2673 14 days ago |
118-22319 118 days |
1 |
| 41793 |
SnirBroshi author:SnirBroshi |
feat(Combinatorics/SimpleGraph): `fromEdgeSet edgeSet` for subgraphs and walks |
`fromEdgeSet G'.edgeSet = G'.spanningCoe` for a subgraph `G'`
`fromEdgeSet p.edgeSet = p.toSubgraph.spanningCoe` for a walk `p`
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
16/2 |
Mathlib/Combinatorics/SimpleGraph/Basic.lean,Mathlib/Combinatorics/SimpleGraph/Connectivity/Subgraph.lean,Mathlib/Combinatorics/SimpleGraph/Subgraph.lean |
3 |
2 |
['YaelDillies', 'github-actions'] |
nobody |
13-17506 13 days ago |
116-65851 116 days ago |
116-65778 116 days |
0 |
| 41623 |
SnirBroshi author:SnirBroshi |
feat(SimpleGraph/Trails): a walk is Eulerian iff it is a trail of length `G.edgeSet.encard` |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
38/3 |
Mathlib/Combinatorics/SimpleGraph/Paths.lean,Mathlib/Combinatorics/SimpleGraph/Trails.lean |
2 |
5 |
['YaelDillies', 'github-actions', 'mathlib-merge-conflicts'] |
nobody |
13-17243 13 days ago |
13-17339 13 days ago |
117-34151 117 days |
0 |
| 41633 |
SnirBroshi author:SnirBroshi |
feat(Combinatorics/SimpleGraph/Paths): length of closed a walk/trail isn't `1`/`2` |
For a closed walk `p`:
- `p.length ≠ 1`
- `p.IsTrail` → `p.length ≠ 2`
- `p.IsTrail` → `p.length ≤ 2` → `p.Nil`
---
Since a circuit is a closed non-nil trail, `IsTrail.nil_of_length_le_two` is basically the contrapositive of `IsCircuit.three_le_length`, but I think this form is useful.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
11/4 |
Mathlib/Combinatorics/SimpleGraph/Paths.lean,Mathlib/Combinatorics/SimpleGraph/Walk/Basic.lean |
2 |
3 |
['YaelDillies', 'github-actions', 'mathlib-merge-conflicts'] |
nobody |
13-17067 13 days ago |
65-1531 65 days ago |
116-19967 116 days |
0 |
| 41241 |
intgrah author:intgrah |
feat(Order/Category): cartesian closed and distributive structure on PartOrd and Preord |
Give `PartOrd` and `Preord` `CartesianMonoidalCategory`, `MonoidalClosed`, and `IsCartesianDistributive` instances.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
new-contributor
t-order
maintainer-merge
|
311/0 |
Mathlib.lean,Mathlib/Order/Category/PartOrd/CartesianClosed.lean,Mathlib/Order/Category/PartOrd/Colimits.lean,Mathlib/Order/Category/PartOrd/Reflective.lean,Mathlib/Order/Category/Preord/CartesianClosed.lean,Mathlib/Order/Category/Preord/Colimits.lean,Mathlib/Order/Category/Preord/Reflective.lean,Mathlib/Tactic/Linter/DirectoryDependency.lean |
8 |
27 |
['Vierkantor', 'YaelDillies', 'github-actions', 'intgrah', 'thomaskwaring'] |
nobody |
12-81973 12 days ago |
13-83851 13 days ago |
126-62066 126 days |
0 |
| 44996 |
WenrongZou author:WenrongZou |
feat(MvPowerSeries/Order): order of a difference of products |
In this PR, we add some lemmas about `MvPowerSeries.order`.
- `coeff_eq_of_lt_weightedOrder_sub`: if `weight w d < (f - g).weightedOrder w`, then `coeff d f = coeff d g`.
- `le_weightedOrder_prod_sub_prod`: if `n ≤ (a i - b i).weightedOrder w` for all `i ∈ s`, then `n ≤ (∏ i ∈ s, a i - ∏ i ∈ s, b i).weightedOrder w`.
- `add_nsmul_le_weightedOrder_prod_sub_prod`: if, in addition, every `a i` and `b i` has weighted order at least `k`, the bound becomes `n + (#s - 1) • k`.
We also add the corresponding `order` versions: `coeff_eq_of_lt_order_sub`, `le_order_prod_sub_prod` and `add_nsmul_le_order_prod_sub_prod`.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-ring-theory
maintainer-merge
|
55/1 |
Mathlib/RingTheory/MvPowerSeries/Order.lean |
1 |
7 |
['Vierkantor', 'WenrongZou', 'github-actions', 'riccardobrasca'] |
nobody |
12-4858 12 days ago |
18-9973 18 days ago |
22-13712 22 days |
1 |
| 45062 |
Parcly-Taxel author:Parcly-Taxel |
chore: remove more `defeqAttrib` options |
I ran `rm_set_option` on my laptop after #45027 but before #45039. These are the places where `set_option backward.defeqAttrib.useBackward true in` could be removed without errors, but doing so triggered the `unusedSimpArgs` linter. |
tech debt
maintainer-merge
awaiting-author
|
20/50 |
Mathlib/Algebra/Category/MonCat/Limits.lean,Mathlib/Algebra/Category/Ring/Constructions.lean,Mathlib/AlgebraicGeometry/Morphisms/RingHomProperties.lean,Mathlib/CategoryTheory/Functor/KanExtension/Basic.lean,Mathlib/CategoryTheory/Limits/Presheaf.lean,Mathlib/CategoryTheory/Limits/Shapes/SequentialProduct.lean,Mathlib/CategoryTheory/Sites/IsSheafFor.lean,Mathlib/CategoryTheory/Sites/Subcanonical.lean,Mathlib/CategoryTheory/Topos/Sheaf.lean,Mathlib/Condensed/Discrete/Colimit.lean,Mathlib/Geometry/RingedSpace/PresheafedSpace.lean,Mathlib/Topology/Sheaves/Alexandrov.lean,Mathlib/Topology/Sheaves/Skyscraper.lean |
13 |
8 |
['Parcly-Taxel', 'github-actions', 'grunweg', 'mathlib-merge-conflicts', 'themathqueen'] |
nobody |
7-20829 7 days ago |
16-84079 16 days ago |
1-43157 1 day |
0 |
| 42370 |
SnirBroshi author:SnirBroshi |
feat(Combinatorics/SimpleGraph/Maps): more `map`/`comap` API |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
114/9 |
Mathlib/Combinatorics/SimpleGraph/Maps.lean |
1 |
3 |
['Ruben-VandeVelde', 'github-actions', 'mathlib-merge-conflicts'] |
nobody |
6-59353 6 days ago |
63-64021 63 days ago |
98-21995 98 days |
1 |
| 43305 |
WenrongZou author:WenrongZou |
feat(PowerSeries/Derivative): add some lemmas |
In this PR, I migrated some results from Polynomial/Derivative.lean to PowerSeries/Derivative.lean.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-ring-theory
maintainer-merge
|
59/0 |
Mathlib/RingTheory/PowerSeries/Derivative.lean |
1 |
5 |
['Ruben-VandeVelde', 'WenrongZou', 'github-actions'] |
nobody |
6-56420 6 days ago |
6-56487 6 days ago |
68-82174 68 days |
0 |
| 41823 |
tb65536 author:tb65536 |
feat(Combinatorics/Design/Defs): definitions of combinatorial designs |
This PR adds the definitions of combinatorial designs.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
151/0 |
Mathlib.lean,Mathlib/Combinatorics/Design/Defs.lean |
2 |
18 |
['Jun2M', 'Parcly-Taxel', 'YaelDillies', 'github-actions', 'tb65536'] |
nobody |
6-38970 6 days ago |
7-14949 7 days ago |
115-54220 115 days |
1 |
| 45575 |
lua-vr author:lua-vr |
feat(Topology/Instances/AddCircle): `Infinite (AddCircle p)` for a densely ordered group |
---
Suggested in https://github.com/leanprover-community/mathlib4/pull/45360#discussion_r4408995830. If the scalars form an ordered group, then this version should be more general than using divisibility. CC @vihdzp
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
<!-- Message of single commit: --> |
t-topology
maintainer-merge
|
12/0 |
Mathlib/Topology/Instances/AddCircle/Defs.lean |
1 |
11 |
['felixpernegger', 'github-actions', 'lua-vr', 'vihdzp'] |
nobody |
5-79874 5 days ago |
5-80221 5 days ago |
7-3141 7 days |
2 |
| 45593 |
TJHeeringa author:TJHeeringa |
feat(Analysis/InnerProductSpace/Positive): add norm_map_le_iff_adjoint_comp_self(_le_id) |
This PR add the theorem `norm_map_le_iff_adjoint_comp_self`, which states that `‖p x‖ ≤ ‖q x‖` holds if and only if `adjoint p ∘L p ≤ adjoint q ∘L q` is true, and the corollary of this for `q = .id 𝕜 E` named `norm_map_le_iff_adjoint_comp_self_le_id`.
---
This is the contraction version of `norm_map_iff_adjoint_comp_self`.
This should probably go into dedicated to contractive maps, but that doesn't exist yet. Future PR?
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-analysis
maintainer-merge
|
13/0 |
Mathlib/Analysis/InnerProductSpace/Positive.lean |
1 |
16 |
['TJHeeringa', 'github-actions', 'themathqueen'] |
nobody |
5-8170 5 days ago |
5-63722 5 days ago |
5-69092 5 days |
0 |
| 45024 |
kim-em author:kim-em |
feat(linter): reject commands scoped with in section |
Commands such as `variable ... in section` do not open the section that their layout suggests: the generated `end` closes the inner section immediately and leaves the generated outer scope open. Named sections fail outright. Prefer opening a section first and putting the command inside it.
Add `linter.style.inSection` to the standard linter set for any command prefix ending in `section`, including `omit`, `include`, `variable`, `set_option`, `open`, `attribute`, local notation, and `universe`. The check uses the generic command-level `in` syntax instead of a list of command names. Nested prefixes receive one warning; scoped linter options are respected. The check lives in the existing style-linter module and adds no imports or separate source scan.
Fix both existing library uses: `Mathlib/Data/TypeVec.lean` (`variable`) and `Mathlib/CategoryTheory/Limits/Shapes/Pullback/IsPullback/BicartesianSq.lean` (`omit`). Preserve the eight intentional `set_option ... in section` test blocks in two existing test files with local opt-outs.
Tests cover all eight command forms above, multiline syntax and comments, section modifiers, nested wrappers, option disabling/re-enabling, valid per-declaration and ordinary section forms, quotations, strings, and elaboration failures. The new test file and both modified test files pass. Both changed library modules compile with the standard linter set and warnings as errors; all 327 compiled declaration-type fingerprints are unchanged. Text-style lint and `git diff --check` pass.
This PR targets current `master` independently of #45016 and #45017, and does not decide whether plain `omit` should be restricted.
:robot: prepared with Codex
|
maintainer-merge
t-linter
merge-conflict
|
274/2 |
Mathlib/CategoryTheory/Limits/Shapes/Pullback/IsPullback/BicartesianSq.lean,Mathlib/Data/TypeVec.lean,Mathlib/Init.lean,Mathlib/Tactic/Linter/Style.lean,MathlibTest/Linter/DeprecatedSyntax.lean,MathlibTest/Linter/InSection.lean,MathlibTest/Linter/TextBased.lean |
7 |
8 |
['adomani', 'github-actions', 'joneugster', 'leanprover-radar', 'mathlib-merge-conflicts'] |
nobody |
5-5481 5 days ago |
5-5482 5 days ago |
16-2867 16 days |
0 |
| 43637 |
gasparattila author:gasparattila |
feat(Topology/Sets): `ClosedIciTopology` and `OrderClosedTopology` instances for `Compacts` |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-topology
maintainer-merge
|
59/0 |
Mathlib/Topology/Sets/VietorisTopology.lean |
1 |
11 |
['gasparattila', 'github-actions', 'themathqueen'] |
alreadydone assignee:alreadydone |
4-75876 4 days ago |
11-59720 11 days ago |
60-77703 60 days |
0 |
| 44799 |
ooovi author:ooovi |
feat(Geometry/Convex): segments in convex space |
Adds segments and open segments for convex spaces, and provides some basic API. Follows `Mathlib.Analysis.Convex.Segment`.
---
I want to define extreme sets in convex space using open segments. I don't need a lot of API and just ported the basics from analysis, but I'm happy to add more if anyone needs anything.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-convex-geometry
maintainer-merge
|
265/0 |
Mathlib.lean,Mathlib/Geometry/Convex/Segment.lean |
2 |
76 |
['YaelDillies', 'github-actions', 'martinwintermath', 'ooovi', 'vihdzp', 'vlad902'] |
vihdzp assignee:vihdzp |
4-12667 4 days ago |
4-12667 4 days ago |
12-16145 12 days |
1 |
| 45190 |
marcelolynch author:marcelolynch |
ci: replace the remaining Node 20 actions |
GitHub's runners force Node 20 actions onto Node 24 and warn on every run. This change replaces the two actions that target an older Node.
`gh-get-current-pr` has no Node 24 release. The local composite action `.github/actions/find-open-pr` replaces it in the post-CI job, `update_dependencies.yml`, and `remove_deprecated_decls.yml`. The bot workflows find the open PR from their branch. The post-CI job uses the PR from the event or from the pushed branch, and only when the PR head is the commit that CI built. A failed API call fails the step.
`sync-task-issues` targets Node 12. An `actions/github-script` step replaces it in `sync_closed_tasks.yaml`. The step checks the `- [ ] depends on: #N` items when #N closes, and unchecks them when #N reopens.
🤖
|
CI
maintainer-merge
|
139/39 |
.github/actions/find-open-pr/action.yml,.github/workflows/build_template.yml,.github/workflows/remove_deprecated_decls.yml,.github/workflows/sync_closed_tasks.yaml,.github/workflows/update_dependencies.yml,docs/workflows.md |
6 |
7 |
['github-actions', 'joneugster', 'marcelolynch'] |
nobody |
4-1268 4 days ago |
13-82289 13 days ago |
15-5440 15 days |
0 |
| 44843 |
mathlib-splicebot author:mathlib-splicebot |
feat: `isInvertible_fderivWithin_writtenInExtChartAt` |
If the `mfderiv` of `f` is injective (invertible), so is the fderivWithin of `f` written in extended charts. |
t-differential-geometry
maintainer-merge
|
13/4 |
Mathlib/Geometry/Manifold/MFDeriv/Basic.lean |
1 |
11 |
['github-actions', 'grunweg', 'scholzhannah'] |
scholzhannah assignee:scholzhannah |
3-80233 3 days ago |
12-10967 12 days ago |
14-55543 14 days |
2 |
| 45644 |
wwylele author:wwylele |
feat(Analysis/Complex): arg(x*y) and log(x*y) for more cases |
Existing lemma only talks about `arg x + arg y ∈ Set.Ioc (-π) π`. Let's add other cases as well.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-analysis
maintainer-merge
|
40/0 |
Mathlib/Analysis/SpecialFunctions/Complex/Arg.lean,Mathlib/Analysis/SpecialFunctions/Complex/Log.lean |
2 |
8 |
['copilot-pull-request-reviewer', 'github-actions', 'themathqueen', 'wwylele'] |
nobody |
3-67235 3 days ago |
3-70606 3 days ago |
5-23008 5 days |
1 |
| 42327 |
riccardobrasca author:riccardobrasca |
feat: add levelOne_qExpansionAlgHom_injective |
We prove that the `q`-expansion map `ModularForm.qExpansionAlgHom` is injective on the graded ring `⨁ k, ModularForm Γ k` of modular forms of level `Γ`, for any arithmetic subgroup `Γ` (`ModularForm.qExpansionAlgHom_injective`).
We also add various API lemmas to to `CongruenceSubgroups.lean`.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-number-theory
maintainer-merge
|
257/20 |
Mathlib.lean,Mathlib/NumberTheory/ModularForms/CongruenceSubgroups.lean,Mathlib/NumberTheory/ModularForms/Cusps.lean,Mathlib/NumberTheory/ModularForms/QExpansion.lean,Mathlib/NumberTheory/ModularForms/QExpansionInjective.lean |
5 |
18 |
['github-actions', 'loefflerd', 'mathlib-merge-conflicts', 'riccardobrasca'] |
loefflerd assignee:loefflerd |
3-20791 3 days ago |
3-20839 3 days ago |
13-35765 13 days |
0 |
| 45357 |
JovanGerb author:JovanGerb |
chore(Util/Export): deprecate |
The file `Mathlib.Util.Export` defines an export format for Lean declarations. It is not documented, not tested, and seemingly not used. Nowadays, there is the alternative https://github.com/leanprover/lean4export. So, we deprecate this file.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
maintainer-merge
t-meta
|
5/0 |
Mathlib/Util/Export.lean |
1 |
3 |
['github-actions', 'j-loreaux', 'joneugster'] |
digama0 and joneugster assignee:digama0 assignee:joneugster |
3-14811 3 days ago |
13-166 13 days ago |
13-93 13 days |
0 |
| 45637 |
marcelolynch author:marcelolynch |
fix(Cache): repeat `--repo` in suggested cache commands |
When the user passes `--repo`, the cache tool now repeats it in the commands that it suggests. This applies to the suggestions of `cache query` and to the missing-files hint of `cache get`. Without `--repo`, the suggested command reads the cache of the checkout's git remote, which is not the repository that the user asked for.
🤖
|
CI
maintainer-merge
|
30/10 |
Cache/Main.lean,Cache/Query.lean,Cache/Test.lean,Cache/Warning.lean |
4 |
3 |
['github-actions', 'joneugster'] |
joneugster assignee:joneugster |
3-12969 3 days ago |
5-58567 5 days ago |
5-58494 5 days |
0 |
| 45573 |
YaelDillies author:YaelDillies |
chore(Algebra/Polynomial): parse `R[X]` as `R` + `[` + `X` + `]` |
The current notation has several issues:
1. It accepts whitespace, so `R [X]` parses as `Polynomial R` too.
2. It makes `[X]` a token, so `simp [X]` parses as `simp` + `[X]` (a parse error) rather than the expected `simp` + `[` + `X` + `]` because of the longest parse rule.
Replacing the `notation` containing the `[X]` token by a `syntax` containing the `[`, `X`, `]` tokens separated by `noWs` fixes the second issue. Adding one more `noWs` before the `[` token fixes the first issue.
The priority of the syntax is decided in comparison to that of `AddMonoidAlgebra` (which is `high`) and `GetElem`.
Written by Claude Opus, tweaked by myself.
Assisted-by: Claude Opus 5.5
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-algebra
LLM-generated
t-meta
maintainer-merge
label:t-algebra$ |
22/8 |
Mathlib/Algebra/Polynomial/Basic.lean |
1 |
2 |
['github-actions', 'joneugster'] |
joneugster assignee:joneugster |
3-11740 3 days ago |
3-80597 3 days ago |
7-19347 7 days |
0 |
| 44786 |
ZRTMRH author:ZRTMRH |
feat(Lean/Quote): restore `Quote` instances for `Int` and `Rat` |
Add `Quote Int` and `Quote Rat` instances, analogous to core's `Quote Nat`.
They turn a number into numeral syntax without a type ascription (e.g. `quote (-7 / 2 : ℚ)` is `-7 / 2`), so the result elaborates at the expected type. These could later be upstreamed to Lean core.
These instances were added in #942 as part of `polyrith`, fixed in #24470, and removed together with the implementation of `polyrith` in #29547. This PR restores them unchanged (apart from naming) in their own file. Tests provided.
Motivated from the project of `maximize` / `minimize` tactics (PR to follow) which print a computed rational bound in a "Try this" suggestion such as `have : 4 * x + y ≤ 7 / 2 := by linarith`. Discussed on Zulip: [maximize / minimize tactic for linear optimization](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/maximize.20.2F.20minimize.20tactic.20for.20linear.20optimization).
The test file is refined with AI assistance (Claude) and has been reviewed by the author.
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Co-authored-by: Aaron Liu <aaronliu2008@outlook.com>
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-meta
LLM-generated
new-contributor
maintainer-merge
|
164/0 |
Mathlib.lean,Mathlib/Lean/Quote.lean,MathlibTest/Quote.lean |
3 |
6 |
['ZRTMRH', 'github-actions', 'joneugster'] |
joneugster assignee:joneugster |
3-8833 3 days ago |
28-46775 28 days ago |
28-46702 28 days |
0 |
| 44997 |
TJHeeringa author:TJHeeringa |
feat(Analysis/InnerProductSpace): add abs for continuousLinearMaps between Hilbert spaces |
Schatten p-norm is based on the absolute value / modulus for continuous linear maps between Hilbert spaces. This PR adds that absolute value.
---
This PR is split of from #44525, which is a draft for the Schatten operators.
Mathlib has the similar `CFC.abs` but the adjoint is not a star operation for continuous linear maps between different Hilbert spaces.
The API I put here is limited as this is all what is needed to define the Schatten p-norms. If more is desired in this PR, then I'd be happy to add it.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-analysis
maintainer-merge
|
175/0 |
Mathlib.lean,Mathlib/Analysis/InnerProductSpace/Abs.lean,Mathlib/Analysis/InnerProductSpace/Positive.lean |
3 |
88 |
['TJHeeringa', 'github-actions', 'themathqueen'] |
nobody |
2-68805 2 days ago |
2-68858 2 days ago |
16-5323 16 days |
3 |
| 40599 |
ChiCubed author:ChiCubed |
feat(LinearAlgebra): rank-nullity theorems for Submodule map/comap |
We show forms of the rank-nullity theorem involving `Submodule.map` and `Submodule.comap`. Together with `LinearMap.ker_comp` this provides a formula for the rank of the kernel of a composite (and, in finite dimensions at least, for the rank of the range).
---
I didn't explicitly write the aforementioned formula for rank ker (f ∘ g) since it is just `LinearMap.ker_comp` followed by `LinearMap.lift_rank_comap`, but perhaps it should be added for discoverability?
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-algebra
new-contributor
maintainer-merge
label:t-algebra$ |
61/14 |
Mathlib/Algebra/Module/Submodule/Ker.lean,Mathlib/Algebra/Module/Submodule/Map.lean,Mathlib/Algebra/Module/Submodule/Range.lean,Mathlib/LinearAlgebra/Dimension/RankNullity.lean |
4 |
57 |
['ADedecker', 'ChiCubed', 'Vierkantor', 'github-actions', 'jcommelin', 'riccardobrasca', 'tb65536', 'themathqueen', 'wwylele'] |
kim-em assignee:kim-em |
1-84441 1 day ago |
2-19344 2 days ago |
134-77939 134 days |
0 |
| 45582 |
vihdzp author:vihdzp |
feat: interaction between `WithBot.succ` and `Order.pred` |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #45578 |
t-order
maintainer-merge
|
25/5 |
Mathlib/Order/SuccPred/Basic.lean,Mathlib/Order/SuccPred/WithBot.lean |
2 |
10 |
['YaelDillies', 'chenson2018', 'github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'vihdzp'] |
nobody |
1-80150 1 day ago |
2-13867 2 days ago |
3-133 3 days |
0 |
| 45617 |
Zetetic-Dhruv author:Zetetic-Dhruv |
feat(Data/Set/Card): `ncard` of `image2`, and sets of a given `ncard` |
- `Set.ncard_image2_le : (image2 f s t).ncard ≤ s.ncard * t.ncard` for finite `s` and `t`.
- `Set.Infinite.exists_superset_ncard_eq` now also says that the superset is finite; new `Set.exists_subset_ncard_eq`, and `Set.exists_superset_ncard_eq` and `Set.exists_ncard_eq` in an infinite type.
- `Set.ncard_eq_zero_iff : s.ncard = 0 ↔ s = ∅ ∨ s.Infinite`, as a `simp` lemma.
- `Data/Set/Card.lean` gets `set_option linter.style.longFile 1700`.
|
t-data
new-contributor
maintainer-merge
|
27/2 |
Mathlib/Data/Set/Card.lean |
1 |
10 |
['YaelDillies', 'Zetetic-Dhruv', 'github-actions'] |
nobody |
1-78743 1 day ago |
2-58238 2 days ago |
4-52605 4 days |
0 |
| 45761 |
VascoSch92 author:VascoSch92 |
fix(Data/ENat/Defs): derive `Repr` for `ℕ∞` |
Small fix.
`ENat` is a `def` for `WithTop ℕ`, so `WithTop.instRepr` is not found and `repr (5 : ℕ∞)` fails to elaborate.
Fixes #45740.
---
AI use: OpenHands (Claude Opus 5.5) located the cause, and propsed the solution. I verified by hand that the proposed solution was correct.
|
t-data
new-contributor
LLM-generated
maintainer-merge
|
1/1 |
Mathlib/Data/ENat/Defs.lean |
1 |
4 |
['github-actions', 'grunweg'] |
nobody |
1-78575 1 day ago |
2-11390 2 days ago |
2-11317 2 days |
0 |
| 44334 |
JovanGerb author:JovanGerb |
feat: `@[gcongr]` for `eq_top_mono` and friends |
This PR tags lemma `eq_top_mono` and various similar lemmas with `@[gcongr]`. This lets us use `grw` in places where we couldn't before. The supported maximal/minimal constants are `⊤`, `⊥`, `(∅ : Set _)`, `Set.univ`, `0`, `1`, each on either side of an equality `=` and an inequality `≠`.
`subset_eq_empty` is renamed to `eq_empty_of_subset`, to match `eq_univ_of_subset`.
Performance note: `@[gcongr]` lemmas are indexed only by the relation and head constand, which for these lemmas is `→` and `=` or `≠`. So, it will need to try all 12 available lemmas in these cases. I do not think that this will cause any noticeable performance issue. If it does, we can consider a more detailed indexing of `@[gcongr]` lemmas.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-order
t-meta
maintainer-merge
|
68/21 |
Mathlib/Algebra/Order/IsBotOne.lean,Mathlib/Data/Set/Basic.lean,Mathlib/Data/Set/Lattice/Bounded.lean,Mathlib/MeasureTheory/Measure/AddContent/CompactSystem.lean,Mathlib/Order/BoundedOrder/Basic.lean,Mathlib/Order/SetDissipate.lean,Mathlib/Topology/Closure.lean,Mathlib/Topology/Compactness/CompactSystem.lean,Mathlib/Topology/Compactness/Lindelof.lean,Mathlib/Topology/MetricSpace/Thickening.lean,Mathlib/Topology/Separation/Regular.lean,MathlibTest/Tactic/GRewrite.lean |
12 |
5 |
['github-actions', 'joneugster', 'leanprover-radar'] |
nobody |
1-74904 1 day ago |
1-74951 1 day ago |
39-39730 39 days |
1 |
| 44148 |
wwylele author:wwylele |
refactor(Geometry/Euclidean): promote Heron's formula to main mathlib |
Now we have a proper definition of triangle's area, we can make Heron's formula an official theorem in the main library. The original proof was mostly unchanged, with only the following modification
**1. Index change**
The naming and indexing was changed from
```
let a := dist p₁ p₂
let b := dist p₃ p₂
let c := dist p₁ p₃
```
to
```
let a := dist p₁ p₂
let b := dist p₁ p₃
let c := dist p₂ p₃
```
This is to follow the existing indexing convention of "1-2, 1-3, 2-3" for triangles. We have similar order for `h₁₂ h₁₃ h₂₃`
**2. Generalized to all degenerate cases**: Removed `(h1 : p₁ ≠ p₂) (h2 : p₃ ≠ p₂)`
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #41220 |
file-removed
t-euclidean-geometry
maintainer-merge
|
72/71 |
Archive.lean,Archive/Wiedijk100Theorems/HeronsFormula.lean,Mathlib/Geometry/Euclidean/Volume/Triangle.lean,docs/100.yaml |
4 |
10 |
['SnirBroshi', 'copilot-pull-request-reviewer', 'github-actions', 'jsm28', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'wwylele'] |
jsm28 assignee:jsm28 |
1-69257 1 day ago |
1-69333 1 day ago |
12-45179 12 days |
2 |
| 45646 |
Parcly-Taxel author:Parcly-Taxel |
feat: simultaneous Dirichlet approximation theorem |
This is an extension of `Real.exists_int_int_abs_mul_sub_le` to multiple numbers. The proof is similar.
----
I proved this along the way to proving Alon's result on [Erdős Problem 798](https://www.erdosproblems.com/forum/thread/798). Aristotle was only used for formalising _some_ parts of Alon's result – this was not one of those parts. |
t-number-theory
maintainer-merge
|
29/1 |
Mathlib/NumberTheory/DiophantineApproximation/Basic.lean |
1 |
7 |
['MichaelStollBayreuth', 'Parcly-Taxel', 'github-actions'] |
MichaelStollBayreuth assignee:MichaelStollBayreuth |
1-3842 1 day ago |
1-48008 1 day ago |
5-14527 5 days |
0 |
| 41308 |
sergantche author:sergantche |
feat: add `List.insertIdx_eraseIdx_getElem_perm` |
Adds `List.insertIdx_eraseIdx_getElem_perm`, showing that erasing an element by index and inserting it at any valid position gives a permutation of the original list.
This packages the existing lemmas `List.perm_insertIdx` and `List.getElem_cons_eraseIdx_perm` into a direct API lemma.
AI assistance was used in preparing this PR; I reviewed the statement and proof.
[](https://gitpod.io/from-referrer/) |
t-data
new-contributor
LLM-generated
maintainer-merge
|
5/0 |
Mathlib/Data/List/Perm/Basic.lean |
1 |
6 |
['YaelDillies', 'github-actions', 'sergantche', 'vlad902'] |
nobody |
1-540 1 day ago |
119-57547 119 days ago |
123-54344 123 days |
0 |
| 41478 |
SnirBroshi author:SnirBroshi |
feat(Combinatorics/SimpleGraph/Paths): more length upper bounds |
Bound the lengths of trails/paths/circuits/cycles by `ENat.card V`/`Nat.card V`/`G.edgeSet.encard`/`G.edgeSet.ncard`.
---
I then used these to slightly golf some other lemmas.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #41476
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
maintainer-merge
|
38/28 |
Mathlib/Combinatorics/SimpleGraph/Paths.lean |
1 |
6 |
['YaelDillies', 'github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] |
nobody |
0-18789 5 hours ago |
41-82645 41 days ago |
86-59942 86 days |
0 |
| 45570 |
BryceT233 author:BryceT233 |
feat(Algebra/TotalMonoidAlgebra): add unit and multiplication |
We added unit and multiplication of total monoid algebras.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
This is a split of #41472 |
t-algebra
maintainer-merge
label:t-algebra$ |
261/0 |
Mathlib/Algebra/MonoidAlgebra/Defs.lean,Mathlib/Algebra/TotalMonoidAlgebra/Defs.lean |
2 |
7 |
['BryceT233', 'YaelDillies', 'github-actions'] |
nobody |
0-18597 5 hours ago |
0-47524 13 hours ago |
6-63524 6 days |
1 |
| 45174 |
YaelDillies author:YaelDillies |
feat({Topology,MeasureTheory}): instances for `Additive`/`Multiplicative` |
This will help me deduce results about automatic continuity of `AddChar`s from the analogous ones for `AddMonoidHom`.
From MeanFourier
Generated by Claude Sonnet, reviewed line-by-line by myself.
Assisted-by: Claude Sonnet 5.5
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-topology
LLM-generated
t-measure-probability
maintainer-merge
|
45/0 |
Mathlib/MeasureTheory/Constructions/BorelSpace/Basic.lean,Mathlib/MeasureTheory/MeasurableSpace/Constructions.lean,Mathlib/MeasureTheory/MeasurableSpace/Embedding.lean,Mathlib/Topology/Bases.lean |
4 |
6 |
['EtienneC30', 'YaelDillies', 'github-actions'] |
urkud assignee:urkud |
0-17256 4 hours ago |
0-17436 4 hours ago |
15-2433 15 days |
1 |
| 45806 |
vihdzp author:vihdzp |
chore(GroupTheory/Coxeter/Basic): clean up `set_option` |
We make `CoxeterSystem.Group` into an `abbrev`, so the `PresentedGroup` API can be used directly for it.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
Mathematically speaking, I'd say Coxeter groups *are* presented groups, so making this transparent seems reasonable to me. |
tech debt
t-group-theory
maintainer-merge
|
28/42 |
Mathlib/GroupTheory/Coxeter/Basic.lean |
1 |
3 |
['github-actions', 'grunweg'] |
nobody |
0-16599 4 hours ago |
1-5284 1 day ago |
1-6110 1 day |
2 |
| 45749 |
grunweg author:grunweg |
chore: golf using finiteness |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
maintainer-merge |
27/37 |
Mathlib/Analysis/BoundedVariation.lean,Mathlib/Analysis/Distribution/SchwartzSpace/Basic.lean,Mathlib/MeasureTheory/Function/ConditionalExpectation/CondexpL2.lean,Mathlib/MeasureTheory/Function/L1Space/Integrable.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Basic.lean,Mathlib/MeasureTheory/Function/LpSeminorm/SMul.lean,Mathlib/MeasureTheory/Function/SimpleFuncDenseLp.lean,Mathlib/MeasureTheory/Integral/BoundedContinuousFunction.lean,Mathlib/MeasureTheory/Integral/Lebesgue/Countable.lean,Mathlib/MeasureTheory/Integral/Prod.lean,Mathlib/MeasureTheory/Integral/SetToL1/ChangeMeasure.lean,Mathlib/MeasureTheory/Measure/Hausdorff.lean,Mathlib/MeasureTheory/Measure/Prod.lean,Mathlib/MeasureTheory/Measure/Typeclasses/SFinite.lean,Mathlib/NumberTheory/NumberField/CanonicalEmbedding/ConvexBody.lean,Mathlib/Topology/MetricSpace/Antilipschitz.lean |
16 |
7 |
['github-actions', 'grunweg', 'mcdoll', 'themathqueen'] |
nobody |
0-15774 4 hours ago |
2-56103 2 days ago |
2-56030 2 days |
0 |
| 45805 |
vihdzp author:vihdzp |
chore(Algebra/Order/Group/Indicator): generalize typeclasses |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-algebra
easy
maintainer-merge
label:t-algebra$ |
3/3 |
Mathlib/Algebra/Order/Group/Indicator.lean |
1 |
2 |
['Hagb', 'github-actions', 'grunweg', 'vlad902'] |
nobody |
0-11992 3 hours ago |
1-1305 1 day ago |
1-1232 1 day |
0 |
| 45803 |
vihdzp author:vihdzp |
chore(Algebra/Order/Monoid/WithTop): generalize typeclass assumptions |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-algebra
easy
maintainer-merge
label:t-algebra$ |
7/7 |
Mathlib/Algebra/Order/Monoid/Unbundled/WithTop.lean,Mathlib/Algebra/Order/Monoid/WithTop.lean,Mathlib/Order/SuccPred/ENat.lean |
3 |
3 |
['Hagb', 'github-actions', 'grunweg', 'vlad902'] |
nobody |
0-11080 3 hours ago |
0-39595 10 hours ago |
0-39522 10 hours |
0 |
| 45804 |
vihdzp author:vihdzp |
chore(Dynamics/Flow): generalize typeclass assumptions |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-dynamics
easy
maintainer-merge
|
10/11 |
Mathlib/Dynamics/Flow.lean |
1 |
5 |
['Hagb', 'github-actions', 'grunweg', 'leanprover-radar'] |
nobody |
0-10510 2 hours ago |
0-41140 11 hours ago |
0-41067 11 hours |
0 |
| 45793 |
Hagb author:Hagb |
feat(Data/{D,}Finsupp/WellFounded): weaken `AddMonoid` to `Zero` in `WellFoundedLT` instances |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-data
easy
maintainer-merge
|
6/6 |
Mathlib/Data/DFinsupp/WellFounded.lean,Mathlib/Data/Finsupp/WellFounded.lean |
2 |
10 |
['Hagb', 'github-actions', 'grunweg', 'leanprover-radar', 'vihdzp'] |
nobody |
0-8653 2 hours ago |
1-43713 1 day ago |
1-43640 1 day |
0 |
| 45758 |
grunweg author:grunweg |
doc(RepresentationTheory/Action): rewrite module doc-string |
The current header 'Main properties' is not very information (and should also be a level one header). Add a more informative header and rewrite the introductory paragraph slightly.
While we're at it, remove a TODO that has been completed by now.
-----
Claude Code was used to suggest a better title and a new paragraph. I then rewrote the paragraph by hand, to remove the AI speak.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
maintainer-merge |
6/7 |
Mathlib/RepresentationTheory/Action.lean |
1 |
5 |
['Whysoserioushah', 'github-actions', 'grunweg'] |
nobody |
0-5102 1 hour ago |
2-10450 2 days ago |
2-18870 2 days |
0 |
| 45083 |
fpvandoorn author:fpvandoorn |
perf: lower prio of expensive instance |
* Lower priority of rarely-used instance
* Also remove a superfluous variable block (these variables were already declared)
---
Other attempts: #45080 (don't import this file); #45084 (other attempted fix, no speedup).
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-algebra
maintainer-merge
label:t-algebra$ |
2/5 |
Mathlib/Algebra/Order/Quantale.lean |
1 |
10 |
['adomani', 'aimmerwahr', 'bryangingechen', 'felixpernegger', 'fpvandoorn', 'github-actions', 'leanprover-radar'] |
nobody |
0-280 4 minutes ago |
20-5165 20 days ago |
20-5092 20 days |
0 |
| Number |
Author |
Title |
Description |
Labels |
+/- |
Modified files (first 100) |
📝 |
💬 |
All users who commented or reviewed |
Assignee(s) |
Updated |
Last status change |
total time in review |
blocks |
| 40994 |
felixpernegger author:felixpernegger |
chore(Topology): rename `IndiscreteTopology` to `HasIndiscreteTopology` |
Per naming convention. https://leanprover-community.github.io/contribute/naming.html#prop-valued-classes .
See [this](https://github.com/leanprover-community/leanprover-community.github.io/pull/882) PR for further information.
Renaming discrete topology will be more involved, sinced its used much more widely
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-topology
awaiting-author
merge-conflict
awaiting-zulip
|
154/109 |
Mathlib/Analysis/Normed/Group/Basic.lean,Mathlib/Topology/AlexandrovDiscrete.lean,Mathlib/Topology/Algebra/Group/Basic.lean,Mathlib/Topology/Algebra/Monoid.lean,Mathlib/Topology/Compactness/Compact.lean,Mathlib/Topology/Constructions.lean,Mathlib/Topology/EMetricSpace/Basic.lean,Mathlib/Topology/Homeomorph/Defs.lean,Mathlib/Topology/Homotopy/Contractible.lean,Mathlib/Topology/Inseparable.lean,Mathlib/Topology/Irreducible.lean,Mathlib/Topology/Maps/Basic.lean,Mathlib/Topology/Metrizable/Basic.lean,Mathlib/Topology/NoetherianSpace.lean,Mathlib/Topology/Order.lean,Mathlib/Topology/Separation/Connected.lean,Mathlib/Topology/Sets/Opens.lean,Mathlib/Topology/Sheaves/PUnit.lean,Mathlib/Topology/UniformSpace/Separation.lean |
19 |
9 |
['felixpernegger', 'github-actions', 'j-loreaux', 'mathlib-merge-conflicts', 'scholzhannah'] |
scholzhannah assignee:scholzhannah |
117-23465 3 months ago |
136-1462 136 days ago |
2-7553 2 days |
0 |
| 42007 |
felixpernegger author:felixpernegger |
chore: don't use `by assumption` for hypothesis with exposed name |
Let's say some goal if solve with `:= by assumption` and `assumption` is using `h` to solve it. Then `:= h` would also solve the goal (note: in most cases this is not possible, we would need to expose names before). This is more readable (tells the used explicitly what is being used) and at least in theory slightly faster.
This PR replace all such `by assumption` with the hypothesis directly. If this looks good / gets merged, I will make another PR replacing also `assumption`'s which do not immediately follow a `by`.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
tech debt
awaiting-author
awaiting-zulip
merge-conflict
|
18/18 |
Mathlib/Algebra/Homology/DerivedCategory/DerivabilityStructureInjectives.lean,Mathlib/Algebra/Polynomial/BigOperators.lean,Mathlib/Analysis/Calculus/FDeriv/Congr.lean,Mathlib/Analysis/Calculus/Gradient/Basic.lean,Mathlib/Analysis/MeanInequalities.lean,Mathlib/Analysis/SpecialFunctions/Trigonometric/Chebyshev/RootsExtrema.lean,Mathlib/CategoryTheory/Limits/FinallySmall.lean,Mathlib/CategoryTheory/Presentable/Type.lean,Mathlib/Combinatorics/Additive/ApproximateSubgroup.lean,Mathlib/Geometry/Manifold/MFDeriv/SpecificFunctions.lean,Mathlib/Geometry/RingedSpace/LocallyRingedSpace.lean,Mathlib/LinearAlgebra/PiTensorProduct/Generators.lean,Mathlib/Order/Atoms.lean,Mathlib/Topology/Algebra/Valued/LocallyCompact.lean,Mathlib/Topology/Category/CompHausLike/EffectiveEpi.lean,Mathlib/Topology/Category/Profinite/Nobeling/Basic.lean,Mathlib/Topology/Category/TopCat/EffectiveEpi.lean |
17 |
16 |
['SnirBroshi', 'Vierkantor', 'felixpernegger', 'github-actions', 'leanprover-radar', 'mathlib-merge-conflicts'] |
nobody |
44-7312 1 month ago |
108-19351 108 days ago |
1-63752 1 day |
0 |
| 45029 |
YaelDillies author:YaelDillies |
feat(Util): support `noWS` in `notation3` |
... and use it to define the conditional probability notation `μ[|s]`.
Generated by Claude Opus, reviewed line-by-line by myself.
Zulip discussion: [#mathlib reviewers > status of `notation3` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954)
Assisted-by: Claude Opus 5.5
---
- [ ] awaiting-Zulip: [#mathlib reviewers > status of `notation3` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954)
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
LLM-generated
maintainer-merge
t-meta
awaiting-zulip
|
40/34 |
Mathlib/Probability/ConditionalProbability.lean,Mathlib/Util/Notation3.lean,MathlibTest/Util/Notation3.lean |
3 |
19 |
['JovanGerb', 'Vierkantor', 'YaelDillies', 'eric-wieser', 'github-actions', 'grunweg'] |
Vierkantor assignee:Vierkantor |
14-23181 14 days ago |
16-3252 16 days ago |
4-40864 4 days |
0 |
| 43136 |
joneugster author:joneugster |
feat(Tactic/Linter/ValidatePRTitle): do not check the capitalisation of the commit subject |
There have been false-positives on abbreviations and proper names which seem to justify not to lint for this.
---
- [ ] awaiting-zulip: [#mathlib reviewers > Check PR title](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Check.20PR.20title/with/604858902)
- [ ] depends on: https://github.com/leanprover-community/leanprover-community.github.io/pull/905
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
blocked-by-other-PR
t-linter
awaiting-zulip
|
3/51 |
Mathlib/Tactic/Linter/ValidatePRTitle.lean,MathlibTest/ValidatePRTitle.lean |
2 |
2 |
['github-actions', 'mathlib-dependent-issues'] |
nobody |
14-22838 14 days ago |
unknown |
unknown |
0 |
| 41348 |
mkaratarakis author:mkaratarakis |
feat(ComputablePolynomial): define MvDegrees, exponent vectors for multivariate polynomials |
`MvDegrees nvars` is an exponent vector for a monomial in `nvars` variables: an array of per-variable exponents with its cached total degree, with pointwise addition (`AddCommMonoid`) and the `List`/`Array` folding lemmas the computable multivariate polynomial library (`MvSparsePoly`) is built on. The proofs were done with the help of Claude.
Based on the univariate `SparsePoly` (#41339); started by Mario Carneiro at the Hausdorff Institute (June 2024) with design notes and an original Lean prototype by James Davenport (https://github.com/JamesHDavenport/Dagstuhl23401, `verify-irred/VerifyIrred`).
---
- [ ] awaiting-zulip: [#mathlib reviewers > Computable polynomials](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Computable.20polynomials/with/608178291)
|
t-meta
awaiting-zulip
|
301/0 |
Mathlib.lean,Mathlib/Tactic.lean,Mathlib/Tactic/ComputablePolynomial/MvDegrees.lean |
3 |
3 |
['Vierkantor', 'github-actions'] |
Vierkantor and thorimur assignee:Vierkantor assignee:thorimur |
14-22778 14 days ago |
16-20042 16 days ago |
39-22282 39 days |
8 |
| 39311 |
felixpernegger author:felixpernegger |
refactor: redefine `eLpNorm` at `p = 0` |
For Zulip discussion see https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/eLpNorm.20junk.20value/with/576356442. In partuclar this change is suggestion 2 in [#mathlib4 > eLpNorm junk value @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/eLpNorm.20junk.20value/near/576340531)
This redefined [MeasureTheory.eLpNorm](https://leanprover-community.github.io/mathlib4_docs/Mathlib/MeasureTheory/Function/LpSeminorm/Defs.html#MeasureTheory.eLpNorm) at `p = 0`. Previously it was always `0` but now it is the measure of the support of the function (technical detail: In order to avoid having to add additional arguments to `eLpNorm`, we define it as the measure of the support of the norm of the function, but this is almost always the same)
The motivation for this comes from the counting measure, in particular this then unifies with https://leanprover-community.github.io/mathlib4_docs/Mathlib/Analysis/Normed/Lp/lpSpace.html#Mem%E2%84%93p. In any case, it is "closer" to the actual mathematical definition
Unfortunately, since `eLpNorm` is widely used, the diff is very large and a lot of theorems break (i.e. now require `p != 0`). Oftentimes `p != 0` is still not required (sometimes with nontrivial arguments), I tried to avoid adding extra hypothesis whenever I could but I almost certainly missed some.
There now may also be places where we dont need `p != 0` as a hypothesis anymore (i.e. for `[Memℓp](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Analysis/Normed/Lp/lpSpace.html#Mem%E2%84%93p)`), but this is not included in this PR.
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/eLpNorm.20junk.20value/with/576356442.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
awaiting-zulip
merge-conflict
t-measure-probability
|
950/595 |
Mathlib/Analysis/Distribution/ContDiffMapSupportedIn.lean,Mathlib/Analysis/Distribution/SchwartzSpace/Basic.lean,Mathlib/Analysis/Distribution/TemperateGrowth.lean,Mathlib/Analysis/Distribution/TemperedDistribution.lean,Mathlib/Analysis/Distribution/TestFunction.lean,Mathlib/Analysis/Fourier/LpSpace.lean,Mathlib/Analysis/FunctionalSpaces/SobolevInequality.lean,Mathlib/Analysis/Normed/Lp/SmoothApprox.lean,Mathlib/Data/ENNReal/Holder.lean,Mathlib/MeasureTheory/Function/ContinuousMapDense.lean,Mathlib/MeasureTheory/Function/ConvergenceInMeasure.lean,Mathlib/MeasureTheory/Function/Holder.lean,Mathlib/MeasureTheory/Function/L1Space/Integrable.lean,Mathlib/MeasureTheory/Function/L2Space.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Basic.lean,Mathlib/MeasureTheory/Function/LpSeminorm/CompareExp.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Defs.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Indicator.lean,Mathlib/MeasureTheory/Function/LpSeminorm/LpNorm.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Monotonicity.lean,Mathlib/MeasureTheory/Function/LpSeminorm/SMul.lean,Mathlib/MeasureTheory/Function/LpSeminorm/TriangleInequality.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Trim.lean,Mathlib/MeasureTheory/Function/LpSpace/Basic.lean,Mathlib/MeasureTheory/Function/LpSpace/Complete.lean,Mathlib/MeasureTheory/Function/LpSpace/CompleteOfCompleteLp.lean,Mathlib/MeasureTheory/Function/LpSpace/ContinuousFunctions.lean,Mathlib/MeasureTheory/Function/LpSpace/Indicator.lean,Mathlib/MeasureTheory/Function/SimpleFuncDenseLp.lean,Mathlib/MeasureTheory/Function/UniformIntegrable.lean,Mathlib/MeasureTheory/Integral/SetToL1.lean,Mathlib/Probability/CentralLimitTheorem.lean,Mathlib/Probability/Distributions/Gaussian/Basic.lean,Mathlib/Probability/Distributions/Gaussian/Fernique.lean,Mathlib/Probability/Distributions/Gaussian/HasGaussianLaw/Basic.lean,Mathlib/Probability/Distributions/Gaussian/Real.lean,Mathlib/Probability/IdentDistrib.lean,Mathlib/Probability/Kernel/Disintegration/CDFToKernel.lean,Mathlib/Probability/Kernel/Disintegration/Density.lean,Mathlib/Probability/Martingale/Convergence.lean,Mathlib/Probability/Moments/CovarianceBilinDual.lean,Mathlib/Probability/Moments/IntegrableExpMul.lean,Mathlib/Probability/Moments/SubGaussian.lean,Mathlib/Probability/Process/Filtration.lean,MathlibTest/congr.lean |
45 |
42 |
['felixpernegger', 'github-actions', 'mathlib-bors', 'mathlib-merge-conflicts', 'sgouezel'] |
nobody |
14-22678 14 days ago |
157-6115 157 days ago |
5-63685 5 days |
0 |
| 39233 |
wrenna-robson author:wrenna-robson |
feat: `Pi.map` rename to `Function.map` |
This PR renames `Pi.map` to `Function.map` and makes the changes necessary to support this. In particular this means that Mathlib.Logic.Function.Defs now only contains the Function namespace.
A future PR may update the names of *.piMap in line with this.
Zulip thread: [#PR reviews > #39233 - rename Pi.map to Function.map @ 💬](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2339233.20-.20rename.20Pi.2Emap.20to.20Function.2Emap/near/594605689)
------
- [ ] awaiting-zulip: [#PR reviews > #39233 - rename Pi.map to Function.map @ 💬](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2339233.20-.20rename.20Pi.2Emap.20to.20Function.2Emap/near/594605689)
General discussion regarding the Pi namespace: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/The.20Pi.20namespace/near/594782721
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
awaiting-zulip
t-data
|
136/126 |
Mathlib/Algebra/Category/Grp/AB.lean,Mathlib/Algebra/Group/Pi/Lemmas.lean,Mathlib/Algebra/Order/Antidiag/Nat.lean,Mathlib/Algebra/Regular/Pi.lean,Mathlib/Analysis/InnerProductSpace/Coalgebra.lean,Mathlib/Analysis/SpecialFunctions/PolarCoord.lean,Mathlib/Condensed/Discrete/LocallyConstant.lean,Mathlib/Control/Bifunctor.lean,Mathlib/Data/Finset/Powerset.lean,Mathlib/Data/Prod/Basic.lean,Mathlib/Data/Set/Prod.lean,Mathlib/Dynamics/Ergodic/MeasurePreserving.lean,Mathlib/Dynamics/PeriodicPts/Defs.lean,Mathlib/Dynamics/PeriodicPts/Lemmas.lean,Mathlib/Dynamics/TopologicalEntropy/Semiconj.lean,Mathlib/FieldTheory/Perfect.lean,Mathlib/Geometry/Manifold/IsManifold/Basic.lean,Mathlib/Geometry/Manifold/IsManifold/ExtChartAt.lean,Mathlib/GroupTheory/MonoidLocalization/Lemmas.lean,Mathlib/LinearAlgebra/Multilinear/Basis.lean,Mathlib/LinearAlgebra/Pi.lean,Mathlib/Logic/Equiv/Basic.lean,Mathlib/Logic/Equiv/PartialEquiv.lean,Mathlib/Logic/Function/Basic.lean,Mathlib/Logic/Function/Defs.lean,Mathlib/Logic/Function/Iterate.lean,Mathlib/Order/Filter/Cofinite.lean,Mathlib/Order/Filter/Pi.lean,Mathlib/RingTheory/Coalgebra/Basic.lean,Mathlib/Topology/Algebra/FilterBasis.lean,Mathlib/Topology/Algebra/Module/ContinuousLinearMap/PiProd.lean,Mathlib/Topology/Algebra/RestrictedProduct/TopologicalSpace.lean,Mathlib/Topology/Constructions.lean,Mathlib/Topology/Maps/Basic.lean,Mathlib/Topology/MetricSpace/HausdorffAlexandroff.lean,Mathlib/Topology/MetricSpace/Isometry.lean,Mathlib/Topology/NhdsWithin.lean |
37 |
6 |
['github-actions', 'mathlib-merge-conflicts', 'themathqueen', 'wrenna-robson'] |
nobody |
14-22637 14 days ago |
180-83376 180 days ago |
0-701 11 minutes |
0 |
| 38957 |
wwylele author:wwylele |
chore(GroupTheory/DivisibleHull): remove `backward.privateInPublic` |
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Should.20we.20expose.20functions.3F
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
tech debt
t-group-theory
awaiting-zulip
|
5/12 |
Mathlib/GroupTheory/DivisibleHull.lean |
1 |
14 |
['Komyyy', 'Vierkantor', 'github-actions', 'grunweg', 'jcommelin', 'wwylele'] |
nobody |
14-22615 14 days ago |
108-20994 108 days ago |
72-80534 72 days |
0 |
| 37346 |
euprunin author:euprunin |
chore: golf using `grind` |
The goal of this PR is to decrease the number of times lemmas are called explicitly. Any decrease in compilation time is a welcome side effect, although it is not a primary objective.
Trace profiling results (differences <30 ms considered measurement noise):
* `✅️ SimpleGraph.Walk.IsPath.getVert_injOn`: unchanged 🎉
* `✅️ SimpleGraph.Walk.length_bypass_le`: unchanged 🎉
* `✅️ Rat.floor_intCast_div_natCast`: unchanged 🎉
* `✅️ InnerProductGeometry.norm_eq_of_angle_sub_eq_angle_sub_rev_of_angle_ne_pi`: unchanged 🎉
* `✅️ padicNorm.zero_of_padicNorm_eq_zero`: unchanged 🎉
Profiled using `set_option trace.profiler true in`.
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/simp.20followed.20by.20grind/with/591450723
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
awaiting-zulip
merge-conflict
|
7/45 |
Mathlib/Combinatorics/SimpleGraph/Paths.lean,Mathlib/Data/Rat/Floor.lean,Mathlib/Geometry/Euclidean/Triangle.lean,Mathlib/NumberTheory/Padics/PadicNorm.lean |
4 |
23 |
['FernandoChu', 'bryangingechen', 'chenson2018', 'euprunin', 'faenuccio', 'github-actions', 'grunweg', 'mathlib-merge-conflicts'] |
nobody |
14-22566 14 days ago |
194-9884 194 days ago |
30-45859 30 days |
0 |
| 35524 |
grunweg author:grunweg |
feat: text-based linter against \t followed by tactic mode |
Wait for the zulip discussion to converge. **If** there is consensus in favour of this change, summarise the motivation here.
[#mathlib4 > Writer should use an additive monoid @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Writer.20should.20use.20an.20additive.20monoid/near/574990415)
---
- [ ] awaiting-zulip: [#mathlib4 > Writer should use an additive monoid @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Writer.20should.20use.20an.20additive.20monoid/near/574990415)
There are currently 80 remaining exceptions in mathlib: ideally, these would get fixed before merging this.
Works best when combined with #35523.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-linter
awaiting-zulip
merge-conflict
|
23/2 |
Mathlib/Tactic/Linter/TextBased.lean |
1 |
5 |
['github-actions', 'grunweg', 'joneugster', 'mathlib-merge-conflicts', 'vihdzp'] |
nobody |
14-22495 14 days ago |
unknown |
unknown |
0 |
| 33368 |
urkud author:urkud |
feat: define `Complex.UnitDisc.shift` |
Also review the existing API
UPD: I'm going to define a `PSL(2, Real)` action instead.
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/116395-maths/topic/Shifts.20.28translations.3F.29.20of.20the.20hyperbolic.20plane/with/566237799
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/) |
t-analysis
awaiting-zulip
merge-conflict
|
273/39 |
Mathlib.lean,Mathlib/Analysis/Complex/UnitDisc/Basic.lean,Mathlib/Analysis/Complex/UnitDisc/Shift.lean |
3 |
7 |
['github-actions', 'j-loreaux', 'mathlib4-merge-conflict-bot', 'sgouezel', 'urkud'] |
j-loreaux assignee:j-loreaux |
14-22126 14 days ago |
306-80835 306 days ago |
5-70690 5 days |
1 |
| 32742 |
LTolDe author:LTolDe |
feat(MeasureTheory/Constructions/Polish/Basic): add class SuslinSpace |
add new class `SuslinSpace` for a topological space that is an analytic set in itself
This will be useful to prove the **Effros Theorem**, see [zulip thread](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Effros.20Theorem/with/558712441).
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Effros.20Theorem/with/558712441
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
new-contributor
awaiting-zulip
t-measure-probability
awaiting-author
|
4/0 |
Mathlib/MeasureTheory/Constructions/Polish/Basic.lean |
1 |
10 |
['ADedecker', 'LTolDe', 'dagurtomas', 'dupuisf', 'github-actions', 'jcommelin'] |
PatrickMassot assignee:PatrickMassot |
14-22051 14 days ago |
306-84297 306 days ago |
11-6345 11 days |
0 |
| 32608 |
PrParadoxy author:PrParadoxy |
feat(LinearAlgebra/PiTensorProduct): API for PiTensorProducts indexed by sets |
This PR addresses a TODO item in LinearAlgebra/PiTensorProduct.lean:
* API for the various ways ι can be split into subsets; connect this
with the binary tensor product
-- specifically by describing tensors of type ⨂ (i : S), M i, for S : Set ι.
Our primary motivation is to formalise the notion of "restricted tensor
products". This will be the content of a follow-up PR.
Beyond that, the Set API is natural in contexts where the index type has
an independent interpretation. An example is quantum physics, where ι
ranges over distinguishable degrees of freedom, and where its is common
practice to annotate objects by the set of indices they are defined on.
---
Stub file with preliminary definition of the restricted tensor product as a direct limit of tensors indexed by finite subsets of an index type:
https://github.com/PrParadoxy/mathlib4/blob/restricted-stub/Mathlib/LinearAlgebra/PiTensorProduct/Restricted.lean
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Tensor.20products.20indexed.20by.20a.20set/with/565043379
- [x] depends on: #32598
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
new-contributor
awaiting-zulip
t-algebra
WIP
merge-conflict
label:t-algebra$ |
300/2 |
Mathlib.lean,Mathlib/LinearAlgebra/PiTensorProduct.lean,Mathlib/LinearAlgebra/PiTensorProduct/Set.lean |
3 |
33 |
['PrParadoxy', 'dagurtomas', 'eric-wieser', 'github-actions', 'goliath-klein', 'leanprover-radar', 'mathlib-bors', 'mathlib-merge-conflicts', 'mathlib4-dependent-issues-bot', 'mathlib4-merge-conflict-bot'] |
nobody |
14-22003 14 days ago |
321-77262 321 days ago |
10-64694 10 days |
1 |
| 30668 |
astrainfinita author:astrainfinita |
feat: `QuotType` |
This typeclass is primarily for use by type synonyms of `Quot` and `Quotient`. Using `QuotType` API for type synonyms of `Quot` and `Quotient` will avoid defeq abuse caused by directly using `Quot` and `Quotient` APIs.
This PR also adds some typeclasses to support different ways to find the quotient map that should be used. See the documentation comments of these typeclasses for examples of usage.
---
<!-- The text above the `---` will become the commit message when your
PR is merged. Please leave a blank newline before the `---`, otherwise
GitHub will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
To indicate co-authors, include lines at the bottom of the commit message
(that is, before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines at the bottom of the commit message
(that is, before the `---`) using the following format:
Moves:
- Vector.* -> Mathlib.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
It's not a typical design to use these auxiliary typeclasses and term elaborators, but I haven't found a better way to support these notations.
Some of the naming may need to be discussed. For example:
- `⟦·⟧` is currently called `mkQ` in names. This distinguishes it from other `.mk`s and makes it possible to write the quotient map as `mkQ` `mkQ'` ~~`mkQ_ h`~~. But this will also require changing the old lemma names.
- It would be helpful if the names of new type classes explained their functionality better.
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/migrate.20to.20.60QuotLike.60.20API
This PR continues the work from #16421.
Original PR: https://github.com/leanprover-community/mathlib4/pull/16421 |
RFC
t-data
awaiting-zulip
awaiting-author
|
629/0 |
Mathlib.lean,Mathlib/Data/QuotType.lean,MathlibTest/QuotType.lean |
3 |
23 |
['SnirBroshi', 'YaelDillies', 'astrainfinita', 'dagurtomas', 'github-actions', 'mathlib4-merge-conflict-bot', 'plp127', 'vihdzp'] |
nobody |
14-21952 14 days ago |
unknown |
unknown |
0 |
| 28803 |
astrainfinita author:astrainfinita |
refactor: unbundle algebra from `ENormed*` |
Further speed up the search in the algebraic typeclass hierarchy by avoiding searching for `TopologicalSpace`.
This PR continues the work from #23961.
- Change `ESeminormed(Add)Monoid` and `ENormed(Add)Monoid` so they no longer carry algebraic data.
- Deprecate `ESeminormed(Add)CommMonoid` and `ENormed(Add)CommMonoid` in favor of `ESeminormed(Add)Monoid` and `ENormed(Add)Monoid` with a commutative algebraic typeclass.
|Old|New|
|---|---|
| `[ESeminormed(Add)(Comm)Monoid E]` | `[(Add)(Comm)Monoid E] [ESeminormed(Add)Monoid E]` |
| `[ENormed(Add)(Comm)Monoid]` | `[(Add)(Comm)Monoid E] [ENormed(Add)Monoid]` |
See [Zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2328803.20refactor.3A.20unbundle.20algebra.20from.20.60ENormed*.60/with/536024350)
------------
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2328803.20refactor.3A.20unbundle.20algebra.20from.20.60ENormed*.60/with/53602435
- [x] depends on: #28813 |
t-algebra
merge-conflict
slow-typeclass-synthesis
awaiting-zulip
t-analysis
label:t-algebra$ |
80/63 |
Mathlib/Analysis/CStarAlgebra/CStarMatrix.lean,Mathlib/Analysis/Normed/Group/Basic.lean,Mathlib/Analysis/Normed/Group/Continuity.lean,Mathlib/Analysis/Normed/Group/InfiniteSum.lean,Mathlib/Analysis/NormedSpace/IndicatorFunction.lean,Mathlib/MeasureTheory/Function/L1Space/AEEqFun.lean,Mathlib/MeasureTheory/Function/L1Space/HasFiniteIntegral.lean,Mathlib/MeasureTheory/Function/L1Space/Integrable.lean,Mathlib/MeasureTheory/Function/LocallyIntegrable.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Basic.lean,Mathlib/MeasureTheory/Function/LpSeminorm/CompareExp.lean,Mathlib/MeasureTheory/Function/LpSeminorm/TriangleInequality.lean,Mathlib/MeasureTheory/Integral/IntegrableOn.lean,Mathlib/MeasureTheory/Integral/IntervalIntegral/Basic.lean |
14 |
28 |
['astrainfinita', 'bryangingechen', 'github-actions', 'grunweg', 'kbuzzard', 'leanprover-bot', 'mathlib-bors', 'mathlib4-dependent-issues-bot', 'mathlib4-merge-conflict-bot', 'sgouezel'] |
grunweg assignee:grunweg |
14-21909 14 days ago |
441-4606 441 days ago |
0-16864 4 hours |
0 |
| 30150 |
imbrem author:imbrem |
feat(CategoryTheory/Monoidal): to_additive for MonoidalCategory |
Add `AddMonoidalCategory`, the additive version of `MonoidalCategory`.
To get this to work, I needed to _remove_ the `to_additive` attributes in `Discrete.lean`, since existing code relies on the `AddMonoid M → MonoidalCategory M` instance. For now, we simply implement the additive variants by hand instead.
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/to_additive.20on.20MonoidalCategory/with/543107104
As discussed in #28718; I added an `AddMonoidalCategory` struct and tagged `MonoidalCategory` with `to_additive`, along with the lemmas in `Category.lean`.
I think this is the right approach, since under this framework the "correct" additive version of `Discrete.lean` would be mapping an `AddMonoid` to an `AddMonoidalCategory`.
Next steps would be to:
- Make `monoidal_coherence` and `coherence` support `AddMonoidalCategory`
- Add `CocartesianMonoidalCategory` extending `AddMonoidalCategory`
<!-- The text above the `---` will become the commit message when your
PR is merged. Please leave a blank newline before the `---`, otherwise
GitHub will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
To indicate co-authors, include at least one commit authored by each
co-author among the commits in the pull request. If necessary, you may
create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
When merging, all the commits will be squashed into a single commit listing all co-authors.
If you are moving or deleting declarations, please include these lines at the bottom of the commit message
(that is, before the `---`) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-category-theory
large-import
new-contributor
merge-conflict
awaiting-zulip
t-meta
|
444/125 |
Mathlib/CategoryTheory/Monoidal/Category.lean,Mathlib/CategoryTheory/Monoidal/Discrete.lean,Mathlib/Tactic/ToAdditive/GuessName.lean |
3 |
22 |
['JovanGerb', 'YaelDillies', 'github-actions', 'imbrem', 'mathlib4-merge-conflict-bot'] |
nobody |
14-21800 14 days ago |
401-20202 401 days ago |
0-29227 8 hours |
3 |
| 41339 |
mkaratarakis author:mkaratarakis |
feat(ComputablePolynomial): define SparsePoly, a computable univariate polynomial |
`SparsePoly R` is a computable, kernel-reducible representation of univariate polynomials over a commutative ring `R` with `DecidableEq R`: a list of `(exponent, coefficient)` pairs with strictly decreasing exponents and nonzero coefficients, making the representation canonical. This first part defines the structure, the semantics `toPoly : SparsePoly R → Polynomial R`, and addition.
Started by Mario Carneiro at the Hausdorff Institute (June 2024) with design notes and an original Lean prototype by James Davenport (https://github.com/JamesHDavenport/Dagstuhl23401, `verify-irred/VerifyIrred`) and the proofs were done with the help of Claude code.
---
- [ ] awaiting-zulip: [#mathlib reviewers > Computable polynomials](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Computable.20polynomials/with/608178291) |
t-meta
awaiting-author
awaiting-zulip
|
217/0 |
Mathlib.lean,Mathlib/Tactic.lean,Mathlib/Tactic/ComputablePolynomial/Basic.lean |
3 |
10 |
['JovanGerb', 'github-actions', 'joneugster', 'mkaratarakis'] |
eric-wieser and joneugster assignee:eric-wieser assignee:joneugster |
14-21560 14 days ago |
24-9411 24 days ago |
104-16295 104 days |
7 |
| 42551 |
plp127 author:plp127 |
chore: rename `Set.mem_singleton` |
Rename `Set.mem_singleton` to `Set.mem_singleton_self` and rename `Set.mem_singleton_iff` to `Set.mem_singleton`. Also rename `Set.notMem_singleton_self` to `Set.notMem_singleton`. This is consistent with other container types like `Finset` and `List`.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
awaiting-zulip
merge-conflict
awaiting-author
|
705/683 |
Archive/Imo/Imo2019Q2.lean,Archive/Imo/Imo2024Q2.lean,Archive/Imo/Imo2024Q3.lean,Archive/Imo/Imo2024Q6.lean,Archive/Wiedijk100Theorems/CubingACube.lean,Counterexamples/CliffordAlgebraNotInjective.lean,Counterexamples/DiscreteTopologyNonDiscreteUniformity.lean,Counterexamples/GrothendieckPower.lean,Mathlib/Algebra/Algebra/NonUnitalSubalgebra.lean,Mathlib/Algebra/Algebra/Subalgebra/Lattice.lean,Mathlib/Algebra/BigOperators/Finprod.lean,Mathlib/Algebra/Category/Grp/Injective.lean,Mathlib/Algebra/CharP/MixedCharZero.lean,Mathlib/Algebra/CharP/Quotient.lean,Mathlib/Algebra/DualNumber.lean,Mathlib/Algebra/Group/Indicator.lean,Mathlib/Algebra/Group/Pointwise/Set/Finite.lean,Mathlib/Algebra/Group/Subgroup/Basic.lean,Mathlib/Algebra/Group/Subgroup/Lattice.lean,Mathlib/Algebra/Group/Submonoid/Defs.lean,Mathlib/Algebra/Group/Submonoid/Membership.lean,Mathlib/Algebra/Group/Submonoid/Operations.lean,Mathlib/Algebra/GroupWithZero/Range.lean,Mathlib/Algebra/Homology/TotalComplexShift.lean,Mathlib/Algebra/Lie/Engel.lean,Mathlib/Algebra/Lie/InvariantForm.lean,Mathlib/Algebra/Lie/Subalgebra.lean,Mathlib/Algebra/Lie/Submodule.lean,Mathlib/Algebra/Module/Submodule/Lattice.lean,Mathlib/Algebra/Module/Torsion/Basic.lean,Mathlib/Algebra/Module/ZLattice/Basic.lean,Mathlib/Algebra/Order/Ring/StandardPart.lean,Mathlib/Algebra/Pointwise/Stabilizer.lean,Mathlib/Algebra/Star/NonUnitalSubalgebra.lean,Mathlib/Algebra/Star/Pointwise.lean,Mathlib/Algebra/Star/Subalgebra.lean,Mathlib/AlgebraicGeometry/IdealSheaf/IrreducibleComponent.lean,Mathlib/AlgebraicGeometry/ProjectiveSpectrum/Topology.lean,Mathlib/AlgebraicTopology/SimplicialSet/Horn.lean,Mathlib/AlgebraicTopology/SimplicialSet/HornColimits.lean,Mathlib/AlgebraicTopology/SimplicialSet/StdSimplex.lean,Mathlib/Analysis/Analytic/Constructions.lean,Mathlib/Analysis/BoxIntegral/Partition/Split.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Basic.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Continuity.lean,Mathlib/Analysis/CStarAlgebra/Hom.lean,Mathlib/Analysis/CStarAlgebra/Projection.lean,Mathlib/Analysis/Calculus/ContDiff/Basic.lean,Mathlib/Analysis/Calculus/ContDiff/FaaDiBruno.lean,Mathlib/Analysis/Calculus/Deriv/Slope.lean,Mathlib/Analysis/Calculus/DerivativeTest.lean,Mathlib/Analysis/Calculus/FDeriv/Measurable.lean,Mathlib/Analysis/Calculus/Taylor.lean,Mathlib/Analysis/Complex/CanonicalDecomposition.lean,Mathlib/Analysis/Complex/Hadamard.lean,Mathlib/Analysis/Convex/Between.lean,Mathlib/Analysis/Convex/Exposed.lean,Mathlib/Analysis/Convex/Extreme.lean,Mathlib/Analysis/Convex/Gauge.lean,Mathlib/Analysis/Convex/Hull.lean,Mathlib/Analysis/Convex/Independent.lean,Mathlib/Analysis/Convex/Integral.lean,Mathlib/Analysis/Convex/Segment.lean,Mathlib/Analysis/Convex/Star.lean,Mathlib/Analysis/Convex/StrictConvexSpace.lean,Mathlib/Analysis/InnerProductSpace/Orthogonal.lean,Mathlib/Analysis/LocallyConvex/Bounded.lean,Mathlib/Analysis/LocallyConvex/Polar.lean,Mathlib/Analysis/LocallyConvex/Separation.lean,Mathlib/Analysis/LocallyConvex/WithSeminorms.lean,Mathlib/Analysis/Meromorphic/Basic.lean,Mathlib/Analysis/Meromorphic/NormalForm.lean,Mathlib/Analysis/Meromorphic/Order.lean,Mathlib/Analysis/Normed/Field/Basic.lean,Mathlib/Analysis/Normed/Lp/lpSpace.lean,Mathlib/Analysis/Normed/Module/Basic.lean,Mathlib/Analysis/Normed/Module/Connected.lean,Mathlib/Analysis/Normed/Unbundled/FiniteExtension.lean,Mathlib/Analysis/Normed/Unbundled/SeminormFromBounded.lean,Mathlib/Analysis/SpecialFunctions/Complex/Log.lean,Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/Rpow/Order.lean,Mathlib/Analysis/SpecialFunctions/Elliptic/Weierstrass.lean,Mathlib/Analysis/SpecialFunctions/Integrals/LogTrigonometric.lean,Mathlib/Analysis/SpecialFunctions/Integrals/PosLogEqCircleAverage.lean,Mathlib/Analysis/SpecialFunctions/Log/NegMulLog.lean,Mathlib/Analysis/SpecialFunctions/Pow/Asymptotics.lean,Mathlib/CategoryTheory/GradedObject.lean,Mathlib/CategoryTheory/GradedObject/Unitor.lean,Mathlib/CategoryTheory/Preadditive/HomOrthogonal.lean,Mathlib/CategoryTheory/Presentable/SharplyLT/Basic.lean,Mathlib/CategoryTheory/Sites/Grothendieck.lean,Mathlib/CategoryTheory/Sites/Sieves.lean,Mathlib/Combinatorics/Graph/Basic.lean,Mathlib/Combinatorics/Matroid/Basic.lean,Mathlib/Combinatorics/Matroid/Circuit.lean,Mathlib/Combinatorics/Matroid/Closure.lean,Mathlib/Combinatorics/Nullstellensatz.lean,Mathlib/Combinatorics/Quiver/Path/Vertices.lean,Mathlib/Combinatorics/SimpleGraph/Acyclic.lean,Mathlib/Combinatorics/SimpleGraph/Basic.lean |
363 |
4 |
['Ruben-VandeVelde', 'github-actions', 'grunweg', 'mathlib-merge-conflicts'] |
nobody |
14-21392 14 days ago |
88-23915 88 days ago |
4-30727 4 days |
0 |
| 44493 |
SnirBroshi author:SnirBroshi |
chore(Algebra/Category/FGModuleCat/Basic): `fgModuleCat` -> `fgmoduleCat` |
The constant is named `FGModuleCat`, and the conventions are to lowercase the initial uppercase streak.
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Lowercasing.20the.20initial.20sequence.20of.20caps
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-algebra
t-category-theory
awaiting-zulip
label:t-algebra$ |
28/8 |
Mathlib/Algebra/Category/FGModuleCat/Basic.lean |
1 |
7 |
['SnirBroshi', 'github-actions', 'joelriou', 'themathqueen'] |
nobody |
14-21024 14 days ago |
35-21606 35 days ago |
0-32670 9 hours |
0 |
| 44494 |
SnirBroshi author:SnirBroshi |
chore(RingTheory/Ideal): `ltSeries` -> `ltseries` |
The constant is named `LTSeries`, and the conventions are to lowercase the initial uppercase streak.
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Lowercasing.20the.20initial.20sequence.20of.20caps
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-ring-theory
awaiting-zulip
|
28/12 |
Mathlib/RingTheory/Ideal/GoingDown.lean,Mathlib/RingTheory/Ideal/GoingUp.lean,Mathlib/RingTheory/Ideal/HasGoingUp.lean,Mathlib/RingTheory/Ideal/Height.lean,Mathlib/RingTheory/Ideal/KrullsHeightTheorem.lean,Mathlib/RingTheory/KrullDimension/Regular.lean,Mathlib/RingTheory/Spectrum/Prime/LTSeries.lean |
7 |
5 |
['SnirBroshi', 'github-actions', 'mathlib-merge-conflicts', 'themathqueen'] |
nobody |
14-21013 14 days ago |
35-9206 35 days ago |
0-43444 12 hours |
0 |
| 44251 |
gotrevor author:gotrevor |
doc(1000-yaml): add the Paris–Harrington theorem |
Adds an external-formalization pointer to the Paris–Harrington entry `Q7137494`, in the same form as my open #41337 (Goodstein / Kirby–Paris).
I know #44115 proposes moving non-mathlib entries out of `1000.yaml` (as @wwylele noted on #41337). I'm opening this anyway so the formalization is easy to find: nobody else needs to redo Paris–Harrington, and anyone who wants to build on it or cite it can start from this one. If #44115 lands, I'm happy to close this and re-home the entry wherever external formalizations end up.
## Entry
| Wikidata | Theorem | Formalization |
|----------|---------|---------------|
| `Q7137494` | **Paris–Harrington theorem**: Peano Arithmetic does not prove the Paris–Harrington principle (the strengthened finite Ramsey theorem with "relatively large" homogeneous sets), though it is true | [`goodstein-independence`](https://github.com/gotrevor/goodstein-independence/blob/main/src/GoodsteinPA/PH/Main.lean) |
## Notes
- Headline: `GoodsteinPA.PH.pa_not_proves_ph`. For every Σ₁ formula defining the principle, PA does not prove its universal closure. Companion theorems: `exists_sigma1_ph_def` (such a formula exists) and `ph_true` (the principle holds, via infinite Ramsey).
- The lower bound follows Buchholz's lecture-notes proof, after Loebl–Nešetřil. Independence then goes through a Wainer-style bound for PA-provable Π₂ sentences, built on the [`FormalizedFormalLogic/Foundation`](https://github.com/FormalizedFormalLogic/Foundation) library, the same library behind the Löb's-theorem entry `Q204884`.
- Developed with AI assistance (Claude Code and Codex).
----
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Purpose.20of.201000.2Eyaml/with/633932200 (in the private reviewers stream)
|
LLM-generated
new-contributor
awaiting-zulip
|
4/0 |
docs/1000.yaml |
1 |
4 |
['SnirBroshi', 'github-actions', 'gotrevor'] |
nobody |
14-19090 14 days ago |
35-60523 35 days ago |
7-21283 7 days |
0 |
| 44066 |
cadamcat author:cadamcat |
doc: note formalisation of Mihăilescu's theorem in 1000.yaml |
Record an external Lean formalisation of Mihăilescu's theorem (Q174955, formerly Catalan's conjecture). The comment no longer says that only the statement is formalised, since the formal-conjectures statement now links to this proof.
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Purpose.20of.201000.2Eyaml/with/633932200 (in the private reviewers stream)
- Formalisation: [cadamcat/catalan-lean4](https://github.com/cadamcat/catalan-lean4), release [v1.0.0](https://github.com/cadamcat/catalan-lean4/releases/tag/v1.0.0). The link points to `Catalan.catalans_conjecture` in `Catalan/Final/Assembly.lean`, pinned at commit `4bf1f74`.
- The statement is verbatim the one in formal-conjectures, which has linked this proof since [google-deepmind/formal-conjectures#6452](https://github.com/google-deepmind/formal-conjectures/pull/6452) (merged 2026-09-22).
- The project pins Lean 4.33.1 and Mathlib `0df444a360eaa60ab8c11dca51a86af692955474`. `#print axioms Catalan.catalans_conjecture` reports `[propext, Classical.choice, Quot.sound]` ([recorded output](https://github.com/cadamcat/catalan-lean4/blob/4bf1f742eb341decbdfc59ec56e1616f4d13e33b/Verification/axioms.txt)). The [supplemental evidence](https://github.com/cadamcat/catalan-lean4/blob/4bf1f742eb341decbdfc59ec56e1616f4d13e33b/Verification/Supplemental/README.md) records our runs of the nanoda kernel checker and a build of the complete Mathlib library from source on Linux, for proof commit `897079d`, whose proof sources are identical to `4bf1f74`.
- The project vendors 871 unmodified modules of [ClassFieldTheory](https://github.com/n-yamaguchi-0729/ClassFieldTheory) (commit `2930b56`, Apache-2.0) for the class field theory it uses.
- `scripts/yaml_check.py docs/100.yaml docs/1000.yaml docs/overview.yaml docs/undergrad.yaml` passes.
AI disclosure: the linked formalisation was developed with AI coding agents (Codex and Claude Code; see its [AUTHORS.md](https://github.com/cadamcat/catalan-lean4/blob/4bf1f742eb341decbdfc59ec56e1616f4d13e33b/AUTHORS.md)). I checked the final statement, its match with formal-conjectures, and the axiom output.
|
new-contributor
awaiting-zulip
LLM-generated
|
4/1 |
docs/1000.yaml |
1 |
4 |
['github-actions', 'grunweg'] |
nobody |
14-19081 14 days ago |
47-19304 47 days ago |
1-1492 1 day |
0 |
| 43318 |
wpegden author:wpegden |
doc(1000): add the strong and weak perfect graph theorems |
Adds external-formalization entries for Q16680059 (strong perfect graph theorem) and Q2800071 (perfect graph theorem), both formalized in Lean 4 at https://github.com/wpegden/spgt with commit-pinned permalinks.
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Purpose.20of.201000.2Eyaml/with/633932200 (in the private reviewers stream)
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
new-contributor
awaiting-zulip
|
8/0 |
docs/1000.yaml |
1 |
15 |
['SnirBroshi', 'github-actions', 'grunweg', 'thorimur', 'wpegden', 'wwylele'] |
nobody |
14-19069 14 days ago |
67-79199 67 days ago |
0-72433 20 hours |
0 |
| 43196 |
danderson70-UNL author:danderson70-UNL |
doc: add Jacobi Four-Square proof to the list of 1000 theorems |
----
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Purpose.20of.201000.2Eyaml/with/633932200 (in the private reviewers stream) |
new-contributor
awaiting-zulip
|
3/0 |
docs/1000.yaml |
1 |
6 |
['SnirBroshi', 'danderson70-UNL', 'github-actions'] |
nobody |
14-19060 14 days ago |
35-60753 35 days ago |
36-84023 36 days |
0 |
| 41337 |
gotrevor author:gotrevor |
doc(1000-yaml): add Goodstein's theorem and the Kirby–Paris theorem |
Claims two listed-but-unclaimed entries in the 1000+ theorems scoreboard by adding external-formalization pointers (no mathlib declaration; same pattern as Löb's theorem [`Q204884`](https://github.com/leanprover-community/mathlib4/blob/master/docs/1000.yaml#L201), the flypitch continuum-hypothesis independence [`Q208416`](https://github.com/leanprover-community/mathlib4/blob/master/docs/1000.yaml#L216), and Arrow's impossibility theorem [`Q33481`](https://github.com/leanprover-community/mathlib4/blob/master/docs/1000.yaml#L30)).
## Entries
| Wikidata | Theorem | Formalization |
|----------|---------|---------------|
| `Q1149185` | **Goodstein's theorem** — every Goodstein sequence terminates | [`lean-gallery`](https://github.com/gotrevor/lean-gallery/blob/main/LeanGallery/Logic/Goodstein/Statement.lean) (ordinal-descent proof) |
| `Q1149185X` | **Kirby–Paris theorem** — PA does not prove that every Goodstein sequence terminates | [`goodstein-independence`](https://github.com/gotrevor/goodstein-independence/blob/main/src/GoodsteinPA/Statement.lean) |
----
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Purpose.20of.201000.2Eyaml/with/633932200 (in the private reviewers stream)
## Notes
- **`Q1149185X` (Kirby–Paris, 1982)** is built on the [`FormalizedFormalLogic/Foundation`](https://github.com/FormalizedFormalLogic/Foundation) library (the same library that backs the existing Löb's-theorem entry [`Q204884`](https://github.com/leanprover-community/mathlib4/blob/master/docs/1000.yaml#L201)), via the Wainer growth-rate route (`Goodstein` outgrows every PA-provably-total function). The headline `peano_not_proves_goodstein` is sorry-free and `#print axioms`-clean — it rests on exactly `[propext, Classical.choice, Quot.sound]`.
- **`Q1149185`** is Goodstein's theorem proper (the termination statement, provable in ZFC / Lean); mathlib does not currently contain it.
- Both formalizations are by Trevor Morris, developed with AI assistance: Claude Code (Fable 5, Opus), Codex, and Harmonic's Aristotle.
🤖 Generated with [Claude Code](https://claude.com/claude-code) |
new-contributor
LLM-generated
awaiting-zulip
|
6/0 |
docs/1000.yaml |
1 |
7 |
['SnirBroshi', 'felixpernegger', 'github-actions', 'gotrevor', 'wwylele'] |
nobody |
14-19027 14 days ago |
127-54576 127 days ago |
0-81461 22 hours |
0 |
| 45150 |
kim-em author:kim-em |
ci: require linked PR discussion for awaiting-zulip |
Require open PRs labelled `awaiting-zulip` to link, in their description or comments, to a Zulip topic that references that same mathlib PR. After a manual label addition, remove the label if no qualifying discussion is linked, and leave a polite, actionable comment mentioning the person who applied it.
The comment-labeling bot checks before applying `awaiting-zulip` and declines invalid requests, mentioning the requester. It uses the same validator as the manual-label check, since its `GITHUB_TOKEN` label changes do not trigger another workflow. It scans issue comments, review bodies, and inline comments; follows message anchors across topic renames; and checks the whole topic. Full GitHub URLs and linkifiers are recognised through rendered destinations and topic-title links, matching the repository and PR number rather than bare numbers.
Checks run on label and PR/comment changes, with a daily sweep to retry missed events/outages and catch changes on Zulip. Manual runs default to dry-run. Verification failures leave labels untouched; notices are updated rather than duplicated. Privileged jobs execute the default branch's action, and tests run without the Zulip secret.
---
- [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/180721-mathlib-maintainers/topic/proposal.20for.20.60awaiting-zulip.60/with/634263477
The first scheduled sweep after merge will also enforce this on existing labels. Uses the existing `ZULIP_API_KEY` and mathlib Zulip bot account; linked private topics must be accessible to that bot. The live dry run used my account's read access, so it does not establish the bot's private-channel permissions.
Motivated by https://github.com/leanprover-community/mathlib4/pull/44489#issuecomment-6327051347.
:robot: prepared with Codex
|
CI
awaiting-author
awaiting-zulip
|
995/1 |
.github/actions/awaiting-zulip/README.md,.github/actions/awaiting-zulip/action.yml,.github/actions/awaiting-zulip/guard.py,.github/actions/awaiting-zulip/test_guard.py,.github/workflows/awaiting_zulip.yml,.github/workflows/labels_from_comment.yml |
6 |
6 |
['SnirBroshi', 'github-actions', 'grunweg', 'joneugster'] |
nobody |
14-18639 14 days ago |
16-50786 16 days ago |
2-7720 2 days |
0 |
| 45016 |
kim-em author:kim-em |
chore: use scoped omit commands |
Replace the 51 persistent `omit` commands in 45 Mathlib files, plus the remaining occurrence in `Archive`, with `omit ... in` on individual declarations. One ineffective omission immediately before `end` is deleted.
Declaration order, proofs, and variables are unchanged. Redundant section wrappers are removed. Per-declaration option settings retain their scope, and local wrappers preserve explicitly named measurable spaces and intended instance parameters where needed.
This is the cleanup prerequisite for the [linter proposal](https://github.com/leanprover-community/mathlib4/pull/45017). The policy remains under [discussion](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/proposal.3A.20lint.20against.20.60omit.20.2E.2E.2E.60.2C.20requiring.20.60omit.20.2E.2E.2E.20in.60/near/632918131), including an exception for plain `omit` at the beginning of a section or namespace. Please wait for that discussion to converge before merging.
The `omit ... in section` grouping has been removed: this syntax relies on surprising scope behaviour and fails with named sections. The library sources are exactly the same as the previously validated per-declaration version at `252adfe7222`.
----
- [ ] awaiting-zulip: [Zulip](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60)
Validation of that version: all 45 affected Mathlib modules and their dependencies build successfully (8,246 jobs), and all 5,214 compiled declaration-type fingerprints match the baseline, including implicit parameter order. Proofs and declaration order are unchanged. Text-style lint and `git diff --check` pass. The restored version also rebuilds successfully (8,246 jobs); full downstream checks remain for CI.
:robot: prepared with Codex
|
awaiting-zulip
LLM-generated
awaiting-author
merge-conflict
|
193/120 |
Archive/Imo/Imo2024Q3.lean,Mathlib/Algebra/Homology/Homotopy.lean,Mathlib/Algebra/Order/BigOperators/GroupWithZero/List.lean,Mathlib/Algebra/Order/BigOperators/GroupWithZero/Multiset.lean,Mathlib/Algebra/Polynomial/Roots.lean,Mathlib/Analysis/Matrix/Order.lean,Mathlib/CategoryTheory/Limits/FormalCoproducts/Basic.lean,Mathlib/CategoryTheory/Monoidal/DayConvolution.lean,Mathlib/CategoryTheory/Triangulated/Basic.lean,Mathlib/CategoryTheory/Triangulated/Pretriangulated.lean,Mathlib/Combinatorics/SimpleGraph/Finite.lean,Mathlib/Geometry/Euclidean/Volume/Measure.lean,Mathlib/LinearAlgebra/AffineSpace/Ordered.lean,Mathlib/LinearAlgebra/Dimension/Localization.lean,Mathlib/LinearAlgebra/Dimension/StrongRankCondition.lean,Mathlib/LinearAlgebra/Dual/Basis.lean,Mathlib/LinearAlgebra/Dual/Lemmas.lean,Mathlib/LinearAlgebra/FiniteDimensional/Basic.lean,Mathlib/LinearAlgebra/Finsupp/LinearCombination.lean,Mathlib/LinearAlgebra/RootSystem/Chain.lean,Mathlib/LinearAlgebra/RootSystem/Finite/CanonicalBilinear.lean,Mathlib/LinearAlgebra/RootSystem/Finite/G2.lean,Mathlib/LinearAlgebra/RootSystem/GeckConstruction/Relations.lean,Mathlib/LinearAlgebra/RootSystem/Reduced.lean,Mathlib/MeasureTheory/Function/StronglyMeasurable/Basic.lean,Mathlib/MeasureTheory/Integral/Lebesgue/Countable.lean,Mathlib/ModelTheory/Skolem.lean,Mathlib/NumberTheory/Cyclotomic/Basic.lean,Mathlib/NumberTheory/LSeries/DirichletContinuation.lean,Mathlib/NumberTheory/NumberField/Ideal/KummerDedekind.lean,Mathlib/Order/IsNormal.lean,Mathlib/Probability/Kernel/Condexp.lean,Mathlib/RingTheory/Algebraic/Basic.lean,Mathlib/RingTheory/Algebraic/Integral.lean,Mathlib/RingTheory/AlgebraicIndependent/AlgebraicClosure.lean,Mathlib/RingTheory/ChainOfDivisors.lean,Mathlib/RingTheory/IntegralClosure/IntegralRestrict.lean,Mathlib/RingTheory/LocalRing/ResidueField/Basic.lean,Mathlib/RingTheory/Localization/FractionRing.lean,Mathlib/RingTheory/TensorProduct/Maps.lean,Mathlib/RingTheory/TensorProduct/MonoidAlgebra.lean,Mathlib/Topology/Algebra/Group/Matrix.lean,Mathlib/Topology/Convenient/GeneratedBy.lean,Mathlib/Topology/Covering/Basic.lean,Mathlib/Topology/Covering/Quotient.lean,Mathlib/Topology/Homotopy/Lifting.lean |
46 |
8 |
['github-actions', 'grunweg', 'kim-em', 'leanprover-radar', 'loefflerd', 'mathlib-merge-conflicts'] |
nobody |
13-64348 13 days ago |
21-28146 21 days ago |
0-8835 2 hours |
1 |
| 30750 |
SnirBroshi author:SnirBroshi |
feat(Data/Quot): `toSet` and `equivClassOf` |
Define `toSet` which gets the set corresponding to an element of a quotient, and `equivClassOf` which gets the equivalence class of an element under a quotient.
---
I found these definitions helpful when working with quotients, specifically `ConnectedComponents` of a `TopologicalSpace`.
<!-- The text above the `---` will become the commit message when your
PR is merged. Please leave a blank newline before the `---`, otherwise
GitHub will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
To indicate co-authors, include at least one commit authored by each
co-author among the commits in the pull request. If necessary, you may
create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
When merging, all the commits will be squashed into a single commit listing all co-authors.
If you are moving or deleting declarations, please include these lines at the bottom of the commit message
(that is, before the `---`) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-data
awaiting-author
awaiting-zulip
|
170/0 |
Mathlib/Basic/SetLike/Basic.lean,Mathlib/Data/Quot.lean,Mathlib/Data/Set/Image.lean,Mathlib/Order/Setoid/Basic.lean |
4 |
12 |
['SnirBroshi', 'TwoFX', 'eric-wieser', 'github-actions', 'grunweg', 'mathlib-merge-conflicts', 'wrenna-robson'] |
TwoFX assignee:TwoFX |
7-40015 7 days ago |
347-24465 347 days ago |
35-75966 35 days |
0 |
| 35578 |
Shreyas4991 author:Shreyas4991 |
fix: writer monad should use an additive logging type |
The Writer monad's w type is supposed to be additive, not multiplicative. This is how it is conceptually used in Haskell (as a logging type). Haskell uses `Monoid` because it doesn't make a distinction between `AddMonoid` and `Monoid`.
[#mathlib4 > Writer should use an additive monoid @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Writer.20should.20use.20an.20additive.20monoid/near/574990415)
---
- [ ] awaiting-zulip: [#mathlib4 > Writer should use an additive monoid @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Writer.20should.20use.20an.20additive.20monoid/near/574990415)
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-data
awaiting-zulip
merge-conflict
|
10/10 |
Mathlib/Control/Monad/Cont.lean,Mathlib/Control/Monad/Writer.lean |
2 |
6 |
['Shreyas4991', 'eric-wieser', 'github-actions', 'mathlib-merge-conflicts'] |
nobody |
6-33714 6 days ago |
261-60073 261 days ago |
0-18022 5 hours |
0 |
| 36934 |
Parcly-Taxel author:Parcly-Taxel |
refactor: make `Language α` an `abbrev` for `SetSemiring (FreeMonoid α)` |
Redefine
```lean
/-- A language is a `SetSemiring` of strings (elements of `FreeMonoid α`) over an alphabet `α`. -/
abbrev Language (α : Type*) := SetSemiring (FreeMonoid α)
```
The existing instances show that this is both `CompleteAtomicBooleanAlgebra` and `IdemSemiring`. |
t-computability
tech debt
large-import
awaiting-zulip
|
314/323 |
Mathlib/Algebra/FreeMonoid/Basic.lean,Mathlib/Computability/ContextFreeGrammar.lean,Mathlib/Computability/DFA.lean,Mathlib/Computability/EpsilonNFA.lean,Mathlib/Computability/Language.lean,Mathlib/Computability/MyhillNerode.lean,Mathlib/Computability/NFA.lean,Mathlib/Computability/RegularExpressions.lean,Mathlib/Data/Set/Semiring.lean |
9 |
49 |
['Parcly-Taxel', 'SnirBroshi', 'YaelDillies', 'ctchou', 'eric-wieser', 'github-actions', 'mathlib-merge-conflicts'] |
YaelDillies assignee:YaelDillies |
4-19659 4 days ago |
4-19659 4 days ago |
15-48127 15 days |
0 |
| 45028 |
YaelDillies author:YaelDillies |
chore: rename `notation3` to `notation +delab` |
This makes it extremely clear what `notation3` does on top of `notation`.
For notations with precedence, the precedence comes before the `+delab`, e.g. `notation:25 +delab ...`.
This rename isn't completely true to the purpose of the elaborator, which is instead to provide Lean 3's `notation` features. Indeed, `notation3` currently has a `(prettyPrint := false)` flag when a delaborator cannot/shouldn't be generated. I am removing this flag because `notation +delab (prettyPrint := false)` would read very weird: "Please generate a delaborator, but don't pretty-print!". Only one notation in mathlib uses this flag, namely cycle notation `c[...]`. It cannot have a delaborator generated due to the use of `by decide` in the expansion. Although `notation +delab` could be fixed to generate a delaborator in this case even (see #45042), I think it is reasonable to say that this rare use-case is unsupported.
I am performing a few auxiliary changes too:
* Update the docstring of `notation +delab` to clarify that it is not deprecated anymore.
* Add a missing space in the `notation +delab` notation, so that `polishPP` needn't add it after the fact.
* Rename the file from `Util.Notation3` to `Util.NotationDelab`.
* Rename the trace option from `trace.notation3` to `trace.notationDelab`.
[Zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60)
Generated by Claude Sonnet/Opus in ~10 prompts, then reviewed line-by-line by myself and hand-edited a bit further.
Assisted-by: Claude Sonnet 5.5, Claude Opus 5.5
---
- [ ] awaiting-zulip: [Zulip](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60)
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #45041
|
file-removed
LLM-generated
awaiting-zulip
tech debt
|
459/403 |
Archive/RiemannStieltjes.lean,Counterexamples/AharoniKorman.lean,Mathlib.lean,Mathlib/Algebra/BigOperators/Finprod.lean,Mathlib/Algebra/Category/Grp/EpiMono.lean,Mathlib/Algebra/DirectSum/Basic.lean,Mathlib/Algebra/Group/Action/Opposite.lean,Mathlib/Algebra/Lie/Weights/Basic.lean,Mathlib/Algebra/Module/Equiv/Defs.lean,Mathlib/Algebra/Module/LinearMap/Defs.lean,Mathlib/Algebra/Order/GroupWithZero/Basic.lean,Mathlib/Algebra/Order/GroupWithZero/Defs.lean,Mathlib/Algebra/Order/Nonneg/Module.lean,Mathlib/Algebra/Polynomial/Bivariate.lean,Mathlib/Algebra/Polynomial/CoeffMem.lean,Mathlib/AlgebraicGeometry/AffineSpace.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Jacobian/Basic.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Jacobian/Formula.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Jacobian/Point.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Projective/Basic.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Projective/Formula.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Projective/Point.lean,Mathlib/AlgebraicGeometry/Gluing.lean,Mathlib/AlgebraicGeometry/Modules/Sheaf.lean,Mathlib/AlgebraicGeometry/OpenImmersion.lean,Mathlib/AlgebraicGeometry/ProjectiveSpectrum/Scheme.lean,Mathlib/AlgebraicGeometry/ProjectiveSpectrum/StructureSheaf.lean,Mathlib/AlgebraicGeometry/Scheme.lean,Mathlib/AlgebraicTopology/SimplicialObject/Basic.lean,Mathlib/AlgebraicTopology/SimplicialSet/Boundary.lean,Mathlib/AlgebraicTopology/SimplicialSet/Horn.lean,Mathlib/AlgebraicTopology/SimplicialSet/StdSimplex.lean,Mathlib/Analysis/Calculus/ContDiff/FTaylorSeries.lean,Mathlib/Analysis/Fourier/RiemannLebesgueLemma.lean,Mathlib/Analysis/RCLike/Inner.lean,Mathlib/Analysis/SpecialFunctions/Elliptic/Weierstrass.lean,Mathlib/Basic/ENNReal/Basic.lean,Mathlib/CategoryTheory/Enriched/Basic.lean,Mathlib/CategoryTheory/Monoidal/PushoutProduct.lean,Mathlib/CategoryTheory/Shift/Basic.lean,Mathlib/Combinatorics/Additive/DoublingConst.lean,Mathlib/Combinatorics/Additive/Energy.lean,Mathlib/Combinatorics/SimpleGraph/Regularity/Bound.lean,Mathlib/Combinatorics/SimpleGraph/Regularity/Chunk.lean,Mathlib/Combinatorics/SimpleGraph/Regularity/Increment.lean,Mathlib/Data/DFinsupp/Defs.lean,Mathlib/Data/Quot.lean,Mathlib/Data/Set/Notation.lean,Mathlib/Data/Sym/Sym2.lean,Mathlib/FieldTheory/JacobsonNoether.lean,Mathlib/FieldTheory/KummerExtension.lean,Mathlib/Geometry/Convex/Cone/Dual.lean,Mathlib/Geometry/Convex/Cone/Pointed.lean,Mathlib/Geometry/Manifold/Diffeomorph.lean,Mathlib/Geometry/Manifold/Instances/Real.lean,Mathlib/GroupTheory/Perm/Cycle/Concrete.lean,Mathlib/LinearAlgebra/AffineSpace/AffineSubspace/Defs.lean,Mathlib/LinearAlgebra/PiTensorProduct/Basic.lean,Mathlib/LinearAlgebra/TensorPower/Symmetric.lean,Mathlib/MeasureTheory/Function/SimpleFuncDenseLp.lean,Mathlib/MeasureTheory/Integral/Average.lean,Mathlib/MeasureTheory/Integral/Bochner/Basic.lean,Mathlib/MeasureTheory/Integral/CircleIntegral.lean,Mathlib/MeasureTheory/Integral/CurveIntegral/Basic.lean,Mathlib/MeasureTheory/Integral/IntervalAverage.lean,Mathlib/MeasureTheory/Integral/IntervalIntegral/Basic.lean,Mathlib/MeasureTheory/Integral/Lebesgue/Basic.lean,Mathlib/MeasureTheory/Integral/Marginal.lean,Mathlib/MeasureTheory/Integral/TorusIntegral.lean,Mathlib/MeasureTheory/Measure/MeasureSpaceDef.lean,Mathlib/MeasureTheory/OuterMeasure/AE.lean,Mathlib/MeasureTheory/VectorMeasure/Integral.lean,Mathlib/MeasureTheory/VectorMeasure/Order.lean,Mathlib/NumberTheory/FLT/Three.lean,Mathlib/NumberTheory/NumberField/CMField.lean,Mathlib/NumberTheory/NumberField/Cyclotomic/Ideal.lean,Mathlib/NumberTheory/NumberField/Cyclotomic/Three.lean,Mathlib/NumberTheory/RamificationInertia/Unramified.lean,Mathlib/NumberTheory/SiegelsLemma.lean,Mathlib/Order/Filter/Defs.lean,Mathlib/Order/Filter/FilterProduct.lean,Mathlib/Order/InitialSeg.lean,Mathlib/Order/PSigma.lean,Mathlib/Order/PiLex.lean,Mathlib/Order/SetNotation.lean,Mathlib/Order/Sigma.lean,Mathlib/Order/Sum/Order.lean,Mathlib/Probability/ConditionalProbability.lean,Mathlib/Probability/Distributions/Binomial.lean,Mathlib/Probability/Distributions/Poisson/Basic.lean,Mathlib/Probability/Independence/Basic.lean,Mathlib/Probability/Independence/Conditional.lean,Mathlib/Probability/Process/Indistinguishable.lean,Mathlib/RingTheory/Coalgebra/CoassocSimps.lean,Mathlib/RingTheory/Coalgebra/IsFrobenius.lean,Mathlib/RingTheory/Coalgebra/TensorProduct.lean,Mathlib/RingTheory/DedekindDomain/Instances.lean,Mathlib/RingTheory/Finiteness/Basic.lean,Mathlib/RingTheory/Kaehler/Basic.lean,Mathlib/RingTheory/NoetherNormalization.lean |
122 |
18 |
['TwoFX', 'YaelDillies', 'github-actions', 'grunweg', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'mathlib-splicebot'] |
nobody |
4-18871 4 days ago |
21-3747 21 days ago |
0-2730 45 minutes |
0 |
| 43143 |
martinwintermath author:martinwintermath |
feat(LinearAlgebra/SesquilinearForm): add instances for SeparatingLeft, SeparatingRight and Nondegenerate |
Add typeclass instances for `Fact B.SeparatingLeft`, `Fact B.SeparatingRight`, `Fact B.Nondegenerate`:
* inferring `Fact B.flip.SeparatingLeft` from `Fact B.SeparatingRight` and vice versa
* inferring `Fact B.SeparatingLeft` and `Fact B.SeparatingRight` from `Fact B.Nondegenerate`
* inferring `Fact B.SeparatingLeft` and `Fact B.Nondegenerate` for `.id` and `Dual.eval`
* inferring `Fact B.Nondegenerate` from `B.IsPerfPair`
I also updated `PointedCone.dual_univ` to demonstrate a use for these additions. Note that I needed to add an import to `Cone/Dual.lean` which somehow imports cardinals. So I needed to remove cardinals from `assert_not_exists`.
Zulip: [#mathlib4 > Typeclass instances for separating bilinear forms](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Typeclass.20instances.20for.20separating.20bilinear.20forms/with/570348517)
---
- [ ] awaiting-zulip: [#mathlib4 > Typeclass instances for separating bilinear forms](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Typeclass.20instances.20for.20separating.20bilinear.20forms/with/570348517)
- [x] depends on: #34487
[](https://gitpod.io/from-referrer/)
|
large-import
t-algebra
awaiting-zulip
merge-conflict
label:t-algebra$ |
32/4 |
Mathlib/Geometry/Convex/Cone/Dual.lean,Mathlib/LinearAlgebra/PerfectPairing/Basic.lean,Mathlib/LinearAlgebra/SesquilinearForm/Basic.lean |
3 |
10 |
['SnirBroshi', 'github-actions', 'martinwintermath', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'themathqueen'] |
nobody |
3-3044 3 days ago |
35-7771 35 days ago |
34-53629 34 days |
0 |
| 45284 |
JX-Mo author:JX-Mo |
feat(Algebra/RingTheory/Center): add `Center` as a type |
We propose a canonical type `Center` attached to any magma (a type `M` with `Mul M`), providing an alternative approach unifying various center subtypes API.
The main engineer work is to equip `Center` with the correct instance for variant `[foo M]` and we end up with `rfl` for all desired simp lemmas, no diamond.
We also provide some functoriality for `Foo = Monoid/Ring/Alg`
1) `Center.fooHom` for the embedding
2) `FooEquiv.toCenter` for restricring isomorphisms to their centers
Update: it turns out that we need `Subgroup.center` crucially and `Subring.center` for `DivisionRing`. Others can probably switch ot `Center` without pain if we ever want.
Zulip discussion: [#mathlib4 > Center unification @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Center.20unification/near/634714255)
---
- [ ] awaiting-zulip: [#mathlib4 > Center unification @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Center.20unification/near/634714255) |
t-ring-theory
WIP
awaiting-zulip
merge-conflict
|
388/95 |
Mathlib/Algebra/Algebra/Basic.lean,Mathlib/Algebra/Algebra/Subalgebra/Basic.lean,Mathlib/Algebra/Group/Center.lean,Mathlib/Algebra/Ring/CentroidHom.lean,Mathlib/Algebra/Ring/Subring/Basic.lean,Mathlib/Algebra/Ring/Subsemiring/Basic.lean,Mathlib/Algebra/Star/Center.lean,Mathlib/Algebra/Star/CentroidHom.lean,Mathlib/Algebra/Star/NonUnitalSubalgebra.lean,Mathlib/Algebra/Star/NonUnitalSubsemiring.lean,Mathlib/GroupTheory/Subgroup/Center.lean,Mathlib/GroupTheory/Submonoid/Center.lean,Mathlib/GroupTheory/Subsemigroup/Center.lean,Mathlib/RingTheory/NonUnitalSubring/Basic.lean,Mathlib/RingTheory/NonUnitalSubsemiring/Basic.lean |
15 |
11 |
['JX-Mo', 'github-actions', 'leanprover-radar', 'mathlib-merge-conflicts'] |
nobody |
1-73536 1 day ago |
unknown |
unknown |
0 |
| 45643 |
felixpernegger author:felixpernegger |
refactor(Topology): unclass `IsClosed` |
Currently, `IsClosed` is a class, unlike `IsOpen` and it also doesnt make much sense and isnt widely used as a class. This was suggested by @eric-wieser on Zulip [#mathlib4 > Fact instances](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Fact.20instances/with/636430414).
This PR makes it a one-field structure (def would also work, but this prevents defeq abuse...).
Some cleanup is needed, for example when `IsClosed` was used in an instance, we now need `[Fact (IsOpen ...`.
Originally `IsClosed` was made a class in mathlib3 in 2021 [here](https://github.com/leanprover-community/mathlib3/pull/6552).
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
awaiting-zulip
merge-conflict
|
122/91 |
Archive/Examples/Kuratowski.lean,Mathlib/Algebra/Module/ZLattice/Basic.lean,Mathlib/AlgebraicGeometry/AlgClosed/Basic.lean,Mathlib/Analysis/CStarAlgebra/Classes.lean,Mathlib/Analysis/CStarAlgebra/Commutative/PosPart.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Range.lean,Mathlib/Analysis/CStarAlgebra/GelfandDuality.lean,Mathlib/Analysis/CStarAlgebra/Spectrum.lean,Mathlib/Analysis/InnerProductSpace/Projection/Basic.lean,Mathlib/Analysis/InnerProductSpace/Reproducing/Operations.lean,Mathlib/Analysis/Normed/Algebra/Spectrum.lean,Mathlib/Analysis/Normed/Group/Quotient.lean,Mathlib/Analysis/Normed/Ring/Units.lean,Mathlib/LinearAlgebra/Eigenspace/ContinuousLinearMap.lean,Mathlib/MeasureTheory/Constructions/Polish/Basic.lean,Mathlib/MeasureTheory/Measure/Haar/Basic.lean,Mathlib/MeasureTheory/VectorMeasure/AddContent.lean,Mathlib/Topology/Algebra/Algebra.lean,Mathlib/Topology/Algebra/Group/Pointwise.lean,Mathlib/Topology/Algebra/Group/Quotient.lean,Mathlib/Topology/Algebra/Module/Basic.lean,Mathlib/Topology/Algebra/Module/ClosedSubmodule.lean,Mathlib/Topology/Algebra/Module/Compact.lean,Mathlib/Topology/Algebra/Module/FiniteDimension.lean,Mathlib/Topology/Algebra/NonUnitalAlgebra.lean,Mathlib/Topology/Algebra/OpenSubgroup.lean,Mathlib/Topology/Algebra/ProperAction/Basic.lean,Mathlib/Topology/Algebra/Ring/Compact.lean,Mathlib/Topology/Connected/PathComponentOne.lean,Mathlib/Topology/ContinuousMap/Ideals.lean,Mathlib/Topology/ContinuousMap/StoneWeierstrass.lean,Mathlib/Topology/Defs/Basic.lean,Mathlib/Topology/Instances/ENNReal/Lemmas.lean,Mathlib/Topology/Neighborhoods.lean,Mathlib/Topology/Sober.lean,Mathlib/Topology/UniformSpace/UniformEmbedding.lean |
36 |
6 |
['JX-Mo', 'SnirBroshi', 'felixpernegger', 'github-actions', 'leanprover-radar', 'mathlib-merge-conflicts'] |
nobody |
1-57772 1 day ago |
4-68581 4 days ago |
0-57078 15 hours |
0 |
| 42692 |
Parcly-Taxel author:Parcly-Taxel |
refactor: unify `Set.mem_ofPred_eq` into `Set.mem_ofPred` |
Before:
```lean
@[simp, mfld_simps, push]
theorem mem_ofPred_eq {x : α} {p : α → Prop} : (x ∈ {y | p y}) = p x := rfl
theorem mem_ofPred {a : α} {p : α → Prop} : a ∈ { x | p x } ↔ p a := Iff.rfl
```
After:
```lean
@[simp, mfld_simps, push]
theorem mem_ofPred {x : α} {p : α → Prop} : (x ∈ {y | p y}) = p x := rfl
@[deprecated (since := "2026-08-12")] alias mem_ofPred_eq := mem_ofPred
```
Note that the lemma with iff is unusable by `dsimp`.
----
- [ ] awaiting-zulip: [#mathlib4 > Set.mem_setOf_eq @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Set.2Emem_setOf_eq/near/617487671) |
tech debt
awaiting-zulip
|
1012/1015 |
Archive/Imo/Imo1988Q6.lean,Archive/Imo/Imo2008Q2.lean,Archive/Imo/Imo2024Q3.lean,Archive/Sensitivity.lean,Archive/Wiedijk100Theorems/AreaOfACircle.lean,Archive/Wiedijk100Theorems/BallotProblem.lean,Archive/Wiedijk100Theorems/CubingACube.lean,Counterexamples/AharoniKorman.lean,Counterexamples/Phillips.lean,Counterexamples/SorgenfreyLine.lean,Mathlib/Algebra/AffineMonoid/Irreducible.lean,Mathlib/Algebra/Algebra/NonUnitalSubalgebra.lean,Mathlib/Algebra/Algebra/Spectrum/Pi.lean,Mathlib/Algebra/Algebra/Spectrum/Quasispectrum.lean,Mathlib/Algebra/Algebra/Subalgebra/Basic.lean,Mathlib/Algebra/BigOperators/Associated.lean,Mathlib/Algebra/Category/Ring/Topology.lean,Mathlib/Algebra/Group/Subgroup/Basic.lean,Mathlib/Algebra/Group/Submonoid/Basic.lean,Mathlib/Algebra/Group/Submonoid/Defs.lean,Mathlib/Algebra/GroupWithZero/NonZeroDivisors.lean,Mathlib/Algebra/Homology/HomotopyCategory/HomComplexCohomology.lean,Mathlib/Algebra/Lie/Abelian.lean,Mathlib/Algebra/Lie/Basis/Base.lean,Mathlib/Algebra/Lie/Basis/Basic.lean,Mathlib/Algebra/Lie/Character.lean,Mathlib/Algebra/Lie/IdealOperations.lean,Mathlib/Algebra/Lie/InvariantForm.lean,Mathlib/Algebra/Lie/LieTheorem.lean,Mathlib/Algebra/Lie/Semisimple/Basic.lean,Mathlib/Algebra/Lie/Solvable.lean,Mathlib/Algebra/Lie/Subalgebra.lean,Mathlib/Algebra/Lie/Submodule.lean,Mathlib/Algebra/Lie/Weights/Cartan.lean,Mathlib/Algebra/Lie/Weights/Killing.lean,Mathlib/Algebra/Module/Submodule/Invariant.lean,Mathlib/Algebra/Module/ZLattice/Basic.lean,Mathlib/Algebra/Module/ZLattice/Covolume.lean,Mathlib/Algebra/Notation/Support.lean,Mathlib/Algebra/Order/Antidiag/Nat.lean,Mathlib/Algebra/Order/Archimedean/IndicatorCard.lean,Mathlib/Algebra/Order/CompleteField.lean,Mathlib/Algebra/Order/Group/Ideal.lean,Mathlib/Algebra/Order/Group/Pointwise/Interval.lean,Mathlib/Algebra/Order/Quantale.lean,Mathlib/Algebra/Order/Rearrangement.lean,Mathlib/Algebra/Polynomial/EraseLead.lean,Mathlib/Algebra/Polynomial/Laurent/Roots.lean,Mathlib/Algebra/Star/Unitary.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Affine/Point.lean,Mathlib/AlgebraicGeometry/Morphisms/Affine.lean,Mathlib/AlgebraicGeometry/ProjectiveSpectrum/Topology.lean,Mathlib/AlgebraicTopology/SimplicialSet/Boundary.lean,Mathlib/AlgebraicTopology/SimplicialSet/Simplices.lean,Mathlib/AlgebraicTopology/SimplicialSet/StdSimplex.lean,Mathlib/Analysis/Analytic/Composition.lean,Mathlib/Analysis/Analytic/Constructions.lean,Mathlib/Analysis/Analytic/Inverse.lean,Mathlib/Analysis/Analytic/Order.lean,Mathlib/Analysis/Asymptotics/Lemmas.lean,Mathlib/Analysis/BoxIntegral/Basic.lean,Mathlib/Analysis/BoxIntegral/Partition/Filter.lean,Mathlib/Analysis/BoxIntegral/Partition/Split.lean,Mathlib/Analysis/BoxIntegral/UnitPartition.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Continuity.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Order.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Range.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Unitary.lean,Mathlib/Analysis/CStarAlgebra/Extreme.lean,Mathlib/Analysis/CStarAlgebra/Spectrum.lean,Mathlib/Analysis/CStarAlgebra/Unitary/Connected.lean,Mathlib/Analysis/Calculus/BumpFunction/SmoothApprox.lean,Mathlib/Analysis/Calculus/Deriv/Inv.lean,Mathlib/Analysis/Calculus/FDeriv/Measurable.lean,Mathlib/Analysis/Calculus/FDeriv/Symmetric.lean,Mathlib/Analysis/Calculus/LineDeriv/Basic.lean,Mathlib/Analysis/Calculus/ParametricIntegral.lean,Mathlib/Analysis/Calculus/SmoothSeries.lean,Mathlib/Analysis/Calculus/TangentCone/Basic.lean,Mathlib/Analysis/Complex/AbelLimit.lean,Mathlib/Analysis/Complex/Basic.lean,Mathlib/Analysis/Complex/BorelCaratheodory.lean,Mathlib/Analysis/Complex/PhragmenLindelof.lean,Mathlib/Analysis/Convex/Caratheodory.lean,Mathlib/Analysis/Convex/Combination.lean,Mathlib/Analysis/Convex/Deriv.lean,Mathlib/Analysis/Convex/DoublyStochasticMatrix.lean,Mathlib/Analysis/Convex/Extrema.lean,Mathlib/Analysis/Convex/Gauge.lean,Mathlib/Analysis/Convex/Quasiconvex.lean,Mathlib/Analysis/Convex/Segment.lean,Mathlib/Analysis/Convex/SimplicialComplex/AffineIndependentUnion.lean,Mathlib/Analysis/Convex/StdSimplex.lean,Mathlib/Analysis/Distribution/TemperateGrowth.lean,Mathlib/Analysis/InnerProductSpace/Defs.lean,Mathlib/Analysis/InnerProductSpace/LinearPMap.lean,Mathlib/Analysis/LocallyConvex/BalancedCoreHull.lean,Mathlib/Analysis/LocallyConvex/Polar.lean,Mathlib/Analysis/Matrix/Order.lean,Mathlib/Analysis/MeanInequalities.lean |
516 |
52 |
['Parcly-Taxel', 'eric-wieser', 'github-actions', 'grunweg', 'mathlib-merge-conflicts'] |
nobody |
1-47186 1 day ago |
35-16508 35 days ago |
7-45754 7 days |
0 |
| Number |
Author |
Title |
Description |
Labels |
+/- |
Modified files (first 100) |
📝 |
💬 |
All users who commented or reviewed |
Assignee(s) |
Updated |
Last status change |
total time in review |
blocks |
| 43095 |
plp127 author:plp127 |
chore(Data/PFunctor): reduce defeq abuse around `PFunctor.W` |
Reduce the defeq abuse around `PFunctor.W` by adding some API.
---
- [x] depends on: #43056
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-data
tech debt
|
88/52 |
Mathlib/Data/PFunctor/Multivariate/W.lean,Mathlib/Data/PFunctor/Univariate/Basic.lean,Mathlib/Data/QPF/Univariate/Basic.lean |
3 |
2 |
['github-actions', 'mathlib-dependent-issues'] |
nobody |
66-70636 2 months ago |
66-70779 66 days ago |
66-80773 66 days |
0 |
| 43781 |
vlad902 author:vlad902 |
chore(AffineSpace/Independent): remove two `backward.isDefEq.respectTransparency` |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-algebra
tech debt
label:t-algebra$ |
3/7 |
Mathlib/LinearAlgebra/AffineSpace/Independent.lean |
1 |
1 |
['github-actions'] |
nobody |
56-67090 1 month ago |
56-67141 56 days ago |
56-67068 56 days |
0 |
| 43569 |
kim-em author:kim-em |
refactor(ModuleCat): state pushforward coherence without identifying functor bracketings |
This PR makes the pushforward of (pre)sheaves of modules along the identity functor and along a composition of functors honestly typed. Currently `pushforwardId` takes `𝟙 S` at the type `S ⟶ (𝟭 C).op ⋙ S` and `pushforwardComp` takes `φ ≫ whiskerLeft F.op ψ` at the type `S ⟶ (F ⋙ G).op ⋙ T`, which only elaborate because `Functor.comp`, `Functor.id` and `Functor.op` unfold. The new `pushforwardIdHom` and `pushforwardCompHom` are the unitor and associator composed with `Functor.opId`/`Functor.opComp` (see `pushforwardIdHom_eq` and `pushforwardCompHom_eq`), and the associativity and unitality isomorphisms of pushforward and pullback are transported along the functor associator and unitors through the new `pushforwardCongr₂`/`pullbackCongr₂` (added at the presheaf level, together with `pushforwardCongr`, `pushforwardNatTrans` and `pushforwardNatIso`). The scheme-level pseudofunctor coherence lemmas in `AlgebraicGeometry.Modules.Sheaf` are reproved from these, and `Adjunction.leftAdjointCompIso_trans` is added for that purpose.
It is extracted from Paul Reichert's experiment making `Functor.comp` and `Functor.id` `instance_reducible` (https://github.com/leanprover-community/mathlib4/compare/master...leanprover-community:mathlib4-nightly-testing:datokrat/functorcomp, discussed at https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/backward.2EisDefEq.2ErespectTransparency), and is the (pre)sheaf-of-modules half of https://github.com/leanprover-community/mathlib4/pull/43566; it is independent of that PR.
🤖 Prepared with Claude Code |
tech debt
t-category-theory
|
480/131 |
Mathlib/Algebra/Category/ModuleCat/Presheaf.lean,Mathlib/Algebra/Category/ModuleCat/Presheaf/Pullback.lean,Mathlib/Algebra/Category/ModuleCat/Presheaf/Pushforward.lean,Mathlib/Algebra/Category/ModuleCat/Sheaf/PullbackContinuous.lean,Mathlib/Algebra/Category/ModuleCat/Sheaf/PushforwardContinuous.lean,Mathlib/Algebra/Category/ModuleCat/Sheaf/Quasicoherent.lean,Mathlib/AlgebraicGeometry/Modules/Sheaf.lean,Mathlib/CategoryTheory/Adjunction/CompositionIso.lean,Mathlib/Topology/Sheaves/Module.lean |
9 |
2 |
['github-actions', 'mathlib-merge-conflicts'] |
nobody |
42-44330 1 month ago |
42-44777 42 days ago |
60-62263 60 days |
0 |
| 44093 |
grunweg author:grunweg |
chore: fix more congruence lemmas |
A `congr` should vary all its explicit arguments, not just some of them. This issue is documented on the docstring of the `@[congr]` attribute, but there is no warning when you write a bad `@[congr]` lemma.
Whenever a lemma seemed used sufficiently often, we fixed the congruence lemma by adding a new variant, with a primed name and the additional arguments varied also.
Found by the linter in #43692; these should be all remaining bad lemmas in mathlib.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-algebra
tech debt
label:t-algebra$ |
74/38 |
Mathlib/Algebra/MonoidAlgebra/Module.lean,Mathlib/Data/Finset/Filter.lean,Mathlib/Data/Finset/Fold.lean,Mathlib/Data/Finsupp/Basic.lean,Mathlib/Data/List/Basic.lean,Mathlib/Data/List/Find.lean,Mathlib/Data/List/Zip.lean,Mathlib/Data/Multiset/Bind.lean,Mathlib/Data/Multiset/Filter.lean,Mathlib/Data/Multiset/Find.lean,Mathlib/Data/Set/Image.lean,Mathlib/Data/Set/NAry.lean,Mathlib/Data/Sym/Basic.lean,Mathlib/Data/Sym/Card.lean,Mathlib/Data/Sym/Sym2.lean,Mathlib/Geometry/Convex/ConvexSpace/Defs.lean,Mathlib/LinearAlgebra/Finsupp/Supported.lean,Mathlib/LinearAlgebra/QuadraticForm/Signature.lean |
18 |
5 |
['github-actions', 'grunweg', 'j-loreaux', 'mathlib-merge-conflicts'] |
nobody |
41-83655 1 month ago |
41-84330 41 days ago |
44-76463 44 days |
0 |
| 44396 |
mathlib-splicebot author:mathlib-splicebot |
chore(Analysis/Complex/UnitDisc/Basic): fix instance diamond |
There were two natural number power instances which differed at implicit transparency.
The `NatPowAssoc` instance is not necessary, hence can be removed.
Found by the linter in #38781.
Co-authored-by: Jovan Gerbscheid <jovan.gerbscheid@gmail.com>
-------- |
tech debt
t-analysis
|
11/16 |
Mathlib/Analysis/Complex/UnitDisc/Basic.lean |
1 |
3 |
['github-actions', 'grunweg', 'leanprover-radar'] |
nobody |
38-69963 1 month ago |
38-71659 38 days ago |
38-71586 38 days |
0 |
| 44032 |
kim-em author:kim-em |
chore: remove backward.privateInPublic by wrapping proofs with private_decl% |
This PR removes 171 uses of `backward.privateInPublic` across 37 files. Wherever a public declaration used a private lemma in a proof position, the proof is wrapped with core's `private_decl%` elaborator, or with the `field := private proof` structure-instance syntax where the proof fills a structure field. Both elaborate the proof in a private context and hide it behind an auxiliary declaration, which is harmless by proof irrelevance. No declaration changes visibility and no statement changes, except that in `Combinatorics/SetFamily/AhlswedeZhang` the `Finset → Set` coercion in `lowerClosure s` is now written explicitly, since `private_decl%` elaborates eagerly and otherwise sees the coercion's pending metavariable.
This follows the plan of #42755 by @thorimur and takes its non-elaborator changes verbatim: moving `variable` commands out of `public section` in four files where almost every declaration is private (Galois/Decomposition, ChevalleyComplexity, GromovHausdorffRealized, NumberField/House; see https://github.com/leanprover/lean4/issues/14708 and https://github.com/leanprover/lean4/issues/14718), making the two lemmas used by the `sz_positivity` macro public under internal names, and separating data from proof in `binomExpansion` and `archimedeanClassOrderIso`. The difference is that this PR uses the elaborator that already exists in core rather than the `private` term elaborator proposed in #42563, so that it can land now. Once #42563 is in, every `private_decl% (…)` here can be replaced mechanically by `private …`. The 13 files that only need the field syntax are in #44023 and are not touched here.
🤖 Prepared with Claude Code |
tech debt |
135/274 |
Mathlib/Algebra/Group/End.lean,Mathlib/Algebra/Lie/BaseChange.lean,Mathlib/Algebra/Lie/Weights/RootSystem.lean,Mathlib/Algebra/Module/Injective.lean,Mathlib/Algebra/Polynomial/Identities.lean,Mathlib/AlgebraicTopology/FundamentalGroupoid/InducedMaps.lean,Mathlib/AlgebraicTopology/SimplicialSet/HomotopyCat.lean,Mathlib/Analysis/InnerProductSpace/TensorProduct.lean,Mathlib/Analysis/Normed/Lp/PiLp.lean,Mathlib/Analysis/Normed/Lp/ProdLp.lean,Mathlib/Analysis/Normed/Operator/Basic.lean,Mathlib/CategoryTheory/Galois/Decomposition.lean,Mathlib/CategoryTheory/Monoidal/Closed/FunctorCategory/Complete.lean,Mathlib/CategoryTheory/Preadditive/CommGrp_.lean,Mathlib/Combinatorics/SetFamily/AhlswedeZhang.lean,Mathlib/Combinatorics/SimpleGraph/Copy.lean,Mathlib/Combinatorics/SimpleGraph/Regularity/Bound.lean,Mathlib/Computability/Primrec/List.lean,Mathlib/Data/Finset/Union.lean,Mathlib/FieldTheory/PerfectClosure.lean,Mathlib/GroupTheory/DivisibleHull.lean,Mathlib/LinearAlgebra/LinearPMap.lean,Mathlib/LinearAlgebra/RootSystem/Basic.lean,Mathlib/ModelTheory/Algebra/Ring/FreeCommRing.lean,Mathlib/NumberTheory/NumberField/House.lean,Mathlib/Order/BooleanAlgebra/Basic.lean,Mathlib/Order/Lattice/Congruence.lean,Mathlib/RingTheory/Coalgebra/TensorProduct.lean,Mathlib/RingTheory/DividedPowers/Padic.lean,Mathlib/RingTheory/DividedPowers/SubDPIdeal.lean,Mathlib/RingTheory/PicardGroup.lean,Mathlib/RingTheory/Spectrum/Prime/ChevalleyComplexity.lean,Mathlib/Topology/ExtremallyDisconnected.lean,Mathlib/Topology/MetricSpace/GromovHausdorffRealized.lean,Mathlib/Topology/MetricSpace/Pseudo/Defs.lean,Mathlib/Topology/UnitInterval.lean |
36 |
5 |
['JovanGerb', 'github-actions', 'kim-em', 'mathlib-merge-conflicts', 'thorimur'] |
nobody |
38-43763 1 month ago |
38-43934 38 days ago |
46-80481 46 days |
0 |
| 44040 |
kim-em author:kim-em |
chore: adaptation notes for the backward.privateInPublic uses blocked on lean4#14708 |
This PR adds an `#adaptation_note` at each `variable` declaration with an autoParam binder whose users need `backward.privateInPublic`. These uses (about 80 of the remaining option lines, in 14 files) are not removable on the Mathlib side: the autoParam helper declaration generated for a `variable` is always private, and any declaration using that variable in a public section silently elaborates to `sorry` without the option. This is https://github.com/leanprover/lean4/issues/14708. The note says which `set_option`s can go once that is fixed, and stops anyone from spending time on them before then. Each affected file was checked by removing its `true`-only option lines and observing the `sorry` warnings and the follow-on `autoParam … is not a constant` errors.
It also deletes the one option line in `CategoryTheory/SmallObject/Iteration/ExtendToSucc` that turned out to be unnecessary.
🤖 Prepared with Claude Code |
tech debt
LLM-generated
|
116/0 |
Mathlib/Algebra/Module/ZLattice/Covolume.lean,Mathlib/AlgebraicTopology/SimplicialSet/CompStruct.lean,Mathlib/AlgebraicTopology/SimplicialSet/StrictSegal.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/NonUnital.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Unital.lean,Mathlib/Analysis/Distribution/TemperedDistribution.lean,Mathlib/CategoryTheory/ComposableArrows/Basic.lean,Mathlib/CategoryTheory/Join/Basic.lean,Mathlib/CategoryTheory/Limits/Shapes/Reflexive.lean,Mathlib/CategoryTheory/LocallyCartesianClosed/ChosenPullbacksAlong.lean,Mathlib/CategoryTheory/Monoidal/Braided/Basic.lean,Mathlib/CategoryTheory/Monoidal/CommGrp_.lean,Mathlib/CategoryTheory/Monoidal/Functor.lean,Mathlib/CategoryTheory/Sites/Point/Basic.lean,Mathlib/CategoryTheory/SmallObject/Iteration/ExtendToSucc.lean |
15 |
1 |
['github-actions'] |
nobody |
32-58447 1 month ago |
48-48979 48 days ago |
48-48906 48 days |
0 |
| 43948 |
JX-Mo author:JX-Mo |
chore(RepresentationTheory/Coinduced): tech debt |
Remove five `backward.isDefEq.respectTransparency.types` and add a CoeFun instance for `coindV` to justify the existing `coe`-named lemmas.
https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60CoeFun.60.20or.20.60.2Eval.60/with/630026437 |
t-algebra
tech debt
easy
label:t-algebra$ |
22/17 |
Mathlib/RepresentationTheory/Coinduced.lean |
1 |
37 |
['JX-Mo', 'Whysoserioushah', 'github-actions', 'jcommelin', 'jjdishere', 'leanprover-radar', 'mathlib-bors'] |
nobody |
32-37589 1 month ago |
35-17348 35 days ago |
37-80537 37 days |
4 |
| 43570 |
kim-em author:kim-em |
refactor(AlgebraicGeometry/Modules): transport pushforward along Opens.map functoriality isos |
This PR defines `Scheme.Modules.pushforwardId` and `pushforwardComp` by transporting the sheaf-of-modules isomorphisms along the existing `Opens.mapId` and `Opens.mapComp` (via `SheafOfModules.pushforwardCongr₂`) rather than by identifying `Opens.map (𝟙 X).base` with `𝟭` and `Opens.map (f ≫ g).base` with `Opens.map g.base ⋙ Opens.map f.base` by unfolding `Opens.map`. The componentwise simp lemmas become `M.presheaf.map_id` rather than `rfl`, and the pseudofunctor coherence fields are discharged explicitly since `cat_disch` no longer finds them by reflexivity. Also adds the simp lemma `Adj.eqToHom_τl`.
It is extracted from Paul Reichert's experiment making `Functor.comp` and `Functor.id` `instance_reducible` (https://github.com/leanprover-community/mathlib4/compare/master...leanprover-community:mathlib4-nightly-testing:datokrat/functorcomp, discussed at https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/backward.2EisDefEq.2ErespectTransparency), and depends on https://github.com/leanprover-community/mathlib4/pull/43569. The diff relative to that PR is https://github.com/kim-em/mathlib4/compare/associators-sheaves...opens-map.
🤖 Prepared with Claude Code |
tech debt |
516/139 |
Mathlib/Algebra/Category/ModuleCat/Presheaf.lean,Mathlib/Algebra/Category/ModuleCat/Presheaf/Pullback.lean,Mathlib/Algebra/Category/ModuleCat/Presheaf/Pushforward.lean,Mathlib/Algebra/Category/ModuleCat/Sheaf/PullbackContinuous.lean,Mathlib/Algebra/Category/ModuleCat/Sheaf/PushforwardContinuous.lean,Mathlib/Algebra/Category/ModuleCat/Sheaf/Quasicoherent.lean,Mathlib/AlgebraicGeometry/Modules/Sheaf.lean,Mathlib/CategoryTheory/Adjunction/CompositionIso.lean,Mathlib/CategoryTheory/Bicategory/Adjunction/Adj.lean,Mathlib/Topology/Sheaves/Module.lean |
10 |
2 |
['github-actions', 'mathlib-merge-conflicts'] |
nobody |
29-40886 29 days ago |
42-44514 42 days ago |
60-62237 60 days |
0 |
| 43885 |
plp127 author:plp127 |
refactor: reduce defeq abuse in `Representation.asModule` |
Reduce defeq abuse around `Representation.asModule` by adding explicitly uses of `Representation.asModuleEquiv` to convert between `V` and `ρ.asModule`. Also reorganize some `@[simp]` lemmas and fix some naming issues.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-algebra
tech debt
label:t-algebra$ |
70/89 |
Mathlib/RepresentationTheory/Basic.lean,Mathlib/RepresentationTheory/Intertwining.lean,Mathlib/RepresentationTheory/Rep/Iso.lean,Mathlib/RepresentationTheory/Submodule.lean,Mathlib/RepresentationTheory/Subrepresentation.lean |
5 |
21 |
['JX-Mo', 'github-actions', 'plp127'] |
nobody |
28-50999 28 days ago |
29-4889 29 days ago |
53-64785 53 days |
0 |
| 44712 |
plp127 author:plp127 |
chore: rename arguments to `Shrink.rec` |
Name the motive `motive` and name the minor premises according to their contents. While we're here, also unexpose `Shrink.rec`, which is the last exposed declaration in this file, so also remove the `@[expose]` from the `@[expose] public section` at the top of the file because none of the declarations are actually exposed.
Also add a docstring.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
tech debt
t-logic
|
10/10 |
Mathlib/Logic/Small/Defs.lean,scripts/nolints.json |
2 |
2 |
['github-actions', 'vihdzp'] |
nobody |
28-32549 28 days ago |
29-4071 29 days ago |
29-53570 29 days |
0 |
| 42488 |
joelriou author:joelriou |
feat(AlgebraicTopology/SimplicialSet): the fundamental groupoid of a Kan complex |
In the file `Mathlib/AlgebraicTopology/SimplicialSet/FundamentalGroupoid/Basic.lean`,
the fundamental groupoid of any simplicial set `X` was defined. In this category,
morphisms can be represented by finite compositions of edges and their formal inverses.
In this PR, we show that if `X` is a Kan complex, then a morphism in `FundamentalGroupoid X` can be represented by a single edge, and commutative triangles in the fundamental groupoid of `X` all arise from `Edge.CompStruct` structures (i.e. `2`-simplices of `X`).
---
- [x] depends on: #44775
- [x] depends on: #42523
- [x] depends on: #42526
- [x] depends on: #42527
- [x] depends on: #38216
- [x] depends on: #42473
- [x] depends on: #38664
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-algebraic-topology
tech debt
|
261/3 |
Mathlib.lean,Mathlib/AlgebraicTopology/SimplicialSet/CompStruct.lean,Mathlib/AlgebraicTopology/SimplicialSet/CompStructTruncated.lean,Mathlib/AlgebraicTopology/SimplicialSet/FundamentalGroupoid/Basic.lean,Mathlib/AlgebraicTopology/SimplicialSet/KanComplex/FundamentalGroupoid.lean,Mathlib/AlgebraicTopology/SimplicialSet/StdSimplex.lean |
6 |
7 |
['github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] |
nobody |
25-23573 25 days ago |
25-23620 25 days ago |
25-23721 25 days |
1 |
| 40841 |
TJHeeringa author:TJHeeringa |
chore(Topology/Algebra): rename .equivOfInverse to .ofContinuousLinearMap |
Renames `ContinuousLinearEquiv.equivOfInverse` and `ContinuousLinearEquiv.equivOfInverse'` to `ContinuousLinearEquiv.ofContinuousLinearMap` and `ContinuousLinearEquiv.ofContinuousLinearMap'`. It reorders the order of arguments to match that of `ofLinearMap`.
---
Addresses the ToDO `*ToDo*: Improve the naiming to make it match `LinearMap.ofLinear`.` for `ContinuousLinearEquiv.equivOfInverse`.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #40865
- [x] depends on: #42818
- [x] depends on: #42822
[](https://gitpod.io/from-referrer/)
|
t-topology
tech debt
|
80/25 |
Mathlib/Analysis/InnerProductSpace/TensorProduct.lean,Mathlib/Topology/Algebra/Module/ContinuousLinearMap/Invertible.lean,Mathlib/Topology/Algebra/Module/Equiv/Basic.lean |
3 |
83 |
['TJHeeringa', 'Whysoserioushah', 'b-mehta', 'github-actions', 'j-loreaux', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'themathqueen'] |
nobody |
23-49555 23 days ago |
44-68911 44 days ago |
61-2015 61 days |
0 |
| 41675 |
joelriou author:joelriou |
feat(AlgebraicTopology): pushout diagrams in the filtration of `Δ[p] ⊗ Δ[1]` |
This will be used in #42295 in order to construct morphisms from `Δ[p] ⊗ Δ[1]` out of the data of the images of the nondegenerate `(p + 1)`-simplices of `Δ[p] ⊗ Δ[1]`.
---
- [x] depends on: #41656
- [x] depends on: #41655
- [x] depends on: #41624
- [x] depends on: #41617
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-algebraic-topology
tech debt
|
244/15 |
Mathlib/AlgebraicTopology/SimplicialSet/AnodyneExtensions/UnionProd.lean,Mathlib/AlgebraicTopology/SimplicialSet/ProdStdSimplex.lean,Mathlib/AlgebraicTopology/SimplicialSet/ProdStdSimplexOne.lean,Mathlib/AlgebraicTopology/SimplicialSet/StdSimplex.lean,Mathlib/AlgebraicTopology/SimplicialSet/Subcomplex.lean,Mathlib/CategoryTheory/Monoidal/FunctorCategory.lean |
6 |
19 |
['github-actions', 'joelriou', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'robin-carlier'] |
nobody |
21-33212 21 days ago |
22-79263 22 days ago |
62-3214 62 days |
2 |
| 44026 |
kim-em author:kim-em |
chore: remove backward.privateInPublic in category theory, topology and analysis |
This PR removes the `backward.privateInPublic` option in 6 files across category theory, topology and analysis. In each case a private definition appeared in the statement of a public declaration, so it was already part of the public interface in all but name. The fix is to drop `private` from those definitions (and from the auxiliary definitions their bodies depend on in exposed sections), adding docstrings where they were missing. In `Analysis/InnerProductSpace/OfNorm` the auxiliary inner product `inner_` moves into the `InnerProductSpaceable` namespace rather than becoming a root-level name; the public lemmas `inner_.norm_sq`, `inner_.conj_symm` and `Continuous.inner_` already carried its name. In `Topology/Category/Compactum` the helper `cl` gets a mathematical docstring, and the two lemmas about it that are only used in proofs stay private.
Files where a private *lemma* appeared in a public statement, and the files with file-wide `public section` restructuring, are handled in #44032. Names are otherwise kept as they were; suggestions for better names are welcome but are not needed for this PR.
🤖 Prepared with Claude Code |
tech debt |
19/63 |
Mathlib/Analysis/InnerProductSpace/OfNorm.lean,Mathlib/CategoryTheory/Monoidal/Internal/FunctorCategory.lean,Mathlib/FieldTheory/Galois/Profinite.lean,Mathlib/Topology/Category/Compactum.lean,Mathlib/Topology/Category/TopCat/Limits/Konig.lean,Mathlib/Topology/MetricSpace/GromovHausdorff.lean |
6 |
1 |
['github-actions'] |
JovanGerb assignee:JovanGerb |
20-50460 20 days ago |
49-19615 49 days ago |
49-32301 49 days |
0 |
| 43817 |
marcelolynch author:marcelolynch |
chore: remove superfluous `@[expose]` modifiers from public sections |
This PR removes `@[expose]` from 91 public sections where it has no effect. A section-level `@[expose]` only changes the bodies of `def`s. These sections hold theorems, instances, abbrevs, structures, inductives, notation, or defs whose bodies Lean keeps private without the modifier.
The `superfluousExpose` linter from #39387 flagged 73 of the 4915 files that open an `@[expose] public section`. A scan of master found 23 more files whose sections contain no `def`.
To check each removal independently of the linter, a script compiles the module with and without the modifier and compares the results. In all 91 cases, the `.olean`, `.olean.private` and `.olean.server` files are byte-identical, and so are the compiler messages.
Five files are left out:
- Three files that the linter flags contain `@[no_expose]` declarations. Without the section `@[expose]`, Lean reports each `@[no_expose]` as redundant, so these files need a second edit. One of them has `@[no_expose, simps! -isSimp app]`, where the attribute still has an effect.
- `Mathlib/Lean/Elab/InfoTree.lean` and `Mathlib/Lean/Elab/Tactic/Meta.lean` cannot import the linter, because `Mathlib.Init` imports them. A direct comparison shows that the removal changes their `.olean`, so they keep the modifier.
#39388 was the first round of this cleanup.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
tech debt
LLM-generated
|
91/91 |
Mathlib/Algebra/Category/ModuleCat/Ext/Baer.lean,Mathlib/Algebra/Category/ModuleCat/Presheaf/OfCommRing.lean,Mathlib/Algebra/Field/Rat.lean,Mathlib/Algebra/Group/Commute/Defs.lean,Mathlib/Algebra/Group/Defs.lean,Mathlib/Algebra/Group/IsCommutative.lean,Mathlib/Algebra/Group/Semiconj/Defs.lean,Mathlib/Algebra/GroupWithZero/Action/Regular.lean,Mathlib/Algebra/GroupWithZero/FunLike.lean,Mathlib/Algebra/HierarchyDesign.lean,Mathlib/Algebra/Homology/HomotopyCategory/ChainComplex.lean,Mathlib/Algebra/Notation/Pi/Defs.lean,Mathlib/Algebra/Order/Archimedean/Real/Basic.lean,Mathlib/Algebra/Order/Field/Basic.lean,Mathlib/Algebra/Order/Nonneg/Lattice.lean,Mathlib/Algebra/Order/Ring/Unbundled/Rat.lean,Mathlib/Algebra/QuadraticAlgebra/AlgHom.lean,Mathlib/AlgebraicTopology/Quasicategory/TwoTruncatedQuasicategory.lean,Mathlib/Analysis/Asymptotics/Arith.lean,Mathlib/Analysis/Asymptotics/Basic.lean,Mathlib/Analysis/Asymptotics/Prod.lean,Mathlib/Analysis/Asymptotics/Ring.lean,Mathlib/Analysis/InnerProductSpace/Coalgebra.lean,Mathlib/Analysis/LocallyConvex/Asymptotics.lean,Mathlib/Analysis/Meromorphic/LogDeriv.lean,Mathlib/Analysis/Normed/Operator/Fredholm/Open.lean,Mathlib/Analysis/ODE/ExistUnique.lean,Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/Rpow/Measurable.lean,Mathlib/CategoryTheory/Abelian/OrthogonalClosed.lean,Mathlib/CategoryTheory/Adhesive/PushoutProduct.lean,Mathlib/CategoryTheory/ComposableArrows/Two.lean,Mathlib/CategoryTheory/Functor/Derived/RightDerivedCompositionCommShift.lean,Mathlib/CategoryTheory/Galois/FullSubcategory.lean,Mathlib/CategoryTheory/Limits/ConstructLimitMap.lean,Mathlib/CategoryTheory/MorphismProperty/LocalClosure.lean,Mathlib/CategoryTheory/ObjectProperty/FiniteLimits.lean,Mathlib/CategoryTheory/ObjectProperty/IsClosedUnderCardinalFilteredColimits.lean,Mathlib/CategoryTheory/ObjectProperty/OrthogonalLimits.lean,Mathlib/CategoryTheory/ObjectProperty/Subobject.lean,Mathlib/CategoryTheory/Presentable/Basic.lean,Mathlib/CategoryTheory/Presentable/IsDiscrete.lean,Mathlib/CategoryTheory/Presentable/PreservesCardinalPresentable.lean,Mathlib/CategoryTheory/Presentable/SolutionSetCondition.lean,Mathlib/CategoryTheory/Presentable/Uniformization.lean,Mathlib/CategoryTheory/Profunctor/Bicategory.lean,Mathlib/CategoryTheory/Triangulated/TStructure/TExact.lean,Mathlib/Data/ENat/Pow.lean,Mathlib/Data/EReal/BigOperators.lean,Mathlib/Data/NNRat/Floor.lean,Mathlib/Data/Nat/Cast/Pi.lean,Mathlib/Data/Rat/Floor.lean,Mathlib/FieldTheory/TranscendentalSeparable.lean,Mathlib/Geometry/Convex/AffineMap/Defs.lean,Mathlib/GroupTheory/FiniteAbelian/Basic.lean,Mathlib/GroupTheory/Finiteness.lean,Mathlib/GroupTheory/SpecificGroups/VirtuallyCyclic.lean,Mathlib/LinearAlgebra/Matrix/Echelon/Pivot.lean,Mathlib/MeasureTheory/Integral/MeanInequalities.lean,Mathlib/MeasureTheory/Integral/SetToL1/ChangeMeasure.lean,Mathlib/MeasureTheory/Integral/SetToL1/DominatedConvergence.lean,Mathlib/MeasureTheory/Measure/Dirac/Basic.lean,Mathlib/NumberTheory/LSeries/PrimesInAP.lean,Mathlib/NumberTheory/LSeries/RiemannZetaLogDeriv.lean,Mathlib/NumberTheory/NumberField/FiniteAdeleRing.lean,Mathlib/Order/CompleteBooleanAlgebra.lean,Mathlib/Order/ConditionallyCompleteLattice/Basic.lean,Mathlib/Order/Defs/Lattice.lean,Mathlib/Order/Heyting/Basic.lean,Mathlib/Order/Lattice/Nat.lean,Mathlib/Order/Sigma.lean,Mathlib/Order/SuccPred/CompleteLinearOrder.lean,Mathlib/Order/SuccPred/ENat.lean,Mathlib/RingTheory/Coalgebra/CoassocSimps.lean,Mathlib/RingTheory/LocalRing/ResidueField/Separable.lean,Mathlib/RingTheory/Localization/Saturation.lean,Mathlib/RingTheory/MvPowerSeries/Ideal.lean,Mathlib/RingTheory/QuadraticAlgebra.lean,Mathlib/RingTheory/QuasiFinite/Basic.lean,Mathlib/RingTheory/QuasiFinite/Weakly.lean,Mathlib/RingTheory/Radical/NatInt.lean,Mathlib/SetTheory/Ordinal/Family.lean,Mathlib/SetTheory/Ordinal/FundamentalSequence.lean,Mathlib/Tactic/Inclusion/Extension/IntervalDyadicReal/Basic.lean,Mathlib/Tactic/Inclusion/Extension/IntervalDyadicReal/Hypotheses.lean,Mathlib/Tactic/Inclusion/Extension/IntervalDyadicReal/Init.lean,Mathlib/Tactic/SimpLibraryNote.lean,Mathlib/Topology/Category/DeltaGenerated.lean,Mathlib/Topology/Category/TopCommRingCat.lean,Mathlib/Topology/EMetricSpace/Weak.lean,Mathlib/Topology/List.lean,Mathlib/Topology/MetricSpace/CoveringExponent.lean |
91 |
2 |
['github-actions', 'mathlib-merge-conflicts'] |
nobody |
17-83440 17 days ago |
17-81345 17 days ago |
42-39585 42 days |
0 |
| 40368 |
Sanghyeok0 author:Sanghyeok0 |
feat: add confluence predicates for relations |
This PR adds a minimal relation-level API for confluence-style properties:
* `Relation.IsDiamond`
* `Relation.IsConfluent`
* `Relation.IsChurchRosser`
It also adds the basic API connecting these predicates:
* `Relation.ReflTransGen.to_eqvGen`
* `Relation.Join.le_eqvGen`
* `Relation.IsChurchRosser.isConfluent`
* `Relation.IsConfluent.isChurchRosser`
* `Relation.IsChurchRosser.join_reflTransGen_eq_eqvGen`
The main downstream application is the polynomial-reduction development in
#41475. There, polynomial reduction is treated as an ordinary relation on
`MvPolynomial`, and these predicates are used to formulate confluence and the
Church--Rosser property.
A more general rewriting API exists in CSLib. This PR does not attempt to
upstream that API wholesale; its scope is intentionally limited to the
declarations needed by the downstream polynomial application.
The earlier version of this PR also introduced
`Relation.StronglyConfluent` and additional equivalence packaging. Those
declarations have been removed to keep this PR small and application-driven.
Reference: Becker, Weispfenning, and Kredel,
*Gröbner Bases: A Computational Approach to Commutative Algebra*.
AI usage disclosure:
I used OpenAI Codex to generate initial drafts of the definitions, theorem statements, proof scripts, and docstrings. I made the final decisions on the mathematical scope and API design, reviewed the generated code and final changes, and made a few edits to statements and docstrings.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-logic
new-contributor
tech debt
LLM-generated
|
103/25 |
Mathlib/GroupTheory/FreeGroup/Basic.lean,Mathlib/Logic/Relation.lean |
2 |
38 |
['Hagb', 'Sanghyeok0', 'SnirBroshi', 'chenson2018', 'github-actions', 'mathlib-merge-conflicts'] |
nobody |
14-65913 14 days ago |
62-58570 62 days ago |
135-28964 135 days |
1 |
| 42402 |
justus-springer author:justus-springer |
refactor(AlgebraicGeometry/Birational): phase out `Scheme.Over` for rational maps |
Split off from #40871
We refactor `PartialMap.IsOver` to not use `Scheme.Hom.IsOver`, which is being phased out. We still keep it as class with one field for now (as opposed to making it an abbrev for the morphism equation directly). This is because I think it's still useful to have instances for `PartialMap.restrict` and `PartialMap.toRationalMap`. However, some things which used to be instances (`isOver_comp` and `IsOver.compHom`) now need to be lemmas.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-algebraic-geometry
tech debt
|
100/86 |
Mathlib/AlgebraicGeometry/Birational/Composition.lean,Mathlib/AlgebraicGeometry/Birational/RationalMap.lean |
2 |
4 |
['Brian-Nugent', 'github-actions', 'justus-springer', 'mathlib-merge-conflicts'] |
nobody |
14-10007 14 days ago |
14-10148 14 days ago |
95-17642 95 days |
1 |
| 32840 |
joelriou author:joelriou |
refactor(CategoryTheory): remove the old Ext API |
As it is now possible to compute `Ext`-groups (defined using the derived category) using an injective resolution #32105 or a projective resolution #32816, the old `Ext` API (based on left derived functors) is removed.
---
- [x] depends on: #44124
- [x] depends on: #44190
- [x] depends on: #32816
- [x] depends on: #32105
- [x] depends on: #32814
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-category-theory
large-import
tech debt
|
285/29 |
Mathlib.lean,Mathlib/Algebra/Homology/Embedding/Basic.lean,Mathlib/Algebra/Homology/Embedding/CochainComplex.lean,Mathlib/Algebra/Homology/HomotopyCategory/HomComplexIsStrictlyGE.lean,Mathlib/Algebra/Homology/LinearYonedaObj.lean,Mathlib/Algebra/Homology/LocalCohomology.lean,Mathlib/CategoryTheory/Abelian/Ext.lean,Mathlib/CategoryTheory/Linear/Yoneda.lean,Mathlib/RepresentationTheory/Homological/GroupCohomology/Basic.lean,Mathlib/RepresentationTheory/Homological/Resolution.lean |
10 |
7 |
['github-actions', 'mathlib-bors', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'mathlib4-merge-conflict-bot'] |
nobody |
14-5739 14 days ago |
14-5912 14 days ago |
14-54982 14 days |
0 |
| 42561 |
SnirBroshi author:SnirBroshi |
feat(Order/RelSeries): order series by refinement |
Define a partial order on `RelSeries`, add basic lemmas for the operations (e.g. `p < p.append q`), and relate to `IsChain` on sets.
This lets us spell "maximal chain" using series.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
tech debt
t-order
|
151/5 |
Mathlib/Order/RelSeries.lean |
1 |
2 |
['github-actions', 'mathlib-merge-conflicts'] |
nobody |
13-67539 13 days ago |
13-67604 13 days ago |
93-17262 93 days |
0 |
| 43705 |
joelriou author:joelriou |
feat(Category/Abelian/Projective): interaction between `ProjectiveResolution.extMk` and the connecting morphism |
This is the dual result to #43224. Obtaining the dual version required introducing more API for the mapping cocone.
---
- [x] depends on: #43224
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-category-theory
tech debt
|
415/29 |
Mathlib/Algebra/Homology/DerivedCategory/Basic.lean,Mathlib/Algebra/Homology/DerivedCategory/ShortExact.lean,Mathlib/Algebra/Homology/DerivedCategory/SingleTriangle.lean,Mathlib/Algebra/Homology/DerivedCategory/SmallShiftedHom.lean,Mathlib/Algebra/Homology/HomotopyCategory/HomComplexShift.lean,Mathlib/Algebra/Homology/HomotopyCategory/HomComplexSingle.lean,Mathlib/Algebra/Homology/HomotopyCategory/MappingCocone.lean,Mathlib/Algebra/Homology/HomotopyCategory/Shift.lean,Mathlib/Algebra/Homology/HomotopyCategory/ShortExact.lean,Mathlib/CategoryTheory/Abelian/Injective/Ext.lean,Mathlib/CategoryTheory/Abelian/Projective/Ext.lean,Mathlib/CategoryTheory/Abelian/Projective/Extend.lean,Mathlib/CategoryTheory/Triangulated/Rotate.lean |
13 |
5 |
['github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] |
nobody |
13-19033 13 days ago |
13-19078 13 days ago |
21-33044 21 days |
0 |
| 45300 |
xroblot author:xroblot |
refactor(RingTheory/Ideal): generalize some absNorm lemmas and move primesEquiv |
This is the clean-up part of #42567, extracted so that the summability work can build on it.
Two divisibility and positivity results about the absolute norm of an ideal are generalized from `ℤ` to a Dedekind domain, and from prime ideals to proper ideals, with the earlier versions deprecated.
The equivalence between the height-one prime ideals of the integral closure of `ℤ` in `ℚ` and the prime numbers is moved to the Dedekind domain files, where it belongs, and redefined through the absolute norm rather than through a generator of the corresponding ideal of `ℤ`. It now assumes less, and the auxiliary API it used to be built from is deprecated without replacement.
Finally, the equivalence between the height-one spectra of two isomorphic rings is reworked so that the surjectivity proofs have the expected type, which removes the need for a `backward.isDefEq` option.
Prepared with Claude Code 🤖
|
tech debt |
136/71 |
Mathlib/NumberTheory/NumberField/Completion/FinitePlace.lean,Mathlib/NumberTheory/Padics/HeightOneSpectrum.lean,Mathlib/RingTheory/DedekindDomain/Ideal/Lemmas.lean,Mathlib/RingTheory/Ideal/Int.lean,Mathlib/RingTheory/Ideal/Norm/AbsNorm.lean |
5 |
1 |
['github-actions'] |
nobody |
12-76525 12 days ago |
12-76660 12 days ago |
14-3342 14 days |
1 |
| 45022 |
Parcly-Taxel author:Parcly-Taxel |
chore: remove some tech debt |
The removals in this PR are `backward.defeqAttrib.useBackward`, some adaptation notes from the upgrade to 4.30.0-rc1 and one `backward.isDefEq.respectTransparency.types`. |
tech debt |
21/54 |
Mathlib/Algebra/DirectSum/Algebra.lean,Mathlib/Algebra/DualNumber.lean,Mathlib/Algebra/QuaternionBasis.lean,Mathlib/Analysis/SpecialFunctions/Complex/Arctan.lean,Mathlib/CategoryTheory/SmallObject/Construction.lean,Mathlib/Combinatorics/Additive/AP/Three/Behrend.lean,Mathlib/Combinatorics/SimpleGraph/Tutte.lean,Mathlib/LinearAlgebra/Determinant.lean,Mathlib/LinearAlgebra/Matrix/Charpoly/Basic.lean,Mathlib/LinearAlgebra/TensorProduct/Basic.lean,Mathlib/LinearAlgebra/TensorProduct/Pi.lean,Mathlib/Order/CompleteLattice/Basic.lean |
12 |
1 |
['github-actions'] |
nobody |
12-38399 12 days ago |
12-38448 12 days ago |
20-47216 20 days |
0 |
| 43857 |
vihdzp author:vihdzp |
feat: split `transfiniteIterate` into `sup` and `inf` versions |
We rename `transfiniteIterate` to `supTransfiniteIterate` and create the analogous `infTransfiniteIterate` in its place. One of them uses suprema to compute the value at limit points, and the other uses infima.
The plan is to then use both of these definitions to deprecate `OrdinalApprox.lfpApprox` and `OrdinalApprox.gfpApprox`, which are simply specializations of these.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
tech debt
t-order
|
177/139 |
Mathlib/CategoryTheory/Abelian/GrothendieckCategory/EnoughInjectives.lean,Mathlib/CategoryTheory/ObjectProperty/LimitsClosure.lean,Mathlib/CategoryTheory/Presentable/SharplyLT/Basic.lean,Mathlib/Order/TransfiniteIteration.lean |
4 |
2 |
['YaelDillies', 'github-actions'] |
YaelDillies assignee:YaelDillies |
11-63904 11 days ago |
11-63904 11 days ago |
54-1683 54 days |
0 |
| 45450 |
mcdoll author:mcdoll |
chore(NumberTheory): replace anonymous constructor by .mk in `ArithmeticFunction` |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-number-theory
tech debt
|
24/27 |
Mathlib/NumberTheory/ArithmeticFunction/Defs.lean,Mathlib/NumberTheory/ArithmeticFunction/LFunction.lean,Mathlib/NumberTheory/ArithmeticFunction/Misc.lean,Mathlib/NumberTheory/ArithmeticFunction/Moebius.lean,Mathlib/NumberTheory/ArithmeticFunction/VonMangoldt.lean,Mathlib/NumberTheory/ArithmeticFunction/Zeta.lean,Mathlib/NumberTheory/LSeries/Convolution.lean |
7 |
1 |
['github-actions'] |
nobody |
11-50447 11 days ago |
11-50495 11 days ago |
11-50422 11 days |
0 |
| 45451 |
Parcly-Taxel author:Parcly-Taxel |
chore: remove transparency `set_option`s in `SimpleGraph`, part 1 |
These should be less controversial changes from #45430. |
tech debt
t-combinatorics
|
14/33 |
Mathlib/Combinatorics/SimpleGraph/AdjMatrix.lean,Mathlib/Combinatorics/SimpleGraph/Clique.lean,Mathlib/Combinatorics/SimpleGraph/Connectivity/Finite.lean,Mathlib/Combinatorics/SimpleGraph/Connectivity/Subgraph.lean,Mathlib/Combinatorics/SimpleGraph/Ends/Defs.lean,Mathlib/Combinatorics/SimpleGraph/Finite.lean,Mathlib/Combinatorics/SimpleGraph/StronglyRegular.lean,Mathlib/Combinatorics/SimpleGraph/Subgraph.lean |
8 |
1 |
['github-actions'] |
nobody |
11-42284 11 days ago |
11-42381 11 days ago |
11-44777 11 days |
1 |
| 45392 |
vihdzp author:vihdzp |
chore: state Borel isomorphism theorem using `Uncountable` |
We also deprecate the specialization of it to `ℕ → Bool`, after proving the instance that allows to infer the uncountability of this type automatically.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-measure-probability
tech debt
|
53/25 |
Mathlib/Basic/Countable/Defs.lean,Mathlib/LinearAlgebra/Dimension/ErdosKaplansky.lean,Mathlib/MeasureTheory/Constructions/Polish/Basic.lean,Mathlib/MeasureTheory/Constructions/Polish/EmbeddingReal.lean,Mathlib/SetTheory/Cardinal/Basic.lean,Mathlib/SetTheory/Cardinal/Finite.lean |
6 |
1 |
['github-actions'] |
nobody |
11-27385 11 days ago |
11-27434 11 days ago |
11-30551 11 days |
0 |
| 45453 |
Parcly-Taxel author:Parcly-Taxel |
chore: remove transparency `set_option`s in `SimpleGraph`, part 2 |
More fixes from #45430.
* `ConnectedComponent.lift` now has `Reachable` in its hypotheses, which allows removing a `set_option`.
* There was a long-standing typo in the statement of `Walk.ofBoxProdRight_boxProdRight`, which has been corrected. Equational lemmas for `Walk.ofBoxProd{Left,Right}` have been added too.
* The golfed proof of `free_killCopies` was done by GPT-6.1 Sol, then hand-optimised. |
tech debt
t-combinatorics
LLM-generated
|
52/67 |
Mathlib/Combinatorics/SimpleGraph/Connectivity/Connected.lean,Mathlib/Combinatorics/SimpleGraph/Copy.lean,Mathlib/Combinatorics/SimpleGraph/Ends/Defs.lean,Mathlib/Combinatorics/SimpleGraph/LapMatrix.lean,Mathlib/Combinatorics/SimpleGraph/Prod.lean,Mathlib/Combinatorics/SimpleGraph/Subgraph.lean |
6 |
1 |
['github-actions'] |
nobody |
11-22149 11 days ago |
11-22251 11 days ago |
11-38646 11 days |
1 |
| 44363 |
Parcly-Taxel author:Parcly-Taxel |
chore: remove `set_option` in `Order.Nucleus` |
|
tech debt
t-order
|
7/15 |
Mathlib/Order/Nucleus.lean |
1 |
13 |
['Parcly-Taxel', 'github-actions', 'grunweg', 'mathlib-merge-conflicts', 'mathlib-splicebot'] |
nobody |
11-14501 11 days ago |
12-14309 12 days ago |
37-53673 37 days |
0 |
| 45528 |
joelriou author:joelriou |
chore(CategoryTheory/Limits): remove set_option for multiequalizers |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-category-theory
tech debt
|
36/80 |
Mathlib/CategoryTheory/Limits/Preserves/Shapes/Multiequalizer.lean,Mathlib/CategoryTheory/Limits/Shapes/Equalizers.lean,Mathlib/CategoryTheory/Limits/Shapes/Multiequalizer.lean,Mathlib/Order/CompleteLattice/MulticoequalizerDiagram.lean |
4 |
1 |
['github-actions'] |
nobody |
9-12137 9 days ago |
9-12198 9 days ago |
9-12126 9 days |
5 |
| 40644 |
j-loreaux author:j-loreaux |
refactor: use `LinearMap.IsWeak` for `WeakBilin` |
This introduces `WeakBilin.linearEquiv : WeakBilin B ≃ₗ[𝕜] E` as the canonical map between a space `E` and its type synonym `WeakBilin B`, for `B : E →ₗ[𝕜] F →ₗ[𝕜] 𝕜`. This serves to provides an abstraction barrier between these defeq types.
We then add `WeakBilin.pairing : WeakBilin B →ₗ[𝕜] F →ₗ[𝕜] 𝕜` as a copy of the bilinear map `B` where we exchange the domain via `LinearEquiv.arrowCongr`.
Finally, we provide an instance of `LinearMap.IsWeak (WeakBilin.pairing B)`. This allows us to remove abuse of definitional equality in the API for `WeakBilin`, and to deprecate most of the basic results in favor of their `LinearMap.IsWeak` variants.
The one result which we don't deprecate is `WeakBilin.continuous_of_continuous_eval`. This is because the specific version we can tag with `fun_prop`, but the more general version would not
be suitable as a `fun_prop` lemma because the linear map `B` inducing the topology would be a metavariable, and cannot be inferred from the type.
---
- [ ] depends on: #40489
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-analysis
t-topology
tech debt
|
220/118 |
Mathlib/Analysis/LocallyConvex/Polar.lean,Mathlib/Analysis/LocallyConvex/WeakDual.lean,Mathlib/Analysis/LocallyConvex/WeakSpace.lean,Mathlib/Analysis/Normed/Module/WeakDual.lean,Mathlib/MeasureTheory/Measure/FiniteMeasure.lean,Mathlib/Topology/Algebra/Module/Spaces/CharacterSpace.lean,Mathlib/Topology/Algebra/Module/Spaces/PointwiseConvergenceCLM.lean,Mathlib/Topology/Algebra/Module/Spaces/WeakBilin.lean,Mathlib/Topology/Algebra/Module/Spaces/WeakDual.lean |
9 |
4 |
['github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] |
mcdoll assignee:mcdoll |
7-59539 7 days ago |
10-24228 10 days ago |
10-24155 10 days |
0 |
| 42138 |
mitchell-horner author:mitchell-horner |
feat(Combinatorics/SimpleGraph): copies into `⊤` and containment in the complete graph |
Add copy constructors mirroring the existing `Copy.bot` API.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #43201
[](https://gitpod.io/from-referrer/)
|
t-combinatorics
tech debt
|
116/31 |
Mathlib/Combinatorics/SimpleGraph/Copy.lean,Mathlib/Combinatorics/SimpleGraph/Maps.lean,Mathlib/Combinatorics/SimpleGraph/Walk/Maps.lean |
3 |
29 |
['Ruben-VandeVelde', 'SnirBroshi', 'github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'mitchell-horner', 'vlad902'] |
jjdishere assignee:jjdishere |
7-50457 7 days ago |
44-39121 44 days ago |
86-2254 86 days |
0 |
| 44427 |
xroblot author:xroblot |
feat(Tactic/NormNum): norm_num extension for Squarefree |
Add a `norm_num` extension deciding `Squarefree n` for numerals `n` in `ℕ` and `ℤ`.
If `n` is not squarefree, the proof uses a witness `a > 1` with `a * a ∣ n`, found with `Nat.minSqFac`. If `n` is squarefree, the proof is a trial division of `n` by the odd numbers `k = 3, 5, 7, …`, keeping the invariant that every prime divisor of the cofactor is at least `k`.
This is adapted from the Mathlib 3 extension by Mario Carneiro (mathlib#11666), which was left commented out in `Mathlib.Data.Nat.Squarefree` during the port. This commented-out code is removed, and the corresponding tests are restored.
As for the `Nat.Prime` extension, the proof is a certificate rather than a kernel evaluation of `Nat.minSqFac` via `Nat.squarefree_iff_minSqFac`. The certificate is also faster to check, but, as for `Nat.Prime`, large numbers need a higher `maxRecDepth`.
**Note**. I have read and checked the ordinary Lean statements and their proofs, but I am not familiar with metaprogramming, so I cannot really vouch for the meta code itself, which was written with the help of an LLM. A review by someone who is comfortable with `norm_num` extensions would be very welcome.
Created with Claude Code 🤖
---
|
tech debt
t-meta
LLM-generated
|
198/205 |
Mathlib.lean,Mathlib/Data/Nat/Squarefree.lean,Mathlib/Tactic.lean,Mathlib/Tactic/NormNum/Squarefree.lean,MathlibTest/Tactic/NormNum/Ext.lean |
5 |
1 |
['github-actions'] |
nobody |
7-18486 7 days ago |
7-18539 7 days ago |
37-55244 37 days |
0 |
| 44584 |
CBirkbeck author:CBirkbeck |
chore(AlgebraicTopology/FundamentalGroupoid): deprecate `transReflReparamAux` in favor of `qRight` |
Deprecate `Path.Homotopy.transReflReparamAux` and its lemmas: the function is `fun t ↦ unitInterval.qRight (t, 0)`, which `trans_refl_reparam` and `transRefl` now use.
---
<!--redteam:v1 {"owner":"AI-DOOM-97fce5ac-e255-4515-b311-12ecf245ce72","findings":["RT-20261006-546cb9"],"patterns":["parallel-reparametrisation-helper"],"severity":"MAJOR"}-->
🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
t-algebraic-topology
tech debt
LLM-generated
|
10/12 |
Mathlib/AlgebraicTopology/FundamentalGroupoid/Basic.lean |
1 |
1 |
['github-actions', 'tb65536'] |
nobody |
7-5660 7 days ago |
9-82013 9 days ago |
9-84111 9 days |
0 |
| 43818 |
JovanGerb author:JovanGerb |
chore: clean up some `to_dual` debt |
This PR cleans up a bunch of uses of `to_dual existing`.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #43750
[](https://gitpod.io/from-referrer/)
|
tech debt |
43/186 |
Mathlib/CategoryTheory/Iso.lean,Mathlib/CategoryTheory/Limits/HasLimits.lean,Mathlib/CategoryTheory/Limits/IsLimit.lean,Mathlib/Order/ConditionallyCompletePartialOrder/Basic.lean,Mathlib/Order/GaloisConnection/Basic.lean,Mathlib/Order/Hom/Basic.lean,Mathlib/Order/Interval/Set/Disjoint.lean,Mathlib/Order/OrdContinuous.lean,Mathlib/Order/RelClasses.lean,Mathlib/Order/SuccPred/Archimedean.lean,Mathlib/Order/UpperLower/Basic.lean,Mathlib/Order/WithBot.lean,Mathlib/Topology/Order/Basic.lean,Mathlib/Topology/Order/Bornology.lean,Mathlib/Topology/Order/OrderClosed.lean |
15 |
5 |
['JovanGerb', 'github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] |
nobody |
6-82076 6 days ago |
6-82159 6 days ago |
34-85937 34 days |
0 |
| 38393 |
staroperator author:staroperator |
refactor(ModelTheory): add typeclasses for algebraic symbols |
`Language.ring` and `Language.presburger` share the same symbols `0`, `1` and `+` and have duplicated instances on `Term` and `realize` simp lemmas. This PR makes these symbols certain typeclasses (similar to [`Language.IsOrdered`](https://leanprover-community.github.io/mathlib4_docs/Mathlib/ModelTheory/Order.html#FirstOrder.Language.IsOrdered)) and removes the duplication.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-logic
tech debt
|
401/202 |
Mathlib.lean,Mathlib/ModelTheory/Algebra/Classes.lean,Mathlib/ModelTheory/Algebra/Field/IsAlgClosed.lean,Mathlib/ModelTheory/Algebra/Ring/Basic.lean,Mathlib/ModelTheory/Algebra/Ring/FreeCommRing.lean,Mathlib/ModelTheory/Arithmetic/Presburger/Basic.lean,Mathlib/ModelTheory/Arithmetic/Presburger/Definability.lean |
7 |
9 |
['fpvandoorn', 'github-actions', 'mathlib-merge-conflicts', 'staroperator'] |
fpvandoorn assignee:fpvandoorn |
6-38014 6 days ago |
6-38095 6 days ago |
43-30112 43 days |
1 |
| 44554 |
JovanGerb author:JovanGerb |
chore: adaptations for stronger `simpNF` - part 1 |
In some cases the `simpNF` linter does not warn when it should warn. Fixing this in `simpNF` surfaces many violations. This PR fixes many of those violations.
- `MvPolynomial.coeff_sub`, `MvPolynomial.coeff_neg` and `MvPolynomial.coeff_smul` have been deprecated, analogously to how `MvPolynomial.coeff_add` was deprecated in #41427. To make adaptations smoother, I added a lemma `AddMonoidAlgebra.coeff_sub_apply`.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
tech debt |
98/123 |
Mathlib/Algebra/Category/FGModuleCat/Basic.lean,Mathlib/Algebra/Category/ModuleCat/Basic.lean,Mathlib/Algebra/Category/ModuleCat/Semi.lean,Mathlib/Algebra/DirectSum/Basic.lean,Mathlib/Algebra/Group/Action/Equidecomp.lean,Mathlib/Algebra/Group/Action/Units.lean,Mathlib/Algebra/Lie/Cochain.lean,Mathlib/Algebra/Lie/Extension.lean,Mathlib/Algebra/MonoidAlgebra/Defs.lean,Mathlib/Algebra/MvPolynomial/Basic.lean,Mathlib/Algebra/MvPolynomial/CommRing.lean,Mathlib/Algebra/Ring/Subring/Defs.lean,Mathlib/Analysis/Normed/Lp/ProdLp.lean,Mathlib/Analysis/Real/Hyperreal.lean,Mathlib/CategoryTheory/Category/Cat.lean,Mathlib/CategoryTheory/Category/Preorder.lean,Mathlib/CategoryTheory/Monoidal/Cartesian/FunctorCategory.lean,Mathlib/CategoryTheory/Monoidal/End.lean,Mathlib/Data/Set/Basic.lean,Mathlib/FieldTheory/IntermediateField/Basic.lean,Mathlib/Order/Filter/FilterProduct.lean,Mathlib/Order/Hom/Basic.lean,Mathlib/Probability/Kernel/Basic.lean,Mathlib/Probability/Kernel/Integral.lean,Mathlib/RepresentationTheory/Coinvariants.lean,Mathlib/RingTheory/MvPolynomial/Groebner.lean,Mathlib/RingTheory/MvPolynomial/IrreducibleQuadratic.lean,Mathlib/RingTheory/MvPolynomial/MonomialOrder.lean,Mathlib/RingTheory/MvPowerSeries/Equiv.lean,Mathlib/RingTheory/Spectrum/Prime/ChevalleyComplexity.lean,Mathlib/SetTheory/Ordinal/Notation.lean,Mathlib/Topology/Algebra/Valued/WithVal.lean,Mathlib/Topology/ContinuousMap/ContinuousMapZero.lean,Mathlib/Topology/FiberBundle/Constructions.lean,Mathlib/Topology/LocallyFinsupp.lean,Mathlib/Topology/MetricSpace/Snowflaking.lean |
36 |
14 |
['JovanGerb', 'github-actions', 'leanprover-radar', 'mathlib-merge-conflicts', 'vihdzp'] |
nobody |
5-80808 5 days ago |
5-80938 5 days ago |
32-25669 32 days |
0 |
| 45607 |
JovanGerb author:JovanGerb |
chore(CategoryTheory/Limits/Shapes/Kernels): use `to_dual` |
This PR uses `to_dual` to generate `cokernel` from `kernel`, as well as the prerequisite material on preserving terminal objects and zero objects.
For now I've removed `colimit_ι_zero_cokernel_desc`, as its dual doesn't exist and it is not used. It was added in the port in #3638 with a porting note.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
tech debt |
195/678 |
Mathlib/AlgebraicGeometry/Limits.lean,Mathlib/CategoryTheory/Abelian/CommSq.lean,Mathlib/CategoryTheory/Abelian/SerreClass/MorphismProperty.lean,Mathlib/CategoryTheory/Limits/Preserves/Shapes/Kernels.lean,Mathlib/CategoryTheory/Limits/Preserves/Shapes/Terminal.lean,Mathlib/CategoryTheory/Limits/Preserves/Shapes/Zero.lean,Mathlib/CategoryTheory/Limits/Shapes/Kernels.lean,Mathlib/CategoryTheory/Limits/Shapes/Pullback/IsPullback/Kernels.lean |
8 |
2 |
['github-actions', 'jcommelin'] |
nobody |
5-25009 5 days ago |
5-78675 5 days ago |
5-80816 5 days |
0 |
| 44593 |
CBirkbeck author:CBirkbeck |
chore(Data/Vector/Zip): deprecate `List.Vector.zipWith` in favour of `List.Vector.map₂` |
Deprecate `List.Vector.zipWith`, a second definition of `List.Vector.map₂`, together with its lemmas, which are restated for `map₂`.
---
<!--redteam:v1 {"owner":"AI-DOOM-97fce5ac-e255-4515-b311-12ecf245ce72","findings":["RT-20261007-187ea0"],"patterns":["second-construction"],"severity":"MAJOR"}-->
🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
t-data
LLM-generated
tech debt
|
25/46 |
Mathlib/Data/Vector/Basic.lean,Mathlib/Data/Vector/Zip.lean |
2 |
2 |
['CBirkbeck', 'github-actions', 'tb65536'] |
nobody |
4-73803 4 days ago |
4-73864 4 days ago |
9-82186 9 days |
0 |
| 45670 |
user202729 author:user202729 |
chore(AlgebraicGeometry/EllipticCurve/Projective): remove `erw` in `Formula.lean` |
Reducing tech debt.
The main reason why `erw` was needed in this file instead of `rw` is the following.
- Background: Each point is represented by a function `P : Fin 3 → R`, and there's local notation `x` being `(0 : Fin 3)`, similar for `y` and `z`. So `P x` is the first coordinate of `P`. For a curve `W'` and a point `P`, `W'.dblXYZ P` is another point, its double i.e. `2 • P`.
- There are functions to compute various operations on elliptic curves, for example, `W.dblY P` computes the `Y`-coordinate of `2 • P`. Of course, this can be equivalently written as `W.dblXYZ P y`.
- The two forms `W.dblY P` and `W.dblXYZ P y` are not definitionally equal at the default transparency level. Depends on which lemma we want to apply, we need to convert the goal to use one form or the other.
---
Personally, I think it's a better idea to normalize on the `W.dblXYZ P y` form, and keep the `W.dblY P` form as strictly an implementation detail if needed. In this case, the `XYZ` suffix wouldn't be needed either, and the main definitions would be:
```
* `WeierstrassCurve.Projective.neg`: The negation `-P` of a point `P`.
* `WeierstrassCurve.Projective.dbl`: The double `2 • P` of a point `P`.
* `WeierstrassCurve.Projective.negDbl`: The negated double `-(2 • P)` of a point `P`.
```
etc. Thoughts? Note that `W.dbl P y` is only 1 character longer than `W.dblY P`.
Most lemmas that we want to apply are already stated in term of the point (except that many use `W.negY P` instead of `W.neg P y`, though currently `W.neg` doesn't exist).
Also, there are (very) long `rw` chains. ([#mathlib4 > Is long `rw` chain bad?](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Is.20long.20.60rw.60.20chain.20bad.3F/with/637217759)) Ideas?
Another idea: have a `array_index` tactic that evaluates `![a, b, c, d] 2` to `c` when the index is a known constant, for example. Currently there is `simp only [fin3_def_ext]` which obviously only works on length-3 arrays.
|
new-contributor
t-algebraic-geometry
tech debt
|
59/24 |
Mathlib/AlgebraicGeometry/EllipticCurve/Projective/Formula.lean |
1 |
2 |
['github-actions'] |
nobody |
4-765 4 days ago |
4-77367 4 days ago |
4-77294 4 days |
0 |
| 43232 |
Parcly-Taxel author:Parcly-Taxel |
refactor: `TrivSqZeroExt` extending `Prod` |
Define à la `Unitization` ([#mathlib4 > TrivSqZeroExt as a 2-field structure @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/TrivSqZeroExt.20as.20a.202-field.20structure/near/620183663))
```lean
structure TrivSqZeroExt (R : Type u) (M : Type v) extends R × M
```
This PR came out of investigating the source of the `DualQuaternion` slowdown in #43078. (`DualNumber R` is an abbrev for `TrivSqZeroExt R R`.)
`Topology.Instances.TrivSqZeroExt` and `Analysis.Normed.Algebra.TrivSqZeroExt` were filled in with significant help from GPT-6.1 Sol. |
t-algebra
tech debt
LLM-generated
label:t-algebra$ |
360/291 |
Mathlib/Algebra/DualNumber.lean,Mathlib/Algebra/DualQuaternion.lean,Mathlib/Algebra/TrivSqZeroExt/Basic.lean,Mathlib/Algebra/TrivSqZeroExt/Ideal.lean,Mathlib/Analysis/Normed/Algebra/TrivSqZeroExt.lean,Mathlib/LinearAlgebra/ExteriorAlgebra/Basic.lean,Mathlib/LinearAlgebra/Matrix/DualNumber.lean,Mathlib/LinearAlgebra/TensorAlgebra/Basic.lean,Mathlib/RingTheory/DualNumber.lean,Mathlib/Topology/Instances/TrivSqZeroExt.lean |
10 |
10 |
['Parcly-Taxel', 'github-actions', 'mathlib-merge-conflicts', 'plp127'] |
nobody |
3-47068 3 days ago |
3-47126 3 days ago |
12-65624 12 days |
0 |
| 45742 |
vihdzp author:vihdzp |
chore: recursor for `SignType` using the simp-normal forms |
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
Co-authored by @plp127
|
tech debt
t-data
|
39/10 |
Mathlib/Basic/Sign/Basic.lean,Mathlib/Basic/Sign/Defs.lean,Mathlib/Data/EReal/Inv.lean |
3 |
1 |
['github-actions'] |
nobody |
2-68989 2 days ago |
2-69048 2 days ago |
2-68975 2 days |
0 |
| 43038 |
plp127 author:plp127 |
feat: `Dyadic` is an ordered ring |
Prove `Dyadic` is a linearly ordered ring, providing instances for `LinearOrder`, `CommRing`, and `IsStrictOrderedRing`. Remove corresponding material from `Mathlib/Tactic/Inclusion/Extension/IntervalDyadicReal/Dyadic`. Follow-up to #45186.
---
[From CGT](https://github.com/vihdzp/combinatorial-games/blob/99a469a2e02fd9fab9a717efe27f7fc84b880bbb/CombinatorialGames/Mathlib/Dyadic.lean).
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-data
tech debt
|
112/23 |
Mathlib.lean,Mathlib/Data/Dyadic/Basic.lean,Mathlib/Tactic/Inclusion/Extension/IntervalDyadicReal/Dyadic.lean |
3 |
20 |
['ADedecker', 'eric-wieser', 'github-actions', 'mathlib-merge-conflicts', 'plp127', 'vihdzp'] |
joneugster assignee:joneugster |
2-67386 2 days ago |
2-67860 2 days ago |
41-47596 41 days |
2 |
| 36239 |
plp127 author:plp127 |
feat(FieldTheory/KrullTopology): define uniform group structure on galois group |
Endow the galois group of a field extension `Gal(L/K)` with the structure of a uniform group. Use this to prove some properties of the galois group earlier, for example, that the galois group is compact is immediate, and in more generality than the version proved in `FieldTheory/Galois/Profinite`. Deprecate some material which used to be used to define the krull topology, but is now unused since the krull topology comes out of the uniform structure.
---
- [x] depends on: #39759
- [x] depends on: #42152
- [x] depends on: #42154
- [x] depends on: #42141
- [x] depends on: #42117
- [x] depends on: #42163
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-algebra
tech debt
increases-technical-debt
label:t-algebra$ |
465/228 |
Mathlib/FieldTheory/AbsoluteGaloisGroup.lean,Mathlib/FieldTheory/Galois/Infinite.lean,Mathlib/FieldTheory/Galois/Profinite.lean,Mathlib/FieldTheory/KrullTopology.lean,Mathlib/NumberTheory/Cyclotomic/CyclotomicCharacter.lean |
5 |
47 |
['acmepjz', 'dagurtomas', 'github-actions', 'mathlib-bors', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'plp127', 'vihdzp'] |
nobody |
2-49553 2 days ago |
23-70739 23 days ago |
99-52275 99 days |
0 |
| 45762 |
Nicola9Falciola author:Nicola9Falciola |
chore(LinearAlgebra/Matrix/SpecialLinearGroup): remove `set_option backward.isDefEq` and clean up |
---
This PR removes `set_option backward.isDefEq.respectTransparency` and `set_option backward.isDefEq.respectTransparency.types` from 5 lemmas.
It adds a reusable theorem `Matrix.SpecialLinearGroup.eta_fin_two` to help removing one in a more clean way, this the analog of `Matrix.eta_fin_two`.
Moreover:
- `S_mul_S_eq` is now just `ext` + `simp` removing the ugly long `simp only` chain.
- `SL2_inv_expl` is one `simp` line.
- l.285 improve maintainability avoiding explicit `.ext` calls.
- l.691 the extra `rw` is merged with the one above.
- `T_mul_apply_one` is just the term as it does not need `simpa`
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-algebra
tech debt
label:t-algebra$ |
25/29 |
Mathlib/LinearAlgebra/Matrix/SpecialLinearGroup.lean |
1 |
1 |
['github-actions'] |
nobody |
2-8784 2 days ago |
2-8838 2 days ago |
2-8765 2 days |
0 |
| 44983 |
tb65536 author:tb65536 |
feat(Analysis/Normed/Unbundled/GelfandRadiusNorm): the Gelfand radius as an algebra norm |
This PR uses the Gelfand radius to construct an algebra norm. This is used in #42985 to construct extensions of absolute values.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #44973
|
t-analysis
tech debt
|
105/2 |
Mathlib.lean,Mathlib/Analysis/Matrix/GelfandRadius.lean,Mathlib/Analysis/Normed/Unbundled/GelfandRadiusNorm.lean,Mathlib/LinearAlgebra/Dimension/Finite.lean |
4 |
8 |
['github-actions', 'mathlib-dependent-issues', 'tb65536', 'themathqueen'] |
nobody |
2-8060 2 days ago |
2-8110 2 days ago |
17-26483 17 days |
1 |
| 45770 |
timbrigham author:timbrigham |
fix(Tactic/DeriveFintype): make deriving Fintype work again for enum types |
I have a project that makes use of the enum type, and recently upgraded from version 4.30 to 4.35.
That broke my project's compilation, due to the behavior ticket #44243 ([link](https://github.com/leanprover-community/mathlib4/issues/44243), reported by @marcopist). The fix was suggested by Paul Reichert in the Zulip thread [Fintype Derive broken](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Fintype.20Derive.20broken/with/613313718).
The fix handles how constructors are handled with no arguments The most notable of which is making sure that the argument type is properly cast
Fixes #44243
---
For the record, I used AI, strictly Claude, in the creation of this pull request, both finding the existing bug report as well as the remediation process.
I'm learning lean in the process, and my larger drive is finding ways of making AI generated code safer and more robust.
|
tech debt
t-meta
new-contributor
|
3/5 |
Mathlib/Tactic/DeriveFintype.lean,MathlibTest/DeriveFintype.lean |
2 |
2 |
['github-actions'] |
nobody |
1-82482 1 day ago |
1-82584 1 day ago |
1-82511 1 day |
0 |
| 43565 |
Parcly-Taxel author:Parcly-Taxel |
refactor(Archive/FriendshipGraphs): golf everything |
Also remove the file's `set_option`s and `@[expose]`. Like #43434, no deprecations are added since this is a leaf file in Archive. |
tech debt |
103/292 |
Archive/Wiedijk100Theorems/FriendshipGraphs.lean |
1 |
9 |
['Parcly-Taxel', 'SnirBroshi', 'github-actions', 'mathlib-merge-conflicts'] |
nobody |
1-72751 1 day ago |
1-72817 1 day ago |
62-34518 62 days |
0 |
| 43858 |
BoltonBailey author:BoltonBailey |
chore(Algebra/GroupWithZero/Units/Basic): rename three lemmas `'` -> `₀` |
These lemmas about `GroupWithZero` are analogous to unprimed lemmas about groups. This PR renames them to use the usual convention of naming such lemmas with an underscored zero.
- `div_left_inj'`
- `div_div_cancel_left'`
- `div_div_div_cancel_left'`
-----
This PR comes about as a result of using Claude to look for easy reductions to the docPrime linter.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
tech debt
LLM-generated
t-algebra
awaiting-requeue
label:t-algebra$ |
28/25 |
Mathlib/Algebra/Field/ModEq.lean,Mathlib/Algebra/GroupWithZero/Units/Basic.lean,Mathlib/Analysis/BoxIntegral/UnitPartition.lean,Mathlib/Analysis/Complex/UpperHalfPlane/Metric.lean,Mathlib/Analysis/Normed/Algebra/QuaternionExponential.lean,Mathlib/Analysis/SpecialFunctions/Log/Base.lean,Mathlib/Analysis/SpecialFunctions/Stirling.lean,Mathlib/Geometry/Euclidean/Angle/Bisector.lean,Mathlib/Geometry/Euclidean/Angle/Oriented/Affine.lean,Mathlib/NumberTheory/FLT/Basic.lean,Mathlib/NumberTheory/Height/NumberField.lean,Mathlib/NumberTheory/LSeries/HurwitzZetaEven.lean,Mathlib/NumberTheory/LSeries/ZMod.lean,Mathlib/NumberTheory/PythagoreanTriples.lean,Mathlib/Probability/Distributions/Gaussian/CharFun.lean,Mathlib/Probability/Distributions/Gaussian/HasGaussianLaw/Independence.lean,Mathlib/RingTheory/Invariant/Basic.lean,Mathlib/Topology/Instances/AddCircle/Real.lean,scripts/nolints_prime_decls.txt |
19 |
13 |
['BoltonBailey', 'felixpernegger', 'github-actions', 'grunweg', 'mathlib-bors', 'mathlib-merge-conflicts'] |
nobody |
1-21495 1 day ago |
1-21496 1 day ago |
48-54737 48 days |
0 |
| 45406 |
astrainfinita author:astrainfinita |
feat(Order/ConditionallyCompleteLattice/WithTop): `OrderSupSet` instances on `WithTop` |
Adds `OrderSupSet (WithTop α)` and `OrderInfSet (WithTop α)` instances (and their `WithBot` duals), and cleans up the API for `sSup` and `sInf` on `WithTop`.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
- [x] depends on: #45402 |
tech debt
t-order
|
145/144 |
Mathlib/Order/ConditionallyCompleteLattice/WithTop.lean |
1 |
13 |
['astrainfinita', 'github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'vihdzp'] |
nobody |
1-14576 1 day ago |
1-39636 1 day ago |
3-53891 3 days |
7 |
| 45810 |
user202729 author:user202729 |
chore: remove many `set_option quotPrecheck false` |
Delete almost all `set_option quotPrecheck false`. Fix errors by stop using generalized field notation (e.g. `Functor.obj`), or change the notations that use variables in the current file to `local notation`.
---
Advantage of enabling quotation precheck is that “Go to definition” works. (Though maybe we can have an intermediate: if the option is false, precheck as many things as possible. There's a risk of going to the wrong definition though)
To see what the symbols should resolve to, adding a `variable (i j k) in #check [the notation]` often works.
It might be nice to have some automatic tool to automatically rewrite an expression into normal notation, if one is confused how a generalized field notation works.
I learnt that `local notation` takes into account the variables in the current file. It would be a good idea for the error message to mention this option instead of just `set_option quotPrecheck false`.
It's odd that some field notation still work (`D.f`). Arguably if it's possible to make it work without making the notation definition more verbose, we should do that, but at the moment I don't know how yet.
The `.invApp` is the most confusing one: the thing before the dot is an instance-implicit parameter to the function. It's not clear why it's written the way it is instead of the shorter form (as printed by `#check`/written in the comment), but it's possible that it's to save instance synthesis time, so I leave it alone.
Perhaps it's a good idea to disallow `set_option quotPrecheck false` entirely, and maybe count `set_option quotPrecheck false in` as a tech debt.
Not sure if `notation3` (“Lean 3 style notation”) should be refactored to the new `notation`. On the other hand, it seems like `notation3` supports generalized field notation just fine so…?
There's at least one notation that use hole (https://github.com/leanprover-community/mathlib4/pull/45810/changes#diff-50fa68fd318fd7e616ab659edfdbea6253edaaa7cadb0d1214c1d739e737b592L121). As mentioned in https://github.com/leanprover-community/mathlib4/pull/45550, I _think_ this will make the delaborator fail, even though elaboration works as usual. (So someone will only notice by looking at the infoview.) |
tech debt
new-contributor
|
21/46 |
Mathlib/AlgebraicTopology/SimplicialObject/Basic.lean,Mathlib/Analysis/Matrix/LDL.lean,Mathlib/CategoryTheory/Monoidal/Closed/Basic.lean,Mathlib/CategoryTheory/Monoidal/Closed/Cartesian.lean,Mathlib/CategoryTheory/Shift/Basic.lean,Mathlib/FieldTheory/CardinalEmb.lean,Mathlib/FieldTheory/KummerExtension.lean,Mathlib/Geometry/RingedSpace/PresheafedSpace/Gluing.lean,Mathlib/LinearAlgebra/TensorProduct/Defs.lean,Mathlib/MeasureTheory/MeasurableSpace/Defs.lean,Mathlib/RepresentationTheory/Homological/Resolution.lean,Mathlib/RingTheory/DedekindDomain/SelmerGroup.lean,Mathlib/RingTheory/Norm/Transitivity.lean,Mathlib/RingTheory/Smooth/NoetherianDescent.lean,Mathlib/RingTheory/WittVector/Basic.lean,Mathlib/RingTheory/WittVector/StructurePolynomial.lean,Mathlib/RingTheory/WittVector/WittPolynomial.lean,Mathlib/Tactic/CategoryTheory/BicategoryCoherence.lean,Mathlib/Topology/UniformSpace/UniformConvergenceTopology.lean |
19 |
2 |
['github-actions'] |
nobody |
0-81943 22 hours ago |
0-81988 22 hours ago |
0-83340 23 hours |
0 |
| 44011 |
joelriou author:joelriou |
chore(Algebra/Homology/ShortComplex): remove `set_option` |
This PR removes all the `set_option` in the `Algebra/Homology/ShortComplex/` files.
This reverts part of #45589 which made too many things globally `implicit_reducible` in my opinion. Here, the idea is to maintain a certain API isolation for the definitions related to `homology` so that in the future it could be attempted to mark `left/right/homology`, `cycles` and `opcycles` as unexposed.
---
- [x] depends on: #43980
- [x] depends on: #43977
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
[](https://gitpod.io/from-referrer/)
|
t-category-theory
tech debt
|
260/473 |
Mathlib/Algebra/Homology/ShortComplex/Ab.lean,Mathlib/Algebra/Homology/ShortComplex/Abelian.lean,Mathlib/Algebra/Homology/ShortComplex/Basic.lean,Mathlib/Algebra/Homology/ShortComplex/ConcreteCategory.lean,Mathlib/Algebra/Homology/ShortComplex/Exact.lean,Mathlib/Algebra/Homology/ShortComplex/FunctorEquivalence.lean,Mathlib/Algebra/Homology/ShortComplex/HomologicalComplex.lean,Mathlib/Algebra/Homology/ShortComplex/Homology.lean,Mathlib/Algebra/Homology/ShortComplex/LeftHomology.lean,Mathlib/Algebra/Homology/ShortComplex/Limits.lean,Mathlib/Algebra/Homology/ShortComplex/Preadditive.lean,Mathlib/Algebra/Homology/ShortComplex/PreservesHomology.lean,Mathlib/Algebra/Homology/ShortComplex/QuasiIso.lean,Mathlib/Algebra/Homology/ShortComplex/RightHomology.lean,Mathlib/Algebra/Homology/ShortComplex/ShortExact.lean,Mathlib/Algebra/Homology/ShortComplex/SnakeLemma.lean,Mathlib/RepresentationTheory/Homological/GroupCohomology/LowDegree.lean,Mathlib/RepresentationTheory/Homological/GroupHomology/LowDegree.lean |
18 |
8 |
['github-actions', 'joelriou', 'leanprover-radar', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] |
nobody |
0-22539 6 hours ago |
0-22589 6 hours ago |
1-55349 1 day |
1 |
| 45709 |
YaelDillies author:YaelDillies |
chore(Algebra/Order): make `Nonneg` a one-field structure |
The goal is to eventually make `NNRat` and `NNReal` `abbrev`s for `Nonneg Rat` and `Nonneg Real`, and deduplicate their API. This is currently not possible due to prohibitive slowdowns when making their definition in terms of `Subtype` visible to automation.
Generated by Claude Sonnet in many rounds of review by myself.
Assisted-by: Claude Sonnet 5.5
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-algebra
tech debt
t-order
large-import
LLM-generated
label:t-algebra$ |
650/253 |
Mathlib.lean,Mathlib/Algebra/Order/Nonneg/Basic.lean,Mathlib/Algebra/Order/Nonneg/Defs.lean,Mathlib/Algebra/Order/Nonneg/Field.lean,Mathlib/Algebra/Order/Nonneg/Floor.lean,Mathlib/Algebra/Order/Nonneg/Interval.lean,Mathlib/Algebra/Order/Nonneg/Lattice.lean,Mathlib/Algebra/Order/Nonneg/Order.lean,Mathlib/Algebra/Order/Nonneg/Ring.lean,Mathlib/Analysis/CStarAlgebra/Basic.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Isometric.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Order.lean,Mathlib/Analysis/CStarAlgebra/Hom.lean,Mathlib/Analysis/CStarAlgebra/Matrix.lean,Mathlib/Analysis/CStarAlgebra/Multiplier.lean,Mathlib/Analysis/CStarAlgebra/Unitization.lean,Mathlib/Analysis/Complex/Basic.lean,Mathlib/Analysis/Complex/Norm.lean,Mathlib/Analysis/Complex/OperatorNorm.lean,Mathlib/Analysis/Complex/UpperHalfPlane/Measure.lean,Mathlib/Analysis/ConstantSpeed.lean,Mathlib/Analysis/Convex/Segment.lean,Mathlib/Analysis/Convex/SpecificFunctions/Pow.lean,Mathlib/Analysis/InnerProductSpace/Basic.lean,Mathlib/Analysis/Matrix/Normed.lean,Mathlib/Analysis/MeanInequalities.lean,Mathlib/Analysis/Normed/Algebra/Spectrum.lean,Mathlib/Analysis/Normed/Algebra/UnitizationL1.lean,Mathlib/Analysis/Normed/Field/Basic.lean,Mathlib/Analysis/Normed/Group/Constructions.lean,Mathlib/Analysis/Normed/Group/Continuity.lean,Mathlib/Analysis/Normed/Group/Uniform.lean,Mathlib/Analysis/Normed/Module/Basic.lean,Mathlib/Analysis/Normed/Operator/Mul.lean,Mathlib/Analysis/Normed/Operator/NNNorm.lean,Mathlib/Analysis/Normed/Operator/NormedSpace.lean,Mathlib/Analysis/Normed/Operator/Prod.lean,Mathlib/Analysis/Quaternion.lean,Mathlib/Basic/NNReal/Basic.lean,Mathlib/Basic/NNReal/Defs.lean,Mathlib/Data/NNRat/Defs.lean,Mathlib/Data/Rat/Cast/Lemmas.lean,Mathlib/Data/Rat/Init.lean,Mathlib/FieldTheory/IntermediateField/Basic.lean,Mathlib/Geometry/Convex/Cone/Pointed.lean,Mathlib/MeasureTheory/Constructions/BorelSpace/Basic.lean,Mathlib/MeasureTheory/Function/ConditionalExpectation/Real.lean,Mathlib/MeasureTheory/Function/SimpleFuncDenseLp.lean,Mathlib/MeasureTheory/Function/SpecialFunctions/Basic.lean,Mathlib/MeasureTheory/Function/UniformIntegrable.lean,Mathlib/MeasureTheory/Integral/SetToL1/L1.lean,Mathlib/MeasureTheory/MeasurableSpace/Constructions.lean,Mathlib/NumberTheory/Modular.lean,Mathlib/NumberTheory/NumberField/CanonicalEmbedding/Basic.lean,Mathlib/RingTheory/RootsOfUnity/Complex.lean,Mathlib/RingTheory/Valuation/ValuationSubring.lean,Mathlib/Topology/Algebra/Field.lean,Mathlib/Topology/Algebra/Order/Module.lean,Mathlib/Topology/Algebra/Ring/Real.lean,Mathlib/Topology/Bornology/Real.lean,Mathlib/Topology/ContinuousMap/Bounded/Basic.lean,Mathlib/Topology/ContinuousMap/Bounded/Normed.lean,Mathlib/Topology/Instances/NNReal/Lemmas.lean,Mathlib/Topology/Instances/Rat.lean,Mathlib/Topology/MetricSpace/Basic.lean,Mathlib/Topology/MetricSpace/ProperSpace/Real.lean,Mathlib/Topology/MetricSpace/Pseudo/Constructions.lean,Mathlib/Topology/MetricSpace/Thickening.lean,Mathlib/Topology/Order/Nonneg.lean,Mathlib/Topology/UniformSpace/Real.lean |
70 |
3 |
['github-actions', 'mathlib-merge-conflicts'] |
nobody |
0-17148 4 hours ago |
0-17239 4 hours ago |
3-43477 3 days |
0 |
| 45806 |
vihdzp author:vihdzp |
chore(GroupTheory/Coxeter/Basic): clean up `set_option` |
We make `CoxeterSystem.Group` into an `abbrev`, so the `PresentedGroup` API can be used directly for it.
---
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
Mathematically speaking, I'd say Coxeter groups *are* presented groups, so making this transparent seems reasonable to me. |
tech debt
t-group-theory
maintainer-merge
|
28/42 |
Mathlib/GroupTheory/Coxeter/Basic.lean |
1 |
3 |
['github-actions', 'grunweg'] |
nobody |
0-16599 4 hours ago |
1-5284 1 day ago |
1-6110 1 day |
2 |
| 45822 |
Parcly-Taxel author:Parcly-Taxel |
refactor: really make `SetSemiring` a one-field structure |
Step 0 in [#mathlib4 > The new `Language` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/The.20new.20.60Language.60/near/638463014). I also add `Membership/Singleton/Insert` instances for `SetSemiring`. |
t-algebra
tech debt
label:t-algebra$ |
56/44 |
Mathlib/Algebra/Algebra/Operations.lean,Mathlib/Data/Set/Semiring.lean |
2 |
9 |
['Parcly-Taxel', 'eric-wieser', 'github-actions'] |
nobody |
0-16536 4 hours ago |
0-16581 4 hours ago |
0-21261 5 hours |
0 |
| 45242 |
Nicola9Falciola author:Nicola9Falciola |
chore(LinearAlgebra/Matrix/SpecialLinearGroup): add missing api |
---
This PR adds missing API for `SpecialLinearGroup`.
- For `coe_mk_mul_mk` both `simp` and ` rw [coe_mul, coe_mk, coe_mk]` fail.
- For `coe_inv_mk` both `simp` and ` rw [coe_inv, coe_mk]` fail.
- For `map_mk_apply` `simp` fails.
Without this API is dealing with matrix literals in `SL` is quite annoying.
<!-- Your PR title will become the first line of the commit message.
In this box, the text above the `---` (if not empty) will be appended
to the commit message, and can be used to give additional context or
details. Please leave a blank newline before the `---`, otherwise GitHub
will format the text above it as a title.
For details on the "pull request lifecycle" in mathlib, please see:
https://leanprover-community.github.io/contribute/index.html
In particular, note that most reviewers will only notice your PR
if it passes the continuous integration checks.
Please ask for help on https://leanprover.zulipchat.com if needed.
When merging, all the commits will be squashed into a single commit
listing all co-authors.
Co-authors in the squash commit are gathered from two sources:
First, all authors of commits to this PR branch are included. Thus,
one way to add co-authors is to include at least one commit authored by
each co-author among the commits in the pull request. If necessary, you
may create empty commits to indicate co-authorship, using commands like so:
git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor"
Second, co-authors can also be listed in lines at the very bottom of
the commit message (that is, directly before the `---`) using the following format:
Co-authored-by: Author Name <author@email.com>
If you are moving or deleting declarations, please include these lines
at the bottom of the commit message (before the `---`, and also before
any "Co-authored-by" lines) using the following format:
Moves:
- Vector.* -> List.Vector.*
- ...
Deletions:
- Nat.bit1_add_bit1
- ...
Any other comments you want to keep out of the PR commit should go
below the `---`, and placed outside this HTML comment, or else they
will be invisible to reviewers.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
|
t-algebra
tech debt
label:t-algebra$ |
46/41 |
Mathlib/LinearAlgebra/Matrix/GeneralLinearGroup/Projective.lean,Mathlib/LinearAlgebra/Matrix/SpecialLinearGroup.lean |
2 |
16 |
['Nicola9Falciola', 'github-actions', 'mathlib-merge-conflicts', 'themathqueen'] |
nobody |
0-6118 1 hour ago |
0-6225 1 hour ago |
14-52266 14 days |
0 |
This page collects anonymous visit counts for usage reporting (no cookies, no IP addresses stored). See the Mathlib Initiative privacy policy.