Zulip Chat Archive

Stream: PR reviews

Topic: Lemmas to handle part_enat.card, #19198


Antoine Chambert-Loir (Jun 17 2023 at 12:13):

In PR #19198, I prove a bunch of lemmas analogous to those existing for nat.card that allow to work with docs#part_enat.card

Antoine Chambert-Loir (Jun 20 2023 at 17:28):

I wrote the companion PR !4#5307 for mathlib4.

(Lint complains there are lines with “by” only; they were created by mathport, how should I format them?)

Floris van Doorn (Jun 20 2023 at 17:29):

put by at the end of the previous line.

Scott Morrison (Jun 20 2023 at 22:28):

(sometimes this requires also breaking the previous line, and then you need to remember the "type signature gets indented by 4 spaces" rules.)

Yury G. Kudryashov (Jul 10 2023 at 14:41):

@Antoine Chambert-Loir You forgot to update SHA sums, so these files are still on the #outofsync list. Could you please create a new PR that updates SHA sums and mention the old PR in the description?

Antoine Chambert-Loir (Jul 10 2023 at 15:21):

I don't know how to do that! If you give me (even approximate) instructions, I'll do it.

Yury G. Kudryashov (Jul 10 2023 at 15:40):

You open a PR, then go over the list of files touched by your old PR and replace the SHA sum in the header (line 7) with the one found at https://leanprover-community.github.io/mathlib-port-status/file/data/nat/part_enat (and similarly for other files). Most probably, you'll need 3ff3f2d6a3118b8711063de7111a0d77a53219a8 in all your files.

Antoine Chambert-Loir (Jul 10 2023 at 18:34):

Done : #5799


Last updated: Dec 20 2023 at 11:08 UTC