Zulip Chat Archive
Stream: triage
Topic: PR !4#1470: feat: `attach` and `filter` lemmas
Random Issue Bot (Sep 14 2023 at 14:03):
Today I chose PR 1470 for discussion!
feat: attach
and filter
lemmas
Created by @Yaël Dillies (@YaelDillies) on 2023-01-10
Labels: awaiting-author, mathlib3-pair, forward-port-placeholder
Is this PR still relevant? Any recent updates? Anyone making progress?
Yaël Dillies (Sep 14 2023 at 14:34):
Still waiting on !3#18087
Kevin Buzzard (Sep 14 2023 at 15:38):
Explain again why we are ever waiting for mathlib3 for anything now?
Ruben Van de Velde (Sep 14 2023 at 15:49):
So Yaël doesn't need to port the code by hand (if ever a mathlib3 reviewer stands up)
Yaël Dillies (Sep 14 2023 at 15:58):
I mean, it's not even like it's unreviewed. It's been LGTM for a month and a half.
Johan Commelin (Sep 14 2023 at 16:11):
cc @Eric Wieser
Patrick Massot (Sep 14 2023 at 16:15):
What about forgetting about Lean 3 and moving on?
Johan Commelin (Sep 14 2023 at 16:18):
Ooh, in cases like this I can imagine that it's nice to have help from mathport automation.
Eric Wieser (Sep 14 2023 at 16:27):
#outofsync is still pretty long, I think review time is better spent there than on mathlib3 PRs
Yaël Dillies (Sep 14 2023 at 17:39):
Johan is exactly right. I've been oneshotting my self-contained PRs and branches, but the ones that span several files are a pain to do by hand.
Last updated: Dec 20 2023 at 11:08 UTC