Zulip Chat Archive

Stream: mathlib4

Topic: permission to review PR with "approve" state


Jz Pan (Feb 06 2025 at 02:40):

I'd like to ask if some special permission is required to review a mathlib PR with "approve" state? Usually I only review with "comment" state. In this page https://leanprover-community.github.io/contribute/pr-review.html it's said that in order to use maintainer XXX command, you need to be a mathlib reviewer. But it does not mention if the permission is required to give "approve" state.

BTW, Is it possible to apply for a mathlib reviewer?

Yaël Dillies (Feb 06 2025 at 05:07):

No, anyone can approve a PR. I don't think anyone ever applied to become a reviewer, but I am sure the maintainers would be happy to see your interest in the role.

Kyle Miller (Feb 06 2025 at 06:03):

Maintainers welcome quality reviews and approvals from everyone!


Last updated: May 02 2025 at 03:31 UTC