Maintainers page: short tasks

Are you a maintainer with just a short amount of time? The following kinds of pull requests could be relevant for you.

If you realise you actually have a bit more time, you can also look at the page for reviewers, or look at the triage page!
This dashboard was last updated on: November 22, 2026 at 13:21 UTC

Stale ready-to-merge'd PRs

There are currently no stale PRs labelled auto-merge-after-CI or ready-to-merge. Congratulations!

Stale maintainer-merge'd PRs

Number Author Title Description Labels +/- Modified files (first 100) 📝 💬 All users who commented or reviewed Assignee(s) Updated Last status change total time in review blocks
40204 Jun2M
author:Jun2M
feat(Combinatorics/HypergraphLike): add HypergraphLike class Introduces `HypergraphLike V I E G`, an object-indexed incidence interface for developing common graph theory across different representations. Defines links and adjacency, incidence maps and fibers, and sets of incident vertices and edges. The basic API provides membership characterizations, fiber disjointness and union identities, and relationships between incidence data, links, and adjacency. Codex assisted with the initial implementation and review; the code was subsequently revised by me. The following is a longer write-up about what this PR is for, what this PR has, and why it is in this shape. ## Considerations 1. The main consideration for this PR is to create a common language different graph types can use to communicate their structure. The data in the type class is deliberately chosen to be as general as possible, accommodating hypergraphs, digraphs, simple graphs, and more. 2. (Hyper)Graphs are used both as a setting in which vertices, edges, walks, and colorings live, and as an algebraic object that can be modified. These two viewpoints can sometimes be at odds with each other. This typeclass is an acknowledgement that these two viewpoints are different, and both need to be fully supported separately with explicit connection. `HypergraphLike` is the way to view a graph as a setting. Various different graph structures are ways to view a graph as an algebraic object. 3. Graph theory has a lot of uses outside of graph theory. For example, group theory, topology, and more. The type class is designed to be easily applied to an arbitrary object that can be associated with a graph structure. ## Contents The definition consists of: | Data | Meaning | | --- | --- | | `V`, `I`, `E` | Ambient types of vertex, incidence, and edge labels | | `V(G)`, `I(G)`, `E(G)` | The set of objects of the (hyper)graph structure | | `attach'`, `edgeMap'` | The vertex and edge assigned to each incidence | | `IsSource`, `IsTarget` | The directions in which an incidence can be traversed | Every incidence is a source, a target, or both. This allows directed and undirected incidences in the same object. Distinct incidences may belong to the same vertex and edge. `HypergraphLike` does not require the object to be a graph or hypergraph, or to be related to one. Any object can be associated with a (hyper)graph structure and use the graph theory API as such via a `HypergraphLike` instance. As a result, it is possible for an arbitrary object to be associated with a graph structure that it has nothing to do with. - **`Link G e u v`:** a traversal of `e` from `u` to `v`, retaining a source incidence and a distinct target incidence. Distinctness prevents entering and leaving an undirected edge through the same incidence. - **`IsLink` and `Adj`:** the existence of a link through a specified edge, and the existence of an edge linking two vertices. - **`attach` and `edgeMap`:** total extensions of the incidence maps when the corresponding types are nonempty. - **`edgeFiber` and `vertexFiber`:** the incidences belonging to an edge or vertex. - **`incVerts` and `incEdges`:** the vertices incident to an edge and the edges incident to a vertex. Apart from operations, graph API should be built on this type class. More specialized theories can add assumptions such as undirectedness, looplessness, or restrictions on the incidences of each edge. See PRs #43768, #43748 and more to come. ## Design decisions ### Why not require one concrete representation? Alternative approach to unify various graph structures is to have one very general hypergraph definition and put all possible API there. By extending the definition with other conditions, you can inherit all the API while describing the graph class you want. This is not used here because 1. It either loses the expected extensionality or restricts which representations can use the API. 2. The API can be inherited using the current instance method more generally (you don't need to `extend` the particular def to inherit them) 3. These two approaches have virtually no difference in formalization cost. Asterisk for number 3 is that I have not tried to formalize every part of graph theory so it should be taken with a grain of salt. Nevertheless, I have not found cases where `extend` method reduces the formalization cost significantly. The generality of application is the strong suit of the current approach. The discussion that led to this PR started with efforts to unify different graph structures in Mathlib and future structures to be implemented. The instance method allows even more flexibility. We could talk about a group (with a chosen generating set) being `HypergraphLike` by associating it with a Cayley graph, a CW complex with its 1-skeleton graph, or a lattice with its Hasse graph, in the same manner `SimpleGraph` is `HypergraphLike`. With `extend`, these will require a separate, bespoke association with the appropriate graph structure. So, it suffices to argue that number 1 is true. The difficulty comes from the fact that the child structures have to contain additional data and therefore additional freedom that it really doesn't need. Consider two simple graphs `G` and `H`, each with vertex set `{u, v}` and single edge between them. In the naive approach where you define `SimpleGraph` like this: ```lean structure SimpleGraph (ν ι ε : Type*) extends undirected ν ι ε, noMultiEdges ν ι ε ... where ``` Then, `G = H` may not hold. They could have different edge type, incidence type, edge set, incidence set, etc. That is, we have extensionality issue. The fix is to constrain further until simple graph structure uniquely determines the rest. Here is one possible definition: ```lean structure SimpleGraph (ν : Type*) extends undirected ν (ν × ν) (Sym2 ν), noMultiEdges ν (ν × ν) (Sym2 ν) ... where edgeMap'_eq (i) : edgeMap' i = Sym2.mk i.val.fst i.val.snd attach'_eq (i) : attach' i = i.val.fst ``` Now, any `multigraph` that happens to be a simple graph cannot use `SimpleGraph` results without going through the normalization function, showing that normalization only changed the labels and showing that the normalization function preserves whatever properties, etc. Results that depend on simplicity should be available for arbitrary incidence representations satisfying simplicity, rather than only for a canonical `SimpleGraph` representation. This happens every time a canonical form is chosen to resolve extensionality issues. ### Why per-object indexing? Indexing by graph type was something I have adopted from `HasAdj` PR (#35776) without critical thinking. In the discussion for `Quiver` (#45034), as soon as I wrote "HypergraphLike expects you to know the edge type before you know what graph you are working with.", I started to think why this is necessary. It is not. All the code I have about HypergraphLike can be migrated to per-object indexing very easily. The statements did get longer due to adding `HypergraphLike` instance to each graph object but virtually all proofs worked without any changes. Philosophically, it makes the role of `HypergraphLike` clearer. `HypergraphLike` is defined to have one common language between different graph structures and that common language is the label types and incidence data. Merely belonging to the same Lean type should not impose additional uniformity. Where a result needs shared labels or compatible incidence maps, it can state those requirements explicitly. In the cases of `Quiver`, it can be supported by `HypergraphLike` as now we supply the edge type along with the specific `Quiver` instance, not before. Another benefit is that you can use `HypergraphLike` even when not all elements of a type can be interpreted as a graph. This aligns with the rest of the type class hierarchy being built on `HypergraphLike`. (#43768, #43748) `G : Graph V E` could happen to be a simple graph. A subset of a plane could be graph-like. ### Why ambient labels and support sets? The `id` function holds a special place in our heads. Consider `G`, K4 graph with vertex set `{1, 2, 3, 4}`, and `H`, K5 graph with vertex set `{1, 2, 3, 4, 5}`. Remove edge `s(1, 2)` from `H`. Up to isomorphism, `G` is still a subgraph of `H`. But, with respect to the `id` function, `G` is no longer a subgraph of `H`. Without support sets, the vertex set is the whole type, so graphs on different vertex sets live on different types. Then only embeddings can be stated, and you lose the labelled subgraph relation. That is, without some special treatment for subtypes, `HypergraphLike` will say `G` is a subgraph of `H` as there exists embedding of `G` into `H`. Support sets in the type class are exactly the mechanism that allows "special treatment" for subtypes. ## Related work (Not dependency) - #36743 - [HasAdj discussion](https://leanprover.zulipchat.com/#narrow/channel/252551-graph-theory/topic/HasAdj/with/575843445) Co-authored-by: OpenAI Codex <codex@openai.com> --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-combinatorics LLM-generated maintainer-merge 458/0 Mathlib.lean,Mathlib/Combinatorics/HypergraphLike/Basic.lean 2 59 ['Jun2M', 'SnirBroshi', 'YaelDillies', 'copilot-pull-request-reviewer', 'github-actions', 'tb65536'] nobody
28-83530
28 days ago
29-38889
29 days ago
141-3278
141 days
10
45029 YaelDillies
author:YaelDillies
feat(Util): support `noWS` in `notation3` ... and use it to define the conditional probability notation `μ[|s]`. Generated by Claude Opus, reviewed line-by-line by myself. Zulip discussion: [#mathlib reviewers > status of &#96;notation3&#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954) Assisted-by: Claude Opus 5.5 --- - [ ] awaiting-Zulip: [#mathlib reviewers > status of &#96;notation3&#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954) <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> LLM-generated maintainer-merge t-meta awaiting-zulip 40/34 Mathlib/Probability/ConditionalProbability.lean,Mathlib/Util/Notation3.lean,MathlibTest/Util/Notation3.lean 3 19 ['JovanGerb', 'Vierkantor', 'YaelDillies', 'eric-wieser', 'github-actions', 'grunweg'] Vierkantor
assignee:Vierkantor
27-18089
27 days ago
28-84560
28 days ago
4-43933
4 days
0
45602 vihdzp
author:vihdzp
feat: `ClosedIicTopology` on partial order is T0 We can't guarantee T1, take e.g. the Sierpinski topology. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-topology t-order maintainer-merge 10/40 Mathlib/Topology/Order/LowerUpperTopology.lean,Mathlib/Topology/Order/OrderClosed.lean,Mathlib/Topology/Order/ScottTopology.lean 3 4 ['github-actions', 'leanprover-radar', 'themathqueen', 'vihdzp'] nobody
3-63469
3 days ago
19-40052
19 days ago
19-40176
19 days
0
46041 j-loreaux
author:j-loreaux
feat: `ContinuousFunctionalCalculus` instance for `Unitization 𝕜 A` Given a non-unital `𝕜`-algebra (`𝕜 := ℝ` or `𝕜 := ℂ`) with a non-unital continuous functional calculus instance, this adds a continuous functional calculus instance for `Unitization 𝕜 A`. For technical reasons, we can't do this as an *instance* for `RCLike 𝕜`, but must do `ℝ` and `ℂ` individually. --- - [x] depends on: #46036 - [x] depends on: #46037 - [x] depends on: #46038 - [x] depends on: #46039 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> maintainer-merge t-analysis 148/0 Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Instances.lean 1 15 ['github-actions', 'j-loreaux', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'themathqueen'] nobody
2-70436
2 days ago
3-68010
3 days ago
3-68574
3 days
1
40644 j-loreaux
author:j-loreaux
refactor: use `LinearMap.IsWeak` for `WeakBilin` This introduces `WeakBilin.linearEquiv : WeakBilin B ≃ₗ[𝕜] E` as the canonical map between a space `E` and its type synonym `WeakBilin B`, for `B : E →ₗ[𝕜] F →ₗ[𝕜] 𝕜`. This serves to provides an abstraction barrier between these defeq types. We then add `WeakBilin.pairing : WeakBilin B →ₗ[𝕜] F →ₗ[𝕜] 𝕜` as a copy of the bilinear map `B` where we exchange the domain via `LinearEquiv.arrowCongr`. Finally, we provide an instance of `LinearMap.IsWeak (WeakBilin.pairing B)`. This allows us to remove abuse of definitional equality in the API for `WeakBilin`, and to deprecate most of the basic results in favor of their `LinearMap.IsWeak` variants. The one result which we don't deprecate is `WeakBilin.continuous_of_continuous_eval`. This is because the specific version we can tag with `fun_prop`, but the more general version would not be suitable as a `fun_prop` lemma because the linear map `B` inducing the topology would be a metavariable, and cannot be inferred from the type. --- - [ ] depends on: #40489 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-analysis t-topology tech debt maintainer-merge 220/118 Mathlib/Analysis/LocallyConvex/Polar.lean,Mathlib/Analysis/LocallyConvex/WeakDual.lean,Mathlib/Analysis/LocallyConvex/WeakSpace.lean,Mathlib/Analysis/Normed/Module/WeakDual.lean,Mathlib/MeasureTheory/Measure/FiniteMeasure.lean,Mathlib/Topology/Algebra/Module/Spaces/CharacterSpace.lean,Mathlib/Topology/Algebra/Module/Spaces/PointwiseConvergenceCLM.lean,Mathlib/Topology/Algebra/Module/Spaces/WeakBilin.lean,Mathlib/Topology/Algebra/Module/Spaces/WeakDual.lean 9 6 ['github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'mcdoll'] mcdoll
assignee:mcdoll
2-48742
2 days ago
23-19136
23 days ago
23-19124
23 days
0
41472 BryceT233
author:BryceT233
feat(Algebra/TotalMonoidAlgebra): add ring structures and canonical equivalences This PR is part of the broader plan on [reworking Finsupp, MonoidAlgebra, HahnSeries. PowerSeries](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Reworking.20Finsupp.2C.20MonoidAlgebra.2C.20HahnSeries.2E.20PowerSeries/with/608547586). We extend the algebraic hierarchy for `TotalMonoidAlgebra` with commutative semiring and ring structures. We also add some canonical maps and equivalences such as `R⟦M × N⟧ ≃+* R⟦N⟧⟦M⟧` --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) - [x] depends on: #41521 - [x] depends on: #44654 - [x] depends on: #44655 - [x] depends on: #44656 - [x] depends on: #44814 - [x] depends on: #45570 t-algebra maintainer-merge
label:t-algebra$
258/1 Mathlib/Algebra/TotalMonoidAlgebra/Defs.lean 1 22 ['BryceT233', 'YaelDillies', 'github-actions', 'mathlib-bors', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'themathqueen'] nobody
2-11684
2 days ago
10-45457
10 days ago
49-8974
49 days
0
45324 joelriou
author:joelriou
feat(AlgebraicTopology): the model structure on Under categories This is dual to the existing construction for `Over` categories --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-category-theory maintainer-merge 118/3 Mathlib/AlgebraicTopology/ModelCategory/Over.lean,Mathlib/CategoryTheory/LiftingProperties/Over.lean,Mathlib/CategoryTheory/Limits/Over.lean,Mathlib/CategoryTheory/MorphismProperty/Comma.lean 4 3 ['FernandoChu', 'github-actions', 'mathlib-merge-conflicts', 'robin-carlier'] robin-carlier
assignee:robin-carlier
2-5679
2 days ago
11-66091
11 days ago
26-69633
26 days
0
45413 joelriou
author:joelriou
feat(CategoryTheory/Abelian): monoidal abelian categories with functorial flat resolutions If `A` is a monoidal category, we introduce a property of objects `ObjectProperty.Monoidal.flat : ObjectProperty A` which is satisfied by objects `X : A` such that both functors `tensorLeft X : A ⥤ A` and `tensorRight X : A ⥤ A` are exact (i.e. preserve both finite limits and finite colimits). Moreover, if `A` is an abelian category, we introduce a typeclass `Abelian.HasFunctorialFlatResolution A` which says that objects in `A` admit a functorial epimorphism from a flat object. --- - [x] depends on: #45418 - [x] depends on: #45417 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-category-theory maintainer-merge 116/4 Mathlib.lean,Mathlib/CategoryTheory/Abelian/Flat/Basic.lean,Mathlib/CategoryTheory/Limits/ExactFunctor.lean,Mathlib/CategoryTheory/ObjectProperty/Retract.lean 4 9 ['github-actions', 'joelriou', 'mathlib-dependent-issues', 'robin-carlier'] robin-carlier
assignee:robin-carlier
2-4281
2 days ago
2-4282
2 days ago
22-64269
22 days
0
45571 JovanGerb
author:JovanGerb
feat(ClickSuggestions): better pasting logic This PR makes `#click_suggestions` insert its suggestions in the correct place, even if the cursor is not in the place where the tactic should go. In particular, if the cursor is placed after a tactic, or at the start of a tactic, then the position of the insertion is made to align with that tactic syntax, instead of using the cursor position. What is more difficult is to determine the appropriate indentation level after a loose `by`. So, the user still needs to manually add the newline after a `by` before using `#click_suggestions`. This might be improved in a future PR. This PR adds a test file that tests the insertion behaviour. In addition to testing the new behaviour, we also tests some other behaviours that weren't previously tested. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-meta maintainer-merge 411/49 Mathlib/Tactic/ClickSuggestions.lean,Mathlib/Tactic/ClickSuggestions/Util.lean,MathlibTest/ClickSuggestions/Insertion.lean,MathlibTest/ClickSuggestions/TestImpl.lean 4 5 ['github-actions', 'joneugster'] joneugster
assignee:joneugster
1-83515
1 day ago
20-41672
20 days ago
20-41659
20 days
0
45529 joelriou
author:joelriou
feat(CategoryTheory/MorphismProperty): images of pushouts by functors If `P : MorphismProperty C` and `F : C ⥤ D` is a functor which preserves pushouts, we show `P.pushouts.map F ≤ (P.map F).pushouts`. Similar results are obtained for other shapes. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-category-theory maintainer-merge 123/2 Mathlib/CategoryTheory/MorphismProperty/Limits.lean,Mathlib/CategoryTheory/MorphismProperty/TransfiniteComposition.lean 2 4 ['github-actions', 'joelriou', 'robin-carlier'] robin-carlier
assignee:robin-carlier
1-80029
1 day ago
2-4209
2 days ago
22-4095
22 days
3
45667 amellendijk
author:amellendijk
fix(Tactic): improve metadata handling in a dozen tactics This PR fixes a dozen tactics that don't properly strip metadata or type annotations when walking through an expression. The main culprit is `Expr.getAppFnArgs`, which expects the user to have stripped the outermost metadata annotations. This is usually done using one of `Expr.consumeMData`, `Expr.cleanupAnnotations` or `whnf` ``` example (n m : ℕ := 3) (h : n < m) : n ≤ m := by linarith example : 0 ≤ x ^ (ofNat(nat_lit 2) : ℕ) := by positivity ``` --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> I found and fixed these bugs using Claude Fable 5.2, after I ran into a bug in `basify`. t-meta LLM-generated maintainer-merge awaiting-author 143/14 Mathlib/Tactic/Abel.lean,Mathlib/Tactic/ApplyFun.lean,Mathlib/Tactic/Basify.lean,Mathlib/Tactic/CancelDenoms/Core.lean,Mathlib/Tactic/CasesM.lean,Mathlib/Tactic/ComputeDegree.lean,Mathlib/Tactic/FinCases.lean,Mathlib/Tactic/Linarith/NNRealPreprocessor.lean,Mathlib/Tactic/Linarith/Preprocessing.lean,Mathlib/Tactic/MoveAdd.lean,Mathlib/Tactic/Positivity/Basic.lean,Mathlib/Tactic/ReduceModChar.lean,MathlibTest/Tactic/Basify.lean,MathlibTest/Tactic/MData.lean 14 11 ['adomani', 'amellendijk', 'bryangingechen', 'github-actions', 'grunweg', 'joneugster', 'leanprover-radar'] joneugster
assignee:joneugster
1-79956
1 day ago
2-5083
2 days ago
10-30480
10 days
0
44773 justus-springer
author:justus-springer
doc(*): add bib entries for free-text references The result of an LLM-assisted audit to find free-text references with no entry in `references.bib`. Most bib entries come from zbmath (those have a `zbl` entry). A few didn't have an entry there, so they come from other sources. Some small notes: - I added the other authors to `boldetal2017`, - In `LinearAlgebra/Matrix/Polynomial.lean`, my LLM flagged that Section 5.3 is probably not the appropriate section to cite for this file, and in fact, it seems to be a historical artifact. I checked the paper and Proposition 2.2 fits much better here, so I changed it. - Wittlich's Master thesis is not available online, but the docstring came from a trustworthy source so I just used the details given there for the bib entry. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> LLM-generated documentation maintainer-merge 246/31 Mathlib/Analysis/CStarAlgebra/Module/Defs.lean,Mathlib/Analysis/InnerProductSpace/Defs.lean,Mathlib/Analysis/InnerProductSpace/Projection/Basic.lean,Mathlib/CategoryTheory/Adjunction/Lifting/Left.lean,Mathlib/CategoryTheory/Adjunction/Lifting/Right.lean,Mathlib/Combinatorics/Additive/AP/Three/Behrend.lean,Mathlib/Combinatorics/Additive/CauchyDavenport.lean,Mathlib/Combinatorics/Compactness.lean,Mathlib/Computability/AkraBazzi/AkraBazzi.lean,Mathlib/Computability/AkraBazzi/SumTransform.lean,Mathlib/Geometry/Euclidean/Angle/Oriented/Basic.lean,Mathlib/InformationTheory/Coding/Kraft.lean,Mathlib/InformationTheory/Coding/KraftMcMillan.lean,Mathlib/LinearAlgebra/Matrix/Adjugate.lean,Mathlib/LinearAlgebra/Matrix/Polynomial.lean,Mathlib/MeasureTheory/Measure/Haar/Basic.lean,Mathlib/Probability/Independence/Basic.lean,Mathlib/Topology/Algebra/InfiniteSum/Defs.lean,Mathlib/Topology/Category/Compactum.lean,docs/references.bib 20 16 ['Vierkantor', 'github-actions', 'grunweg', 'joneugster', 'justus-springer', 'mathlib-merge-conflicts'] nobody
1-76573
1 day ago
1-86053
1 day ago
33-12769
33 days
0
46249 Vierkantor
author:Vierkantor
chore(Algebra/Algebra): deduplicate `AlgHom.coe_mks` and `AlgHom.mk_coe` This PR removes the duplication between two `AlgHom` lemmas that are nearly the same: the only difference is `mk_coe` started out with an `AlgHom` and `coe_mks` started out with a plain function. But since we can generalize the condition for free in `mk_coe`, we can easily merge the two lemmas. Idem for `BialgHom`, `CoalgHom` and `GradedAlgHom`. I decided to keep `mk_coe` since its name makes more sense according to the naming conventions. Noticed while reviewing #45954. --- I'd like to bench this before merging in case the extra generality makes `simp` slower (I do not expect so since everything still is keyed on a whole pile of constructors). <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-algebra t-ring-theory maintainer-merge
label:t-algebra$
20/30 Mathlib/Algebra/Algebra/Hom.lean,Mathlib/RingTheory/Bialgebra/Hom.lean,Mathlib/RingTheory/Coalgebra/Hom.lean,Mathlib/RingTheory/GradedAlgebra/AlgHom.lean,Mathlib/RingTheory/Localization/Basic.lean 5 8 ['Vierkantor', 'github-actions', 'leanprover-radar', 'mathlib-merge-conflicts', 'themathqueen'] nobody
1-72148
1 day ago
2-9272
2 days ago
2-40132
2 days
0
46306 mcdoll
author:mcdoll
chore(RingTheory/Coalgebra): fix a definition As per #31365 definitions should not take classes, but the concrete object. We fix this for `Repr.induced`. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-ring-theory maintainer-merge 1/3 Mathlib/RingTheory/Coalgebra/Hom.lean 1 3 ['github-actions', 'themathqueen'] nobody
1-30567
1 day ago
1-31877
1 day ago
1-31864
1 day
0
46218 urkud
author:urkud
feat(Topology/MetricSpace/Bounded): add `Metric.ediam_closedBall_le` Add `Metric.ediam_closedBall_le : ediam (closedBall x r) ≤ 2 * ENNReal.ofReal r`, the `closedBall` analogue of `Metric.ediam_closedEBall_le`. Upstreamed from the https://github.com/urkud/SardMoreira project. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) t-topology easy maintainer-merge 15/0 Mathlib/Topology/MetricSpace/Bounded.lean,Mathlib/Topology/MetricSpace/Pseudo/Defs.lean 2 3 ['github-actions', 'themathqueen'] nobody
1-29419
1 day ago
2-33251
2 days ago
2-59668
2 days
2

All maintainer merge'd PRs

Number Author Title Description Labels +/- Modified files (first 100) 📝 💬 All users who commented or reviewed Assignee(s) Updated Last status change total time in review blocks
40204 Jun2M
author:Jun2M
feat(Combinatorics/HypergraphLike): add HypergraphLike class Introduces `HypergraphLike V I E G`, an object-indexed incidence interface for developing common graph theory across different representations. Defines links and adjacency, incidence maps and fibers, and sets of incident vertices and edges. The basic API provides membership characterizations, fiber disjointness and union identities, and relationships between incidence data, links, and adjacency. Codex assisted with the initial implementation and review; the code was subsequently revised by me. The following is a longer write-up about what this PR is for, what this PR has, and why it is in this shape. ## Considerations 1. The main consideration for this PR is to create a common language different graph types can use to communicate their structure. The data in the type class is deliberately chosen to be as general as possible, accommodating hypergraphs, digraphs, simple graphs, and more. 2. (Hyper)Graphs are used both as a setting in which vertices, edges, walks, and colorings live, and as an algebraic object that can be modified. These two viewpoints can sometimes be at odds with each other. This typeclass is an acknowledgement that these two viewpoints are different, and both need to be fully supported separately with explicit connection. `HypergraphLike` is the way to view a graph as a setting. Various different graph structures are ways to view a graph as an algebraic object. 3. Graph theory has a lot of uses outside of graph theory. For example, group theory, topology, and more. The type class is designed to be easily applied to an arbitrary object that can be associated with a graph structure. ## Contents The definition consists of: | Data | Meaning | | --- | --- | | `V`, `I`, `E` | Ambient types of vertex, incidence, and edge labels | | `V(G)`, `I(G)`, `E(G)` | The set of objects of the (hyper)graph structure | | `attach'`, `edgeMap'` | The vertex and edge assigned to each incidence | | `IsSource`, `IsTarget` | The directions in which an incidence can be traversed | Every incidence is a source, a target, or both. This allows directed and undirected incidences in the same object. Distinct incidences may belong to the same vertex and edge. `HypergraphLike` does not require the object to be a graph or hypergraph, or to be related to one. Any object can be associated with a (hyper)graph structure and use the graph theory API as such via a `HypergraphLike` instance. As a result, it is possible for an arbitrary object to be associated with a graph structure that it has nothing to do with. - **`Link G e u v`:** a traversal of `e` from `u` to `v`, retaining a source incidence and a distinct target incidence. Distinctness prevents entering and leaving an undirected edge through the same incidence. - **`IsLink` and `Adj`:** the existence of a link through a specified edge, and the existence of an edge linking two vertices. - **`attach` and `edgeMap`:** total extensions of the incidence maps when the corresponding types are nonempty. - **`edgeFiber` and `vertexFiber`:** the incidences belonging to an edge or vertex. - **`incVerts` and `incEdges`:** the vertices incident to an edge and the edges incident to a vertex. Apart from operations, graph API should be built on this type class. More specialized theories can add assumptions such as undirectedness, looplessness, or restrictions on the incidences of each edge. See PRs #43768, #43748 and more to come. ## Design decisions ### Why not require one concrete representation? Alternative approach to unify various graph structures is to have one very general hypergraph definition and put all possible API there. By extending the definition with other conditions, you can inherit all the API while describing the graph class you want. This is not used here because 1. It either loses the expected extensionality or restricts which representations can use the API. 2. The API can be inherited using the current instance method more generally (you don't need to `extend` the particular def to inherit them) 3. These two approaches have virtually no difference in formalization cost. Asterisk for number 3 is that I have not tried to formalize every part of graph theory so it should be taken with a grain of salt. Nevertheless, I have not found cases where `extend` method reduces the formalization cost significantly. The generality of application is the strong suit of the current approach. The discussion that led to this PR started with efforts to unify different graph structures in Mathlib and future structures to be implemented. The instance method allows even more flexibility. We could talk about a group (with a chosen generating set) being `HypergraphLike` by associating it with a Cayley graph, a CW complex with its 1-skeleton graph, or a lattice with its Hasse graph, in the same manner `SimpleGraph` is `HypergraphLike`. With `extend`, these will require a separate, bespoke association with the appropriate graph structure. So, it suffices to argue that number 1 is true. The difficulty comes from the fact that the child structures have to contain additional data and therefore additional freedom that it really doesn't need. Consider two simple graphs `G` and `H`, each with vertex set `{u, v}` and single edge between them. In the naive approach where you define `SimpleGraph` like this: ```lean structure SimpleGraph (ν ι ε : Type*) extends undirected ν ι ε, noMultiEdges ν ι ε ... where ``` Then, `G = H` may not hold. They could have different edge type, incidence type, edge set, incidence set, etc. That is, we have extensionality issue. The fix is to constrain further until simple graph structure uniquely determines the rest. Here is one possible definition: ```lean structure SimpleGraph (ν : Type*) extends undirected ν (ν × ν) (Sym2 ν), noMultiEdges ν (ν × ν) (Sym2 ν) ... where edgeMap'_eq (i) : edgeMap' i = Sym2.mk i.val.fst i.val.snd attach'_eq (i) : attach' i = i.val.fst ``` Now, any `multigraph` that happens to be a simple graph cannot use `SimpleGraph` results without going through the normalization function, showing that normalization only changed the labels and showing that the normalization function preserves whatever properties, etc. Results that depend on simplicity should be available for arbitrary incidence representations satisfying simplicity, rather than only for a canonical `SimpleGraph` representation. This happens every time a canonical form is chosen to resolve extensionality issues. ### Why per-object indexing? Indexing by graph type was something I have adopted from `HasAdj` PR (#35776) without critical thinking. In the discussion for `Quiver` (#45034), as soon as I wrote "HypergraphLike expects you to know the edge type before you know what graph you are working with.", I started to think why this is necessary. It is not. All the code I have about HypergraphLike can be migrated to per-object indexing very easily. The statements did get longer due to adding `HypergraphLike` instance to each graph object but virtually all proofs worked without any changes. Philosophically, it makes the role of `HypergraphLike` clearer. `HypergraphLike` is defined to have one common language between different graph structures and that common language is the label types and incidence data. Merely belonging to the same Lean type should not impose additional uniformity. Where a result needs shared labels or compatible incidence maps, it can state those requirements explicitly. In the cases of `Quiver`, it can be supported by `HypergraphLike` as now we supply the edge type along with the specific `Quiver` instance, not before. Another benefit is that you can use `HypergraphLike` even when not all elements of a type can be interpreted as a graph. This aligns with the rest of the type class hierarchy being built on `HypergraphLike`. (#43768, #43748) `G : Graph V E` could happen to be a simple graph. A subset of a plane could be graph-like. ### Why ambient labels and support sets? The `id` function holds a special place in our heads. Consider `G`, K4 graph with vertex set `{1, 2, 3, 4}`, and `H`, K5 graph with vertex set `{1, 2, 3, 4, 5}`. Remove edge `s(1, 2)` from `H`. Up to isomorphism, `G` is still a subgraph of `H`. But, with respect to the `id` function, `G` is no longer a subgraph of `H`. Without support sets, the vertex set is the whole type, so graphs on different vertex sets live on different types. Then only embeddings can be stated, and you lose the labelled subgraph relation. That is, without some special treatment for subtypes, `HypergraphLike` will say `G` is a subgraph of `H` as there exists embedding of `G` into `H`. Support sets in the type class are exactly the mechanism that allows "special treatment" for subtypes. ## Related work (Not dependency) - #36743 - [HasAdj discussion](https://leanprover.zulipchat.com/#narrow/channel/252551-graph-theory/topic/HasAdj/with/575843445) Co-authored-by: OpenAI Codex <codex@openai.com> --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-combinatorics LLM-generated maintainer-merge 458/0 Mathlib.lean,Mathlib/Combinatorics/HypergraphLike/Basic.lean 2 59 ['Jun2M', 'SnirBroshi', 'YaelDillies', 'copilot-pull-request-reviewer', 'github-actions', 'tb65536'] nobody
28-83530
28 days ago
29-38889
29 days ago
141-3278
141 days
10
45029 YaelDillies
author:YaelDillies
feat(Util): support `noWS` in `notation3` ... and use it to define the conditional probability notation `μ[|s]`. Generated by Claude Opus, reviewed line-by-line by myself. Zulip discussion: [#mathlib reviewers > status of &#96;notation3&#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954) Assisted-by: Claude Opus 5.5 --- - [ ] awaiting-Zulip: [#mathlib reviewers > status of &#96;notation3&#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954) <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> LLM-generated maintainer-merge t-meta awaiting-zulip 40/34 Mathlib/Probability/ConditionalProbability.lean,Mathlib/Util/Notation3.lean,MathlibTest/Util/Notation3.lean 3 19 ['JovanGerb', 'Vierkantor', 'YaelDillies', 'eric-wieser', 'github-actions', 'grunweg'] Vierkantor
assignee:Vierkantor
27-18089
27 days ago
28-84560
28 days ago
4-43933
4 days
0
45602 vihdzp
author:vihdzp
feat: `ClosedIicTopology` on partial order is T0 We can't guarantee T1, take e.g. the Sierpinski topology. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-topology t-order maintainer-merge 10/40 Mathlib/Topology/Order/LowerUpperTopology.lean,Mathlib/Topology/Order/OrderClosed.lean,Mathlib/Topology/Order/ScottTopology.lean 3 4 ['github-actions', 'leanprover-radar', 'themathqueen', 'vihdzp'] nobody
3-63469
3 days ago
19-40052
19 days ago
19-40176
19 days
0
46041 j-loreaux
author:j-loreaux
feat: `ContinuousFunctionalCalculus` instance for `Unitization 𝕜 A` Given a non-unital `𝕜`-algebra (`𝕜 := ℝ` or `𝕜 := ℂ`) with a non-unital continuous functional calculus instance, this adds a continuous functional calculus instance for `Unitization 𝕜 A`. For technical reasons, we can't do this as an *instance* for `RCLike 𝕜`, but must do `ℝ` and `ℂ` individually. --- - [x] depends on: #46036 - [x] depends on: #46037 - [x] depends on: #46038 - [x] depends on: #46039 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> maintainer-merge t-analysis 148/0 Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Instances.lean 1 15 ['github-actions', 'j-loreaux', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'themathqueen'] nobody
2-70436
2 days ago
3-68010
3 days ago
3-68574
3 days
1
40644 j-loreaux
author:j-loreaux
refactor: use `LinearMap.IsWeak` for `WeakBilin` This introduces `WeakBilin.linearEquiv : WeakBilin B ≃ₗ[𝕜] E` as the canonical map between a space `E` and its type synonym `WeakBilin B`, for `B : E →ₗ[𝕜] F →ₗ[𝕜] 𝕜`. This serves to provides an abstraction barrier between these defeq types. We then add `WeakBilin.pairing : WeakBilin B →ₗ[𝕜] F →ₗ[𝕜] 𝕜` as a copy of the bilinear map `B` where we exchange the domain via `LinearEquiv.arrowCongr`. Finally, we provide an instance of `LinearMap.IsWeak (WeakBilin.pairing B)`. This allows us to remove abuse of definitional equality in the API for `WeakBilin`, and to deprecate most of the basic results in favor of their `LinearMap.IsWeak` variants. The one result which we don't deprecate is `WeakBilin.continuous_of_continuous_eval`. This is because the specific version we can tag with `fun_prop`, but the more general version would not be suitable as a `fun_prop` lemma because the linear map `B` inducing the topology would be a metavariable, and cannot be inferred from the type. --- - [ ] depends on: #40489 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-analysis t-topology tech debt maintainer-merge 220/118 Mathlib/Analysis/LocallyConvex/Polar.lean,Mathlib/Analysis/LocallyConvex/WeakDual.lean,Mathlib/Analysis/LocallyConvex/WeakSpace.lean,Mathlib/Analysis/Normed/Module/WeakDual.lean,Mathlib/MeasureTheory/Measure/FiniteMeasure.lean,Mathlib/Topology/Algebra/Module/Spaces/CharacterSpace.lean,Mathlib/Topology/Algebra/Module/Spaces/PointwiseConvergenceCLM.lean,Mathlib/Topology/Algebra/Module/Spaces/WeakBilin.lean,Mathlib/Topology/Algebra/Module/Spaces/WeakDual.lean 9 6 ['github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'mcdoll'] mcdoll
assignee:mcdoll
2-48742
2 days ago
23-19136
23 days ago
23-19124
23 days
0
41472 BryceT233
author:BryceT233
feat(Algebra/TotalMonoidAlgebra): add ring structures and canonical equivalences This PR is part of the broader plan on [reworking Finsupp, MonoidAlgebra, HahnSeries. PowerSeries](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Reworking.20Finsupp.2C.20MonoidAlgebra.2C.20HahnSeries.2E.20PowerSeries/with/608547586). We extend the algebraic hierarchy for `TotalMonoidAlgebra` with commutative semiring and ring structures. We also add some canonical maps and equivalences such as `R⟦M × N⟧ ≃+* R⟦N⟧⟦M⟧` --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) - [x] depends on: #41521 - [x] depends on: #44654 - [x] depends on: #44655 - [x] depends on: #44656 - [x] depends on: #44814 - [x] depends on: #45570 t-algebra maintainer-merge
label:t-algebra$
258/1 Mathlib/Algebra/TotalMonoidAlgebra/Defs.lean 1 22 ['BryceT233', 'YaelDillies', 'github-actions', 'mathlib-bors', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'themathqueen'] nobody
2-11684
2 days ago
10-45457
10 days ago
49-8974
49 days
0
45324 joelriou
author:joelriou
feat(AlgebraicTopology): the model structure on Under categories This is dual to the existing construction for `Over` categories --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-category-theory maintainer-merge 118/3 Mathlib/AlgebraicTopology/ModelCategory/Over.lean,Mathlib/CategoryTheory/LiftingProperties/Over.lean,Mathlib/CategoryTheory/Limits/Over.lean,Mathlib/CategoryTheory/MorphismProperty/Comma.lean 4 3 ['FernandoChu', 'github-actions', 'mathlib-merge-conflicts', 'robin-carlier'] robin-carlier
assignee:robin-carlier
2-5679
2 days ago
11-66091
11 days ago
26-69633
26 days
0
45413 joelriou
author:joelriou
feat(CategoryTheory/Abelian): monoidal abelian categories with functorial flat resolutions If `A` is a monoidal category, we introduce a property of objects `ObjectProperty.Monoidal.flat : ObjectProperty A` which is satisfied by objects `X : A` such that both functors `tensorLeft X : A ⥤ A` and `tensorRight X : A ⥤ A` are exact (i.e. preserve both finite limits and finite colimits). Moreover, if `A` is an abelian category, we introduce a typeclass `Abelian.HasFunctorialFlatResolution A` which says that objects in `A` admit a functorial epimorphism from a flat object. --- - [x] depends on: #45418 - [x] depends on: #45417 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-category-theory maintainer-merge 116/4 Mathlib.lean,Mathlib/CategoryTheory/Abelian/Flat/Basic.lean,Mathlib/CategoryTheory/Limits/ExactFunctor.lean,Mathlib/CategoryTheory/ObjectProperty/Retract.lean 4 9 ['github-actions', 'joelriou', 'mathlib-dependent-issues', 'robin-carlier'] robin-carlier
assignee:robin-carlier
2-4281
2 days ago
2-4282
2 days ago
22-64269
22 days
0
45571 JovanGerb
author:JovanGerb
feat(ClickSuggestions): better pasting logic This PR makes `#click_suggestions` insert its suggestions in the correct place, even if the cursor is not in the place where the tactic should go. In particular, if the cursor is placed after a tactic, or at the start of a tactic, then the position of the insertion is made to align with that tactic syntax, instead of using the cursor position. What is more difficult is to determine the appropriate indentation level after a loose `by`. So, the user still needs to manually add the newline after a `by` before using `#click_suggestions`. This might be improved in a future PR. This PR adds a test file that tests the insertion behaviour. In addition to testing the new behaviour, we also tests some other behaviours that weren't previously tested. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-meta maintainer-merge 411/49 Mathlib/Tactic/ClickSuggestions.lean,Mathlib/Tactic/ClickSuggestions/Util.lean,MathlibTest/ClickSuggestions/Insertion.lean,MathlibTest/ClickSuggestions/TestImpl.lean 4 5 ['github-actions', 'joneugster'] joneugster
assignee:joneugster
1-83515
1 day ago
20-41672
20 days ago
20-41659
20 days
0
45529 joelriou
author:joelriou
feat(CategoryTheory/MorphismProperty): images of pushouts by functors If `P : MorphismProperty C` and `F : C ⥤ D` is a functor which preserves pushouts, we show `P.pushouts.map F ≤ (P.map F).pushouts`. Similar results are obtained for other shapes. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-category-theory maintainer-merge 123/2 Mathlib/CategoryTheory/MorphismProperty/Limits.lean,Mathlib/CategoryTheory/MorphismProperty/TransfiniteComposition.lean 2 4 ['github-actions', 'joelriou', 'robin-carlier'] robin-carlier
assignee:robin-carlier
1-80029
1 day ago
2-4209
2 days ago
22-4095
22 days
3
45667 amellendijk
author:amellendijk
fix(Tactic): improve metadata handling in a dozen tactics This PR fixes a dozen tactics that don't properly strip metadata or type annotations when walking through an expression. The main culprit is `Expr.getAppFnArgs`, which expects the user to have stripped the outermost metadata annotations. This is usually done using one of `Expr.consumeMData`, `Expr.cleanupAnnotations` or `whnf` ``` example (n m : ℕ := 3) (h : n < m) : n ≤ m := by linarith example : 0 ≤ x ^ (ofNat(nat_lit 2) : ℕ) := by positivity ``` --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> I found and fixed these bugs using Claude Fable 5.2, after I ran into a bug in `basify`. t-meta LLM-generated maintainer-merge awaiting-author 143/14 Mathlib/Tactic/Abel.lean,Mathlib/Tactic/ApplyFun.lean,Mathlib/Tactic/Basify.lean,Mathlib/Tactic/CancelDenoms/Core.lean,Mathlib/Tactic/CasesM.lean,Mathlib/Tactic/ComputeDegree.lean,Mathlib/Tactic/FinCases.lean,Mathlib/Tactic/Linarith/NNRealPreprocessor.lean,Mathlib/Tactic/Linarith/Preprocessing.lean,Mathlib/Tactic/MoveAdd.lean,Mathlib/Tactic/Positivity/Basic.lean,Mathlib/Tactic/ReduceModChar.lean,MathlibTest/Tactic/Basify.lean,MathlibTest/Tactic/MData.lean 14 11 ['adomani', 'amellendijk', 'bryangingechen', 'github-actions', 'grunweg', 'joneugster', 'leanprover-radar'] joneugster
assignee:joneugster
1-79956
1 day ago
2-5083
2 days ago
10-30480
10 days
0
44773 justus-springer
author:justus-springer
doc(*): add bib entries for free-text references The result of an LLM-assisted audit to find free-text references with no entry in `references.bib`. Most bib entries come from zbmath (those have a `zbl` entry). A few didn't have an entry there, so they come from other sources. Some small notes: - I added the other authors to `boldetal2017`, - In `LinearAlgebra/Matrix/Polynomial.lean`, my LLM flagged that Section 5.3 is probably not the appropriate section to cite for this file, and in fact, it seems to be a historical artifact. I checked the paper and Proposition 2.2 fits much better here, so I changed it. - Wittlich's Master thesis is not available online, but the docstring came from a trustworthy source so I just used the details given there for the bib entry. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> LLM-generated documentation maintainer-merge 246/31 Mathlib/Analysis/CStarAlgebra/Module/Defs.lean,Mathlib/Analysis/InnerProductSpace/Defs.lean,Mathlib/Analysis/InnerProductSpace/Projection/Basic.lean,Mathlib/CategoryTheory/Adjunction/Lifting/Left.lean,Mathlib/CategoryTheory/Adjunction/Lifting/Right.lean,Mathlib/Combinatorics/Additive/AP/Three/Behrend.lean,Mathlib/Combinatorics/Additive/CauchyDavenport.lean,Mathlib/Combinatorics/Compactness.lean,Mathlib/Computability/AkraBazzi/AkraBazzi.lean,Mathlib/Computability/AkraBazzi/SumTransform.lean,Mathlib/Geometry/Euclidean/Angle/Oriented/Basic.lean,Mathlib/InformationTheory/Coding/Kraft.lean,Mathlib/InformationTheory/Coding/KraftMcMillan.lean,Mathlib/LinearAlgebra/Matrix/Adjugate.lean,Mathlib/LinearAlgebra/Matrix/Polynomial.lean,Mathlib/MeasureTheory/Measure/Haar/Basic.lean,Mathlib/Probability/Independence/Basic.lean,Mathlib/Topology/Algebra/InfiniteSum/Defs.lean,Mathlib/Topology/Category/Compactum.lean,docs/references.bib 20 16 ['Vierkantor', 'github-actions', 'grunweg', 'joneugster', 'justus-springer', 'mathlib-merge-conflicts'] nobody
1-76573
1 day ago
1-86053
1 day ago
33-12769
33 days
0
46249 Vierkantor
author:Vierkantor
chore(Algebra/Algebra): deduplicate `AlgHom.coe_mks` and `AlgHom.mk_coe` This PR removes the duplication between two `AlgHom` lemmas that are nearly the same: the only difference is `mk_coe` started out with an `AlgHom` and `coe_mks` started out with a plain function. But since we can generalize the condition for free in `mk_coe`, we can easily merge the two lemmas. Idem for `BialgHom`, `CoalgHom` and `GradedAlgHom`. I decided to keep `mk_coe` since its name makes more sense according to the naming conventions. Noticed while reviewing #45954. --- I'd like to bench this before merging in case the extra generality makes `simp` slower (I do not expect so since everything still is keyed on a whole pile of constructors). <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-algebra t-ring-theory maintainer-merge
label:t-algebra$
20/30 Mathlib/Algebra/Algebra/Hom.lean,Mathlib/RingTheory/Bialgebra/Hom.lean,Mathlib/RingTheory/Coalgebra/Hom.lean,Mathlib/RingTheory/GradedAlgebra/AlgHom.lean,Mathlib/RingTheory/Localization/Basic.lean 5 8 ['Vierkantor', 'github-actions', 'leanprover-radar', 'mathlib-merge-conflicts', 'themathqueen'] nobody
1-72148
1 day ago
2-9272
2 days ago
2-40132
2 days
0
46306 mcdoll
author:mcdoll
chore(RingTheory/Coalgebra): fix a definition As per #31365 definitions should not take classes, but the concrete object. We fix this for `Repr.induced`. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-ring-theory maintainer-merge 1/3 Mathlib/RingTheory/Coalgebra/Hom.lean 1 3 ['github-actions', 'themathqueen'] nobody
1-30567
1 day ago
1-31877
1 day ago
1-31864
1 day
0
46218 urkud
author:urkud
feat(Topology/MetricSpace/Bounded): add `Metric.ediam_closedBall_le` Add `Metric.ediam_closedBall_le : ediam (closedBall x r) ≤ 2 * ENNReal.ofReal r`, the `closedBall` analogue of `Metric.ediam_closedEBall_le`. Upstreamed from the https://github.com/urkud/SardMoreira project. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) t-topology easy maintainer-merge 15/0 Mathlib/Topology/MetricSpace/Bounded.lean,Mathlib/Topology/MetricSpace/Pseudo/Defs.lean 2 3 ['github-actions', 'themathqueen'] nobody
1-29419
1 day ago
2-33251
2 days ago
2-59668
2 days
2
46234 xroblot
author:xroblot
feat(NumberTheory/NumberField/Basic): add `SMulCommClass G (𝓞 K) (𝓞 L)` instance This PR adds the instance `SMulCommClass G (𝓞 K) (𝓞 L)` for a group `G` acting on `L` and commuting with the action of `K`. :robot: This result is used in the proof of Stickelberger's theorem in #46022. It was extracted by Claude from the [SKW project](https://github.com/xroblot/SKW). t-ring-theory maintainer-merge 24/1 Mathlib/NumberTheory/NumberField/Basic.lean 1 15 ['github-actions', 'leanprover-radar', 'tb65536', 'xroblot'] nobody
0-85155
23 hours ago
1-84576
1 day ago
2-80788
2 days
1
46233 xroblot
author:xroblot
feat(FieldTheory/Galois): naturality of restrictHom and comparison with restrictNormalHom This PR shows that `IsGaloisGroup.restrictHom` is characterized by its compatibility with `algebraMap B C`, that it does not depend on the tower used to define it, and that, for fields, it is equal to `AlgEquiv.restrictNormalHom`. :robot: This result is used in the proof of Stickelberger's theorem in #46022. It was extracted by Claude from the [SKW project](https://github.com/xroblot/SKW). t-ring-theory t-algebra maintainer-merge
label:t-algebra$
34/0 Mathlib/FieldTheory/Galois/IsGaloisGroup.lean 1 2 ['github-actions', 'tb65536'] nobody
0-85081
23 hours ago
3-6115
3 days ago
3-7505
3 days
1
43924 xroblot
author:xroblot
feat(NumberTheory/NumberField): generalize isTotallyReal_sup Generalize `NumberField.isTotallyReal_sup` and `NumberField.isTotallyReal_iSup` so they no longer require the ambient field to be of characteristic zero and algebraic over `ℚ`: a compositum of totally real subfields of any field is totally real. :robot: This PR was extracted from the [SKW project](https://github.com/xroblot/SKW) by Claude. --- - [x] depends on: #43925 t-number-theory maintainer-merge 22/14 Mathlib/NumberTheory/NumberField/InfinitePlace/TotallyRealComplex.lean 1 7 ['MichaelStollBayreuth', 'github-actions', 'mathlib-dependent-issues', 'tb65536', 'xroblot'] MichaelStollBayreuth
assignee:MichaelStollBayreuth
0-84915
23 hours ago
5-6483
5 days ago
5-8172
5 days
0
46265 gasparattila
author:gasparattila
chore(Analysis/Complex): make `UpperHalfPlane.I` protected Since there is a coercion from `ℍ` to `ℂ`, writing `I` can mean `↑UpperHalfPlane.I` instead of the intended `Complex.I`. This mistake occurs in multiple lemmas, which are fixed in this PR (including those that explicitly use `UpperHalfPlane.I` instead of `Complex.I`). --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-number-theory t-analysis maintainer-merge 57/77 Mathlib/Analysis/Complex/UpperHalfPlane/Basic.lean,Mathlib/Analysis/Complex/UpperHalfPlane/FixedPoints.lean,Mathlib/Analysis/Complex/UpperHalfPlane/Manifold.lean,Mathlib/Analysis/Complex/UpperHalfPlane/MoebiusAction.lean,Mathlib/Analysis/Complex/UpperHalfPlane/ProperAction.lean,Mathlib/NumberTheory/Modular.lean,Mathlib/NumberTheory/ModularForms/Bounds.lean,Mathlib/NumberTheory/ModularForms/DedekindEta.lean,Mathlib/NumberTheory/ModularForms/Derivative.lean,Mathlib/NumberTheory/ModularForms/Discriminant.lean,Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Defs.lean,Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/MDifferentiable.lean,Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Summable.lean,Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Transform.lean,Mathlib/NumberTheory/ModularForms/EisensteinSeries/QExpansion.lean,Mathlib/NumberTheory/ModularForms/LFunction.lean,Mathlib/NumberTheory/ModularForms/LevelOne/Basic.lean,Mathlib/NumberTheory/ModularForms/LevelOne/DimensionFormula.lean,Mathlib/NumberTheory/ModularForms/NormTrace.lean,Mathlib/NumberTheory/ModularForms/QExpansion.lean,Mathlib/NumberTheory/ModularForms/RamanujanFormula.lean 21 4 ['gasparattila', 'github-actions', 'mathlib-merge-conflicts', 'themathqueen'] nobody
0-79184
21 hours ago
2-3108
2 days ago
2-46586
2 days
0
45861 grunweg
author:grunweg
chore: rename three lemmas involving the name some_eq_coe Reference the actual coercion being used. The ENNReal renames deserve a careful look. Found using the linter in #45229: among the cases of misnamed coercion lemmas using WithTop.some, these are some more interesting cases. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> tech debt t-order maintainer-merge 34/28 Mathlib/Algebra/Order/Monoid/Unbundled/WithTop.lean,Mathlib/Analysis/BoxIntegral/Partition/Additive.lean,Mathlib/Analysis/BoxIntegral/Partition/Basic.lean,Mathlib/Analysis/SpecialFunctions/Pow/NNReal.lean,Mathlib/Basic/ENNReal/Basic.lean,Mathlib/Data/List/MinMax.lean,Mathlib/Order/WithBot.lean,Mathlib/Tactic/Echelon/Reflection.lean,Mathlib/Tactic/Inclusion/Extension/Interval/Basic.lean,Mathlib/Topology/Algebra/Ring/Real.lean,scripts/nolints_prime_decls.txt 11 11 ['YaelDillies', 'github-actions', 'grunweg', 'themathqueen'] nobody
0-74441
20 hours ago
11-78692
11 days ago
11-78898
11 days
0
46316 mathlib-splicebot
author:mathlib-splicebot
feat(Algebra/Algebra/NonUnitalHom): add `NonUnitalAlgHom.toLinearMap` --- This PR was automatically created from PR #46266 by @EtienneC30 via a [review comment](https://github.com/leanprover-community/mathlib4/pull/46266#discussion_r4653490663) by @themathqueen. maintainer-merge t-algebra
label:t-algebra$
12/0 Mathlib/Algebra/Algebra/NonUnitalHom.lean 1 3 ['github-actions', 'themathqueen'] nobody
0-74019
20 hours ago
0-76937
21 hours ago
0-76924
21 hours
0
43965 YaelDillies
author:YaelDillies
feat(NumberTheory): `decide`, `#eval` and `norm_num` for Carmichael numbers Provide both an efficient decidability instance and a `norm_num` extension to decide whether a given literal is a Carmichael number. This lets us prove that 561 is the smallest Carmichael number "in a computationally efficient manner". Deprecate the version of Korselt's criterion that was supposed to be used for this (but was less efficient than these new instance/extension). Generated by Claude Opus in several rounds of review to optimise various parts of the algorithms and make sure that the decidability instance works for both `#eval` and `decide`. I haven't made much of an effort to clean the proofs (existing proofs internal to `norm_num` read like garbage to me anyway). From FormalConjectures Assisted-by: Claude Opus 5.1 --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-number-theory LLM-generated t-meta maintainer-merge 317/10 Mathlib/NumberTheory/CarmichaelNumber.lean,MathlibTest/NumberTheory/CarmichaelNumber.lean 2 39 ['Parcly-Taxel', 'SnirBroshi', 'Vierkantor', 'YaelDillies', 'github-actions', 'joneugster', 'leanprover-radar', 'mathlib-merge-conflicts', 'vihdzp', 'wwylele'] nobody
0-73977
20 hours ago
0-74360
20 hours ago
59-18527
59 days
1
45877 joelcanary
author:joelcanary
feat(NumberTheory/ArithmeticFunction/Moebius): `∑ n ≤ N, μ n * (N / n) = 1` This PR adds one lemma. It says that for `N ≠ 0` and for any ring `R`: ```lean ∑ n ∈ Ioc 0 N, (μ n : R) * (N / n : ℕ) = 1 ``` This is the same as `∑_{n ≤ N} μ(n)⌊N/n⌋ = 1`. The classical bound `|∑_{n ≤ N} μ(n)/n| ≤ 1` follows from this identity. PNT+ proves the identity again by hand inside `sum_mobius_div_self_le`; with this lemma, that part becomes one line. ------------ About the AI: I used an AI agent (Claude Code) to write the statement and the proof. I chose the target and I checked the result. t-number-theory LLM-generated new-contributor maintainer-merge 6/0 Mathlib/NumberTheory/ArithmeticFunction/Moebius.lean 1 10 ['GoldenPhysicsProject', 'MichaelStollBayreuth', 'github-actions', 'jcommelin', 'joelcanary'] MichaelStollBayreuth
assignee:MichaelStollBayreuth
0-73182
20 hours ago
5-15254
5 days ago
11-48387
11 days
0
45839 artie2000
author:artie2000
refactor(Topology/Algebra/Order): improve polynomial limit theorems * Improve statement of characterisation of polynomials with constant limit at infinity to be simpler and more usable * Prove that $$f(-X)=c$$ iff $$f(X)=c$$ --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-topology t-algebra t-order maintainer-merge
label:t-algebra$
46/13 Mathlib/Algebra/Polynomial/Degree/Lemmas.lean,Mathlib/Topology/Algebra/Order/Polynomial.lean 2 21 ['artie2000', 'github-actions', 'tb65536'] nobody
0-69897
19 hours ago
0-80704
22 hours ago
11-50840
11 days
0
46314 wrenna-robson
author:wrenna-robson
fix(GroupTheory/GroupAction/Hom): make `0 : A →+[M] A` the zero map, not the identity Since #34249, `to_additive` has translated `One (A →*[M] A)` (the identity map) to an instance `DistribMulActionHom.instZeroId : Zero (A →+[M] A)`, also the identity. This competes with the pointwise zero `DistriMulActionHom.instZero` on `A →ₑ+[φ] B`, and wins instance synthesis. (Note the lack of b!) As a result, on `master`: - `0 : A →+[M] A` is the identity map, and `One (A →+[M] A)` does not synthesise. - `DistribMulActionHom.coe_zero : ⇑(0 : A →+[M] A) = id` and `DistriMulActionHom.coe_zero : ⇑(0 : A →ₑ+[φ] B) = 0` are both `@[simp]`, and talk about different `0`s. This PR uses the approach of `Monoid.End`: 1. Add `to_additive_dont_translate` to `MulDistribMulActionHom`,. 2. Name the three generated declarations explicitly, as otherwise `to_additive` would still name them `instZeroId`, `coe_zero` and `zero_apply`. 3. Move the hand-written `DistriMulActionHom` instances and lemms to the `DistribMulActionHom` namespace (i.e. correct the typo). Note that `DistribMulActionHom.coe_zero` and `DistribMulActionHom.zero_apply` keep their names but change statement, from `⇑0 = id` and `0 a = a` to `⇑0 = 0` and `0 a = 0`. These are the statements they had before #34249, as are those of `coe_one` and `one_apply`. The old names cannot be deprecated, since they are reused - I feel this is fair dos as it's fixing a bug. The underlying issue: translating the identity map to `0` (and composition to `+`) is only safe when the raw type has no pointwise `+` or `0` of its own. `M ≃+ M` has none, so `AddAut` can do this; `A →+[M] A` does, so `DistribMulActionHom` needs `AddMonoid.End`'s convention instead. Unsure if there's a better way of ensuring this doesn't happen. --- ### Demonstration on `master` ```lean import Mathlib.GroupTheory.GroupAction.Hom variable {M A : Type*} [Monoid M] [AddMonoid A] [DistribMulAction M A] example (a : A) : (0 : A →+[M] A) a = 0 := by rw [DistriMulActionHom.zero_apply] -- error: Tactic `rewrite` failed: Did not find an occurrence of the pattern -- 0 ?a -- in the target expression -- 0 a = 0 theorem zero_ne_zero (a : A) (ha : a ≠ 0) : @OfNat.ofNat (A →+[M] A) (nat_lit 0) (@Zero.toOfNat0 _ DistriMulActionHom.instZero) ≠ 0 := fun h => ha (DFunLike.congr_fun h a).symm #check @zero_ne_zero -- @zero_ne_zero : ∀ {M A} … (a : A), a ≠ 0 → 0 ≠ 0 ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code) LLM-generated t-group-theory maintainer-merge 12/7 Mathlib/GroupTheory/GroupAction/Hom.lean 1 10 ['github-actions', 'themathqueen', 'wrenna-robson'] nobody
0-65597
18 hours ago
0-78357
21 hours ago
0-78344
21 hours
0
45215 riccardobrasca
author:riccardobrasca
feat: add IsCyclotomicExtension.Rat.seven_pid We now have enough technology to prove this in one declaration. From flt-regular. - [x] depends on: #44548 --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-number-theory maintainer-merge 67/31 Mathlib/NumberTheory/NumberField/ClassNumber.lean,Mathlib/NumberTheory/NumberField/Cyclotomic/PID.lean 2 42 ['DavidLedvinka', 'MichaelStollBayreuth', 'emlis42', 'github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'ocfnash', 'raoxiaojia', 'riccardobrasca', 'tb65536', 'xroblot'] MichaelStollBayreuth
assignee:MichaelStollBayreuth
0-63502
17 hours ago
0-63985
17 hours ago
4-62061
4 days
0
41975 fbarroero
author:fbarroero
feat(NumberTheory/NumberField/Ostrowski): prove nonarchimedean Ostrowski's theorem This PR proves the nonarchimedean case of Ostrowski’s theorem for number fields. The main declaration is ```lean theorem exists_heightOneSpectrum_equiv_adicAbv {f : AbsoluteValue K ℝ} (hf_nonarch : IsNonarchimedean f) (hf_nontriv : f.IsNontrivial) ∃! P : HeightOneSpectrum (𝓞 K), f ≈ adicAbv K P ``` --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> - [x] depends on: #40848 [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-number-theory maintainer-merge 215/0 Mathlib.lean,Mathlib/Algebra/Module/Submodule/Defs.lean,Mathlib/NumberTheory/NumberField/Ostrowski.lean,Mathlib/RingTheory/DedekindDomain/AdicValuation/Valuation.lean 4 20 ['MichaelStollBayreuth', 'fbarroero', 'github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] MichaelStollBayreuth
assignee:MichaelStollBayreuth
0-61292
17 hours ago
1-44560
1 day ago
6-29258
6 days
0
46056 eric-wieser
author:eric-wieser
chore(Data/Matrix/Block): deprecate toSquareBlockProp and clean up nearby API Additionally this makes `toBlock` and `toSquareBlock` `abbrev`s, to avoid the need to duplicate the API for each one. One lemma about square blocks generalizes for free to `submatrix`. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-data maintainer-merge 89/63 Mathlib/Data/Matrix/Block.lean,Mathlib/LinearAlgebra/Matrix/Block.lean,Mathlib/LinearAlgebra/Matrix/Charpoly/Basic.lean,Mathlib/RingTheory/Norm/Transitivity.lean,Mathlib/Tactic/Hessenberg/Charpoly.lean 5 13 ['eric-wieser', 'github-actions', 'mathlib-merge-conflicts', 'themathqueen'] nobody
0-54724
15 hours ago
0-68962
19 hours ago
1-46221
1 day
1
42966 SnirBroshi
author:SnirBroshi
feat(Combinatorics/SimpleGraph/Hasse): smaller path graphs are contained in bigger ones --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-combinatorics maintainer-merge 34/2 Mathlib/Combinatorics/SimpleGraph/Hasse.lean 1 14 ['SnirBroshi', 'YaelDillies', 'b-mehta', 'github-actions', 'mathlib-merge-conflicts'] nobody
0-4371
1 hour ago
1-74208
1 day ago
87-39615
87 days
0
45896 YaelDillies
author:YaelDillies
feat(Tactic): `forallImpEq`, the dual simproc to `existsAndEq` It is useful to eliminate equalities under existential quantifiers but there is no finite set of simp lemmas that do it always, and instead the simproc `existsAndEq` does the job. Such a simproc was missing for the dual goal of eliminating equalities under binders. This PR adds it and uses it where possible. Assisted-by: Claude Opus 5.5 --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> LLM-generated t-meta maintainer-merge 246/52 Counterexamples/ZeroDivisorsInAddMonoidAlgebras.lean,Mathlib/Algebra/BigOperators/Associated.lean,Mathlib/Algebra/BigOperators/Group/Finset/Piecewise.lean,Mathlib/Algebra/MonoidAlgebra/Defs.lean,Mathlib/Algebra/MvPolynomial/Basic.lean,Mathlib/Algebra/Order/Monoid/Lex.lean,Mathlib/Analysis/Calculus/TangentCone/Defs.lean,Mathlib/Analysis/InnerProductSpace/Orthogonal.lean,Mathlib/Combinatorics/Additive/Convolution.lean,Mathlib/Combinatorics/Additive/Corner/Roth.lean,Mathlib/Data/Finset/NoncommProd.lean,Mathlib/Data/Finsupp/Basic.lean,Mathlib/Data/Finsupp/Weight.lean,Mathlib/Data/List/Basic.lean,Mathlib/Data/Matrix/Basis.lean,Mathlib/Data/Matrix/PEquiv.lean,Mathlib/Data/Multiset/Fintype.lean,Mathlib/Data/Sym/Sym2.lean,Mathlib/GroupTheory/OrderOfElement.lean,Mathlib/LinearAlgebra/Matrix/PosDef.lean,Mathlib/MeasureTheory/MeasurableSpace/Constructions.lean,Mathlib/NumberTheory/Chebyshev.lean,Mathlib/NumberTheory/Divisors.lean,Mathlib/NumberTheory/Harmonic/ZetaAsymp.lean,Mathlib/Order/Filter/Defs.lean,Mathlib/RingTheory/MvPolynomial/Groebner.lean,Mathlib/RingTheory/PowerSeries/Substitution.lean,Mathlib/RingTheory/Spectrum/Prime/ChevalleyComplexity.lean,Mathlib/SetTheory/ZFC/Class.lean,Mathlib/Tactic/Simproc/ExistsAndEq.lean,Mathlib/Topology/Algebra/IsOpenUnits.lean,Mathlib/Topology/CompactOpen.lean,Mathlib/Topology/Instances/Real/Lemmas.lean,Mathlib/Topology/MetricSpace/UniformConvergence.lean,MathlibTest/Simproc/ExistsAndEq.lean 35 10 ['SnirBroshi', 'YaelDillies', 'github-actions', 'joneugster', 'leanprover-radar', 'mathlib-merge-conflicts'] joneugster
assignee:joneugster
0-2411
40 minutes ago
2-20073
2 days ago
9-29974
9 days
0
41524 SnirBroshi
author:SnirBroshi
feat(SimpleGraph/Trails): define Eulerian graphs Define `SimpleGraph.IsEulerian` to be `∃ (v : V) (p : G.Walk v v), p.IsEulerian`, and prove basic results. Also show that in a connected Eulerian graph there exists an Eulerian circuit from any vertex. This lets us take a circuit at a specific vertex, much like [`IsHamiltonian.exists_isHamiltonianCycle`](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Combinatorics/SimpleGraph/Hamiltonian.html#SimpleGraph.IsHamiltonian.exists_isHamiltonianCycle) in Hamiltonian graphs. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-combinatorics awaiting-author maintainer-merge 88/11 Mathlib/Combinatorics/SimpleGraph/Trails.lean 1 32 ['SnirBroshi', 'YaelDillies', 'github-actions', 'mathlib-merge-conflicts', 'vlad902'] nobody
0-2265
37 minutes ago
0-2320
38 minutes ago
108-72280
108 days
1

PRs blocked on a zulip discussion

Number Author Title Description Labels +/- Modified files (first 100) 📝 💬 All users who commented or reviewed Assignee(s) Updated Last status change total time in review blocks
40994 felixpernegger
author:felixpernegger
chore(Topology): rename `IndiscreteTopology` to `HasIndiscreteTopology` Per naming convention. https://leanprover-community.github.io/contribute/naming.html#prop-valued-classes . See [this](https://github.com/leanprover-community/leanprover-community.github.io/pull/882) PR for further information. Renaming discrete topology will be more involved, sinced its used much more widely --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-topology awaiting-author merge-conflict awaiting-zulip 154/109 Mathlib/Analysis/Normed/Group/Basic.lean,Mathlib/Topology/AlexandrovDiscrete.lean,Mathlib/Topology/Algebra/Group/Basic.lean,Mathlib/Topology/Algebra/Monoid.lean,Mathlib/Topology/Compactness/Compact.lean,Mathlib/Topology/Constructions.lean,Mathlib/Topology/EMetricSpace/Basic.lean,Mathlib/Topology/Homeomorph/Defs.lean,Mathlib/Topology/Homotopy/Contractible.lean,Mathlib/Topology/Inseparable.lean,Mathlib/Topology/Irreducible.lean,Mathlib/Topology/Maps/Basic.lean,Mathlib/Topology/Metrizable/Basic.lean,Mathlib/Topology/NoetherianSpace.lean,Mathlib/Topology/Order.lean,Mathlib/Topology/Separation/Connected.lean,Mathlib/Topology/Sets/Opens.lean,Mathlib/Topology/Sheaves/PUnit.lean,Mathlib/Topology/UniformSpace/Separation.lean 19 9 ['felixpernegger', 'github-actions', 'j-loreaux', 'mathlib-merge-conflicts', 'scholzhannah'] scholzhannah
assignee:scholzhannah
130-18373
4 months ago
148-82770
148 days ago
2-10191
2 days
0
42007 felixpernegger
author:felixpernegger
chore: don't use `by assumption` for hypothesis with exposed name Let's say some goal if solve with `:= by assumption` and `assumption` is using `h` to solve it. Then `:= h` would also solve the goal (note: in most cases this is not possible, we would need to expose names before). This is more readable (tells the used explicitly what is being used) and at least in theory slightly faster. This PR replace all such `by assumption` with the hypothesis directly. If this looks good / gets merged, I will make another PR replacing also `assumption`'s which do not immediately follow a `by`. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) tech debt awaiting-author awaiting-zulip merge-conflict 18/18 Mathlib/Algebra/Homology/DerivedCategory/DerivabilityStructureInjectives.lean,Mathlib/Algebra/Polynomial/BigOperators.lean,Mathlib/Analysis/Calculus/FDeriv/Congr.lean,Mathlib/Analysis/Calculus/Gradient/Basic.lean,Mathlib/Analysis/MeanInequalities.lean,Mathlib/Analysis/SpecialFunctions/Trigonometric/Chebyshev/RootsExtrema.lean,Mathlib/CategoryTheory/Limits/FinallySmall.lean,Mathlib/CategoryTheory/Presentable/Type.lean,Mathlib/Combinatorics/Additive/ApproximateSubgroup.lean,Mathlib/Geometry/Manifold/MFDeriv/SpecificFunctions.lean,Mathlib/Geometry/RingedSpace/LocallyRingedSpace.lean,Mathlib/LinearAlgebra/PiTensorProduct/Generators.lean,Mathlib/Order/Atoms.lean,Mathlib/Topology/Algebra/Valued/LocallyCompact.lean,Mathlib/Topology/Category/CompHausLike/EffectiveEpi.lean,Mathlib/Topology/Category/Profinite/Nobeling/Basic.lean,Mathlib/Topology/Category/TopCat/EffectiveEpi.lean 17 16 ['SnirBroshi', 'Vierkantor', 'felixpernegger', 'github-actions', 'leanprover-radar', 'mathlib-merge-conflicts'] nobody
57-2220
1 month ago
121-14259
121 days ago
1-66762
1 day
0
45029 YaelDillies
author:YaelDillies
feat(Util): support `noWS` in `notation3` ... and use it to define the conditional probability notation `μ[|s]`. Generated by Claude Opus, reviewed line-by-line by myself. Zulip discussion: [#mathlib reviewers > status of &#96;notation3&#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954) Assisted-by: Claude Opus 5.5 --- - [ ] awaiting-Zulip: [#mathlib reviewers > status of &#96;notation3&#96; @ 💬](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60/near/632986954) <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> LLM-generated maintainer-merge t-meta awaiting-zulip 40/34 Mathlib/Probability/ConditionalProbability.lean,Mathlib/Util/Notation3.lean,MathlibTest/Util/Notation3.lean 3 19 ['JovanGerb', 'Vierkantor', 'YaelDillies', 'eric-wieser', 'github-actions', 'grunweg'] Vierkantor
assignee:Vierkantor
27-18089
27 days ago
28-84560
28 days ago
4-43933
4 days
0
43136 joneugster
author:joneugster
feat(Tactic/Linter/ValidatePRTitle): do not check the capitalisation of the commit subject There have been false-positives on abbreviations and proper names which seem to justify not to lint for this. --- - [ ] awaiting-zulip: [#mathlib reviewers > Check PR title](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Check.20PR.20title/with/604858902) - [ ] depends on: https://github.com/leanprover-community/leanprover-community.github.io/pull/905 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) blocked-by-other-PR t-linter awaiting-zulip 3/51 Mathlib/Tactic/Linter/ValidatePRTitle.lean,MathlibTest/ValidatePRTitle.lean 2 2 ['github-actions', 'mathlib-dependent-issues'] nobody
27-17746
27 days ago
87-71330
87 days ago
0-15
15 seconds
0
41348 mkaratarakis
author:mkaratarakis
feat(ComputablePolynomial): define MvDegrees, exponent vectors for multivariate polynomials `MvDegrees nvars` is an exponent vector for a monomial in `nvars` variables: an array of per-variable exponents with its cached total degree, with pointwise addition (`AddCommMonoid`) and the `List`/`Array` folding lemmas the computable multivariate polynomial library (`MvSparsePoly`) is built on. The proofs were done with the help of Claude. Based on the univariate `SparsePoly` (#41339); started by Mario Carneiro at the Hausdorff Institute (June 2024) with design notes and an original Lean prototype by James Davenport (https://github.com/JamesHDavenport/Dagstuhl23401, `verify-irred/VerifyIrred`). --- - [ ] awaiting-zulip: [#mathlib reviewers > Computable polynomials](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Computable.20polynomials/with/608178291) t-meta awaiting-zulip 301/0 Mathlib.lean,Mathlib/Tactic.lean,Mathlib/Tactic/ComputablePolynomial/MvDegrees.lean 3 3 ['Vierkantor', 'github-actions'] Vierkantor and thorimur
assignee:Vierkantor assignee:thorimur
27-17686
27 days ago
29-14950
29 days ago
39-24877
39 days
8
39311 felixpernegger
author:felixpernegger
refactor: redefine `eLpNorm` at `p = 0` For Zulip discussion see https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/eLpNorm.20junk.20value/with/576356442. In partuclar this change is suggestion 2 in [#mathlib4 > eLpNorm junk value @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/eLpNorm.20junk.20value/near/576340531) This redefined [MeasureTheory.eLpNorm](https://leanprover-community.github.io/mathlib4_docs/Mathlib/MeasureTheory/Function/LpSeminorm/Defs.html#MeasureTheory.eLpNorm) at `p = 0`. Previously it was always `0` but now it is the measure of the support of the function (technical detail: In order to avoid having to add additional arguments to `eLpNorm`, we define it as the measure of the support of the norm of the function, but this is almost always the same) The motivation for this comes from the counting measure, in particular this then unifies with https://leanprover-community.github.io/mathlib4_docs/Mathlib/Analysis/Normed/Lp/lpSpace.html#Mem%E2%84%93p. In any case, it is "closer" to the actual mathematical definition Unfortunately, since `eLpNorm` is widely used, the diff is very large and a lot of theorems break (i.e. now require `p != 0`). Oftentimes `p != 0` is still not required (sometimes with nontrivial arguments), I tried to avoid adding extra hypothesis whenever I could but I almost certainly missed some. There now may also be places where we dont need `p != 0` as a hypothesis anymore (i.e. for `[Memℓp](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Analysis/Normed/Lp/lpSpace.html#Mem%E2%84%93p)`), but this is not included in this PR. --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/eLpNorm.20junk.20value/with/576356442. <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) awaiting-zulip merge-conflict t-measure-probability 950/595 Mathlib/Analysis/Distribution/ContDiffMapSupportedIn.lean,Mathlib/Analysis/Distribution/SchwartzSpace/Basic.lean,Mathlib/Analysis/Distribution/TemperateGrowth.lean,Mathlib/Analysis/Distribution/TemperedDistribution.lean,Mathlib/Analysis/Distribution/TestFunction.lean,Mathlib/Analysis/Fourier/LpSpace.lean,Mathlib/Analysis/FunctionalSpaces/SobolevInequality.lean,Mathlib/Analysis/Normed/Lp/SmoothApprox.lean,Mathlib/Data/ENNReal/Holder.lean,Mathlib/MeasureTheory/Function/ContinuousMapDense.lean,Mathlib/MeasureTheory/Function/ConvergenceInMeasure.lean,Mathlib/MeasureTheory/Function/Holder.lean,Mathlib/MeasureTheory/Function/L1Space/Integrable.lean,Mathlib/MeasureTheory/Function/L2Space.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Basic.lean,Mathlib/MeasureTheory/Function/LpSeminorm/CompareExp.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Defs.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Indicator.lean,Mathlib/MeasureTheory/Function/LpSeminorm/LpNorm.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Monotonicity.lean,Mathlib/MeasureTheory/Function/LpSeminorm/SMul.lean,Mathlib/MeasureTheory/Function/LpSeminorm/TriangleInequality.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Trim.lean,Mathlib/MeasureTheory/Function/LpSpace/Basic.lean,Mathlib/MeasureTheory/Function/LpSpace/Complete.lean,Mathlib/MeasureTheory/Function/LpSpace/CompleteOfCompleteLp.lean,Mathlib/MeasureTheory/Function/LpSpace/ContinuousFunctions.lean,Mathlib/MeasureTheory/Function/LpSpace/Indicator.lean,Mathlib/MeasureTheory/Function/SimpleFuncDenseLp.lean,Mathlib/MeasureTheory/Function/UniformIntegrable.lean,Mathlib/MeasureTheory/Integral/SetToL1.lean,Mathlib/Probability/CentralLimitTheorem.lean,Mathlib/Probability/Distributions/Gaussian/Basic.lean,Mathlib/Probability/Distributions/Gaussian/Fernique.lean,Mathlib/Probability/Distributions/Gaussian/HasGaussianLaw/Basic.lean,Mathlib/Probability/Distributions/Gaussian/Real.lean,Mathlib/Probability/IdentDistrib.lean,Mathlib/Probability/Kernel/Disintegration/CDFToKernel.lean,Mathlib/Probability/Kernel/Disintegration/Density.lean,Mathlib/Probability/Martingale/Convergence.lean,Mathlib/Probability/Moments/CovarianceBilinDual.lean,Mathlib/Probability/Moments/IntegrableExpMul.lean,Mathlib/Probability/Moments/SubGaussian.lean,Mathlib/Probability/Process/Filtration.lean,MathlibTest/congr.lean 45 42 ['felixpernegger', 'github-actions', 'mathlib-bors', 'mathlib-merge-conflicts', 'sgouezel'] nobody
27-17586
27 days ago
170-705
170 days ago
5-67427
5 days
0
38957 wwylele
author:wwylele
chore(GroupTheory/DivisibleHull): remove `backward.privateInPublic` --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Should.20we.20expose.20functions.3F <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) tech debt t-group-theory awaiting-zulip 5/12 Mathlib/GroupTheory/DivisibleHull.lean 1 14 ['Komyyy', 'Vierkantor', 'github-actions', 'grunweg', 'jcommelin', 'wwylele'] nobody
27-17523
27 days ago
121-15902
121 days ago
73-19357
73 days
0
37346 euprunin
author:euprunin
chore: golf using `grind` The goal of this PR is to decrease the number of times lemmas are called explicitly. Any decrease in compilation time is a welcome side effect, although it is not a primary objective. Trace profiling results (differences <30 ms considered measurement noise): * `✅️ SimpleGraph.Walk.IsPath.getVert_injOn`: unchanged 🎉 * `✅️ SimpleGraph.Walk.length_bypass_le`: unchanged 🎉 * `✅️ Rat.floor_intCast_div_natCast`: unchanged 🎉 * `✅️ InnerProductGeometry.norm_eq_of_angle_sub_eq_angle_sub_rev_of_angle_ne_pi`: unchanged 🎉 * `✅️ padicNorm.zero_of_padicNorm_eq_zero`: unchanged 🎉 Profiled using `set_option trace.profiler true in`. --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/simp.20followed.20by.20grind/with/591450723 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) awaiting-zulip merge-conflict 7/45 Mathlib/Combinatorics/SimpleGraph/Paths.lean,Mathlib/Data/Rat/Floor.lean,Mathlib/Geometry/Euclidean/Triangle.lean,Mathlib/NumberTheory/Padics/PadicNorm.lean 4 23 ['FernandoChu', 'bryangingechen', 'chenson2018', 'euprunin', 'faenuccio', 'github-actions', 'grunweg', 'mathlib-merge-conflicts'] nobody
27-17474
27 days ago
207-4792
207 days ago
30-49603
30 days
0
35524 grunweg
author:grunweg
feat: text-based linter against \t followed by tactic mode Wait for the zulip discussion to converge. **If** there is consensus in favour of this change, summarise the motivation here. [#mathlib4 > Writer should use an additive monoid @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Writer.20should.20use.20an.20additive.20monoid/near/574990415) --- - [ ] awaiting-zulip: [#mathlib4 > Writer should use an additive monoid @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Writer.20should.20use.20an.20additive.20monoid/near/574990415) There are currently 80 remaining exceptions in mathlib: ideally, these would get fixed before merging this. Works best when combined with #35523. <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-linter awaiting-zulip merge-conflict 23/2 Mathlib/Tactic/Linter/TextBased.lean 1 5 ['github-actions', 'grunweg', 'joneugster', 'mathlib-merge-conflicts', 'vihdzp'] nobody
27-17403
27 days ago
276-12746
276 days ago
0-187
3 minutes
0
33368 urkud
author:urkud
feat: define `Complex.UnitDisc.shift` Also review the existing API UPD: I'm going to define a `PSL(2, Real)` action instead. --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/116395-maths/topic/Shifts.20.28translations.3F.29.20of.20the.20hyperbolic.20plane/with/566237799 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-analysis awaiting-zulip merge-conflict 273/39 Mathlib.lean,Mathlib/Analysis/Complex/UnitDisc/Basic.lean,Mathlib/Analysis/Complex/UnitDisc/Shift.lean 3 7 ['github-actions', 'j-loreaux', 'mathlib4-merge-conflict-bot', 'sgouezel', 'urkud'] j-loreaux
assignee:j-loreaux
27-17034
27 days ago
319-75743
319 days ago
7-33574
7 days
1
32742 LTolDe
author:LTolDe
feat(MeasureTheory/Constructions/Polish/Basic): add class SuslinSpace add new class `SuslinSpace` for a topological space that is an analytic set in itself This will be useful to prove the **Effros Theorem**, see [zulip thread](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Effros.20Theorem/with/558712441). --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Effros.20Theorem/with/558712441 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) new-contributor awaiting-zulip t-measure-probability awaiting-author 4/0 Mathlib/MeasureTheory/Constructions/Polish/Basic.lean 1 10 ['ADedecker', 'LTolDe', 'dagurtomas', 'dupuisf', 'github-actions', 'jcommelin'] PatrickMassot
assignee:PatrickMassot
27-16959
27 days ago
319-79205
319 days ago
11-7507
11 days
0
32608 PrParadoxy
author:PrParadoxy
feat(LinearAlgebra/PiTensorProduct): API for PiTensorProducts indexed by sets This PR addresses a TODO item in LinearAlgebra/PiTensorProduct.lean: * API for the various ways ι can be split into subsets; connect this with the binary tensor product -- specifically by describing tensors of type ⨂ (i : S), M i, for S : Set ι. Our primary motivation is to formalise the notion of "restricted tensor products". This will be the content of a follow-up PR. Beyond that, the Set API is natural in contexts where the index type has an independent interpretation. An example is quantum physics, where ι ranges over distinguishable degrees of freedom, and where its is common practice to annotate objects by the set of indices they are defined on. --- Stub file with preliminary definition of the restricted tensor product as a direct limit of tensors indexed by finite subsets of an index type: https://github.com/PrParadoxy/mathlib4/blob/restricted-stub/Mathlib/LinearAlgebra/PiTensorProduct/Restricted.lean --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Tensor.20products.20indexed.20by.20a.20set/with/565043379 - [x] depends on: #32598 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) new-contributor awaiting-zulip t-algebra WIP merge-conflict
label:t-algebra$
300/2 Mathlib.lean,Mathlib/LinearAlgebra/PiTensorProduct.lean,Mathlib/LinearAlgebra/PiTensorProduct/Set.lean 3 33 ['PrParadoxy', 'dagurtomas', 'eric-wieser', 'github-actions', 'goliath-klein', 'leanprover-radar', 'mathlib-bors', 'mathlib-merge-conflicts', 'mathlib4-dependent-issues-bot', 'mathlib4-merge-conflict-bot'] nobody
27-16911
27 days ago
334-72170
334 days ago
10-66980
10 days
1
30668 astrainfinita
author:astrainfinita
feat: `QuotType` This typeclass is primarily for use by type synonyms of `Quot` and `Quotient`. Using `QuotType` API for type synonyms of `Quot` and `Quotient` will avoid defeq abuse caused by directly using `Quot` and `Quotient` APIs. This PR also adds some typeclasses to support different ways to find the quotient map that should be used. See the documentation comments of these typeclasses for examples of usage. --- <!-- The text above the `---` will become the commit message when your PR is merged. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. To indicate co-authors, include lines at the bottom of the commit message (that is, before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (that is, before the `---`) using the following format: Moves: - Vector.* -> Mathlib.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> It's not a typical design to use these auxiliary typeclasses and term elaborators, but I haven't found a better way to support these notations. Some of the naming may need to be discussed. For example: - `⟦·⟧` is currently called `mkQ` in names. This distinguishes it from other `.mk`s and makes it possible to write the quotient map as `mkQ` `mkQ'` ~~`mkQ_ h`~~. But this will also require changing the old lemma names. - It would be helpful if the names of new type classes explained their functionality better. - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/migrate.20to.20.60QuotLike.60.20API This PR continues the work from #16421. Original PR: https://github.com/leanprover-community/mathlib4/pull/16421 RFC t-data awaiting-zulip awaiting-author 629/0 Mathlib.lean,Mathlib/Data/QuotType.lean,MathlibTest/QuotType.lean 3 23 ['SnirBroshi', 'YaelDillies', 'astrainfinita', 'dagurtomas', 'github-actions', 'mathlib4-merge-conflict-bot', 'plp127', 'vihdzp'] nobody
27-16860
27 days ago
399-29550
399 days ago
0-81
1 minute
0
28803 astrainfinita
author:astrainfinita
refactor: unbundle algebra from `ENormed*` Further speed up the search in the algebraic typeclass hierarchy by avoiding searching for `TopologicalSpace`. This PR continues the work from #23961. - Change `ESeminormed(Add)Monoid` and `ENormed(Add)Monoid` so they no longer carry algebraic data. - Deprecate `ESeminormed(Add)CommMonoid` and `ENormed(Add)CommMonoid` in favor of `ESeminormed(Add)Monoid` and `ENormed(Add)Monoid` with a commutative algebraic typeclass. |Old|New| |---|---| | `[ESeminormed(Add)(Comm)Monoid E]` | `[(Add)(Comm)Monoid E] [ESeminormed(Add)Monoid E]` | | `[ENormed(Add)(Comm)Monoid]` | `[(Add)(Comm)Monoid E] [ENormed(Add)Monoid]` | See [Zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2328803.20refactor.3A.20unbundle.20algebra.20from.20.60ENormed*.60/with/536024350) ------------ - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2328803.20refactor.3A.20unbundle.20algebra.20from.20.60ENormed*.60/with/53602435 - [x] depends on: #28813 t-algebra merge-conflict slow-typeclass-synthesis awaiting-zulip t-analysis
label:t-algebra$
80/63 Mathlib/Analysis/CStarAlgebra/CStarMatrix.lean,Mathlib/Analysis/Normed/Group/Basic.lean,Mathlib/Analysis/Normed/Group/Continuity.lean,Mathlib/Analysis/Normed/Group/InfiniteSum.lean,Mathlib/Analysis/NormedSpace/IndicatorFunction.lean,Mathlib/MeasureTheory/Function/L1Space/AEEqFun.lean,Mathlib/MeasureTheory/Function/L1Space/HasFiniteIntegral.lean,Mathlib/MeasureTheory/Function/L1Space/Integrable.lean,Mathlib/MeasureTheory/Function/LocallyIntegrable.lean,Mathlib/MeasureTheory/Function/LpSeminorm/Basic.lean,Mathlib/MeasureTheory/Function/LpSeminorm/CompareExp.lean,Mathlib/MeasureTheory/Function/LpSeminorm/TriangleInequality.lean,Mathlib/MeasureTheory/Integral/IntegrableOn.lean,Mathlib/MeasureTheory/Integral/IntervalIntegral/Basic.lean 14 28 ['astrainfinita', 'bryangingechen', 'github-actions', 'grunweg', 'kbuzzard', 'leanprover-bot', 'mathlib-bors', 'mathlib4-dependent-issues-bot', 'mathlib4-merge-conflict-bot', 'sgouezel'] grunweg
assignee:grunweg
27-16817
27 days ago
453-85914
453 days ago
0-19882
5 hours
0
30150 imbrem
author:imbrem
feat(CategoryTheory/Monoidal): to_additive for MonoidalCategory Add `AddMonoidalCategory`, the additive version of `MonoidalCategory`. To get this to work, I needed to _remove_ the `to_additive` attributes in `Discrete.lean`, since existing code relies on the `AddMonoid M → MonoidalCategory M` instance. For now, we simply implement the additive variants by hand instead. --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/to_additive.20on.20MonoidalCategory/with/543107104 As discussed in #28718; I added an `AddMonoidalCategory` struct and tagged `MonoidalCategory` with `to_additive`, along with the lemmas in `Category.lean`. I think this is the right approach, since under this framework the "correct" additive version of `Discrete.lean` would be mapping an `AddMonoid` to an `AddMonoidalCategory`. Next steps would be to: - Make `monoidal_coherence` and `coherence` support `AddMonoidalCategory` - Add `CocartesianMonoidalCategory` extending `AddMonoidalCategory` <!-- The text above the `---` will become the commit message when your PR is merged. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. To indicate co-authors, include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" When merging, all the commits will be squashed into a single commit listing all co-authors. If you are moving or deleting declarations, please include these lines at the bottom of the commit message (that is, before the `---`) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-category-theory large-import new-contributor merge-conflict awaiting-zulip t-meta 444/125 Mathlib/CategoryTheory/Monoidal/Category.lean,Mathlib/CategoryTheory/Monoidal/Discrete.lean,Mathlib/Tactic/ToAdditive/GuessName.lean 3 22 ['JovanGerb', 'YaelDillies', 'github-actions', 'imbrem', 'mathlib4-merge-conflict-bot'] nobody
27-16708
27 days ago
414-15110
414 days ago
1-160
1 day
3
41339 mkaratarakis
author:mkaratarakis
feat(ComputablePolynomial): define SparsePoly, a computable univariate polynomial `SparsePoly R` is a computable, kernel-reducible representation of univariate polynomials over a commutative ring `R` with `DecidableEq R`: a list of `(exponent, coefficient)` pairs with strictly decreasing exponents and nonzero coefficients, making the representation canonical. This first part defines the structure, the semantics `toPoly : SparsePoly R → Polynomial R`, and addition. Started by Mario Carneiro at the Hausdorff Institute (June 2024) with design notes and an original Lean prototype by James Davenport (https://github.com/JamesHDavenport/Dagstuhl23401, `verify-irred/VerifyIrred`) and the proofs were done with the help of Claude code. --- - [ ] awaiting-zulip: [#mathlib reviewers > Computable polynomials](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Computable.20polynomials/with/608178291) t-meta awaiting-author awaiting-zulip 217/0 Mathlib.lean,Mathlib/Tactic.lean,Mathlib/Tactic/ComputablePolynomial/Basic.lean 3 10 ['JovanGerb', 'github-actions', 'joneugster', 'mkaratarakis'] eric-wieser and joneugster
assignee:eric-wieser assignee:joneugster
27-16468
27 days ago
37-4319
37 days ago
104-17253
104 days
7
42551 plp127
author:plp127
chore: rename `Set.mem_singleton` Rename `Set.mem_singleton` to `Set.mem_singleton_self` and rename `Set.mem_singleton_iff` to `Set.mem_singleton`. Also rename `Set.notMem_singleton_self` to `Set.notMem_singleton`. This is consistent with other container types like `Finset` and `List`. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) awaiting-zulip merge-conflict awaiting-author 705/683 Archive/Imo/Imo2019Q2.lean,Archive/Imo/Imo2024Q2.lean,Archive/Imo/Imo2024Q3.lean,Archive/Imo/Imo2024Q6.lean,Archive/Wiedijk100Theorems/CubingACube.lean,Counterexamples/CliffordAlgebraNotInjective.lean,Counterexamples/DiscreteTopologyNonDiscreteUniformity.lean,Counterexamples/GrothendieckPower.lean,Mathlib/Algebra/Algebra/NonUnitalSubalgebra.lean,Mathlib/Algebra/Algebra/Subalgebra/Lattice.lean,Mathlib/Algebra/BigOperators/Finprod.lean,Mathlib/Algebra/Category/Grp/Injective.lean,Mathlib/Algebra/CharP/MixedCharZero.lean,Mathlib/Algebra/CharP/Quotient.lean,Mathlib/Algebra/DualNumber.lean,Mathlib/Algebra/Group/Indicator.lean,Mathlib/Algebra/Group/Pointwise/Set/Finite.lean,Mathlib/Algebra/Group/Subgroup/Basic.lean,Mathlib/Algebra/Group/Subgroup/Lattice.lean,Mathlib/Algebra/Group/Submonoid/Defs.lean,Mathlib/Algebra/Group/Submonoid/Membership.lean,Mathlib/Algebra/Group/Submonoid/Operations.lean,Mathlib/Algebra/GroupWithZero/Range.lean,Mathlib/Algebra/Homology/TotalComplexShift.lean,Mathlib/Algebra/Lie/Engel.lean,Mathlib/Algebra/Lie/InvariantForm.lean,Mathlib/Algebra/Lie/Subalgebra.lean,Mathlib/Algebra/Lie/Submodule.lean,Mathlib/Algebra/Module/Submodule/Lattice.lean,Mathlib/Algebra/Module/Torsion/Basic.lean,Mathlib/Algebra/Module/ZLattice/Basic.lean,Mathlib/Algebra/Order/Ring/StandardPart.lean,Mathlib/Algebra/Pointwise/Stabilizer.lean,Mathlib/Algebra/Star/NonUnitalSubalgebra.lean,Mathlib/Algebra/Star/Pointwise.lean,Mathlib/Algebra/Star/Subalgebra.lean,Mathlib/AlgebraicGeometry/IdealSheaf/IrreducibleComponent.lean,Mathlib/AlgebraicGeometry/ProjectiveSpectrum/Topology.lean,Mathlib/AlgebraicTopology/SimplicialSet/Horn.lean,Mathlib/AlgebraicTopology/SimplicialSet/HornColimits.lean,Mathlib/AlgebraicTopology/SimplicialSet/StdSimplex.lean,Mathlib/Analysis/Analytic/Constructions.lean,Mathlib/Analysis/BoxIntegral/Partition/Split.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Basic.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Continuity.lean,Mathlib/Analysis/CStarAlgebra/Hom.lean,Mathlib/Analysis/CStarAlgebra/Projection.lean,Mathlib/Analysis/Calculus/ContDiff/Basic.lean,Mathlib/Analysis/Calculus/ContDiff/FaaDiBruno.lean,Mathlib/Analysis/Calculus/Deriv/Slope.lean,Mathlib/Analysis/Calculus/DerivativeTest.lean,Mathlib/Analysis/Calculus/FDeriv/Measurable.lean,Mathlib/Analysis/Calculus/Taylor.lean,Mathlib/Analysis/Complex/CanonicalDecomposition.lean,Mathlib/Analysis/Complex/Hadamard.lean,Mathlib/Analysis/Convex/Between.lean,Mathlib/Analysis/Convex/Exposed.lean,Mathlib/Analysis/Convex/Extreme.lean,Mathlib/Analysis/Convex/Gauge.lean,Mathlib/Analysis/Convex/Hull.lean,Mathlib/Analysis/Convex/Independent.lean,Mathlib/Analysis/Convex/Integral.lean,Mathlib/Analysis/Convex/Segment.lean,Mathlib/Analysis/Convex/Star.lean,Mathlib/Analysis/Convex/StrictConvexSpace.lean,Mathlib/Analysis/InnerProductSpace/Orthogonal.lean,Mathlib/Analysis/LocallyConvex/Bounded.lean,Mathlib/Analysis/LocallyConvex/Polar.lean,Mathlib/Analysis/LocallyConvex/Separation.lean,Mathlib/Analysis/LocallyConvex/WithSeminorms.lean,Mathlib/Analysis/Meromorphic/Basic.lean,Mathlib/Analysis/Meromorphic/NormalForm.lean,Mathlib/Analysis/Meromorphic/Order.lean,Mathlib/Analysis/Normed/Field/Basic.lean,Mathlib/Analysis/Normed/Lp/lpSpace.lean,Mathlib/Analysis/Normed/Module/Basic.lean,Mathlib/Analysis/Normed/Module/Connected.lean,Mathlib/Analysis/Normed/Unbundled/FiniteExtension.lean,Mathlib/Analysis/Normed/Unbundled/SeminormFromBounded.lean,Mathlib/Analysis/SpecialFunctions/Complex/Log.lean,Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/Rpow/Order.lean,Mathlib/Analysis/SpecialFunctions/Elliptic/Weierstrass.lean,Mathlib/Analysis/SpecialFunctions/Integrals/LogTrigonometric.lean,Mathlib/Analysis/SpecialFunctions/Integrals/PosLogEqCircleAverage.lean,Mathlib/Analysis/SpecialFunctions/Log/NegMulLog.lean,Mathlib/Analysis/SpecialFunctions/Pow/Asymptotics.lean,Mathlib/CategoryTheory/GradedObject.lean,Mathlib/CategoryTheory/GradedObject/Unitor.lean,Mathlib/CategoryTheory/Preadditive/HomOrthogonal.lean,Mathlib/CategoryTheory/Presentable/SharplyLT/Basic.lean,Mathlib/CategoryTheory/Sites/Grothendieck.lean,Mathlib/CategoryTheory/Sites/Sieves.lean,Mathlib/Combinatorics/Graph/Basic.lean,Mathlib/Combinatorics/Matroid/Basic.lean,Mathlib/Combinatorics/Matroid/Circuit.lean,Mathlib/Combinatorics/Matroid/Closure.lean,Mathlib/Combinatorics/Nullstellensatz.lean,Mathlib/Combinatorics/Quiver/Path/Vertices.lean,Mathlib/Combinatorics/SimpleGraph/Acyclic.lean,Mathlib/Combinatorics/SimpleGraph/Basic.lean 363 4 ['Ruben-VandeVelde', 'github-actions', 'grunweg', 'mathlib-merge-conflicts'] nobody
27-16300
27 days ago
101-18823
101 days ago
4-40823
4 days
0
44251 gotrevor
author:gotrevor
doc(1000-yaml): add the Paris–Harrington theorem Adds an external-formalization pointer to the Paris–Harrington entry `Q7137494`, in the same form as my open #41337 (Goodstein / Kirby–Paris). I know #44115 proposes moving non-mathlib entries out of `1000.yaml` (as @wwylele noted on #41337). I'm opening this anyway so the formalization is easy to find: nobody else needs to redo Paris–Harrington, and anyone who wants to build on it or cite it can start from this one. If #44115 lands, I'm happy to close this and re-home the entry wherever external formalizations end up. ## Entry | Wikidata | Theorem | Formalization | |----------|---------|---------------| | `Q7137494` | **Paris–Harrington theorem**: Peano Arithmetic does not prove the Paris–Harrington principle (the strengthened finite Ramsey theorem with "relatively large" homogeneous sets), though it is true | [`goodstein-independence`](https://github.com/gotrevor/goodstein-independence/blob/main/src/GoodsteinPA/PH/Main.lean) | ## Notes - Headline: `GoodsteinPA.PH.pa_not_proves_ph`. For every Σ₁ formula defining the principle, PA does not prove its universal closure. Companion theorems: `exists_sigma1_ph_def` (such a formula exists) and `ph_true` (the principle holds, via infinite Ramsey). - The lower bound follows Buchholz's lecture-notes proof, after Loebl–Nešetřil. Independence then goes through a Wainer-style bound for PA-provable Π₂ sentences, built on the [`FormalizedFormalLogic/Foundation`](https://github.com/FormalizedFormalLogic/Foundation) library, the same library behind the Löb's-theorem entry `Q204884`. - Developed with AI assistance (Claude Code and Codex). ---- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Purpose.20of.201000.2Eyaml/with/633932200 (in the private reviewers stream) LLM-generated new-contributor awaiting-zulip 4/0 docs/1000.yaml 1 4 ['SnirBroshi', 'github-actions', 'gotrevor'] nobody
27-13998
27 days ago
48-55431
48 days ago
7-21662
7 days
0
44066 cadamcat
author:cadamcat
doc: note formalisation of Mihăilescu's theorem in 1000.yaml Record an external Lean formalisation of Mihăilescu's theorem (Q174955, formerly Catalan's conjecture). The comment no longer says that only the statement is formalised, since the formal-conjectures statement now links to this proof. --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Purpose.20of.201000.2Eyaml/with/633932200 (in the private reviewers stream) - Formalisation: [cadamcat/catalan-lean4](https://github.com/cadamcat/catalan-lean4), release [v1.0.0](https://github.com/cadamcat/catalan-lean4/releases/tag/v1.0.0). The link points to `Catalan.catalans_conjecture` in `Catalan/Final/Assembly.lean`, pinned at commit `4bf1f74`. - The statement is verbatim the one in formal-conjectures, which has linked this proof since [google-deepmind/formal-conjectures#6452](https://github.com/google-deepmind/formal-conjectures/pull/6452) (merged 2026-09-22). - The project pins Lean 4.33.1 and Mathlib `0df444a360eaa60ab8c11dca51a86af692955474`. `#print axioms Catalan.catalans_conjecture` reports `[propext, Classical.choice, Quot.sound]` ([recorded output](https://github.com/cadamcat/catalan-lean4/blob/4bf1f742eb341decbdfc59ec56e1616f4d13e33b/Verification/axioms.txt)). The [supplemental evidence](https://github.com/cadamcat/catalan-lean4/blob/4bf1f742eb341decbdfc59ec56e1616f4d13e33b/Verification/Supplemental/README.md) records our runs of the nanoda kernel checker and a build of the complete Mathlib library from source on Linux, for proof commit `897079d`, whose proof sources are identical to `4bf1f74`. - The project vendors 871 unmodified modules of [ClassFieldTheory](https://github.com/n-yamaguchi-0729/ClassFieldTheory) (commit `2930b56`, Apache-2.0) for the class field theory it uses. - `scripts/yaml_check.py docs/100.yaml docs/1000.yaml docs/overview.yaml docs/undergrad.yaml` passes. AI disclosure: the linked formalisation was developed with AI coding agents (Codex and Claude Code; see its [AUTHORS.md](https://github.com/cadamcat/catalan-lean4/blob/4bf1f742eb341decbdfc59ec56e1616f4d13e33b/AUTHORS.md)). I checked the final statement, its match with formal-conjectures, and the axiom output. new-contributor awaiting-zulip LLM-generated 4/1 docs/1000.yaml 1 4 ['github-actions', 'grunweg'] nobody
27-13989
27 days ago
60-14212
60 days ago
1-2028
1 day
0
43318 wpegden
author:wpegden
doc(1000): add the strong and weak perfect graph theorems Adds external-formalization entries for Q16680059 (strong perfect graph theorem) and Q2800071 (perfect graph theorem), both formalized in Lean 4 at https://github.com/wpegden/spgt with commit-pinned permalinks. --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Purpose.20of.201000.2Eyaml/with/633932200 (in the private reviewers stream) <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) new-contributor awaiting-zulip 8/0 docs/1000.yaml 1 15 ['SnirBroshi', 'github-actions', 'grunweg', 'thorimur', 'wpegden', 'wwylele'] nobody
27-13977
27 days ago
80-74107
80 days ago
0-72926
20 hours
0
41337 gotrevor
author:gotrevor
doc(1000-yaml): add Goodstein's theorem and the Kirby–Paris theorem Claims two listed-but-unclaimed entries in the 1000+ theorems scoreboard by adding external-formalization pointers (no mathlib declaration; same pattern as Löb's theorem [`Q204884`](https://github.com/leanprover-community/mathlib4/blob/master/docs/1000.yaml#L201), the flypitch continuum-hypothesis independence [`Q208416`](https://github.com/leanprover-community/mathlib4/blob/master/docs/1000.yaml#L216), and Arrow's impossibility theorem [`Q33481`](https://github.com/leanprover-community/mathlib4/blob/master/docs/1000.yaml#L30)). ## Entries | Wikidata | Theorem | Formalization | |----------|---------|---------------| | `Q1149185` | **Goodstein's theorem** — every Goodstein sequence terminates | [`lean-gallery`](https://github.com/gotrevor/lean-gallery/blob/main/LeanGallery/Logic/Goodstein/Statement.lean) (ordinal-descent proof) | | `Q1149185X` | **Kirby–Paris theorem** — PA does not prove that every Goodstein sequence terminates | [`goodstein-independence`](https://github.com/gotrevor/goodstein-independence/blob/main/src/GoodsteinPA/Statement.lean) | ---- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Purpose.20of.201000.2Eyaml/with/633932200 (in the private reviewers stream) ## Notes - **`Q1149185X` (Kirby–Paris, 1982)** is built on the [`FormalizedFormalLogic/Foundation`](https://github.com/FormalizedFormalLogic/Foundation) library (the same library that backs the existing Löb's-theorem entry [`Q204884`](https://github.com/leanprover-community/mathlib4/blob/master/docs/1000.yaml#L201)), via the Wainer growth-rate route (`Goodstein` outgrows every PA-provably-total function). The headline `peano_not_proves_goodstein` is sorry-free and `#print axioms`-clean — it rests on exactly `[propext, Classical.choice, Quot.sound]`. - **`Q1149185`** is Goodstein's theorem proper (the termination statement, provable in ZFC / Lean); mathlib does not currently contain it. - Both formalizations are by Trevor Morris, developed with AI assistance: Claude Code (Fable 5, Opus), Codex, and Harmonic's Aristotle. 🤖 Generated with [Claude Code](https://claude.com/claude-code) new-contributor LLM-generated awaiting-zulip 6/0 docs/1000.yaml 1 7 ['SnirBroshi', 'felixpernegger', 'github-actions', 'gotrevor', 'wwylele'] nobody
27-13935
27 days ago
140-49484
140 days ago
0-81856
22 hours
0
45150 kim-em
author:kim-em
ci: require linked PR discussion for awaiting-zulip Require open PRs labelled `awaiting-zulip` to link, in their description or comments, to a Zulip topic that references that same mathlib PR. After a manual label addition, remove the label if no qualifying discussion is linked, and leave a polite, actionable comment mentioning the person who applied it. The comment-labeling bot checks before applying `awaiting-zulip` and declines invalid requests, mentioning the requester. It uses the same validator as the manual-label check, since its `GITHUB_TOKEN` label changes do not trigger another workflow. It scans issue comments, review bodies, and inline comments; follows message anchors across topic renames; and checks the whole topic. Full GitHub URLs and linkifiers are recognised through rendered destinations and topic-title links, matching the repository and PR number rather than bare numbers. Checks run on label and PR/comment changes, with a daily sweep to retry missed events/outages and catch changes on Zulip. Manual runs default to dry-run. Verification failures leave labels untouched; notices are updated rather than duplicated. Privileged jobs execute the default branch's action, and tests run without the Zulip secret. --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/180721-mathlib-maintainers/topic/proposal.20for.20.60awaiting-zulip.60/with/634263477 The first scheduled sweep after merge will also enforce this on existing labels. Uses the existing `ZULIP_API_KEY` and mathlib Zulip bot account; linked private topics must be accessible to that bot. The live dry run used my account's read access, so it does not establish the bot's private-channel permissions. Motivated by https://github.com/leanprover-community/mathlib4/pull/44489#issuecomment-6327051347. :robot: prepared with Codex CI awaiting-author awaiting-zulip 995/1 .github/actions/awaiting-zulip/README.md,.github/actions/awaiting-zulip/action.yml,.github/actions/awaiting-zulip/guard.py,.github/actions/awaiting-zulip/test_guard.py,.github/workflows/awaiting_zulip.yml,.github/workflows/labels_from_comment.yml 6 6 ['SnirBroshi', 'github-actions', 'grunweg', 'joneugster'] nobody
27-13547
27 days ago
29-45694
29 days ago
2-8028
2 days
0
45016 kim-em
author:kim-em
chore: use scoped omit commands Replace the 51 persistent `omit` commands in 45 Mathlib files, plus the remaining occurrence in `Archive`, with `omit ... in` on individual declarations. One ineffective omission immediately before `end` is deleted. Declaration order, proofs, and variables are unchanged. Redundant section wrappers are removed. Per-declaration option settings retain their scope, and local wrappers preserve explicitly named measurable spaces and intended instance parameters where needed. This is the cleanup prerequisite for the [linter proposal](https://github.com/leanprover-community/mathlib4/pull/45017). The policy remains under [discussion](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/proposal.3A.20lint.20against.20.60omit.20.2E.2E.2E.60.2C.20requiring.20.60omit.20.2E.2E.2E.20in.60/near/632918131), including an exception for plain `omit` at the beginning of a section or namespace. Please wait for that discussion to converge before merging. The `omit ... in section` grouping has been removed: this syntax relies on surprising scope behaviour and fails with named sections. The library sources are exactly the same as the previously validated per-declaration version at `252adfe7222`. ---- - [ ] awaiting-zulip: [Zulip](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60) Validation of that version: all 45 affected Mathlib modules and their dependencies build successfully (8,246 jobs), and all 5,214 compiled declaration-type fingerprints match the baseline, including implicit parameter order. Proofs and declaration order are unchanged. Text-style lint and `git diff --check` pass. The restored version also rebuilds successfully (8,246 jobs); full downstream checks remain for CI. :robot: prepared with Codex awaiting-zulip LLM-generated awaiting-author merge-conflict 193/120 Archive/Imo/Imo2024Q3.lean,Mathlib/Algebra/Homology/Homotopy.lean,Mathlib/Algebra/Order/BigOperators/GroupWithZero/List.lean,Mathlib/Algebra/Order/BigOperators/GroupWithZero/Multiset.lean,Mathlib/Algebra/Polynomial/Roots.lean,Mathlib/Analysis/Matrix/Order.lean,Mathlib/CategoryTheory/Limits/FormalCoproducts/Basic.lean,Mathlib/CategoryTheory/Monoidal/DayConvolution.lean,Mathlib/CategoryTheory/Triangulated/Basic.lean,Mathlib/CategoryTheory/Triangulated/Pretriangulated.lean,Mathlib/Combinatorics/SimpleGraph/Finite.lean,Mathlib/Geometry/Euclidean/Volume/Measure.lean,Mathlib/LinearAlgebra/AffineSpace/Ordered.lean,Mathlib/LinearAlgebra/Dimension/Localization.lean,Mathlib/LinearAlgebra/Dimension/StrongRankCondition.lean,Mathlib/LinearAlgebra/Dual/Basis.lean,Mathlib/LinearAlgebra/Dual/Lemmas.lean,Mathlib/LinearAlgebra/FiniteDimensional/Basic.lean,Mathlib/LinearAlgebra/Finsupp/LinearCombination.lean,Mathlib/LinearAlgebra/RootSystem/Chain.lean,Mathlib/LinearAlgebra/RootSystem/Finite/CanonicalBilinear.lean,Mathlib/LinearAlgebra/RootSystem/Finite/G2.lean,Mathlib/LinearAlgebra/RootSystem/GeckConstruction/Relations.lean,Mathlib/LinearAlgebra/RootSystem/Reduced.lean,Mathlib/MeasureTheory/Function/StronglyMeasurable/Basic.lean,Mathlib/MeasureTheory/Integral/Lebesgue/Countable.lean,Mathlib/ModelTheory/Skolem.lean,Mathlib/NumberTheory/Cyclotomic/Basic.lean,Mathlib/NumberTheory/LSeries/DirichletContinuation.lean,Mathlib/NumberTheory/NumberField/Ideal/KummerDedekind.lean,Mathlib/Order/IsNormal.lean,Mathlib/Probability/Kernel/Condexp.lean,Mathlib/RingTheory/Algebraic/Basic.lean,Mathlib/RingTheory/Algebraic/Integral.lean,Mathlib/RingTheory/AlgebraicIndependent/AlgebraicClosure.lean,Mathlib/RingTheory/ChainOfDivisors.lean,Mathlib/RingTheory/IntegralClosure/IntegralRestrict.lean,Mathlib/RingTheory/LocalRing/ResidueField/Basic.lean,Mathlib/RingTheory/Localization/FractionRing.lean,Mathlib/RingTheory/TensorProduct/Maps.lean,Mathlib/RingTheory/TensorProduct/MonoidAlgebra.lean,Mathlib/Topology/Algebra/Group/Matrix.lean,Mathlib/Topology/Convenient/GeneratedBy.lean,Mathlib/Topology/Covering/Basic.lean,Mathlib/Topology/Covering/Quotient.lean,Mathlib/Topology/Homotopy/Lifting.lean 46 8 ['github-actions', 'grunweg', 'kim-em', 'leanprover-radar', 'loefflerd', 'mathlib-merge-conflicts'] nobody
26-59256
26 days ago
34-21536
34 days ago
0-12341
3 hours
1
30750 SnirBroshi
author:SnirBroshi
feat(Data/Quot): `toSet` and `equivClassOf` Define `toSet` which gets the set corresponding to an element of a quotient, and `equivClassOf` which gets the equivalence class of an element under a quotient. --- I found these definitions helpful when working with quotients, specifically `ConnectedComponents` of a `TopologicalSpace`. <!-- The text above the `---` will become the commit message when your PR is merged. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. To indicate co-authors, include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" When merging, all the commits will be squashed into a single commit listing all co-authors. If you are moving or deleting declarations, please include these lines at the bottom of the commit message (that is, before the `---`) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-data awaiting-author awaiting-zulip 170/0 Mathlib/Basic/SetLike/Basic.lean,Mathlib/Data/Quot.lean,Mathlib/Data/Set/Image.lean,Mathlib/Order/Setoid/Basic.lean 4 12 ['SnirBroshi', 'TwoFX', 'eric-wieser', 'github-actions', 'grunweg', 'mathlib-merge-conflicts', 'wrenna-robson'] TwoFX
assignee:TwoFX
20-34923
20 days ago
360-19373
360 days ago
35-84279
35 days
0
35578 Shreyas4991
author:Shreyas4991
fix: writer monad should use an additive logging type The Writer monad's w type is supposed to be additive, not multiplicative. This is how it is conceptually used in Haskell (as a logging type). Haskell uses `Monoid` because it doesn't make a distinction between `AddMonoid` and `Monoid`. [#mathlib4 > Writer should use an additive monoid @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Writer.20should.20use.20an.20additive.20monoid/near/574990415) --- - [ ] awaiting-zulip: [#mathlib4 > Writer should use an additive monoid @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Writer.20should.20use.20an.20additive.20monoid/near/574990415) <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-data awaiting-zulip merge-conflict 10/10 Mathlib/Control/Monad/Cont.lean,Mathlib/Control/Monad/Writer.lean 2 6 ['Shreyas4991', 'eric-wieser', 'github-actions', 'mathlib-merge-conflicts'] nobody
19-28622
19 days ago
274-54981
274 days ago
0-18707
5 hours
0
43143 martinwintermath
author:martinwintermath
feat(LinearAlgebra/SesquilinearForm): add instances for SeparatingLeft, SeparatingRight and Nondegenerate Add typeclass instances for `Fact B.SeparatingLeft`, `Fact B.SeparatingRight`, `Fact B.Nondegenerate`: * inferring `Fact B.flip.SeparatingLeft` from `Fact B.SeparatingRight` and vice versa * inferring `Fact B.SeparatingLeft` and `Fact B.SeparatingRight` from `Fact B.Nondegenerate` * inferring `Fact B.SeparatingLeft` and `Fact B.Nondegenerate` for `.id` and `Dual.eval` * inferring `Fact B.Nondegenerate` from `B.IsPerfPair` I also updated `PointedCone.dual_univ` to demonstrate a use for these additions. Note that I needed to add an import to `Cone/Dual.lean` which somehow imports cardinals. So I needed to remove cardinals from `assert_not_exists`. Zulip: [#mathlib4 > Typeclass instances for separating bilinear forms](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Typeclass.20instances.20for.20separating.20bilinear.20forms/with/570348517) --- - [ ] awaiting-zulip: [#mathlib4 > Typeclass instances for separating bilinear forms](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Typeclass.20instances.20for.20separating.20bilinear.20forms/with/570348517) - [x] depends on: #34487 [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) large-import t-algebra awaiting-zulip merge-conflict
label:t-algebra$
32/4 Mathlib/Geometry/Convex/Cone/Dual.lean,Mathlib/LinearAlgebra/PerfectPairing/Basic.lean,Mathlib/LinearAlgebra/SesquilinearForm/Basic.lean 3 10 ['SnirBroshi', 'github-actions', 'martinwintermath', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'themathqueen'] nobody
15-84352
15 days ago
48-2679
48 days ago
34-59100
34 days
0
45643 felixpernegger
author:felixpernegger
refactor(Topology): unclass `IsClosed` Currently, `IsClosed` is a class, unlike `IsOpen` and it also doesnt make much sense and isnt widely used as a class. This was suggested by @eric-wieser on Zulip [#mathlib4 > Fact instances](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Fact.20instances/with/636430414). This PR makes it a one-field structure (def would also work, but this prevents defeq abuse...). Some cleanup is needed, for example when `IsClosed` was used in an instance, we now need `[Fact (IsOpen ...`. Originally `IsClosed` was made a class in mathlib3 in 2021 [here](https://github.com/leanprover-community/mathlib3/pull/6552). --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> awaiting-zulip merge-conflict 122/91 Archive/Examples/Kuratowski.lean,Mathlib/Algebra/Module/ZLattice/Basic.lean,Mathlib/AlgebraicGeometry/AlgClosed/Basic.lean,Mathlib/Analysis/CStarAlgebra/Classes.lean,Mathlib/Analysis/CStarAlgebra/Commutative/PosPart.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Range.lean,Mathlib/Analysis/CStarAlgebra/GelfandDuality.lean,Mathlib/Analysis/CStarAlgebra/Spectrum.lean,Mathlib/Analysis/InnerProductSpace/Projection/Basic.lean,Mathlib/Analysis/InnerProductSpace/Reproducing/Operations.lean,Mathlib/Analysis/Normed/Algebra/Spectrum.lean,Mathlib/Analysis/Normed/Group/Quotient.lean,Mathlib/Analysis/Normed/Ring/Units.lean,Mathlib/LinearAlgebra/Eigenspace/ContinuousLinearMap.lean,Mathlib/MeasureTheory/Constructions/Polish/Basic.lean,Mathlib/MeasureTheory/Measure/Haar/Basic.lean,Mathlib/MeasureTheory/VectorMeasure/AddContent.lean,Mathlib/Topology/Algebra/Algebra.lean,Mathlib/Topology/Algebra/Group/Pointwise.lean,Mathlib/Topology/Algebra/Group/Quotient.lean,Mathlib/Topology/Algebra/Module/Basic.lean,Mathlib/Topology/Algebra/Module/ClosedSubmodule.lean,Mathlib/Topology/Algebra/Module/Compact.lean,Mathlib/Topology/Algebra/Module/FiniteDimension.lean,Mathlib/Topology/Algebra/NonUnitalAlgebra.lean,Mathlib/Topology/Algebra/OpenSubgroup.lean,Mathlib/Topology/Algebra/ProperAction/Basic.lean,Mathlib/Topology/Algebra/Ring/Compact.lean,Mathlib/Topology/Connected/PathComponentOne.lean,Mathlib/Topology/ContinuousMap/Ideals.lean,Mathlib/Topology/ContinuousMap/StoneWeierstrass.lean,Mathlib/Topology/Defs/Basic.lean,Mathlib/Topology/Instances/ENNReal/Lemmas.lean,Mathlib/Topology/Neighborhoods.lean,Mathlib/Topology/Sober.lean,Mathlib/Topology/UniformSpace/UniformEmbedding.lean 36 6 ['JX-Mo', 'SnirBroshi', 'felixpernegger', 'github-actions', 'leanprover-radar', 'mathlib-merge-conflicts'] nobody
14-52680
14 days ago
17-63489
17 days ago
0-58485
16 hours
0
43196 danderson70-UNL
author:danderson70-UNL
doc: add Jacobi Four-Square proof to the list of 1000 theorems ---- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Purpose.20of.201000.2Eyaml/with/633932200 (in the private reviewers stream) new-contributor awaiting-zulip 3/0 docs/1000.yaml 1 6 ['SnirBroshi', 'danderson70-UNL', 'github-actions'] nobody
5-68089
5 days ago
48-55661
48 days ago
36-84896
36 days
0
36934 Parcly-Taxel
author:Parcly-Taxel
refactor: make `Language α` an `abbrev` for `SetSemiring (FreeMonoid α)` Redefine ```lean /-- A language is a `SetSemiring` of strings (elements of `FreeMonoid α`) over an alphabet `α`. -/ abbrev Language (α : Type*) := SetSemiring (FreeMonoid α) ``` The existing instances show that this is both `CompleteAtomicBooleanAlgebra` and `IdemSemiring`. t-computability tech debt large-import awaiting-zulip 313/320 Mathlib/Algebra/FreeMonoid/Basic.lean,Mathlib/Computability/ContextFreeGrammar.lean,Mathlib/Computability/DFA.lean,Mathlib/Computability/EpsilonNFA.lean,Mathlib/Computability/Language.lean,Mathlib/Computability/MyhillNerode.lean,Mathlib/Computability/NFA.lean,Mathlib/Computability/RegularExpressions.lean,Mathlib/Data/Set/Semiring.lean 9 50 ['Parcly-Taxel', 'SnirBroshi', 'YaelDillies', 'ctchou', 'eric-wieser', 'github-actions', 'mathlib-merge-conflicts'] YaelDillies
assignee:YaelDillies
5-30775
5 days ago
17-14567
17 days ago
15-62700
15 days
0
45802 vihdzp
author:vihdzp
refactor: dualize `ScottContinuous` predicate The idea is that `InfScottContinuous` can be used for the property of preserving infima of nonempty sets in a linear order. See [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/ScottContinuous.20and.20LeftOrdContinuous/near/637456525). --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-order awaiting-zulip 232/131 Mathlib/Order/Bounds/Basic.lean,Mathlib/Order/Bounds/Image.lean,Mathlib/Order/CompletePartialOrder.lean,Mathlib/Order/OmegaCompletePartialOrder.lean,Mathlib/Order/ScottContinuity.lean,Mathlib/Order/ScottContinuity/Complete.lean,Mathlib/Order/ScottContinuity/Prod.lean,Mathlib/Topology/OmegaCompletePartialOrder.lean,Mathlib/Topology/Order/ScottTopology.lean 9 5 ['SnirBroshi', 'YaelDillies', 'github-actions'] YaelDillies
assignee:YaelDillies
4-63101
4 days ago
7-12960
7 days ago
6-34061
6 days
0
44494 SnirBroshi
author:SnirBroshi
chore(RingTheory/Ideal): `ltSeries` -> `ltseries` The constant is named `LTSeries`, and the conventions are to lowercase the initial uppercase streak. --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Lowercasing.20the.20initial.20sequence.20of.20caps <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-ring-theory awaiting-zulip merge-conflict 28/12 Mathlib/RingTheory/Ideal/GoingDown.lean,Mathlib/RingTheory/Ideal/GoingUp.lean,Mathlib/RingTheory/Ideal/HasGoingUp.lean,Mathlib/RingTheory/Ideal/Height.lean,Mathlib/RingTheory/Ideal/KrullsHeightTheorem.lean,Mathlib/RingTheory/KrullDimension/Regular.lean,Mathlib/RingTheory/Spectrum/Prime/LTSeries.lean 7 6 ['SnirBroshi', 'github-actions', 'mathlib-merge-conflicts', 'themathqueen'] nobody
4-14433
4 days ago
48-4114
48 days ago
0-45675
12 hours
0
39233 wrenna-robson
author:wrenna-robson
refactor: rename `Pi.map` to `Function.piMap` This PR renames `Pi.map` to `Function.piMap` and makes the changes necessary to support this. In particular this means that Mathlib.Logic.Function.Defs now only contains the Function namespace. The name `Function.piMap` (rather than `Function.map`) keeps it consistent with the existing `*.piMap` names: the bundled versions `MulHom.piMap`, `MonoidHom.piMap`, `LinearMap.piMap`, `ContinuousLinearMap.piMap`, and the predicate lemmas `Function.Injective.piMap`, `Continuous.piMap`, `IsFixedPt.piMap` etc. Renames (all with deprecated aliases): - `Pi.map` → `Function.piMap` - `Pi.map_apply` → `Function.piMap_apply` - `Pi.map_id` → `Function.piMap_id` - `Pi.map_id'` → `Function.piMap_id'` - `Pi.map_comp_map` → `Function.piMap_comp_piMap` - `Pi.map_injective` → `Function.piMap_injective` - `Pi.map_update` → `Function.piMap_update` - `Pi.map_iterate` → `Function.piMap_iterate` New: `Function.piMap_def`, `Function.piMap_const`. Zulip thread: [#PR reviews > #39233 - rename Pi.map to Function.map @ 💬](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2339233.20-.20rename.20Pi.2Emap.20to.20Function.2Emap/near/594605689) ------ - [ ] awaiting-zulip: [#PR reviews > #39233 - rename Pi.map to Function.map @ 💬](https://leanprover.zulipchat.com/#narrow/channel/144837-PR-reviews/topic/.2339233.20-.20rename.20Pi.2Emap.20to.20Function.2Emap/near/594605689) General discussion regarding the Pi namespace: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/The.20Pi.20namespace/near/594782721 --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) awaiting-zulip t-data merge-conflict 139/127 Mathlib/Algebra/Category/Grp/AB.lean,Mathlib/Algebra/Group/Pi/Hom.lean,Mathlib/Algebra/Order/Antidiag/Nat.lean,Mathlib/Algebra/Regular/Pi.lean,Mathlib/Analysis/InnerProductSpace/Coalgebra.lean,Mathlib/Analysis/SpecialFunctions/PolarCoord.lean,Mathlib/Condensed/Discrete/LocallyConstant.lean,Mathlib/Control/Bifunctor.lean,Mathlib/Data/Finset/Powerset.lean,Mathlib/Data/Prod/Basic.lean,Mathlib/Data/Set/Prod.lean,Mathlib/Dynamics/Ergodic/MeasurePreserving.lean,Mathlib/Dynamics/PeriodicPts/Defs.lean,Mathlib/Dynamics/PeriodicPts/Lemmas.lean,Mathlib/Dynamics/TopologicalEntropy/Semiconj.lean,Mathlib/FieldTheory/Perfect.lean,Mathlib/Geometry/Manifold/IsManifold/Basic.lean,Mathlib/Geometry/Manifold/IsManifold/ExtChartAt.lean,Mathlib/GroupTheory/MonoidLocalization/Lemmas.lean,Mathlib/LinearAlgebra/Multilinear/Basis.lean,Mathlib/LinearAlgebra/Pi.lean,Mathlib/Logic/Equiv/Basic.lean,Mathlib/Logic/Equiv/PartialEquiv.lean,Mathlib/Logic/Function/Basic.lean,Mathlib/Logic/Function/Defs.lean,Mathlib/Logic/Function/Iterate.lean,Mathlib/NumberTheory/NumberField/InfiniteAdeleRing.lean,Mathlib/Order/Filter/Cofinite.lean,Mathlib/Order/Filter/Pi.lean,Mathlib/RingTheory/Coalgebra/Basic.lean,Mathlib/Topology/Algebra/FilterBasis.lean,Mathlib/Topology/Algebra/Module/ContinuousLinearMap/PiProd.lean,Mathlib/Topology/Algebra/RestrictedProduct/TopologicalSpace.lean,Mathlib/Topology/Constructions.lean,Mathlib/Topology/Maps/Basic.lean,Mathlib/Topology/MetricSpace/HausdorffAlexandroff.lean,Mathlib/Topology/MetricSpace/Isometry.lean,Mathlib/Topology/NhdsWithin.lean 38 8 ['github-actions', 'mathlib-merge-conflicts', 'themathqueen', 'wrenna-robson'] nobody
3-13919
3 days ago
193-78284
193 days ago
0-7302
2 hours
0
44493 SnirBroshi
author:SnirBroshi
chore(Algebra/Category/FGModuleCat/Basic): `fgModuleCat` -> `fgmoduleCat` The constant is named `FGModuleCat`, and the conventions are to lowercase the initial uppercase streak. --- - [ ] awaiting-zulip: https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/Lowercasing.20the.20initial.20sequence.20of.20caps <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-algebra t-category-theory awaiting-zulip merge-conflict
label:t-algebra$
28/8 Mathlib/Algebra/Category/FGModuleCat/Basic.lean 1 8 ['SnirBroshi', 'github-actions', 'joelriou', 'mathlib-merge-conflicts', 'themathqueen'] nobody
3-7344
3 days ago
48-16514
48 days ago
0-33285
9 hours
0
42692 Parcly-Taxel
author:Parcly-Taxel
refactor: unify `Set.mem_ofPred_eq` into `Set.mem_ofPred` Before: ```lean @[simp, mfld_simps, push] theorem mem_ofPred_eq {x : α} {p : α → Prop} : (x ∈ {y | p y}) = p x := rfl theorem mem_ofPred {a : α} {p : α → Prop} : a ∈ { x | p x } ↔ p a := Iff.rfl ``` After: ```lean @[simp, mfld_simps, push] theorem mem_ofPred {x : α} {p : α → Prop} : (x ∈ {y | p y}) = p x := rfl @[deprecated (since := "2026-08-12")] alias mem_ofPred_eq := mem_ofPred ``` Note that the lemma with iff is unusable by `dsimp`. ---- - [ ] awaiting-zulip: [#mathlib4 > Set.mem_setOf_eq @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Set.2Emem_setOf_eq/near/617487671) tech debt awaiting-zulip 995/998 Archive/Imo/Imo1988Q6.lean,Archive/Imo/Imo2008Q2.lean,Archive/Imo/Imo2024Q3.lean,Archive/Sensitivity.lean,Archive/Wiedijk100Theorems/AreaOfACircle.lean,Archive/Wiedijk100Theorems/BallotProblem.lean,Archive/Wiedijk100Theorems/CubingACube.lean,Counterexamples/AharoniKorman.lean,Counterexamples/Phillips.lean,Counterexamples/SorgenfreyLine.lean,Mathlib/Algebra/AffineMonoid/Irreducible.lean,Mathlib/Algebra/Algebra/NonUnitalSubalgebra.lean,Mathlib/Algebra/Algebra/Spectrum/Pi.lean,Mathlib/Algebra/Algebra/Spectrum/Quasispectrum.lean,Mathlib/Algebra/Algebra/Subalgebra/Basic.lean,Mathlib/Algebra/BigOperators/Associated.lean,Mathlib/Algebra/Category/Ring/Topology.lean,Mathlib/Algebra/Group/Subgroup/Basic.lean,Mathlib/Algebra/Group/Submonoid/Basic.lean,Mathlib/Algebra/Group/Submonoid/Defs.lean,Mathlib/Algebra/GroupWithZero/NonZeroDivisors.lean,Mathlib/Algebra/Homology/HomotopyCategory/HomComplexCohomology.lean,Mathlib/Algebra/Lie/Abelian.lean,Mathlib/Algebra/Lie/Basis/Base.lean,Mathlib/Algebra/Lie/Basis/Basic.lean,Mathlib/Algebra/Lie/Character.lean,Mathlib/Algebra/Lie/IdealOperations.lean,Mathlib/Algebra/Lie/InvariantForm.lean,Mathlib/Algebra/Lie/LieTheorem.lean,Mathlib/Algebra/Lie/Semisimple/Basic.lean,Mathlib/Algebra/Lie/Solvable.lean,Mathlib/Algebra/Lie/Subalgebra.lean,Mathlib/Algebra/Lie/Submodule.lean,Mathlib/Algebra/Lie/Weights/Cartan.lean,Mathlib/Algebra/Lie/Weights/Killing.lean,Mathlib/Algebra/Module/Submodule/Invariant.lean,Mathlib/Algebra/Module/ZLattice/Basic.lean,Mathlib/Algebra/Module/ZLattice/Covolume.lean,Mathlib/Algebra/Notation/Support.lean,Mathlib/Algebra/Order/Antidiag/Nat.lean,Mathlib/Algebra/Order/Archimedean/IndicatorCard.lean,Mathlib/Algebra/Order/CompleteField.lean,Mathlib/Algebra/Order/Group/Ideal.lean,Mathlib/Algebra/Order/Group/Pointwise/Interval.lean,Mathlib/Algebra/Order/Quantale.lean,Mathlib/Algebra/Order/Rearrangement.lean,Mathlib/Algebra/Polynomial/EraseLead.lean,Mathlib/Algebra/Polynomial/Laurent/Roots.lean,Mathlib/Algebra/Star/Unitary.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Affine/Point.lean,Mathlib/AlgebraicGeometry/Morphisms/Affine.lean,Mathlib/AlgebraicGeometry/ProjectiveSpectrum/Topology.lean,Mathlib/AlgebraicTopology/SimplicialSet/Boundary.lean,Mathlib/AlgebraicTopology/SimplicialSet/Simplices.lean,Mathlib/AlgebraicTopology/SimplicialSet/StdSimplex.lean,Mathlib/Analysis/Analytic/Composition.lean,Mathlib/Analysis/Analytic/Constructions.lean,Mathlib/Analysis/Analytic/Inverse.lean,Mathlib/Analysis/Analytic/Order.lean,Mathlib/Analysis/Asymptotics/Lemmas.lean,Mathlib/Analysis/BoxIntegral/Basic.lean,Mathlib/Analysis/BoxIntegral/Partition/Filter.lean,Mathlib/Analysis/BoxIntegral/Partition/Split.lean,Mathlib/Analysis/BoxIntegral/UnitPartition.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Continuity.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Order.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Range.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Unitary.lean,Mathlib/Analysis/CStarAlgebra/Extreme.lean,Mathlib/Analysis/CStarAlgebra/Spectrum.lean,Mathlib/Analysis/CStarAlgebra/Unitary/Connected.lean,Mathlib/Analysis/Calculus/BumpFunction/SmoothApprox.lean,Mathlib/Analysis/Calculus/Deriv/Inv.lean,Mathlib/Analysis/Calculus/FDeriv/Measurable.lean,Mathlib/Analysis/Calculus/FDeriv/Symmetric.lean,Mathlib/Analysis/Calculus/LineDeriv/Basic.lean,Mathlib/Analysis/Calculus/ParametricIntegral.lean,Mathlib/Analysis/Calculus/SmoothSeries.lean,Mathlib/Analysis/Calculus/TangentCone/Basic.lean,Mathlib/Analysis/Complex/AbelLimit.lean,Mathlib/Analysis/Complex/Basic.lean,Mathlib/Analysis/Complex/BorelCaratheodory.lean,Mathlib/Analysis/Complex/PhragmenLindelof.lean,Mathlib/Analysis/Convex/Caratheodory.lean,Mathlib/Analysis/Convex/Combination.lean,Mathlib/Analysis/Convex/Deriv.lean,Mathlib/Analysis/Convex/DoublyStochasticMatrix.lean,Mathlib/Analysis/Convex/Extrema.lean,Mathlib/Analysis/Convex/Gauge.lean,Mathlib/Analysis/Convex/Quasiconvex.lean,Mathlib/Analysis/Convex/Segment.lean,Mathlib/Analysis/Convex/SimplicialComplex/AffineIndependentUnion.lean,Mathlib/Analysis/Convex/StdSimplex.lean,Mathlib/Analysis/Distribution/TemperateGrowth.lean,Mathlib/Analysis/InnerProductSpace/Defs.lean,Mathlib/Analysis/InnerProductSpace/LinearPMap.lean,Mathlib/Analysis/LocallyConvex/BalancedCoreHull.lean,Mathlib/Analysis/LocallyConvex/Polar.lean,Mathlib/Analysis/Matrix/Order.lean,Mathlib/Analysis/MeanInequalities.lean 516 58 ['Parcly-Taxel', 'eric-wieser', 'github-actions', 'grunweg', 'mathlib-merge-conflicts'] nobody
2-45635
2 days ago
48-11416
48 days ago
8-929
8 days
0
45028 YaelDillies
author:YaelDillies
chore: rename `notation3` to `notation +delab` This makes it extremely clear what `notation3` does on top of `notation`. For notations with precedence, the precedence comes before the `+delab`, e.g. `notation:25 +delab ...`. This rename isn't completely true to the purpose of the elaborator, which is instead to provide Lean 3's `notation` features. Indeed, `notation3` currently has a `(prettyPrint := false)` flag when a delaborator cannot/shouldn't be generated. I am removing this flag because `notation +delab (prettyPrint := false)` would read very weird: "Please generate a delaborator, but don't pretty-print!". Only one notation in mathlib uses this flag, namely cycle notation `c[...]`. It cannot have a delaborator generated due to the use of `by decide` in the expansion. Although `notation +delab` could be fixed to generate a delaborator in this case even (see #45042), I think it is reasonable to say that this rare use-case is unsupported. I am performing a few auxiliary changes too: * Update the docstring of `notation +delab` to clarify that it is not deprecated anymore. * Add a missing space in the `notation +delab` notation, so that `polishPP` needn't add it after the fact. * Rename the file from `Util.Notation3` to `Util.NotationDelab`. * Rename the trace option from `trace.notation3` to `trace.notationDelab`. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60) Generated by Claude Sonnet/Opus in ~10 prompts, then reviewed line-by-line by myself and hand-edited a bit further. Assisted-by: Claude Sonnet 5.5, Claude Opus 5.5 --- - [ ] awaiting-zulip: [Zulip](https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/status.20of.20.60notation3.60) <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> - [x] depends on: #45041 file-removed LLM-generated awaiting-zulip tech debt 459/403 Archive/RiemannStieltjes.lean,Counterexamples/AharoniKorman.lean,Mathlib.lean,Mathlib/Algebra/BigOperators/Finprod.lean,Mathlib/Algebra/Category/Grp/EpiMono.lean,Mathlib/Algebra/DirectSum/Basic.lean,Mathlib/Algebra/Group/Action/Opposite.lean,Mathlib/Algebra/Lie/Weights/Basic.lean,Mathlib/Algebra/Module/Equiv/Defs.lean,Mathlib/Algebra/Module/LinearMap/Defs.lean,Mathlib/Algebra/Order/GroupWithZero/Basic.lean,Mathlib/Algebra/Order/GroupWithZero/Defs.lean,Mathlib/Algebra/Order/Nonneg/Module.lean,Mathlib/Algebra/Polynomial/Bivariate.lean,Mathlib/Algebra/Polynomial/CoeffMem.lean,Mathlib/AlgebraicGeometry/AffineSpace.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Jacobian/Basic.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Jacobian/Formula.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Jacobian/Point.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Projective/Basic.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Projective/Formula.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Projective/Point.lean,Mathlib/AlgebraicGeometry/Gluing.lean,Mathlib/AlgebraicGeometry/Modules/Sheaf.lean,Mathlib/AlgebraicGeometry/OpenImmersion.lean,Mathlib/AlgebraicGeometry/ProjectiveSpectrum/Scheme.lean,Mathlib/AlgebraicGeometry/ProjectiveSpectrum/StructureSheaf.lean,Mathlib/AlgebraicGeometry/Scheme.lean,Mathlib/AlgebraicTopology/SimplicialObject/Basic.lean,Mathlib/AlgebraicTopology/SimplicialSet/Boundary.lean,Mathlib/AlgebraicTopology/SimplicialSet/Horn.lean,Mathlib/AlgebraicTopology/SimplicialSet/StdSimplex.lean,Mathlib/Analysis/Calculus/ContDiff/FTaylorSeries.lean,Mathlib/Analysis/Fourier/RiemannLebesgueLemma.lean,Mathlib/Analysis/RCLike/Inner.lean,Mathlib/Analysis/SpecialFunctions/Elliptic/Weierstrass.lean,Mathlib/Basic/ENNReal/Basic.lean,Mathlib/CategoryTheory/Enriched/Basic.lean,Mathlib/CategoryTheory/Monoidal/PushoutProduct.lean,Mathlib/CategoryTheory/Shift/Basic.lean,Mathlib/Combinatorics/Additive/DoublingConst.lean,Mathlib/Combinatorics/Additive/Energy.lean,Mathlib/Combinatorics/SimpleGraph/Regularity/Bound.lean,Mathlib/Combinatorics/SimpleGraph/Regularity/Chunk.lean,Mathlib/Combinatorics/SimpleGraph/Regularity/Increment.lean,Mathlib/Data/DFinsupp/Defs.lean,Mathlib/Data/Quot.lean,Mathlib/Data/Set/Notation.lean,Mathlib/Data/Sym/Sym2.lean,Mathlib/FieldTheory/JacobsonNoether.lean,Mathlib/FieldTheory/KummerExtension.lean,Mathlib/Geometry/Convex/Cone/Dual.lean,Mathlib/Geometry/Convex/Cone/Pointed.lean,Mathlib/Geometry/Manifold/Diffeomorph.lean,Mathlib/Geometry/Manifold/Instances/Real.lean,Mathlib/GroupTheory/Perm/Cycle/Concrete.lean,Mathlib/LinearAlgebra/AffineSpace/AffineSubspace/Defs.lean,Mathlib/LinearAlgebra/PiTensorProduct/Basic.lean,Mathlib/LinearAlgebra/TensorPower/Symmetric.lean,Mathlib/MeasureTheory/Function/SimpleFuncDenseLp.lean,Mathlib/MeasureTheory/Integral/Average.lean,Mathlib/MeasureTheory/Integral/Bochner/Basic.lean,Mathlib/MeasureTheory/Integral/CircleIntegral.lean,Mathlib/MeasureTheory/Integral/CurveIntegral/Basic.lean,Mathlib/MeasureTheory/Integral/IntervalAverage.lean,Mathlib/MeasureTheory/Integral/IntervalIntegral/Basic.lean,Mathlib/MeasureTheory/Integral/Lebesgue/Basic.lean,Mathlib/MeasureTheory/Integral/Marginal.lean,Mathlib/MeasureTheory/Integral/TorusIntegral.lean,Mathlib/MeasureTheory/Measure/MeasureSpaceDef.lean,Mathlib/MeasureTheory/OuterMeasure/AE.lean,Mathlib/MeasureTheory/VectorMeasure/Integral.lean,Mathlib/MeasureTheory/VectorMeasure/Order.lean,Mathlib/NumberTheory/FLT/Three.lean,Mathlib/NumberTheory/NumberField/CMField.lean,Mathlib/NumberTheory/NumberField/Cyclotomic/Ideal.lean,Mathlib/NumberTheory/NumberField/Cyclotomic/Three.lean,Mathlib/NumberTheory/RamificationInertia/Unramified.lean,Mathlib/NumberTheory/SiegelsLemma.lean,Mathlib/Order/Filter/Defs.lean,Mathlib/Order/Filter/FilterProduct.lean,Mathlib/Order/InitialSeg.lean,Mathlib/Order/PSigma.lean,Mathlib/Order/PiLex.lean,Mathlib/Order/SetNotation.lean,Mathlib/Order/Sigma.lean,Mathlib/Order/Sum/Order.lean,Mathlib/Probability/ConditionalProbability.lean,Mathlib/Probability/Distributions/Binomial.lean,Mathlib/Probability/Distributions/Poisson/Basic.lean,Mathlib/Probability/Independence/Basic.lean,Mathlib/Probability/Independence/Conditional.lean,Mathlib/Probability/Process/Indistinguishable.lean,Mathlib/RingTheory/Coalgebra/CoassocSimps.lean,Mathlib/RingTheory/Coalgebra/IsFrobenius.lean,Mathlib/RingTheory/Coalgebra/TensorProduct.lean,Mathlib/RingTheory/DedekindDomain/Instances.lean,Mathlib/RingTheory/Finiteness/Basic.lean,Mathlib/RingTheory/Kaehler/Basic.lean,Mathlib/RingTheory/NoetherNormalization.lean 122 20 ['TwoFX', 'YaelDillies', 'github-actions', 'grunweg', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'mathlib-splicebot'] nobody
1-85476
1 day ago
33-83558
33 days ago
0-6611
1 hour
0
45284 JX-Mo
author:JX-Mo
feat(Algebra/RingTheory/Center): add `Center` as a type We propose a canonical type `Center` attached to any magma (a type `M` with `Mul M`), providing an alternative approach unifying various center subtypes API. The main engineer work is to equip `Center` with the correct instance for variant `[foo M]` and we end up with `rfl` for all desired simp lemmas, no diamond. We also provide some functoriality for `Foo = Monoid/Ring/Alg` 1) `Center.fooHom` for the embedding 2) `FooEquiv.toCenter` for restricring isomorphisms to their centers Update: it turns out that we need `Subgroup.center` crucially and `Subring.center` for `DivisionRing`. Others can probably switch ot `Center` without pain if we ever want. Zulip discussion: [#mathlib4 > Center unification @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Center.20unification/near/634714255) --- - [ ] awaiting-zulip: [#mathlib4 > Center unification @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Center.20unification/near/634714255) t-ring-theory WIP awaiting-zulip 379/111 Mathlib/Algebra/Algebra/Basic.lean,Mathlib/Algebra/Algebra/Subalgebra/Basic.lean,Mathlib/Algebra/Group/Center.lean,Mathlib/Algebra/Ring/CentroidHom.lean,Mathlib/Algebra/Ring/Subring/Basic.lean,Mathlib/Algebra/Ring/Subsemiring/Basic.lean,Mathlib/Algebra/Star/Center.lean,Mathlib/Algebra/Star/CentroidHom.lean,Mathlib/Algebra/Star/NonUnitalSubalgebra.lean,Mathlib/Algebra/Star/NonUnitalSubsemiring.lean,Mathlib/GroupTheory/Subgroup/Center.lean,Mathlib/GroupTheory/Submonoid/Center.lean,Mathlib/GroupTheory/Subsemigroup/Center.lean,Mathlib/RingTheory/NonUnitalSubring/Basic.lean,Mathlib/RingTheory/NonUnitalSubsemiring/Basic.lean 15 12 ['JX-Mo', 'github-actions', 'leanprover-radar', 'mathlib-merge-conflicts'] nobody
1-66043
1 day ago
27-63517
27 days ago
0-1336
22 minutes
0

PRs on the review queue labelled 'tech debt' or 'longest-pole'

Number Author Title Description Labels +/- Modified files (first 100) 📝 💬 All users who commented or reviewed Assignee(s) Updated Last status change total time in review blocks
44040 kim-em
author:kim-em
chore: adaptation notes for the backward.privateInPublic uses blocked on lean4#14708 This PR adds an `#adaptation_note` at each `variable` declaration with an autoParam binder whose users need `backward.privateInPublic`. These uses (about 80 of the remaining option lines, in 14 files) are not removable on the Mathlib side: the autoParam helper declaration generated for a `variable` is always private, and any declaration using that variable in a public section silently elaborates to `sorry` without the option. This is https://github.com/leanprover/lean4/issues/14708. The note says which `set_option`s can go once that is fixed, and stops anyone from spending time on them before then. Each affected file was checked by removing its `true`-only option lines and observing the `sorry` warnings and the follow-on `autoParam … is not a constant` errors. It also deletes the one option line in `CategoryTheory/SmallObject/Iteration/ExtendToSucc` that turned out to be unnecessary. 🤖 Prepared with Claude Code tech debt LLM-generated 116/0 Mathlib/Algebra/Module/ZLattice/Covolume.lean,Mathlib/AlgebraicTopology/SimplicialSet/CompStruct.lean,Mathlib/AlgebraicTopology/SimplicialSet/StrictSegal.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/NonUnital.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Unital.lean,Mathlib/Analysis/Distribution/TemperedDistribution.lean,Mathlib/CategoryTheory/ComposableArrows/Basic.lean,Mathlib/CategoryTheory/Join/Basic.lean,Mathlib/CategoryTheory/Limits/Shapes/Reflexive.lean,Mathlib/CategoryTheory/LocallyCartesianClosed/ChosenPullbacksAlong.lean,Mathlib/CategoryTheory/Monoidal/Braided/Basic.lean,Mathlib/CategoryTheory/Monoidal/CommGrp_.lean,Mathlib/CategoryTheory/Monoidal/Functor.lean,Mathlib/CategoryTheory/Sites/Point/Basic.lean,Mathlib/CategoryTheory/SmallObject/Iteration/ExtendToSucc.lean 15 1 ['github-actions'] nobody
45-53355
1 month ago
61-45175
61 days ago
61-46347
61 days
0
43885 plp127
author:plp127
refactor: reduce defeq abuse in `Representation.asModule` Reduce defeq abuse around `Representation.asModule` by adding explicitly uses of `Representation.asModuleEquiv` to convert between `V` and `ρ.asModule`. Also reorganize some `@[simp]` lemmas and fix some naming issues. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-algebra tech debt
label:t-algebra$
70/89 Mathlib/RepresentationTheory/Basic.lean,Mathlib/RepresentationTheory/Intertwining.lean,Mathlib/RepresentationTheory/Rep/Iso.lean,Mathlib/RepresentationTheory/Submodule.lean,Mathlib/RepresentationTheory/Subrepresentation.lean 5 21 ['JX-Mo', 'github-actions', 'plp127'] nobody
41-45907
1 month ago
62-66978
62 days ago
66-62820
66 days
0
44712 plp127
author:plp127
chore: rename arguments to `Shrink.rec` Name the motive `motive` and name the minor premises according to their contents. While we're here, also unexpose `Shrink.rec`, which is the last exposed declaration in this file, so also remove the `@[expose]` from the `@[expose] public section` at the top of the file because none of the declarations are actually exposed. Also add a docstring. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> tech debt t-logic 10/10 Mathlib/Logic/Small/Defs.lean,scripts/nolints.json 2 2 ['github-actions', 'vihdzp'] nobody
41-27457
1 month ago
42-54414
42 days ago
42-54401
42 days
0
42561 SnirBroshi
author:SnirBroshi
feat(Order/RelSeries): order series by refinement Define a partial order on `RelSeries`, add basic lemmas for the operations (e.g. `p < p.append q`), and relate to `IsChain` on sets. This lets us spell "maximal chain" using series. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) tech debt t-order 151/5 Mathlib/Order/RelSeries.lean 1 2 ['github-actions', 'mathlib-merge-conflicts'] nobody
26-62447
26 days ago
26-64642
26 days ago
106-24762
106 days
0
45450 mcdoll
author:mcdoll
chore(NumberTheory): replace anonymous constructor by .mk in `ArithmeticFunction` --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-number-theory tech debt 24/27 Mathlib/NumberTheory/ArithmeticFunction/Defs.lean,Mathlib/NumberTheory/ArithmeticFunction/LFunction.lean,Mathlib/NumberTheory/ArithmeticFunction/Misc.lean,Mathlib/NumberTheory/ArithmeticFunction/Moebius.lean,Mathlib/NumberTheory/ArithmeticFunction/VonMangoldt.lean,Mathlib/NumberTheory/ArithmeticFunction/Zeta.lean,Mathlib/NumberTheory/LSeries/Convolution.lean 7 1 ['github-actions'] nobody
24-45355
24 days ago
24-46034
24 days ago
24-46021
24 days
0
45392 vihdzp
author:vihdzp
chore: state Borel isomorphism theorem using `Uncountable` We also deprecate the specialization of it to `ℕ → Bool`, after proving the instance that allows to infer the uncountability of this type automatically. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-measure-probability tech debt 53/25 Mathlib/Basic/Countable/Defs.lean,Mathlib/LinearAlgebra/Dimension/ErdosKaplansky.lean,Mathlib/MeasureTheory/Constructions/Polish/Basic.lean,Mathlib/MeasureTheory/Constructions/Polish/EmbeddingReal.lean,Mathlib/SetTheory/Cardinal/Basic.lean,Mathlib/SetTheory/Cardinal/Finite.lean 6 1 ['github-actions'] nobody
24-22293
24 days ago
25-30533
25 days ago
25-37937
25 days
0
44363 Parcly-Taxel
author:Parcly-Taxel
chore: remove `set_option` in `Order.Nucleus` tech debt t-order 7/15 Mathlib/Order/Nucleus.lean 1 13 ['Parcly-Taxel', 'github-actions', 'grunweg', 'mathlib-merge-conflicts', 'mathlib-splicebot'] nobody
24-9409
24 days ago
25-9602
25 days ago
50-67642
50 days
0
44584 CBirkbeck
author:CBirkbeck
chore(AlgebraicTopology/FundamentalGroupoid): deprecate `transReflReparamAux` in favor of `qRight` Deprecate `Path.Homotopy.transReflReparamAux` and its lemmas: the function is `fun t ↦ unitInterval.qRight (t, 0)`, which `trans_refl_reparam` and `transRefl` now use. --- <!--redteam:v1 {"owner":"AI-DOOM-97fce5ac-e255-4515-b311-12ecf245ce72","findings":["RT-20261006-546cb9"],"patterns":["parallel-reparametrisation-helper"],"severity":"MAJOR"}--> 🤖 Generated with [Claude Code](https://claude.com/claude-code) t-algebraic-topology tech debt LLM-generated 10/12 Mathlib/AlgebraicTopology/FundamentalGroupoid/Basic.lean 1 1 ['github-actions', 'tb65536'] nobody
20-568
20 days ago
22-79730
22 days ago
22-79717
22 days
0
45742 vihdzp
author:vihdzp
chore: recursor for `SignType` using the simp-normal forms --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> Co-authored by @plp127 tech debt t-data 39/10 Mathlib/Basic/Sign/Basic.lean,Mathlib/Basic/Sign/Defs.lean,Mathlib/Data/EReal/Inv.lean 3 1 ['github-actions'] nobody
15-63897
15 days ago
15-66543
15 days ago
15-66530
15 days
0
45849 Whysoserioushah
author:Whysoserioushah
chore(Topology/Sheaves/Stalks): add implicit_reducible to stalk Extracted from [Stacks Project](https://github.com/AxiomMath/Stacks) formalization. co-authored-by: Axiom Formalization team --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> tech debt 4/9 Mathlib/Geometry/RingedSpace/PresheafedSpace.lean,Mathlib/Geometry/RingedSpace/Stalks.lean,Mathlib/Topology/Sheaves/Stalks.lean 3 1 ['github-actions'] nobody
12-61612
12 days ago
12-66742
12 days ago
12-66729
12 days
0
45889 vihdzp
author:vihdzp
refactor: rename `Cardinal.lt_aleph0_iff_finite` → `Cardinal.mk_lt_aleph0_iff` I claim that the older name is not good, since it doesn't mention `Cardinal.mk`. We also rename some similar surrounding theorems. This incidentally gets rid of two duplicate declarations. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-set-theory tech debt 88/94 Mathlib/Algebra/Module/SpanRank.lean,Mathlib/Combinatorics/Matroid/Rank/Cardinal.lean,Mathlib/Data/Set/Finite/Basic.lean,Mathlib/Data/W/Cardinal.lean,Mathlib/FieldTheory/CardinalEmb.lean,Mathlib/FieldTheory/FinTrdeg.lean,Mathlib/FieldTheory/Finiteness.lean,Mathlib/FieldTheory/IsAlgClosed/Classification.lean,Mathlib/LinearAlgebra/Dimension/ErdosKaplansky.lean,Mathlib/LinearAlgebra/Dimension/Finite.lean,Mathlib/LinearAlgebra/Dimension/FreeAndStrongRankCondition.lean,Mathlib/LinearAlgebra/Dimension/StrongRankCondition.lean,Mathlib/LinearAlgebra/FiniteDimensional/Basic.lean,Mathlib/ModelTheory/Algebra/Field/IsAlgClosed.lean,Mathlib/ModelTheory/Satisfiability.lean,Mathlib/Order/Filter/CardinalInter.lean,Mathlib/Order/Filter/Cocardinal.lean,Mathlib/RingTheory/Algebraic/Cardinality.lean,Mathlib/SetTheory/Cardinal/Basic.lean,Mathlib/SetTheory/Cardinal/CountableCover.lean,Mathlib/SetTheory/Cardinal/Finite.lean,Mathlib/SetTheory/Cardinal/Finsupp.lean,Mathlib/SetTheory/Cardinal/Subfield.lean,Mathlib/SetTheory/Ordinal/Basic.lean 24 1 ['github-actions'] nobody
11-26365
11 days ago
11-26404
11 days ago
11-26442
11 days
0
43045 plp127
author:plp127
feat: `Dyadic` is a localization Prove that `Dyadic` is a localization of the integers generated by inverting `2`. --- - [x] depends on: #43038 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-data tech debt 97/0 Mathlib.lean,Mathlib/Data/Dyadic/IsLocalization.lean 2 13 ['github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'metakunt', 'plp127', 'vihdzp'] nobody
10-37178
10 days ago
11-67401
11 days ago
11-67715
11 days
0
44026 kim-em
author:kim-em
chore: remove backward.privateInPublic in category theory, topology and analysis This PR removes the `backward.privateInPublic` option in 6 files across category theory, topology and analysis. In each case a private definition appeared in the statement of a public declaration, so it was already part of the public interface in all but name. The fix is to drop `private` from those definitions (and from the auxiliary definitions their bodies depend on in exposed sections), adding docstrings where they were missing. In `Analysis/InnerProductSpace/OfNorm` the auxiliary inner product `inner_` moves into the `InnerProductSpaceable` namespace rather than becoming a root-level name; the public lemmas `inner_.norm_sq`, `inner_.conj_symm` and `Continuous.inner_` already carried its name. In `Topology/Category/Compactum` the helper `cl` gets a mathematical docstring, and the two lemmas about it that are only used in proofs stay private. Files where a private *lemma* appeared in a public statement, and the files with file-wide `public section` restructuring, are handled in #44032. Names are otherwise kept as they were; suggestions for better names are welcome but are not needed for this PR. 🤖 Prepared with Claude Code tech debt 19/63 Mathlib/Analysis/InnerProductSpace/OfNorm.lean,Mathlib/CategoryTheory/Monoidal/Internal/FunctorCategory.lean,Mathlib/FieldTheory/Galois/Profinite.lean,Mathlib/Topology/Category/Compactum.lean,Mathlib/Topology/Category/TopCat/Limits/Konig.lean,Mathlib/Topology/MetricSpace/GromovHausdorff.lean 6 3 ['github-actions', 'jjdishere'] nobody
7-77494
7 days ago
62-28591
62 days ago
62-28578
62 days
0
37279 imalinowskip
author:imalinowskip
feat(Probability): multivariate CLT --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> <!-- [ ] depends on: #40345 --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) new-contributor t-measure-probability tech debt 210/18 Mathlib/MeasureTheory/Function/ConvergenceInDistribution.lean,Mathlib/MeasureTheory/Function/StronglyMeasurable/AEStronglyMeasurable.lean,Mathlib/MeasureTheory/Function/StronglyMeasurable/Basic.lean,Mathlib/MeasureTheory/Integral/Bochner/Basic.lean,Mathlib/MeasureTheory/Measure/LevyConvergence.lean,Mathlib/MeasureTheory/Measure/ProbabilityMeasure.lean,Mathlib/Probability/CentralLimitTheorem.lean,Mathlib/Probability/CramerWold.lean,Mathlib/Probability/Distributions/Gaussian/Multivariate.lean,Mathlib/Probability/Moments/Variance.lean 10 66 ['EtienneC30', 'RemyDegenne', 'github-actions', 'imalinowskip', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] EtienneC30
assignee:EtienneC30
7-67526
7 days ago
11-64993
11 days ago
57-19174
57 days
0
45808 vihdzp
author:vihdzp
feat(GroupTheory/Coxeter/Basic): add theorems for `CoxeterMatrix.simple` These match and help golf existing theorems on `CoxeterSystem.simple`. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> I'm unsure on whether we want to be reproving things for `CoxeterMatrix.simple` and `CoxeterSystem.simple`. See [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Design.20of.20Coxeter.20systems/with/638594141). - [x] depends on: #45806 tech debt t-group-theory 42/13 Mathlib/GroupTheory/Coxeter/Basic.lean 1 4 ['github-actions', 'mathlib-dependent-issues', 'wwylele'] nobody
7-20297
7 days ago
11-20010
11 days ago
11-20598
11 days
1
44995 WenrongZou
author:WenrongZou
feat(RingTheory/MvFormalGroup): multivariate formal group definition This PR defines multivariate (including infinite dimensional) formal group laws over a commutative ring `R`. Main definitions: - `MvFormalGroup σ R`: a family `F = (F_i)_{i : σ}` of power series in two sets of variables `X, Y`, with zero constant coefficient, linear term `X_i + Y_i`, and associativity `F(F(X, Y), Z) = F(X, F(Y, Z))`. - `MvFormalGroup.IsComm`: the commutativity condition `F(X, Y) = F(Y, X)`. Main results: - `zero_add`, `add_zero`: `F(0, X) = X` and `F(X, 0) = X`. --- - [x] depends on: #44942 - [x] depends on: #44996 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-ring-theory tech debt 289/0 Mathlib.lean,Mathlib/RingTheory/MvFormalGroup/Basic.lean 2 9 ['WenrongZou', 'github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'wwylele'] nobody
7-16896
7 days ago
8-73467
8 days ago
8-75532
8 days
0
43095 plp127
author:plp127
chore(Data/PFunctor): reduce defeq abuse around `PFunctor.W` Reduce the defeq abuse around `PFunctor.W` by adding some API. --- - [x] depends on: #43056 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-data tech debt 88/52 Mathlib/Data/PFunctor/Multivariate/W.lean,Mathlib/Data/PFunctor/Univariate/Basic.lean,Mathlib/Data/QPF/Univariate/Basic.lean 3 6 ['github-actions', 'mathlib-dependent-issues', 'plp127', 'vihdzp'] nobody
6-38645
6 days ago
79-76374
79 days ago
79-77198
79 days
0
43565 Parcly-Taxel
author:Parcly-Taxel
refactor(Archive/FriendshipGraphs): golf everything Also remove the file's `set_option`s and `@[expose]`. Like #43434, no deprecations are added since this is a leaf file in Archive. tech debt 103/292 Archive/Wiedijk100Theorems/FriendshipGraphs.lean 1 9 ['Parcly-Taxel', 'SnirBroshi', 'github-actions', 'mathlib-merge-conflicts'] jjdishere
assignee:jjdishere
5-45369
5 days ago
14-68068
14 days ago
75-34911
75 days
0
32840 joelriou
author:joelriou
refactor(CategoryTheory): remove the old Ext API As it is now possible to compute `Ext`-groups (defined using the derived category) using an injective resolution #32105 or a projective resolution #32816, the old `Ext` API (based on left derived functors) is removed. --- - [x] depends on: #44124 - [x] depends on: #44190 - [x] depends on: #32816 - [x] depends on: #32105 - [x] depends on: #32814 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-category-theory large-import tech debt 283/29 Mathlib.lean,Mathlib/Algebra/Homology/Embedding/Basic.lean,Mathlib/Algebra/Homology/Embedding/CochainComplex.lean,Mathlib/Algebra/Homology/HomotopyCategory/HomComplexIsStrictlyGE.lean,Mathlib/Algebra/Homology/LinearYonedaObj.lean,Mathlib/Algebra/Homology/LocalCohomology.lean,Mathlib/CategoryTheory/Abelian/Ext.lean,Mathlib/CategoryTheory/Linear/Yoneda.lean,Mathlib/RepresentationTheory/Homological/GroupCohomology/Basic.lean,Mathlib/RepresentationTheory/Homological/Resolution.lean 10 9 ['github-actions', 'joelriou', 'mathlib-bors', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'mathlib4-merge-conflict-bot'] nobody
5-6586
5 days ago
5-7157
5 days ago
27-39534
27 days
0
45931 vihdzp
author:vihdzp
chore(SetTheory/Ordinal/CantorNormalForm): miscellaneous cleanup This PR does a few small things: * Give better names to the arguments of `CNF.rec`, as per our convention on recursors. * Use the `induction` tactic instead of applying `CNF.rec` explicitly. * Generalize `coeff_zero_left` and `coeff_one_left` syntactically, by proving the unapplied versions instead. * Remove a redundant argument from `CNF.opow_mul_add`, and from some theorems that depended on it. * Golf a few other proofs slightly. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> - [x] depends on: #45930 t-set-theory tech debt 79/81 Mathlib/SetTheory/Ordinal/CantorNormalForm.lean 1 2 ['github-actions', 'mathlib-dependent-issues'] nobody
4-82253
4 days ago
5-958
5 days ago
5-1700
5 days
1
41675 joelriou
author:joelriou
feat(AlgebraicTopology): pushout diagrams in the filtration of `Δ[p] ⊗ Δ[1]` This will be used in #42295 in order to construct morphisms from `Δ[p] ⊗ Δ[1]` out of the data of the images of the nondegenerate `(p + 1)`-simplices of `Δ[p] ⊗ Δ[1]`. --- - [x] depends on: #41656 - [x] depends on: #41655 - [x] depends on: #41624 - [x] depends on: #41617 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-algebraic-topology tech debt 244/13 Mathlib/AlgebraicTopology/SimplicialSet/AnodyneExtensions/UnionProd.lean,Mathlib/AlgebraicTopology/SimplicialSet/ProdStdSimplex.lean,Mathlib/AlgebraicTopology/SimplicialSet/ProdStdSimplexOne.lean,Mathlib/AlgebraicTopology/SimplicialSet/StdSimplex.lean,Mathlib/AlgebraicTopology/SimplicialSet/Subcomplex.lean,Mathlib/CategoryTheory/Monoidal/FunctorCategory.lean 6 19 ['github-actions', 'joelriou', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'robin-carlier'] nobody
4-9668
4 days ago
35-75470
35 days ago
75-3195
75 days
2
46055 WenrongZou
author:WenrongZou
chore(MvPowerSeries): avoid `DefEq` abuse In this PR, we try to fix the `backward.isDefEq.respectTransparency` in `MvPowerSeries` folder --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-ring-theory tech debt 70/130 Mathlib/RingTheory/MvPowerSeries/Basic.lean,Mathlib/RingTheory/MvPowerSeries/Equiv.lean,Mathlib/RingTheory/MvPowerSeries/Expand.lean,Mathlib/RingTheory/MvPowerSeries/LinearTopology.lean,Mathlib/RingTheory/MvPowerSeries/Order.lean,Mathlib/RingTheory/MvPowerSeries/PiTopology.lean,Mathlib/RingTheory/MvPowerSeries/Substitution.lean,Mathlib/RingTheory/MvPowerSeries/Trunc.lean 8 1 ['github-actions'] nobody
3-73811
3 days ago
6-52943
6 days ago
6-52930
6 days
0
46180 Nicola9Falciola
author:Nicola9Falciola
chore(Algebra/Module/Submodule/Invariant): remove all the `set_option` in the fille and api This PR removes all the defeq abuse in the file and adds small API lemmas such as the compatibility between `invtSubmodule` and `compatibleMaps`. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-algebra tech debt
label:t-algebra$
21/14 Mathlib/Algebra/Module/Submodule/Invariant.lean 1 8 ['Nicola9Falciola', 'github-actions', 'themathqueen'] nobody
3-67923
3 days ago
3-72006
3 days ago
3-71993
3 days
0
45791 JonasReif
author:JonasReif
chore: remove obsolete proof workarounds Several proofs still carried workarounds marked by TODOs, porting notes, an adaptation note, or `erw`, for problems that have since been fixed: the missing lemmas now exist, or Lean no longer needs the hint. This PR removes those workarounds. Only proofs change; every statement stays the same. - `PullbackCone.isLimitOfFactors`: use `t.condition_assoc h` instead of the manual reassoc workaround - `Scheme.basicOpen_add_le`: use `Opens.mem_sup` (resolves the TODO) - `Cardinal.toNat_congr`: use `mk_congr_lift`, dropping the universe hint - `LieIdeal.map_of_image`: replace `erw [h]` with `exact h.subset` - `isPullback_inl_inl_coprodMap`: plain `simp` works now that `Scheme.Hom.mem_opensRange` exists (resolves the TODO) - `Proj.fromOfGlobalSections_preimage_basicOpen`: use `Scheme.Hom.mem_preimage` (resolves the TODO) - `Tuple.graph.card`: one-line injectivity proof - `StarModule.decomposeProdAdjoint`: drop the `erw` and its outdated note - `skyscraperPresheaf_isSheaf`: the universe annotation is no longer needed --- Created with Claude Opus 5.5 in Claude Code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) tech debt new-contributor 11/29 Mathlib/Algebra/Lie/Ideal.lean,Mathlib/Algebra/Star/Module.lean,Mathlib/AlgebraicGeometry/Limits.lean,Mathlib/AlgebraicGeometry/ProjectiveSpectrum/Basic.lean,Mathlib/AlgebraicGeometry/Scheme.lean,Mathlib/CategoryTheory/Limits/Shapes/Pullback/Mono.lean,Mathlib/Data/Fin/Tuple/Sort.lean,Mathlib/SetTheory/Cardinal/ToNat.lean,Mathlib/Topology/Sheaves/Skyscraper.lean 9 9 ['JonasReif', 'Parcly-Taxel', 'github-actions', 'grunweg'] nobody
3-51916
3 days ago
3-54665
3 days ago
4-2635
4 days
0
45451 Parcly-Taxel
author:Parcly-Taxel
chore: remove transparency `set_option`s in `SimpleGraph`, part 1 These should be less controversial changes from #45430. tech debt t-combinatorics 14/33 Mathlib/Combinatorics/SimpleGraph/AdjMatrix.lean,Mathlib/Combinatorics/SimpleGraph/Clique.lean,Mathlib/Combinatorics/SimpleGraph/Connectivity/Finite.lean,Mathlib/Combinatorics/SimpleGraph/Connectivity/Subgraph.lean,Mathlib/Combinatorics/SimpleGraph/Ends/Defs.lean,Mathlib/Combinatorics/SimpleGraph/Finite.lean,Mathlib/Combinatorics/SimpleGraph/StronglyRegular.lean,Mathlib/Combinatorics/SimpleGraph/Subgraph.lean 8 1 ['github-actions'] SnirBroshi
assignee:SnirBroshi
3-15811
3 days ago
3-16324
3 days ago
24-40869
24 days
1
45453 Parcly-Taxel
author:Parcly-Taxel
chore: remove transparency `set_option`s in `SimpleGraph`, part 2 More fixes from #45430. * `ConnectedComponent.lift` now has `Reachable` in its hypotheses, which allows removing a `set_option`. * There was a long-standing typo in the statement of `Walk.ofBoxProdRight_boxProdRight`, which has been corrected. Equational lemmas for `Walk.ofBoxProd{Left,Right}` have been added too. * The golfed proof of `free_killCopies` was done by GPT-6.1 Sol, then hand-optimised. tech debt t-combinatorics LLM-generated 52/67 Mathlib/Combinatorics/SimpleGraph/Connectivity/Connected.lean,Mathlib/Combinatorics/SimpleGraph/Copy.lean,Mathlib/Combinatorics/SimpleGraph/Ends/Defs.lean,Mathlib/Combinatorics/SimpleGraph/LapMatrix.lean,Mathlib/Combinatorics/SimpleGraph/Prod.lean,Mathlib/Combinatorics/SimpleGraph/Subgraph.lean 6 1 ['github-actions'] SnirBroshi
assignee:SnirBroshi
3-15332
3 days ago
3-16147
3 days ago
24-35584
24 days
1
43948 JX-Mo
author:JX-Mo
chore(RepresentationTheory/Coinduced): tech debt Remove five `backward.isDefEq.respectTransparency.types` and add a CoeFun instance for `coindV` to justify the existing `coe`-named lemmas. https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60CoeFun.60.20or.20.60.2Eval.60/with/630026437 t-algebra tech debt easy
label:t-algebra$
22/17 Mathlib/RepresentationTheory/Coinduced.lean 1 38 ['JX-Mo', 'Whysoserioushah', 'github-actions', 'jcommelin', 'jjdishere', 'leanprover-radar', 'mathlib-bors', 'mathlib-merge-conflicts'] nobody
3-6315
3 days ago
3-7339
3 days ago
50-77693
50 days
4
43705 joelriou
author:joelriou
feat(Category/Abelian/Projective): interaction between `ProjectiveResolution.extMk` and the connecting morphism This is the dual result to #43224. Obtaining the dual version required introducing more API for the mapping cocone. --- - [x] depends on: #43224 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-category-theory tech debt increases-technical-debt 408/20 Mathlib/Algebra/Homology/DerivedCategory/Basic.lean,Mathlib/Algebra/Homology/DerivedCategory/ShortExact.lean,Mathlib/Algebra/Homology/DerivedCategory/SingleTriangle.lean,Mathlib/Algebra/Homology/DerivedCategory/SmallShiftedHom.lean,Mathlib/Algebra/Homology/HomotopyCategory/HomComplexShift.lean,Mathlib/Algebra/Homology/HomotopyCategory/HomComplexSingle.lean,Mathlib/Algebra/Homology/HomotopyCategory/MappingCocone.lean,Mathlib/Algebra/Homology/HomotopyCategory/Shift.lean,Mathlib/Algebra/Homology/HomotopyCategory/ShortExact.lean,Mathlib/CategoryTheory/Abelian/Injective/Ext.lean,Mathlib/CategoryTheory/Abelian/Projective/Ext.lean,Mathlib/CategoryTheory/Abelian/Projective/Extend.lean 12 7 ['github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] nobody
3-5286
3 days ago
3-5944
3 days ago
34-19500
34 days
0
45528 joelriou
author:joelriou
chore(CategoryTheory/Limits): remove set_option for multiequalizers --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-category-theory tech debt 36/80 Mathlib/CategoryTheory/Limits/Preserves/Shapes/Multiequalizer.lean,Mathlib/CategoryTheory/Limits/Shapes/Equalizers.lean,Mathlib/CategoryTheory/Limits/Shapes/Multiequalizer.lean,Mathlib/Order/CompleteLattice/MulticoequalizerDiagram.lean 4 1 ['github-actions'] nobody
2-80737
2 days ago
22-8964
22 days ago
22-8951
22 days
6
46176 Nicola9Falciola
author:Nicola9Falciola
chore(LinearAlgebra/Matrix/FixedDetMatrices): remove all the `set_option` in the file due to defeq abuse This PR adds a `_.mk` for `FixedDetMatrix` and small API lemmas to avoid defeq abuse later in the file removing all the remaining `set_options`. I have modified a couple of proofs also to save heartbeats. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-algebra tech debt
label:t-algebra$
29/17 Mathlib/LinearAlgebra/Matrix/FixedDetMatrices.lean 1 1 ['github-actions'] nobody
2-76940
2 days ago
2-79288
2 days ago
3-54346
3 days
0
43232 Parcly-Taxel
author:Parcly-Taxel
refactor: `TrivSqZeroExt` extending `Prod` Define à la `Unitization` ([#mathlib4 > TrivSqZeroExt as a 2-field structure @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/TrivSqZeroExt.20as.20a.202-field.20structure/near/620183663)) ```lean structure TrivSqZeroExt (R : Type u) (M : Type v) extends R × M ``` This PR came out of investigating the source of the `DualQuaternion` slowdown in #43078. (`DualNumber R` is an abbrev for `TrivSqZeroExt R R`.) `Topology.Instances.TrivSqZeroExt` and `Analysis.Normed.Algebra.TrivSqZeroExt` were filled in with significant help from GPT-6.1 Sol. t-algebra tech debt LLM-generated
label:t-algebra$
360/290 Mathlib/Algebra/DualNumber.lean,Mathlib/Algebra/DualQuaternion.lean,Mathlib/Algebra/TrivSqZeroExt/Basic.lean,Mathlib/Algebra/TrivSqZeroExt/Ideal.lean,Mathlib/Analysis/Normed/Algebra/TrivSqZeroExt.lean,Mathlib/LinearAlgebra/ExteriorAlgebra/Basic.lean,Mathlib/LinearAlgebra/Matrix/DualNumber.lean,Mathlib/LinearAlgebra/TensorAlgebra/Basic.lean,Mathlib/RingTheory/DualNumber.lean,Mathlib/Topology/Instances/TrivSqZeroExt.lean 10 10 ['Parcly-Taxel', 'github-actions', 'mathlib-merge-conflicts', 'plp127'] nobody
2-74323
2 days ago
16-42471
16 days ago
25-62474
25 days
0
46248 felixpernegger
author:felixpernegger
chore(Basic): unsqueeze terminal `simp only`s Per style guide. A few terminal `simp only` remain, but they have to, due to stuff looping wrongly etc --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> tech debt t-data 90/91 Mathlib/Basic/Complex/Basic.lean,Mathlib/Basic/ENNReal/Action.lean,Mathlib/Basic/ENNReal/Basic.lean,Mathlib/Basic/ENNReal/BigOperators.lean,Mathlib/Basic/ENNReal/Inv.lean,Mathlib/Basic/ENNReal/Operations.lean,Mathlib/Basic/ENNReal/Real.lean,Mathlib/Basic/ExistsUnique.lean,Mathlib/Basic/IsEmpty/Basic.lean,Mathlib/Basic/Logic/Basic.lean,Mathlib/Basic/NNReal/Basic.lean,Mathlib/Basic/NNReal/Defs.lean,Mathlib/Basic/NNReal/Star.lean,Mathlib/Basic/Nontrivial/Basic.lean,Mathlib/Basic/Nontrivial/Defs.lean,Mathlib/Basic/PEquiv.lean,Mathlib/Basic/Real/Basic.lean,Mathlib/Basic/Real/Pointwise.lean,Mathlib/Basic/Sign/Basic.lean,Mathlib/Basic/Sign/Defs.lean 20 3 ['felixpernegger', 'github-actions', 'leanprover-radar'] nobody
2-73776
2 days ago
2-77037
2 days ago
2-77116
2 days
0
44743 vihdzp
author:vihdzp
refactor(Wiedijk100Theorems/AreaOfACircle): delete file The area formula for circles exists within Mathlib already, and in fact we also have formulas for the volume of an n-sphere. So we delete the file on the archive, in favor for the Mathlib theorem. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> Not sure if this is the right thing to do. Maybe we could change the link on 100.yaml, but still keep the archive file as an alternate proof of a similar result? t-measure-probability file-removed tech debt 13/140 Archive.lean,Archive/Wiedijk100Theorems/AreaOfACircle.lean,Mathlib/MeasureTheory/Measure/Lebesgue/VolumeOfBalls.lean,docs/100.yaml 4 4 ['Parcly-Taxel', 'github-actions', 'mathlib-merge-conflicts'] RemyDegenne
assignee:RemyDegenne
2-52004
2 days ago
2-52479
2 days ago
41-75996
41 days
0
40644 j-loreaux
author:j-loreaux
refactor: use `LinearMap.IsWeak` for `WeakBilin` This introduces `WeakBilin.linearEquiv : WeakBilin B ≃ₗ[𝕜] E` as the canonical map between a space `E` and its type synonym `WeakBilin B`, for `B : E →ₗ[𝕜] F →ₗ[𝕜] 𝕜`. This serves to provides an abstraction barrier between these defeq types. We then add `WeakBilin.pairing : WeakBilin B →ₗ[𝕜] F →ₗ[𝕜] 𝕜` as a copy of the bilinear map `B` where we exchange the domain via `LinearEquiv.arrowCongr`. Finally, we provide an instance of `LinearMap.IsWeak (WeakBilin.pairing B)`. This allows us to remove abuse of definitional equality in the API for `WeakBilin`, and to deprecate most of the basic results in favor of their `LinearMap.IsWeak` variants. The one result which we don't deprecate is `WeakBilin.continuous_of_continuous_eval`. This is because the specific version we can tag with `fun_prop`, but the more general version would not be suitable as a `fun_prop` lemma because the linear map `B` inducing the topology would be a metavariable, and cannot be inferred from the type. --- - [ ] depends on: #40489 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-analysis t-topology tech debt maintainer-merge 220/118 Mathlib/Analysis/LocallyConvex/Polar.lean,Mathlib/Analysis/LocallyConvex/WeakDual.lean,Mathlib/Analysis/LocallyConvex/WeakSpace.lean,Mathlib/Analysis/Normed/Module/WeakDual.lean,Mathlib/MeasureTheory/Measure/FiniteMeasure.lean,Mathlib/Topology/Algebra/Module/Spaces/CharacterSpace.lean,Mathlib/Topology/Algebra/Module/Spaces/PointwiseConvergenceCLM.lean,Mathlib/Topology/Algebra/Module/Spaces/WeakBilin.lean,Mathlib/Topology/Algebra/Module/Spaces/WeakDual.lean 9 6 ['github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts', 'mcdoll'] mcdoll
assignee:mcdoll
2-48742
2 days ago
23-19136
23 days ago
23-19124
23 days
0
38393 staroperator
author:staroperator
refactor(ModelTheory): add typeclasses for algebraic symbols `Language.ring` and `Language.presburger` share the same symbols `0`, `1` and `+` and have duplicated instances on `Term` and `realize` simp lemmas. This PR makes these symbols certain typeclasses (similar to [`Language.IsOrdered`](https://leanprover-community.github.io/mathlib4_docs/Mathlib/ModelTheory/Order.html#FirstOrder.Language.IsOrdered)) and removes the duplication. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-logic tech debt 401/202 Mathlib.lean,Mathlib/ModelTheory/Algebra/Classes.lean,Mathlib/ModelTheory/Algebra/Field/IsAlgClosed.lean,Mathlib/ModelTheory/Algebra/Ring/Basic.lean,Mathlib/ModelTheory/Algebra/Ring/FreeCommRing.lean,Mathlib/ModelTheory/Arithmetic/Presburger/Basic.lean,Mathlib/ModelTheory/Arithmetic/Presburger/Definability.lean 7 10 ['fpvandoorn', 'github-actions', 'mathlib-merge-conflicts', 'staroperator'] fpvandoorn
assignee:fpvandoorn
2-27710
2 days ago
2-28118
2 days ago
55-38425
55 days
1
46133 thorimur
author:thorimur
chore: change uses of `TopologicalSpace.Opens.is_open'` to `TopologicalSpace.Opens.isOpen` This PR changes uses of the projection `TopologicalSpace.Opens` to `isOpen` and advises doing so more generally in that field's docstring. Note: it does not make `is_open'` private, though, as that would require making the constructor private too, preventing us from writing e.g. `{ carrier := ..., is_open' := ... }`. Moving to a smart constructor or linting against this projection is a larger change. --- - [x] depends on: #45389 <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-topology tech debt 173/172 Mathlib/AlgebraicGeometry/AffineScheme.lean,Mathlib/AlgebraicGeometry/AffineTransitionLimit.lean,Mathlib/AlgebraicGeometry/Artinian.lean,Mathlib/AlgebraicGeometry/Birational/Birational.lean,Mathlib/AlgebraicGeometry/Birational/Composition.lean,Mathlib/AlgebraicGeometry/Birational/RationalMap.lean,Mathlib/AlgebraicGeometry/Cover/QuasiCompact.lean,Mathlib/AlgebraicGeometry/GammaSpecAdjunction.lean,Mathlib/AlgebraicGeometry/Group/Smooth.lean,Mathlib/AlgebraicGeometry/IdealSheaf/Basic.lean,Mathlib/AlgebraicGeometry/Modules/Tilde.lean,Mathlib/AlgebraicGeometry/Morphisms/Affine.lean,Mathlib/AlgebraicGeometry/Morphisms/ClosedImmersion.lean,Mathlib/AlgebraicGeometry/Morphisms/Constructors.lean,Mathlib/AlgebraicGeometry/Morphisms/Flat.lean,Mathlib/AlgebraicGeometry/Morphisms/FlatRank.lean,Mathlib/AlgebraicGeometry/Morphisms/OpenImmersion.lean,Mathlib/AlgebraicGeometry/Morphisms/QuasiCompact.lean,Mathlib/AlgebraicGeometry/Morphisms/QuasiSeparated.lean,Mathlib/AlgebraicGeometry/Morphisms/Smooth.lean,Mathlib/AlgebraicGeometry/Morphisms/SurjectiveOnStalks.lean,Mathlib/AlgebraicGeometry/Morphisms/UnderlyingMap.lean,Mathlib/AlgebraicGeometry/Morphisms/UniversallyClosed.lean,Mathlib/AlgebraicGeometry/Normalization.lean,Mathlib/AlgebraicGeometry/OpenImmersion.lean,Mathlib/AlgebraicGeometry/PointsPi.lean,Mathlib/AlgebraicGeometry/ProjectiveSpectrum/Scheme.lean,Mathlib/AlgebraicGeometry/Properties.lean,Mathlib/AlgebraicGeometry/QuasiAffine.lean,Mathlib/AlgebraicGeometry/Sites/SmallAffineZariski.lean,Mathlib/AlgebraicGeometry/Spec.lean,Mathlib/AlgebraicGeometry/SpreadingOut.lean,Mathlib/AlgebraicGeometry/Stalk.lean,Mathlib/AlgebraicGeometry/StructureSheaf.lean,Mathlib/AlgebraicGeometry/ZariskisMainTheorem.lean,Mathlib/Geometry/Manifold/HasGroupoid.lean,Mathlib/Geometry/Manifold/IsManifold/InteriorBoundary.lean,Mathlib/Geometry/Manifold/Sheaf/LocallyRingedSpace.lean,Mathlib/Geometry/RingedSpace/Basic.lean,Mathlib/Geometry/RingedSpace/LocallyRingedSpace/HasColimits.lean,Mathlib/MeasureTheory/Integral/RieszMarkovKakutani/Real.lean,Mathlib/MeasureTheory/Measure/Content.lean,Mathlib/RingTheory/Spectrum/Prime/Chevalley.lean,Mathlib/RingTheory/Spectrum/Prime/FreeLocus.lean,Mathlib/RingTheory/Spectrum/Prime/TensorProduct.lean,Mathlib/RingTheory/Spectrum/Prime/Topology.lean,Mathlib/Topology/Category/TopCat/Opens.lean,Mathlib/Topology/Constructible.lean,Mathlib/Topology/ContinuousMap/T0Sierpinski.lean,Mathlib/Topology/JacobsonSpace.lean,Mathlib/Topology/LocalAtTarget.lean,Mathlib/Topology/OpenPartialHomeomorph/Basic.lean,Mathlib/Topology/OpenPartialHomeomorph/Constructions.lean,Mathlib/Topology/Order/Category/FrameAdjunction.lean,Mathlib/Topology/Sets/Closeds.lean,Mathlib/Topology/Sets/CompactOpenCovered.lean,Mathlib/Topology/Sets/Compacts.lean,Mathlib/Topology/Sets/OpenCover.lean,Mathlib/Topology/Sets/Opens.lean,Mathlib/Topology/Sheaves/Points.lean,Mathlib/Topology/Sheaves/Presheaf.lean,Mathlib/Topology/Sheaves/Skyscraper.lean,Mathlib/Topology/Sheaves/Stalks.lean,Mathlib/Topology/Spectral/Prespectral.lean 64 4 ['github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] nobody
2-12724
2 days ago
2-63681
2 days ago
3-81383
3 days
0
45670 user202729
author:user202729
chore(AlgebraicGeometry/EllipticCurve/Projective): remove `erw` in `Formula.lean` Reducing tech debt. The main reason why `erw` was needed in this file instead of `rw` is the following. - Background: Each point is represented by a function `P : Fin 3 → R`, and there's local notation `x` being `(0 : Fin 3)`, similar for `y` and `z`. So `P x` is the first coordinate of `P`. For a curve `W'` and a point `P`, `W'.dblXYZ P` is another point, its double i.e. `2 • P`. - There are functions to compute various operations on elliptic curves, for example, `W.dblY P` computes the `Y`-coordinate of `2 • P`. Of course, this can be equivalently written as `W.dblXYZ P y`. - The two forms `W.dblY P` and `W.dblXYZ P y` are not definitionally equal at the default transparency level. Depends on which lemma we want to apply, we need to convert the goal to use one form or the other. --- Personally, I think it's a better idea to normalize on the `W.dblXYZ P y` form, and keep the `W.dblY P` form as strictly an implementation detail if needed. In this case, the `XYZ` suffix wouldn't be needed either, and the main definitions would be: ``` * `WeierstrassCurve.Projective.neg`: The negation `-P` of a point `P`. * `WeierstrassCurve.Projective.dbl`: The double `2 • P` of a point `P`. * `WeierstrassCurve.Projective.negDbl`: The negated double `-(2 • P)` of a point `P`. ``` etc. Thoughts? Note that `W.dbl P y` is only 1 character longer than `W.dblY P`. Most lemmas that we want to apply are already stated in term of the point (except that many use `W.negY P` instead of `W.neg P y`, though currently `W.neg` doesn't exist). Also, there are (very) long `rw` chains. ([#mathlib4 > Is long &#96;rw&#96; chain bad?](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Is.20long.20.60rw.60.20chain.20bad.3F/with/637217759)) Ideas? Another idea: have a `array_index` tactic that evaluates `![a, b, c, d] 2` to `c` when the index is a known constant, for example. Currently there is `simp only [fin3_def_ext]` which obviously only works on length-3 arrays. new-contributor t-algebraic-geometry tech debt 59/24 Mathlib/AlgebraicGeometry/EllipticCurve/Projective/Formula.lean 1 5 ['Multramate', 'github-actions', 'tb65536'] nobody
1-73426
1 day ago
17-73228
17 days ago
17-73215
17 days
0
46111 Hagb
author:Hagb
chore(Order/RelSeries): tag definitions providing `RelSeries` with `implicit_reducible` These definitions are sometimes applied with `Fin _` whose the type-correctness needs unfolding the definition. For example, ``` def ofLE (x : RelSeries r) {s : SetRel α α} (h : r ≤ s) : RelSeries s where length := x.length toFun := x step := ... ``` is used with `ofLE s h n` (i.e. `(ofLE s h).toFun n`) where `(ofLE s h).toFun` is a `Fin ((ofLE s h).length + 1) → α` and `n` is in `Fin (s.length + 1)` instead of `Fin ((ofLE s h).length + 1)`, unless w.r.t. higher transparency. It would be possible to cast these `Fin _` or use `Fin (EXPR.length + 1)` (where `EXPR` is the expression of a `RelSeries r` such as `ofLE s h`), which are painful. This PR tags these definitions with `@[implicit_reducible]` so that they can be unfolded in `implicit` transparency. As a result, `set_option backward.*` in `Mathlib.Order.RelSeries` can be removed. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> tech debt t-order 33/56 Mathlib/Order/JordanHolder.lean,Mathlib/Order/RelSeries.lean 2 4 ['Hagb', 'github-actions', 'leanprover-radar', 'mathlib-merge-conflicts'] nobody
1-71245
1 day ago
1-72620
1 day ago
2-73705
2 days
0
46299 themathqueen
author:themathqueen
chore(Algebra): weakening `AlgEquiv` definitions to use nonunital --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-algebra tech debt
label:t-algebra$
38/23 Mathlib/Algebra/Algebra/Equiv.lean,Mathlib/Algebra/Algebra/Opposite.lean,Mathlib/Algebra/Algebra/Pi.lean,Mathlib/Algebra/Algebra/Prod.lean 4 3 ['github-actions', 'leanprover-radar', 'themathqueen'] nobody
1-61012
1 day ago
1-62748
1 day ago
1-62735
1 day
0
44672 JovanGerb
author:JovanGerb
feat(Algebra/Homology/HomologicalComplex): use `to_dual` This PR uses `to_dual` on `HomologicalComplex`, making `ChainComplex` dual to `CochainComplex`. - The type of `CochainComplex.ofHom` and `CochainComplex.mkHom` changed: the direction of the equality flipped to match with the dual. - `HomologicalComplex.Hom.sqFrom` gained a `simps!` attribute to replace two manually written lemmas. - `ChainComplex.mkAux` and `ChainComplex.mkHomAux` needed to use `to_dual existing`, because `to_dual` currently doesn't like recursive definitions that use a match for the recursion. - `mkXIso` and `mk'XIso` and a few theorems didn't have duals before this PR. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> - [x] depends on: #43804 tech debt 159/351 Mathlib/Algebra/Homology/ComplexShape.lean,Mathlib/Algebra/Homology/HomologicalComplex.lean,Mathlib/AlgebraicTopology/AlternatingFaceMapComplex.lean,Mathlib/CategoryTheory/Abelian/Injective/Resolution.lean 4 3 ['github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] nobody
1-31834
1 day ago
1-32394
1 day ago
1-33395
1 day
0
40940 JovanGerb
author:JovanGerb
feat(CategoryTheory/Comma/StructuredArrow): use `to_dual` This PR generates declarations about `CostructuredArrow` from those about `StructuredArrow` using `to_dual`. This PR deprecates `hom_eq_iff` in favour of `ext_iff`/`hom_ext_iff`. `StructuredArrow.isoMk` and its dependencies are difficult to dualize for `to_dual`, so they are left as-is. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> - [x] depends on: #40503 - [x] depends on: #42861 [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) t-category-theory tech debt 157/423 Mathlib/CategoryTheory/Comma/Basic.lean,Mathlib/CategoryTheory/Comma/StructuredArrow/Basic.lean,Mathlib/CategoryTheory/Comma/StructuredArrow/CommaMap.lean,Mathlib/CategoryTheory/Filtered/Final.lean,Mathlib/CategoryTheory/Limits/Indization/ParallelPair.lean,Mathlib/Tactic/Translate/ToDual.lean,Mathlib/Topology/Category/Profinite/Extend.lean 7 9 ['JovanGerb', 'github-actions', 'joelriou', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] nobody
1-30069
1 day ago
1-32275
1 day ago
1-41613
1 day
0
46277 wrenna-robson
author:wrenna-robson
chore(GroupTheory/Perm/Support): split into smaller files Part of the `Equiv.Perm.support` refactor discussed on [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/support.20of.20permutations.20on.20Type.20instead.20of.20Fintype/near/640706043): #46119 (move `IsSwap` and pow-apply lemmas) → #46277 (split `Support.lean`) → #46082 (rename to `supportFinset`) → #46126 (`Set`-valued `support`). This prepares for a `Set`-valued definition of `Equiv.Perm.support`, which needs no `Fintype` or `DecidableEq` assumptions. Splitting the file first separates the material that needs no finiteness assumptions from the current `Finset`-valued `support`, so that the later changes stay small and easy to review. Some splits have also been made to reduce unnecessary imports. Split `Mathlib/GroupTheory/Perm/Support.lean` into: * `Support/Basic.lean`: the `set_support_*` lemmas, with no finiteness assumptions; * `Support/Disjoint.lean`: the `Equiv.Perm.Disjoint` API that does not involve `support`; * `Support/Finset/Basic.lean`: the `Finset`-valued `Equiv.Perm.support` and its API; * `Support/Finset/Card.lean`: lemmas about the cardinality of `support`, including `fixed_point_card_lt_of_ne_one`; * `Support/NoncommProd.lean`: lemmas about `Finset.noncommProd` of permutations. This is a pure move: no declarations are renamed or restated. An LLM has been used in the preparation of this PR but as it contains no new content - i.e. it is just a move - I am omitting the LLM-generated tag. - [x] depends on: #46119 tech debt t-group-theory 733/601 Mathlib.lean,Mathlib/Algebra/Order/Rearrangement.lean,Mathlib/GroupTheory/Perm/ClosureSwap.lean,Mathlib/GroupTheory/Perm/Cycle/Factors.lean,Mathlib/GroupTheory/Perm/Finite.lean,Mathlib/GroupTheory/Perm/List.lean,Mathlib/GroupTheory/Perm/Sign.lean,Mathlib/GroupTheory/Perm/Support.lean,Mathlib/GroupTheory/Perm/Support/Basic.lean,Mathlib/GroupTheory/Perm/Support/Disjoint.lean,Mathlib/GroupTheory/Perm/Support/Finset/Basic.lean,Mathlib/GroupTheory/Perm/Support/Finset/Card.lean,Mathlib/GroupTheory/Perm/Support/NoncommProd.lean,Mathlib/LinearAlgebra/Matrix/SemiringInverse.lean 14 3 ['github-actions', 'mathlib-dependent-issues', 'mathlib-merge-conflicts'] nobody
0-85196
23 hours ago
1-22
1 day ago
1-9359
1 day
2
44427 xroblot
author:xroblot
feat(Tactic/NormNum): norm_num extension for Squarefree Add a `norm_num` extension deciding `Squarefree n` for numerals `n` in `ℕ` and `ℤ`. If `n` is not squarefree, the proof uses a witness `a > 1` with `a * a ∣ n`, found with `Nat.minSqFac`. If `n` is squarefree, the proof is a trial division of `n` by the odd numbers `k = 3, 5, 7, …`, keeping the invariant that every prime divisor of the cofactor is at least `k`. This is adapted from the Mathlib 3 extension by Mario Carneiro (mathlib#11666), which was left commented out in `Mathlib.Data.Nat.Squarefree` during the port. This commented-out code is removed, and the corresponding tests are restored. As for the `Nat.Prime` extension, the proof is a certificate rather than a kernel evaluation of `Nat.minSqFac` via `Nat.squarefree_iff_minSqFac`. The certificate is also faster to check, but, as for `Nat.Prime`, large numbers need a higher `maxRecDepth`. **Note**. I have read and checked the ordinary Lean statements and their proofs, but I am not familiar with metaprogramming, so I cannot really vouch for the meta code itself, which was written with the help of an LLM. A review by someone who is comfortable with `norm_num` extensions would be very welcome. Created with Claude Code 🤖 --- tech debt t-meta LLM-generated 198/204 Mathlib.lean,Mathlib/Data/Nat/Squarefree.lean,Mathlib/Tactic.lean,Mathlib/Tactic/NormNum/Squarefree.lean,MathlibTest/Tactic/NormNum/Ext.lean 5 2 ['github-actions', 'mathlib-merge-conflicts'] nobody
0-84927
23 hours ago
10-14974
10 days ago
49-1405
49 days
0
45300 xroblot
author:xroblot
refactor(RingTheory/Ideal): generalize some absNorm lemmas and move primesEquiv This is the clean-up part of #42567, extracted so that the summability work can build on it. Two divisibility and positivity results about the absolute norm of an ideal are generalized from `ℤ` to a Dedekind domain, and from prime ideals to proper ideals, with the earlier versions deprecated. The equivalence between the height-one prime ideals of the integral closure of `ℤ` in `ℚ` and the prime numbers is moved to the Dedekind domain files, where it belongs, and redefined through the absolute norm rather than through a generator of the corresponding ideal of `ℤ`. It now assumes less, and the auxiliary API it used to be built from is deprecated without replacement. Finally, the equivalence between the height-one spectra of two isomorphic rings is reworked so that the surjectivity proofs have the expected type, which removes the need for a `backward.isDefEq` option. The mathematics and design are mine. Claude Code was used as a coding assistant and for the housekeeping around this PR. 🤖 tech debt 134/72 Mathlib/NumberTheory/NumberField/Completion/FinitePlace.lean,Mathlib/NumberTheory/Padics/HeightOneSpectrum.lean,Mathlib/RingTheory/DedekindDomain/Ideal/Lemmas.lean,Mathlib/RingTheory/Ideal/Int.lean,Mathlib/RingTheory/Ideal/Norm/AbsNorm.lean 5 9 ['github-actions', 'mathlib-merge-conflicts', 'tb65536', 'xroblot'] nobody
0-84887
23 hours ago
3-1792
3 days ago
24-61626
24 days
1
45709 YaelDillies
author:YaelDillies
chore(Algebra/Order): make `Nonneg` a structure The goal is to eventually make `NNRat` and `NNReal` `abbrev`s for `Nonneg Rat` and `Nonneg Real`, and deduplicate their API. This is currently not possible due to prohibitive slowdowns when making their definition in terms of `Subtype` visible to automation. Generated by Claude Sonnet in many rounds of review by myself. Assisted-by: Claude Sonnet 5.5 --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> t-algebra tech debt t-order large-import LLM-generated
label:t-algebra$
766/354 Archive/Wiedijk100Theorems/AreaOfACircle.lean,Mathlib.lean,Mathlib/Algebra/Field/Rat.lean,Mathlib/Algebra/Order/Nonneg/Basic.lean,Mathlib/Algebra/Order/Nonneg/Defs.lean,Mathlib/Algebra/Order/Nonneg/Field.lean,Mathlib/Algebra/Order/Nonneg/Floor.lean,Mathlib/Algebra/Order/Nonneg/Interval.lean,Mathlib/Algebra/Order/Nonneg/Lattice.lean,Mathlib/Algebra/Order/Nonneg/Order.lean,Mathlib/Algebra/Order/Nonneg/Ring.lean,Mathlib/Analysis/Analytic/Composition.lean,Mathlib/Analysis/BoxIntegral/Integrability.lean,Mathlib/Analysis/CStarAlgebra/Basic.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Isometric.lean,Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Order.lean,Mathlib/Analysis/CStarAlgebra/GelfandDuality.lean,Mathlib/Analysis/CStarAlgebra/Hom.lean,Mathlib/Analysis/CStarAlgebra/Matrix.lean,Mathlib/Analysis/CStarAlgebra/Multiplier.lean,Mathlib/Analysis/CStarAlgebra/Unitization.lean,Mathlib/Analysis/Complex/Basic.lean,Mathlib/Analysis/Complex/CauchyIntegral.lean,Mathlib/Analysis/Complex/Norm.lean,Mathlib/Analysis/Complex/OperatorNorm.lean,Mathlib/Analysis/Complex/UpperHalfPlane/Measure.lean,Mathlib/Analysis/ConstantSpeed.lean,Mathlib/Analysis/Convex/Cone/Closure.lean,Mathlib/Analysis/Convex/Segment.lean,Mathlib/Analysis/Convex/SpecificFunctions/Pow.lean,Mathlib/Analysis/InnerProductSpace/Basic.lean,Mathlib/Analysis/LocallyConvex/Asymptotics.lean,Mathlib/Analysis/Matrix/Normed.lean,Mathlib/Analysis/MeanInequalities.lean,Mathlib/Analysis/Normed/Algebra/Spectrum.lean,Mathlib/Analysis/Normed/Algebra/UnitizationL1.lean,Mathlib/Analysis/Normed/Field/Basic.lean,Mathlib/Analysis/Normed/Group/Constructions.lean,Mathlib/Analysis/Normed/Group/Continuity.lean,Mathlib/Analysis/Normed/Group/Hom.lean,Mathlib/Analysis/Normed/Group/Uniform.lean,Mathlib/Analysis/Normed/Lp/lpHolder.lean,Mathlib/Analysis/Normed/Module/Basic.lean,Mathlib/Analysis/Normed/Operator/Basic.lean,Mathlib/Analysis/Normed/Operator/Mul.lean,Mathlib/Analysis/Normed/Operator/NNNorm.lean,Mathlib/Analysis/Normed/Operator/NormedSpace.lean,Mathlib/Analysis/Normed/Operator/Prod.lean,Mathlib/Analysis/ODE/PicardLindelof.lean,Mathlib/Analysis/Quaternion.lean,Mathlib/Analysis/SpecialFunctions/Pow/NNReal.lean,Mathlib/Basic/ENNReal/Basic.lean,Mathlib/Basic/NNReal/Basic.lean,Mathlib/Basic/NNReal/Defs.lean,Mathlib/Data/NNRat/Defs.lean,Mathlib/Data/Rat/Cast/Lemmas.lean,Mathlib/Data/Rat/Init.lean,Mathlib/FieldTheory/IntermediateField/Basic.lean,Mathlib/Geometry/Convex/Cone/Dual.lean,Mathlib/Geometry/Convex/Cone/Pointed.lean,Mathlib/MeasureTheory/Constructions/BorelSpace/Basic.lean,Mathlib/MeasureTheory/Function/ConditionalExpectation/Real.lean,Mathlib/MeasureTheory/Function/Jacobian.lean,Mathlib/MeasureTheory/Function/SimpleFuncDenseLp.lean,Mathlib/MeasureTheory/Function/SpecialFunctions/Basic.lean,Mathlib/MeasureTheory/Function/UniformIntegrable.lean,Mathlib/MeasureTheory/Integral/Bochner/Basic.lean,Mathlib/MeasureTheory/Integral/SetToL1/L1.lean,Mathlib/MeasureTheory/MeasurableSpace/Constructions.lean,Mathlib/MeasureTheory/Measure/Prokhorov.lean,Mathlib/MeasureTheory/Measure/Stieltjes.lean,Mathlib/NumberTheory/Modular.lean,Mathlib/NumberTheory/NumberField/CanonicalEmbedding/Basic.lean,Mathlib/Probability/Moments/IntegrableExpMul.lean,Mathlib/Probability/Moments/Tilted.lean,Mathlib/RingTheory/RootsOfUnity/Complex.lean,Mathlib/RingTheory/Valuation/ValuationSubring.lean,Mathlib/Topology/Algebra/Field.lean,Mathlib/Topology/Algebra/MetricSpace/Lipschitz.lean,Mathlib/Topology/Algebra/Order/Module.lean,Mathlib/Topology/Algebra/Ring/Real.lean,Mathlib/Topology/Bornology/Real.lean,Mathlib/Topology/ContinuousMap/Bounded/Basic.lean,Mathlib/Topology/ContinuousMap/Bounded/Normed.lean,Mathlib/Topology/Instances/NNReal/Lemmas.lean,Mathlib/Topology/Instances/Rat.lean,Mathlib/Topology/MetricSpace/Basic.lean,Mathlib/Topology/MetricSpace/Cauchy.lean,Mathlib/Topology/MetricSpace/HausdorffDimension.lean,Mathlib/Topology/MetricSpace/Lipschitz.lean,Mathlib/Topology/MetricSpace/ProperSpace/Real.lean,Mathlib/Topology/MetricSpace/Pseudo/Constructions.lean,Mathlib/Topology/MetricSpace/Thickening.lean,Mathlib/Topology/Order/Nonneg.lean,Mathlib/Topology/UniformSpace/Real.lean 95 7 ['github-actions', 'mathlib-merge-conflicts'] nobody
0-77323
21 hours ago
0-79366
22 hours ago
12-32957
12 days
0
45861 grunweg
author:grunweg
chore: rename three lemmas involving the name some_eq_coe Reference the actual coercion being used. The ENNReal renames deserve a careful look. Found using the linter in #45229: among the cases of misnamed coercion lemmas using WithTop.some, these are some more interesting cases. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> tech debt t-order maintainer-merge 34/28 Mathlib/Algebra/Order/Monoid/Unbundled/WithTop.lean,Mathlib/Analysis/BoxIntegral/Partition/Additive.lean,Mathlib/Analysis/BoxIntegral/Partition/Basic.lean,Mathlib/Analysis/SpecialFunctions/Pow/NNReal.lean,Mathlib/Basic/ENNReal/Basic.lean,Mathlib/Data/List/MinMax.lean,Mathlib/Order/WithBot.lean,Mathlib/Tactic/Echelon/Reflection.lean,Mathlib/Tactic/Inclusion/Extension/Interval/Basic.lean,Mathlib/Topology/Algebra/Ring/Real.lean,scripts/nolints_prime_decls.txt 11 11 ['YaelDillies', 'github-actions', 'grunweg', 'themathqueen'] nobody
0-74441
20 hours ago
11-78692
11 days ago
11-78898
11 days
0
45826 Parcly-Taxel
author:Parcly-Taxel
refactor: `Lex/Colex` as one-field structures Redefine ```lean structure Lex (α : Sort*) where /-- Equip a type with its lexicographic order. -/ toLex :: /-- The underlying element -/ ofLex : α ``` and similarly for `Colex`. Several rounds of Codex were used to repair some (but not all) of the proofs. t-order tech debt LLM-generated 1184/1076 Counterexamples/MapFloor.lean,Counterexamples/SeparableNotSecondCountable.lean,Counterexamples/ZeroDivisorsInAddMonoidAlgebras.lean,Mathlib/Algebra/CharP/Synonym.lean,Mathlib/Algebra/Field/Basic.lean,Mathlib/Algebra/MvPolynomial/SchwartzZippel.lean,Mathlib/Algebra/MvPolynomial/Variables.lean,Mathlib/Algebra/Order/Group/Action/Synonym.lean,Mathlib/Algebra/Order/Group/Equiv.lean,Mathlib/Algebra/Order/Group/PiLex.lean,Mathlib/Algebra/Order/Group/Synonym.lean,Mathlib/Algebra/Order/GroupWithZero/Action/Synonym.lean,Mathlib/Algebra/Order/GroupWithZero/Lex.lean,Mathlib/Algebra/Order/GroupWithZero/Synonym.lean,Mathlib/Algebra/Order/Module/Equiv.lean,Mathlib/Algebra/Order/Module/HahnEmbedding.lean,Mathlib/Algebra/Order/Module/Synonym.lean,Mathlib/Algebra/Order/Monoid/Lex.lean,Mathlib/Algebra/Order/Rearrangement.lean,Mathlib/Algebra/Order/Ring/Synonym.lean,Mathlib/Algebra/Vertex/HVertexOperator.lean,Mathlib/Analysis/Calculus/ContDiffHolder/Pointwise.lean,Mathlib/Combinatorics/Colex.lean,Mathlib/Combinatorics/SetFamily/KruskalKatona.lean,Mathlib/Data/DFinsupp/Lex.lean,Mathlib/Data/DFinsupp/WellFounded.lean,Mathlib/Data/Fin/Tuple/BubbleSortInduction.lean,Mathlib/Data/Fin/Tuple/Sort.lean,Mathlib/Data/Finsupp/Lex.lean,Mathlib/Data/Finsupp/MonomialOrder.lean,Mathlib/Data/Finsupp/MonomialOrder/DegLex.lean,Mathlib/Data/Finsupp/WellFounded.lean,Mathlib/Data/Fintype/Card.lean,Mathlib/Data/Fintype/Defs.lean,Mathlib/Data/Sum/Interval.lean,Mathlib/Order/CompleteLattice/PiLex.lean,Mathlib/Order/Extension/Well.lean,Mathlib/Order/Hom/Lex.lean,Mathlib/Order/Interval/Finset/Gaps.lean,Mathlib/Order/Interval/Lex.lean,Mathlib/Order/Lex.lean,Mathlib/Order/PSigma.lean,Mathlib/Order/PiLex.lean,Mathlib/Order/Prod/Lex/Basic.lean,Mathlib/Order/Prod/Lex/Hom.lean,Mathlib/Order/Sigma.lean,Mathlib/Order/Sum/Lattice.lean,Mathlib/Order/Sum/Order.lean,Mathlib/Order/WellFoundedSet.lean,Mathlib/RingTheory/HahnSeries/Basic.lean,Mathlib/RingTheory/HahnSeries/HahnEmbedding.lean,Mathlib/RingTheory/HahnSeries/Lex.lean,Mathlib/RingTheory/MvPolynomial/Symmetric/FundamentalTheorem.lean,Mathlib/RingTheory/MvPowerSeries/LexOrder.lean,Mathlib/RingTheory/Spectrum/Prime/ChevalleyComplexity.lean,Mathlib/SetTheory/Cardinal/Arithmetic.lean,Mathlib/SetTheory/Ordinal/Arithmetic.lean,Mathlib/SetTheory/Ordinal/Basic.lean,Mathlib/Topology/Order/Completion.lean,MathlibTest/NonemptyIntervalLex.lean 60 32 ['Parcly-Taxel', 'github-actions', 'mathlib-merge-conflicts', 'vihdzp'] nobody
0-33508
9 hours ago
4-6175
4 days ago
10-39759
10 days
0
46043 EtienneC30
author:EtienneC30
refactor: make `WithTop` and `WithBot` inductive types Some points to notice: - The order on `WithZero` given by [WithZero.le](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Algebra/Order/GroupWithZero/Canonical.html#WithZero.le) is defined through defeq with `WithBot`, which no longer holds. Thus this PR also makes `WithZero` an inductive type and transfers the order through an equivalence passing through `Option`. - In `Mathlib.Order.Hom.WithTopBot` file, I can't make the lemmas generated by `simps!` for `withTop'` and `withBot'` dual to each other, while they are currently. I don't really understand what is going on. Declarations deleted without deprecation: - [WithBot.some_eq_coe](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Order/WithBot.html#WithBot.some_eq_coe), [WithTop.some_eq_coe](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Order/WithBot.html#WithTop.some_eq_coe): those are now syntactic equalities. - [WithTop.mul_coe_eq_bind](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Algebra/Order/Ring/WithTop.html#WithTop.mul_coe_eq_bind), [WithBot.mul_coe_eq_bind](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Algebra/Order/Ring/WithTop.html#WithBot.mul_coe_eq_bind) - [WithTop.coe_mul_eq_bind](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Algebra/Order/Ring/WithTop.html#WithTop.coe_mul_eq_bind), [WithBot.coe_mul_eq_bind](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Algebra/Order/Ring/WithTop.html#WithBot.coe_mul_eq_bind) - [WithOne.instMonad](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Algebra/Group/WithOne/Defs.html#WithOne.instMonad), [WithZero.instMonad](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Algebra/Group/WithOne/Defs.html#WithZero.instMonad) Zulip thread: https://leanprover.zulipchat.com/#narrow/channel/217875-Is-there-code-for-X.3F/topic/Identity.20equivalence.20between.20WithTop.2FWithBot.20and.20Option/with/639616431 --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> large-import tech debt t-order 1133/964 Archive/RiemannStieltjes.lean,Counterexamples/HomogeneousPrimeNotPrime.lean,Mathlib/Algebra/Group/WithOne/Basic.lean,Mathlib/Algebra/Group/WithOne/Defs.lean,Mathlib/Algebra/Group/WithOne/Map.lean,Mathlib/Algebra/GroupWithZero/Range.lean,Mathlib/Algebra/GroupWithZero/WithZero.lean,Mathlib/Algebra/Order/GroupWithZero/Canonical.lean,Mathlib/Algebra/Order/Interval/Basic.lean,Mathlib/Algebra/Order/Monoid/ToMulBot.lean,Mathlib/Algebra/Order/Monoid/Unbundled/WithTop.lean,Mathlib/Algebra/Order/Ring/WithTop.lean,Mathlib/Algebra/Polynomial/BigOperators.lean,Mathlib/Algebra/Polynomial/Degree/Defs.lean,Mathlib/Algebra/Polynomial/Degree/Operations.lean,Mathlib/AlgebraicGeometry/EllipticCurve/Affine/Point.lean,Mathlib/Analysis/BoxIntegral/Box/Basic.lean,Mathlib/Analysis/BoxIntegral/Partition/Additive.lean,Mathlib/Analysis/BoxIntegral/Partition/Basic.lean,Mathlib/Analysis/BoxIntegral/Partition/Split.lean,Mathlib/Analysis/Convex/Combination.lean,Mathlib/Analysis/Convex/Jensen.lean,Mathlib/Analysis/Meromorphic/Order.lean,Mathlib/Analysis/SpecialFunctions/Pow/NNReal.lean,Mathlib/Basic/Countable/Basic.lean,Mathlib/Basic/ENNReal/Basic.lean,Mathlib/CategoryTheory/Presentable/CardinalDirectedPoset.lean,Mathlib/Combinatorics/SetFamily/AhlswedeZhang.lean,Mathlib/Data/ENat/Defs.lean,Mathlib/Data/ENat/Pow.lean,Mathlib/Data/Finset/Lattice/Fold.lean,Mathlib/Data/Finset/Lattice/Union.lean,Mathlib/Data/Finset/Max.lean,Mathlib/Data/Finset/NAry.lean,Mathlib/Data/Fintype/WithTopBot.lean,Mathlib/Data/Int/WithZero.lean,Mathlib/Data/List/MinMax.lean,Mathlib/Data/Ordmap/Invariants.lean,Mathlib/Data/Ordmap/Ordset.lean,Mathlib/GroupTheory/ArchimedeanDensely.lean,Mathlib/MeasureTheory/Constructions/BorelSpace/Real.lean,Mathlib/MeasureTheory/Constructions/BorelSpace/WithTop.lean,Mathlib/MeasureTheory/Group/Measure.lean,Mathlib/MeasureTheory/MeasurableSpace/Constructions.lean,Mathlib/Order/Category/BddLat.lean,Mathlib/Order/ConditionallyCompleteLattice/WithTop.lean,Mathlib/Order/Hom/WithTopBot.lean,Mathlib/Order/Interval/Basic.lean,Mathlib/Order/Interval/Finset/Defs.lean,Mathlib/Order/KrullDimension.lean,Mathlib/Order/Set.lean,Mathlib/Order/SuccPred/Basic.lean,Mathlib/Order/Sum/Order.lean,Mathlib/Order/TypeTags.lean,Mathlib/Order/WithBot.lean,Mathlib/RingTheory/DedekindDomain/AdicValuation/Completion.lean,Mathlib/RingTheory/DedekindDomain/AdicValuation/Valuation.lean,Mathlib/RingTheory/DiscreteValuationRing/Basic.lean,Mathlib/RingTheory/MvPowerSeries/LexOrder.lean,Mathlib/RingTheory/OrderOfVanishing/Basic.lean,Mathlib/RingTheory/OrderOfVanishing/Noetherian.lean,Mathlib/RingTheory/Polynomial/Resultant/Basic.lean,Mathlib/RingTheory/UniqueFactorizationDomain/FactorSet.lean,Mathlib/RingTheory/Valuation/Discrete/IsDiscreteValuationRing.lean,Mathlib/Tactic/Echelon/Reflection.lean,Mathlib/Tactic/Inclusion/Extension/Interval/Basic.lean,Mathlib/Tactic/Inclusion/Extension/IntervalDyadicReal/BinarySplit.lean,Mathlib/Tactic/Inclusion/Extension/IntervalDyadicReal/Exp.lean,Mathlib/Tactic/Inclusion/Extension/IntervalDyadicReal/Log.lean,Mathlib/Tactic/Inclusion/Extension/IntervalInt/BinarySplit.lean,Mathlib/Topology/Algebra/Valued/WithVal.lean,Mathlib/Topology/Compactification/OnePoint/Basic.lean,Mathlib/Topology/EMetricSpace/Defs.lean,Mathlib/Topology/EMetricSpace/Weak.lean,Mathlib/Topology/Instances/ENNReal/Lemmas.lean,Mathlib/Topology/Order/Lattice.lean,MathlibTest/DifferentialGeometry/Notation/Basic.lean 77 13 ['EtienneC30', 'eric-wieser', 'github-actions', 'mathlib-merge-conflicts', 'plp127', 'vihdzp'] nobody
0-9442
2 hours ago
0-11204
3 hours ago
3-56438
3 days
0
46266 EtienneC30
author:EtienneC30
refactor: remove the coercion from `SemilinearMapClass` to `SemilinearMap` Deals with `SemilinearMapClass` in #31365. --- <!-- Your PR title will become the first line of the commit message. In this box, the text above the `---` (if not empty) will be appended to the commit message, and can be used to give additional context or details. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. For details on the "pull request lifecycle" in mathlib, please see: https://leanprover-community.github.io/contribute/index.html In particular, note that most reviewers will only notice your PR if it passes the continuous integration checks. Please ask for help on https://leanprover.zulipchat.com if needed. When merging, all the commits will be squashed into a single commit listing all co-authors. Co-authors in the squash commit are gathered from two sources: First, all authors of commits to this PR branch are included. Thus, one way to add co-authors is to include at least one commit authored by each co-author among the commits in the pull request. If necessary, you may create empty commits to indicate co-authorship, using commands like so: git commit --author="Author Name <author@email.com>" --allow-empty -m "add Author Name as coauthor" Second, co-authors can also be listed in lines at the very bottom of the commit message (that is, directly before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> If you are moving or deleting declarations, please include these lines at the bottom of the commit message (before the `---`, and also before any "Co-authored-by" lines) using the following format: Moves: - Vector.* -> List.Vector.* - ... Deletions: - Nat.bit1_add_bit1 - ... Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> - [x] depends on: #45954 t-algebra tech debt
label:t-algebra$
191/152 Mathlib/Algebra/Algebra/Bilinear.lean,Mathlib/Algebra/Algebra/Equiv.lean,Mathlib/Algebra/Algebra/Hom.lean,Mathlib/Algebra/Algebra/NonUnitalHom.lean,Mathlib/Algebra/Algebra/Subalgebra/Basic.lean,Mathlib/Algebra/Algebra/Subalgebra/Tower.lean,Mathlib/Algebra/Category/CoalgCat/Basic.lean,Mathlib/Algebra/Category/CoalgCat/ComonEquivalence.lean,Mathlib/Algebra/Module/Equiv/Defs.lean,Mathlib/Algebra/Module/LinearMap/Defs.lean,Mathlib/Algebra/Order/Module/PositiveLinearMap.lean,Mathlib/Algebra/Polynomial/Taylor.lean,Mathlib/Algebra/Star/LinearMap.lean,Mathlib/Algebra/Star/Subalgebra.lean,Mathlib/Analysis/CStarAlgebra/CStarMatrix.lean,Mathlib/Analysis/CStarAlgebra/CompletelyPositiveMap.lean,Mathlib/Analysis/CStarAlgebra/PositiveLinearMap.lean,Mathlib/Analysis/Convex/LinearIsometry.lean,Mathlib/Analysis/InnerProductSpace/Orthogonal.lean,Mathlib/Analysis/InnerProductSpace/Projection/Basic.lean,Mathlib/Analysis/Matrix/HermitianFunctionalCalculus.lean,Mathlib/Analysis/Normed/Algebra/Spectrum.lean,Mathlib/Analysis/Normed/Operator/Basic.lean,Mathlib/Analysis/Normed/Operator/LinearIsometry.lean,Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/PosPart/Basic.lean,Mathlib/Data/Matrix/Basic.lean,Mathlib/FieldTheory/Minpoly/Field.lean,Mathlib/FieldTheory/NormalizedTrace.lean,Mathlib/LinearAlgebra/LinearDisjoint.lean,Mathlib/LinearAlgebra/Matrix/Kronecker.lean,Mathlib/LinearAlgebra/SymmetricAlgebra/Basic.lean,Mathlib/LinearAlgebra/TensorProduct/Submodule.lean,Mathlib/LinearAlgebra/Trace.lean,Mathlib/NumberTheory/Modular.lean,Mathlib/RepresentationTheory/Coinvariants.lean,Mathlib/RepresentationTheory/Invariants.lean,Mathlib/RepresentationTheory/Rep/Res.lean,Mathlib/RingTheory/Adjoin/Basic.lean,Mathlib/RingTheory/Bialgebra/Basic.lean,Mathlib/RingTheory/Bialgebra/Hom.lean,Mathlib/RingTheory/Bialgebra/TensorProduct.lean,Mathlib/RingTheory/Coalgebra/Basic.lean,Mathlib/RingTheory/Coalgebra/Convolution.lean,Mathlib/RingTheory/Coalgebra/Equiv.lean,Mathlib/RingTheory/Coalgebra/Hom.lean,Mathlib/RingTheory/Coalgebra/TensorProduct.lean,Mathlib/RingTheory/DedekindDomain/LinearDisjoint.lean,Mathlib/RingTheory/Flat/Equalizer.lean,Mathlib/RingTheory/GradedAlgebra/AlgHom.lean,Mathlib/RingTheory/GradedAlgebra/TensorProduct.lean,Mathlib/RingTheory/LocalProperties/Exactness.lean,Mathlib/RingTheory/LocalRing/Quotient.lean,Mathlib/RingTheory/Localization/BaseChange.lean,Mathlib/RingTheory/Localization/Module.lean,Mathlib/RingTheory/TensorProduct/Basic.lean,Mathlib/RingTheory/TensorProduct/Maps.lean 56 10 ['EtienneC30', 'github-actions', 'mathlib-dependent-issues', 'mathlib-splicebot', 'themathqueen'] nobody
0-2542
42 minutes ago
0-2542
42 minutes ago
0-28730
7 hours
0

This page collects anonymous visit counts for usage reporting (no cookies, no IP addresses stored). See the Mathlib Initiative privacy policy.